From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.17695.1600244929366862978 for ; Wed, 16 Sep 2020 01:28:49 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=iV15j1Cq; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: ray.ni@intel.com) IronPort-SDR: qXPlqKnYgPsYv/OVqdoqp3+dUojRPO348Htct3M0Uggy4bLFOr8SbD7Dm0Np0Pe9mlwHP47bmE oi1smIdFW34g== X-IronPort-AV: E=McAfee;i="6000,8403,9745"; a="156833805" X-IronPort-AV: E=Sophos;i="5.76,432,1592895600"; d="scan'208";a="156833805" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2020 01:28:48 -0700 IronPort-SDR: 34gv3FPKHrpP9V7afSHBTAmcNDLO9vgqNsegapAvppHS1F1FHUoGar7iyEyRlwnZEWNe5OemPi SRjJhitdxS0Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,432,1592895600"; d="scan'208";a="319762910" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga002.jf.intel.com with ESMTP; 16 Sep 2020 01:28:48 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 16 Sep 2020 01:28:47 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 16 Sep 2020 01:28:47 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.174) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 16 Sep 2020 01:28:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vv/Y0jNuhj0hzg5owUojMeKh3SA9wNebygWCmgY6gWKF8lfEPmS4P5KvB/aJkhs/dqb27DXmY9rswGk4V91sc2is8kjNBQUv+y6h12+5a37gRy37eu/r7JbD97JWB6sUTrp22oXxE01dwr5aKyeyVD4DT5fm6xRe0SvzvOxlHT6FtJKO4Oa98ExykHkZkweEUDRvPr/oSNN4ca9nzEPAg6E/+7aFe/C47KCENR9MfPrVFcRfNcoaiqzFxvTzuVJahWJ2INzAiaiDPve05Uqhhmt3EO4RQ8LE5clpOcbsaZzOOSfG13gyPZ/+wHMD3uFxZHN3Ad09Oyxn9pOMII3iZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KTiIaGIF14DAduLRnAy5XLcumCzkXezDQUYzmcDhrfs=; b=cOhjb3cUoIAnzg8EVtF6ADvkhEbAaRtXaCLCj+SOhTLNlM9djZSkcnaVdTXR2XZWESbnJuqrmlMyLW3Q/NRSNFK/x13fGjgLLxSZIT+f+M43ECmarpWqVqcvT0CVnpfAND5JyMrPcruYRRuYgxoRX584oaj9qS+nDxRpR4CJLN/bMhHNy0avDkcPLIGejdTMZVJqJo0JkIEnpCsDWLdg1yAQqg/YXAczALw1npxwsDO+Q4FkQkKq+tPpOvrLBYCTsi3e2Z3mrnaKNFmdwJSu3XhUzQtgY2b4nN/5FzYacWnFpcT8Hj/lq7mCnHGL/gFl62oRrM0eEN/NAKWeVuzO3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KTiIaGIF14DAduLRnAy5XLcumCzkXezDQUYzmcDhrfs=; b=iV15j1CqZUMyf6AQPNHGbQtNn4cVCo8lgcmleLPE4ZmZKgP0jayONOPoS4wE740gEcWgIjUXwXUHfpjvkXUz+ENNITHVgYuChcq6vw0Kbm5rq9icfJZo1jP/Q9+sAnjP6SAmZIgfnNcToRUujblzydrWBoMVAJmtl6gemp0hOaY= Received: from BY5PR11MB4007.namprd11.prod.outlook.com (2603:10b6:a03:189::28) by BYAPR11MB3813.namprd11.prod.outlook.com (2603:10b6:a03:ff::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.11; Wed, 16 Sep 2020 08:28:42 +0000 Received: from BY5PR11MB4007.namprd11.prod.outlook.com ([fe80::1533:4053:1c45:3596]) by BY5PR11MB4007.namprd11.prod.outlook.com ([fe80::1533:4053:1c45:3596%6]) with mapi id 15.20.3370.019; Wed, 16 Sep 2020 08:28:42 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "marcello.bauer@9elements.com" Subject: Re: [edk2-devel] [PATCH v2 0/2] Add support for scanning Option ROMs Thread-Topic: [edk2-devel] [PATCH v2 0/2] Add support for scanning Option ROMs Thread-Index: AQHWi1tzGzjhTKraNEe3bWC1kVroLKlq5bQg Date: Wed, 16 Sep 2020 08:28:41 +0000 Message-ID: References: <20200915122616.17196-1-marcello.bauer@9elements.com> In-Reply-To: <20200915122616.17196-1-marcello.bauer@9elements.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 869ab30b-928a-4a2c-88b9-08d85a1a8508 x-ms-traffictypediagnostic: BYAPR11MB3813: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7USFWo+jFMEHVHtd2+Y/AHwGsXbc7WBVi9DpAOCR/ZYNoTna0+1f7tyqh5VTLC03o3WcUIAyXL2EpfUW1skLs1Q5/W8icd3sSjUFABOmr9bM63/SJ8f3DYixheAlC80kUebQ4ADabJHGkaFptZO9Irx/H54r+3fnSmL9gZJPNX0WmZxXxRvGCsGRdtS5IsQI3TExhQOZ8pafCGmztppsuur541+2FV+qsbEa3ln9C9lvQmdG3ZGF9IkwumvuValCVu9z3nYrKBZuMdV2aOSQ++U1s+dGgQ+vxPI+DZU6dhIlyrEx1ndGBTtONNjJeb+g2lonRx3RJKe7WYd27mBC1hirdb9wU7wmANR6qwMnY4dVp2kZ5EybWKoLr/q/fOtBMklwLN/3j++fYWwyKZATPQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR11MB4007.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(396003)(366004)(376002)(39860400002)(346002)(86362001)(7696005)(66556008)(52536014)(66476007)(966005)(64756008)(66446008)(5660300002)(83380400001)(76116006)(55016002)(9686003)(8676002)(478600001)(316002)(110136005)(2906002)(8936002)(33656002)(26005)(66946007)(71200400001)(186003)(53546011)(6506007)(19627235002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: msfVnUFiUZn1rUIlaJgbZIrDv1hEOAG5tpTkwS9FBu5A/UNq0heebW2b/6UEWfnrf5G6Oa0FZsVNYlg2uBxLmrVPcgNLVboiOtin+9yqQPBmpNRQ/JNotvq7GsgLUmjzSrCVrY/1weln9A8rDR15pq4REEIEmgjZ0oTp2KBhlKFQqPVSy9srQboN73rzrGfowNr5nY/3xK8WCMr3Y9ag5iTErP5SPx9JxLwTlQUF7l9ehDnWXL8Q89cYSNX+wFNKNeobyWscQb7emr5TDfPqJCj3wtq1mcqYyQPipYzHf1/3vxxbNkl7QFNxBON8AOAzVdypu43+YwFSGRyYr6kiVoUbfBJqhyAyeZURCTm7ovPD0LlnvPMd5cZlaZ4GwFjCB24tPAGe85O1w4EOgalsaIc4l4q+Z+ULFs+yB3rRTW7eNdEybtjtUgH3Mv9PSLjbrPkFsZBV2yL1nWTbLllPbA5na/8KlOxAobVv2I57Aoh3uJR6igc8Z3f8f0ki3193ps1msEwOntn+rYR9rdTe9rK2kDAuFac98EFgCTRqrxOhhr4cbEBQvWlFpqzstRD1p5p1t91C8nn5/TUt4rS1EomTHcK11oMjxhT2FuiMUi9vMhP2InX0HojTCMVmF8dOiGs5ueTzmbkhzG3dG86uuw== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4007.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 869ab30b-928a-4a2c-88b9-08d85a1a8508 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2020 08:28:41.9084 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RljEBownDcxFwsb9+G+wK8olm7O16ddjoPOWgDTMREN4iWzFZ5AoY5R4IyJlYYGTZYok2tO2ODCH1MsK1+aRgQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3813 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Why running it will disable the ability of PciPlatform code to scan for ROM= s? I guess it is because the PciIoDevice->AllOpRomProcessed is set which caus= es GetPciRom() is skipped. Can you explain more in the code comment? > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Marcello > Sylvester Bauer > Sent: Tuesday, September 15, 2020 8:26 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH v2 0/2] Add support for scanning Option ROM= s >=20 > Fix Option ROM enumeration and support scanning. >=20 > v2: > * add correct Maintainer and Reviewer to Cc > * PciPlatformDxe: > - Update description > - add function description >=20 > Branch: https://github.com/9elements/edk2-1/tree/UefiPayloadPkg- > Option_ROMs > PR: https://github.com/tianocore/edk2/pull/926 >=20 > Patrick Rudolph (2): > MdeModulePkg: Fix OptionROM scanning > UefiPayloadPkg: Scan for Option ROMs >=20 > UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 1 + > UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 1 + > UefiPayloadPkg/UefiPayloadPkg.fdf | 1 + > UefiPayloadPkg/PciPlatformDxe/PciPlatformDxe.inf | 46 +++ > UefiPayloadPkg/PciPlatformDxe/PciPlatformDxe.h | 19 + > MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 10 +- > UefiPayloadPkg/PciPlatformDxe/PciPlatformDxe.c | 426 > ++++++++++++++++++++ > 7 files changed, 500 insertions(+), 4 deletions(-) > create mode 100644 UefiPayloadPkg/PciPlatformDxe/PciPlatformDxe.inf > create mode 100644 UefiPayloadPkg/PciPlatformDxe/PciPlatformDxe.h > create mode 100644 UefiPayloadPkg/PciPlatformDxe/PciPlatformDxe.c >=20 > -- > 2.28.0 >=20 >=20 >=20