From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.2914.1600392372799953998 for ; Thu, 17 Sep 2020 18:26:13 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=c4NhRqFC; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: ray.ni@intel.com) IronPort-SDR: Th8PYgxFu33prRWbUlEMQEZfjFEjkjrJ42zXvjrO3mSf1l07zrW4Ch74f3RIuvmUqVOlI5uR3I 1WUxfz1J/CQQ== X-IronPort-AV: E=McAfee;i="6000,8403,9747"; a="139332133" X-IronPort-AV: E=Sophos;i="5.77,273,1596524400"; d="scan'208";a="139332133" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2020 18:26:08 -0700 IronPort-SDR: CzBFStwptEfx21dJHjL2ub6gKXQ8o/NDXnqWmRFxcemrJUHZ88XSsIWgbIeNY8DlWLq9hMU7J0 JGVBfEsaA61Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,273,1596524400"; d="scan'208";a="339630952" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga002.fm.intel.com with ESMTP; 17 Sep 2020 18:26:08 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 17 Sep 2020 18:26:07 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 17 Sep 2020 18:26:07 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.103) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 17 Sep 2020 18:25:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eijXVEWhT1363N9cUdkWL4fhb+pXTh1aQIJF5AvNU5kWgkqlrjuKyJacwkFsGxegsAIqTexyu+us/wFC8eJA3mehAp6ZBI1yVkeVPjZYDDfZSDzP32wNZ16x3VGbKdpl6RiQ+B3qUBXMtzqtzONoL4Q8qHmm8aPUbVlPqEVGIbOjLHNp5+AlJllyplpKJ1XNjrsxX6RgY/zBSU+D1htnUalIUlxK4t+Ium7e6UIptInp1TV8yGKp/TiEXd3ewcxMefsittP1x0ftQS3XhHJWfbMGXgZhOo/zF41CjJUSnAf1GBQyIeNqSFTFYoQZP2RIduj/2Kh90Ic0s/so2EC1XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mlfR03swurADvGRTT5lR6m3k9iMDo+SGAkOUcKEY4U8=; b=ZY8TWAIyDaVih2kMEGAEYeZrXGFMhyGzhWIDPrElEMJCgsDCIxDX5Ffks8umnLgFdWmsc03S65qpf8Vx08EdIhmrjYBzA7tkWbU4H7UBOYhypBiTFCw8gYOtpt2FMB492T8LJtdIPAqWdTpPdPyRlYhuODi6UCAU03boOyB+0qlYGdXyAC6Bi92OI9+vF4s4Uf+SslPQkD5QHp0lHvIH84x3IaOcW6QTi4n0FlEiM0vyuLxJQwaggPK8tmosVHYsDZZnTkNYAnKIBlN7EKzZEkxfs6Zt3vJwJJAoF8OYnD6KKrFP9H+CzLjpcFHTMLPaEabNEnvlwRmycgqMr7gg3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mlfR03swurADvGRTT5lR6m3k9iMDo+SGAkOUcKEY4U8=; b=c4NhRqFCINFCwI/r4/d0dtrfhur2hw3Xm8xwvf/LjfuTLhKBxJK818v/mEgi4HUe5Sa7Lhdch+knh56iDew8N/V47KAjDsx5vg4RxrvJ9NycdtkdclrmJGdFQzShj/2epPN1aP+Rijm7x33jGvNDLScN0TkCdNeUHVzpn8EGt84= Received: from BY5PR11MB4007.namprd11.prod.outlook.com (2603:10b6:a03:189::28) by BYAPR11MB2598.namprd11.prod.outlook.com (2603:10b6:a02:cb::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Fri, 18 Sep 2020 01:25:56 +0000 Received: from BY5PR11MB4007.namprd11.prod.outlook.com ([fe80::1533:4053:1c45:3596]) by BY5PR11MB4007.namprd11.prod.outlook.com ([fe80::1533:4053:1c45:3596%6]) with mapi id 15.20.3370.019; Fri, 18 Sep 2020 01:25:56 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "michael.kubacki@outlook.com" CC: "Kinney, Michael D" , Liming Gao , "Liu, Zhiguang" Subject: Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Correct EFI_BLOCK_IO_PROTOCOL_REVISION3 value Thread-Topic: [edk2-devel] [PATCH v1 1/1] MdePkg: Correct EFI_BLOCK_IO_PROTOCOL_REVISION3 value Thread-Index: AQHWisKVFkCAgrThqk+NfHdplcaY3altnzLg Date: Fri, 18 Sep 2020 01:25:56 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.218] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 85184598-076a-40e3-72ba-08d85b71cae7 x-ms-traffictypediagnostic: BYAPR11MB2598: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2887; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UfcY/BR7wmlJB+K+vjZXSs6VR2Xa/zbUX8OxmWOWNsPHlYd6GpoPDrv2Dgdw88eymCNaD1p2dFUtu2ramqNL+tYm5YbFPmswldwvJy7B567bVg3JR04K6VxGlcnx0eMZ1arFQr+NnNK6BgM6lqDTSMayjU9CcKCEpTrcOU5VTEaFoTRPMd2NUk1hFesHYq/5DuKSzL9lWy0wamagBnCsZfwfkYuqs4hArdzj6zh3U1KCW3wppVfNVmHF6iLp9+7ooKXAJnWKkcL/5icocSuMIqCc3R4RiAwgcI62E+IyN67QwhkLDf5JUF30TdJy+t6MlDgV4yUJ/F+BVbAYxAJnxl1PSsOTY+gUIG4qOf8si2aLz6ykRjRNQhq+Vi3xP0xvD78ef1uPohC07qVbKLwQkA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR11MB4007.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(346002)(136003)(376002)(396003)(39860400002)(8936002)(55016002)(2906002)(53546011)(107886003)(52536014)(9686003)(33656002)(6506007)(83380400001)(7696005)(8676002)(966005)(478600001)(4326008)(71200400001)(26005)(316002)(186003)(76116006)(5660300002)(86362001)(64756008)(66476007)(66446008)(66556008)(110136005)(66946007)(54906003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: OLMY/cZ7fLmD+X2Y6Oyg834UKkSz0jJUITDwUXpcjDzwbUdCulyrPSZUhSvGZcUihP/Ni0Y8eLfwRrtvUyTsdj7xGPBzathWfPJB9rkJ6e/xz+MO7wv1i7p6YB5rP76yeWPIiLYZ7q3hsfXculsV/oIsBgcGSZqE2VPdqEr8rRXQpSlq8iqDAaNFjgV6pikeZ/lggI6ybF3+0M1qiZlSGb1njzi1FPim6Ogq8nHnCODT8XB2IdY6GNDO+fpOgdg8BcNiL9TWwgujW7Lmr1FVyl8jQq4NYu7LA3yP6PCdPjMvhmLQYkb3357vhMI82F0G+CUBtWvSoRUpRWmfv73wSbiGzCyX7e6ImOGZp9PeAnDAe4H6by/57pMzRMw+B4PavXtYAiuqkfNQRPEVzJ0Y67PoW1KYj6Q5+NFL1PXfXEAZFEVPGp3oz9vSH+UTuWnvU2XXRD+UKaoZuMBK7jCIOgrLSc7w4Ooa86BQP0ehSiYJ8XIYv738sY2cVeCdr6f0gEGUlVLd39kzIYgoXIKMGjwLv3Z2BHfxNhAvfKmjQhSCau9vUnK85ocKFKnQezxe8OGYBk78yN9hQQ5Q+yEhsrLEeplCjJjWXYhuIBX0OqwhsYzUGAESmNBI4z4MUghJdCLsBgRD4BBxVEW/QW8e+w== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4007.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 85184598-076a-40e3-72ba-08d85b71cae7 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Sep 2020 01:25:56.5563 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MtsuF5xbW2FLWvjvJjJwmQlmQ6WQ2Fcps5pH2uuRTZOXVzTsNlUQG9fggdMIX+y+WHhDzL13mwbTlQr3Bqwl4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2598 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Mike, Have you evaluated the impact to the already-released module that relies o= n the macro value? Basically, you changed to a smaller value that may cause a revision3 check= fail: a released module expects the revision is bigger than 0x31, but the value = is 0x1f. Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Michael K= ubacki > Sent: Tuesday, September 15, 2020 2:11 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Liming Gao ; Liu, Zhiguang > > Subject: [edk2-devel] [PATCH v1 1/1] MdePkg: Correct EFI_BLOCK_IO_PROTOC= OL_REVISION3 value >=20 > From: Michael Kubacki >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2961 >=20 > The value of EFI_BLOCK_IO_PROTOCOL_REVISION3 is currently > 0x00020031. However, the value assigned in the UEFI Specification > 2.8B is ((2<<16) | (31)) which is 0x0002001F. >=20 > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Signed-off-by: Michael Kubacki > --- > MdePkg/Include/Protocol/BlockIo.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/MdePkg/Include/Protocol/BlockIo.h b/MdePkg/Include/Protocol= /BlockIo.h > index 7b332691ede3..3bd76885e11c 100644 > --- a/MdePkg/Include/Protocol/BlockIo.h > +++ b/MdePkg/Include/Protocol/BlockIo.h > @@ -201,7 +201,7 @@ typedef struct { >=20 > #define EFI_BLOCK_IO_PROTOCOL_REVISION 0x00010000 > #define EFI_BLOCK_IO_PROTOCOL_REVISION2 0x00020001 > -#define EFI_BLOCK_IO_PROTOCOL_REVISION3 0x00020031 > +#define EFI_BLOCK_IO_PROTOCOL_REVISION3 0x0002001F >=20 > /// > /// Revision defined in EFI1.1. > -- > 2.28.0.windows.1 >=20 >=20 >=20