From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web09.3584.1608689231552804546 for ; Tue, 22 Dec 2020 18:07:11 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=TA1J9py4; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: bob.c.feng@intel.com) IronPort-SDR: 97IyQWaDNdP72cyXqCgMUbGmQTctukvSYgHSbSb4IgNtSjZPCkiD8vvretr6+LEwLnpwsu1USG Km62h8Du0HIQ== X-IronPort-AV: E=McAfee;i="6000,8403,9843"; a="172438407" X-IronPort-AV: E=Sophos;i="5.78,440,1599548400"; d="scan'208";a="172438407" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Dec 2020 18:07:10 -0800 IronPort-SDR: q4Cc9ncEMKoMaMcjtCP/LMXpnMQEZDb46oslh5ua4yHxk2zKMRtZ84mGyUwgnNMa05wsIFF1Km ZFm2SMXbrWKw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,440,1599548400"; d="scan'208";a="457757980" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 22 Dec 2020 18:07:10 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 22 Dec 2020 18:07:09 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 22 Dec 2020 18:07:09 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.44) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 22 Dec 2020 18:07:09 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LvGUEkwHjSlxqjHrKaMk+jMi3l3Fb+LYoghz253sJlVXNn/bsGVBnhcChIgMJmPQIvBJu8cTvaqjP9mI5ODiSyKpL/MtHJZ6eafiM2m8OoWmD/MAjT4EeBLb8osMkxGDiKg32A/oY7jr7bbDkbCb5Iy/pkfhEzkm3bpbF6D01bL8vjJj2a8Bev56Ynghxh4lQ8CWg7480p7k2DhjFOP2JJ2d1fjxW/rjNIm6r1TrXPOK3gTV0bPRt8oWY9n+F71+kfH/PZk1kEzI4tVznqIVs+0uDiChWaHwTNEQxgW3Wi/1RKQa7FOwchiYeVPG3uKOtMXS3Xhn0vxeHehNZ0WgWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0RdjR/ucTQ60S1xMF2gdoWDvfYHbWG8RyvQM4blU2os=; b=StpDkKFXXibumSJYRAFTF+cCxhQCFRQxIyEI0IuUHHu2dICKHhk7aZD6y2Kx3PZyerCcz99/0yukne4EQGMtjAgpbCgSVBX0OxQlWPHrbndQrjSPSOZXBTSRMUDYxQK2IgSqHZbQR2HxPgFnDo3Jbp9stoslcnYCJ20Q2on7dPtiXb4/0MzkCirOYZ5/eWZD05ZTYhHqfXIcZxNf9brbFQpDPO4LyI/t8BI0K6+5G6QlxC+fFhB0w7vs2PDxlO7IyJBXknznofrr3uGx+h4cLAjvVAMaN00q73SDs7DCx/eVi8+/f5deMNsctSSTLRxMcUcLy+fEUMZHaTX+MGUdUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0RdjR/ucTQ60S1xMF2gdoWDvfYHbWG8RyvQM4blU2os=; b=TA1J9py4rleP8kJE+pPNUmWzGEPnFTUhI/+9XOMuapvIlDIZoqhD9VGYkvyzn+lh7Mmevp47bEn4R5FLqSza48+q5jqGyIFdonogl7s1EIHmlJlKNyvhirrIHejRU6Vg5vwfNo7QPa+59j2e60PvTkTWZrfSF07TiERN1TijtDE= Received: from BY5PR11MB4070.namprd11.prod.outlook.com (2603:10b6:a03:181::16) by SJ0PR11MB4879.namprd11.prod.outlook.com (2603:10b6:a03:2da::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.29; Wed, 23 Dec 2020 02:07:05 +0000 Received: from BY5PR11MB4070.namprd11.prod.outlook.com ([fe80::45ef:9c3b:15cf:7d82]) by BY5PR11MB4070.namprd11.prod.outlook.com ([fe80::45ef:9c3b:15cf:7d82%7]) with mapi id 15.20.3676.034; Wed, 23 Dec 2020 02:07:05 +0000 From: "Bob Feng" To: "devel@edk2.groups.io" , "Feng, Bob C" , Yunhua Feng CC: Liming Gao , "Chen, Christine" Subject: Re: [edk2-devel] [PATCH v2] BaseTools: Should always define PCD TOKEN value as Zero for static PCD Thread-Topic: [edk2-devel] [PATCH v2] BaseTools: Should always define PCD TOKEN value as Zero for static PCD Thread-Index: AQHW1BFwqnbJn+hn8k+hoU+8QP9ET6oAzmZggAMqBNA= Date: Wed, 23 Dec 2020 02:07:05 +0000 Message-ID: References: <20201217010951.2098-1-fengyunhua@byosoft.com.cn> <16529824D9BE42B5.13568@groups.io> In-Reply-To: <16529824D9BE42B5.13568@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 24727d10-b307-462b-13ca-08d8a6e7724e x-ms-traffictypediagnostic: SJ0PR11MB4879: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1051; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1tAz5EmJA+Duy4oIVkeitX8+Z2r8IREUOeC4Yz3cFdWW2bZCISPGWEKtPjdSyrk3aQheMHsd7RwXrTh/dELTaqb+DPLtWvzFMdiqf54ZLfisPWqjAcXSMX+0zUdEeo2s7VqzEUA4RBeqDthYGnvtQyMtymsMwL7TiWtvNY9sK6VBAZzBvut2uFrvkTiTIzet4YNrMgF/0HmS5VMf3hMordILgzuDy3S7gqUcqxKshmAYE4iS7B2tTGsyJJAmUYnwf3xyPwLNS5emUlek6kCVtuVaPt1DThSAvXiz12+Ejy9W/a24WpmX/HLBflDezPGoCQas/xbDUqheulGSjOjJbYtMiWaFB/XLkM7VCw4MEoREadjvJIVZk6mJxCLaTTQ2MpiaSWp7ls9QHR9iQE4XbaCk3BnvKW0qQX5BFuXgx+TzyQTYuAvoqntDhxDYq/9Eg79nxmWaLQBe96QVFqo4lw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR11MB4070.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(366004)(346002)(136003)(396003)(376002)(9686003)(64756008)(4326008)(53546011)(66476007)(33656002)(107886003)(66946007)(66446008)(52536014)(186003)(55016002)(54906003)(26005)(7696005)(86362001)(76116006)(6506007)(2906002)(8676002)(966005)(66556008)(316002)(83380400001)(71200400001)(8936002)(5660300002)(110136005)(478600001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Yea1X/UE3kmEcMKjiNXxepmMOAXH50XcgpWKiIDFEmIUs6qHOsW6xlJdhSLv?= =?us-ascii?Q?GL68Xw6AhgnFp8Kh5IAsHcBdCNHVVsdBz3D4ad+BhsHoxw9f2eRZuOIxbXSi?= =?us-ascii?Q?rMG1HNNjcGYKdcpTnlh/Lr4HpvOmjnXY1+VW5Uo4vXc3aQ4mDNLIMn+gyEAt?= =?us-ascii?Q?6a0CF5ZcFJgop7vcJfS+6EVTIk4HENwFuh40NK+vkMkqhIzYNOtfEB54bYDd?= =?us-ascii?Q?4Gnd1X+sD/qQvYgvh+GM5XbFTZ9P7E69/rh3vN/WMrJ4aQApVubwjGu1ct7T?= =?us-ascii?Q?NJDhLWbyDaF+9wAcu54V90hWRBaFPZvQcCRqxabPWIlarz6J0Y/dy4NjbNjA?= =?us-ascii?Q?x5fdm/r0PIOsDNqWZ3xk/xdq/Ybcv+dvKGNENrU0pOVHiLjhQvWQSX/mHZw0?= =?us-ascii?Q?OOLL17pQO4smdyF7xlAYq8aVJCT0tx8nTyDx65BH6bBwpB9h73Z2HjZRTN8W?= =?us-ascii?Q?/cmcNA11tTQtLqgcEQ/POhQ6pDBR7q2tNYXhcSEAgeo0Q94XNbb3cBtJCoKx?= =?us-ascii?Q?rLLgzuNXgiiOak+KdLSq4NZ/WcDHeGiCZd2ZsljcsH3goeAcjA60+cNFlTMR?= =?us-ascii?Q?r2A+2oUdAmHHFTBi/XW3kra94vSJqymW2mlbtDGO2jtnapGo0dhFVA5esivO?= =?us-ascii?Q?pG8axEFTmazfIgW/sw76te+CqRPp9SxWX93N6xvf+T0wsxuMqks6lZ3OqeOt?= =?us-ascii?Q?WCqdh9r0/XmMcwHNub3w29mqdX0YUWH1mj401RPvDsIhbUjXr/OjSn82hz2m?= =?us-ascii?Q?shjOiI1UhP4bPsTnk9/wXK947/LJ6iUAkDisADmTZAHw41v7Y6aNvEsxsmMh?= =?us-ascii?Q?IKoTPMN5ide2v3wDqCnNz7b9Kw44pVQsWYpE8oxuzSDe37FEDMFd1M8vIqLz?= =?us-ascii?Q?12jGFTp8YTpO+mlZI7s/0nHO1YkvhZiXwvsmqFMXuleS/nysDW9muC5Iwp4i?= =?us-ascii?Q?AlGbcTKDJoDxXTRh+dgJg0kzDYco7PGS3WuMjx1ptRE=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4070.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 24727d10-b307-462b-13ca-08d8a6e7724e X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2020 02:07:05.7721 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wk3zqwhGOGfuxem4QHm9mLera4E20+dhNvS5xbHE2y8NgOHBoxqwOk8302efhfYhBa4UzU6phHMDpOtB4iYaQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4879 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Created a PR https://github.com/tianocore/edk2/pull/1265 Thanks, Bob -----Original Message----- From: devel@edk2.groups.io On Behalf Of Bob Feng Sent: Monday, December 21, 2020 9:48 AM To: Yunhua Feng ; devel@edk2.groups.io Cc: Liming Gao ; Chen, Christine Subject: Re: [edk2-devel] [PATCH v2] BaseTools: Should always define PCD T= OKEN value as Zero for static PCD Reviewed-by: Bob Feng -----Original Message----- From: Yunhua Feng =20 Sent: Thursday, December 17, 2020 9:10 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Liming Gao ; Chen, Christine Subject: [PATCH v2] BaseTools: Should always define PCD TOKEN value as Zer= o for static PCD REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3120 FixedAtBuild, PatchableInModule and FeatureFlag PCD don't use PCD TOKEN. Their PCD TOKEN value can always be zero. AutoGen.h will not be changed when static PCD is added or removed. Dynamic PCD add or remove will still cause dynamic PCD token value be chan= ged. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Yunhua Feng --- BaseTools/Source/Python/AutoGen/PlatformAutoGen.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py b/BaseTool= s/Source/Python/AutoGen/PlatformAutoGen.py index c001828937..7d8e7b3c7c 100644 --- a/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py +++ b/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py @@ -1037,8 +1037,7 @@ class PlatformAutoGen(AutoGen): TokenNumber +=3D 1 =20 for Pcd in self.NonDynamicPcdList: - RetVal[Pcd.TokenCName, Pcd.TokenSpaceGuidCName] =3D TokenNumb= er - TokenNumber +=3D 1 + RetVal[Pcd.TokenCName, Pcd.TokenSpaceGuidCName] =3D 0 return RetVal =20 @cached_property -- 2.27.0.windows.1