Re: [edk2-devel] [Patch 0/3] Remove fixed CPU architecture list assumptions

["Bob Feng" <bob.c.feng@intel.com>]

Mike,

The patch 3/3 is good to me. After sperate it into 2 patches, Reviewed-by: Bob Feng <bob.c.feng@intel.com>

For the patch 2/3 CryptoPkg/Library/Include,  the Copyright Year is missing to change.

Thanks,
Bob


-----Original Message-----
From: Kinney, Michael D <michael.d.kinney@intel.com> 
Sent: Tuesday, April 13, 2021 10:39 AM
To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Lu, XiaoyuX <xiaoyux.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>; Feng, Bob C <bob.c.feng@intel.com>; Chen, Christine <yuwei.chen@intel.com>; 'Andrew Fish' <afish@apple.com>; 'Abner Chang' <abner.chang@hpe.com>
Subject: RE: [edk2-devel] [Patch 0/3] Remove fixed CPU architecture list assumptions



> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Monday, April 12, 2021 6:28 PM
> To: devel@edk2.groups.io; Kinney, Michael D 
> <michael.d.kinney@intel.com>
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J 
> <jian.j.wang@intel.com>; Lu, XiaoyuX <xiaoyux.lu@intel.com>; Jiang, 
> Guomin <guomin.jiang@intel.com>; Liu, Zhiguang 
> <zhiguang.liu@intel.com>; Feng, Bob C <bob.c.feng@intel.com>; Chen, 
> Christine <yuwei.chen@intel.com>; 'Andrew Fish' <afish@apple.com>; 
> 'Abner Chang' <abner.chang@hpe.com>
> Subject: 回复: [edk2-devel] [Patch 0/3] Remove fixed CPU architecture 
> list assumptions
> 
> Mike:
>   Is this update for new ARCH support? With this patch set, new ARCH 
> support doesn't need to modify BaseTools. Right?

Correct

> 
>   For this patch set 3/3 BaseTools/Source, I may suggest to split it 
> to two patches, one is for C tools, another is for Python tools.

I agree.  I will send V2.

> 
>   For other patch, they are good to me. Reviewed-by: Liming Gao 
> <gaoliming@byosoft.com.cn>
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Michael D Kinney
> > 发送时间: 2021年4月8日 14:33
> > 收件人: devel@edk2.groups.io
> > 抄送: Jiewen Yao <jiewen.yao@intel.com>; Jian J Wang 
> > <jian.j.wang@intel.com>; Xiaoyu Lu <xiaoyux.lu@intel.com>; Guomin 
> > Jiang <guomin.jiang@intel.com>; Liming Gao 
> > <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>; 
> > Bob Feng <bob.c.feng@intel.com>; Yuwei Chen <yuwei.chen@intel.com>; 
> > Andrew Fish <afish@apple.com>; Abner Chang <abner.chang@hpe.com>
> > 主题: [edk2-devel] [Patch 0/3] Remove fixed CPU architecture list 
> > assumptions
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3308
> >
> > The EDK II Build Specifications do not restrict the set of CPU 
> > architectures that can be supported.  Remove places in the EDK II 
> > that assume a fixed set of CPU architectures.
> >
> > Remove build breaks in the following tools and DEFINES when a check
> against
> > a fixed set of CPU architectures is made.
> >
> > * Build
> > * GenFds
> > * TargetTool
> > * GenFw
> > * SIXTY_FOUR_BIT and THIRTY_TWO_BIT
> > * EFI_IMAGE_MACHINE_TYPE_SUPPORTED
> > * EFI_IMAGE_MACHINE_CROSS_TYPE_SUPPORTED
> > * EFI_REMOVABLE_MEDIA_FILE_NAME
> >
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>Cc
> > Cc: Guomin Jiang <guomin.jiang@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > Cc: Bob Feng <bob.c.feng@intel.com>
> > Cc: Yuwei Chen <yuwei.chen@intel.com>
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Abner Chang <abner.chang@hpe.com>
> > Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> >
> > Michael D Kinney (3):
> >   MdePkg/Include: Allow CPU specific defines to be predefined
> >   CryptoPkg/Library/Include: Allow CPU specific defines to be predefined
> >   BaseTools/Source: Remove CPU architecture assumptions
> >
> >  BaseTools/Source/C/GenFw/Elf32Convert.c          | 5 ++---
> >  BaseTools/Source/C/GenFw/Elf64Convert.c          | 5 ++---
> >  BaseTools/Source/Python/GenFds/FdfParser.py      | 4 +---
> >  BaseTools/Source/Python/TargetTool/TargetTool.py | 4 ++--
> >  BaseTools/Source/Python/build/buildoptions.py    | 4 ++--
> >  CryptoPkg/Library/Include/CrtLibSupport.h        | 2 ++
> >  MdePkg/Include/Uefi/UefiBaseType.h               | 4 +++-
> >  MdePkg/Include/Uefi/UefiSpec.h                   | 4 +++-
> >  8 files changed, 17 insertions(+), 15 deletions(-)
> >
> > --
> > 2.31.1.windows.1
> >
> >
> >
> > 
> >
> 
>