From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web12.9080.1597367118370816680 for ; Thu, 13 Aug 2020 18:05:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=ai7xz1oe; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: bob.c.feng@intel.com) IronPort-SDR: K3ExeG9bwM7yS2Kc84AkwZ0wqqxE81mPIPG5stnFBtYMT9iObsCDkOrR3iB8WKzq+IiBakOiA7 rkO5+H7aSwYg== X-IronPort-AV: E=McAfee;i="6000,8403,9712"; a="153569899" X-IronPort-AV: E=Sophos;i="5.76,310,1592895600"; d="scan'208";a="153569899" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2020 18:05:17 -0700 IronPort-SDR: SNqMhl+RavVpM2lAMhboHlYhngb8xkJh5NsPB2lTIJGnj6L7Z0L+YYFvrX85XyDx8oe1JRFxEi 5Slwi5LPtKhw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,310,1592895600"; d="scan'208";a="277002014" Received: from fmsmsx603-2.cps.intel.com (HELO fmsmsx603.amr.corp.intel.com) ([10.18.84.213]) by fmsmga007.fm.intel.com with ESMTP; 13 Aug 2020 18:05:17 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 13 Aug 2020 18:05:16 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 13 Aug 2020 18:05:16 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 13 Aug 2020 18:05:16 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 13 Aug 2020 18:05:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZJEu36sv1skFBw7Ei3B9zugaOM/RfNXVF7bbzWVXdiAoFREdJ014b5PEcUvo3b/aJpRmJQ1YATQSL6CvICbKB4XAwVW5r/GT3yvn2q1J3tdkrpo9yG8gnatcaUh8MRuwa5V5o/hljvRl1vdnTcAxuzXSqz/T1J2+mAJCyzQvesfkr2ufNjC0wakDNj8nWzwJ3yuNaJ0KulekGRf1tbDyOVqhlUk39+s3fUSdiAIBB5qAwo9qvN79f1v824avk6Lc6oT7bm9LNTcpVordKFCg1/ReM9i7m/Qg+jWA7ceQjRTLcRRz4HWlSwqktPX8OT6+kEdAXrPLH+yrd7xqgwh6Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ThCDQOdGyqNfFgR75z7EK2qX+Hlg1Jd7J4SJM6sZL8U=; b=nST0bWNTLzSOZ5rxuU2FFyU5G7a25ZnyksMGGPsXbSWGyUl8Rg2b4qEyJyzvpmFhVUl7SBDsomfUqQGQw+A41H2oOO1VwKl8l7tErqi40rG7nvZuJmbEbyTCkwAq2BgjGeyNX7EbYPh+UvcjWVOTzTw9nAwq8aLiqG+hH5dI26DJbzVXU2cRe8YJ2/F1zdF+Y7yBGyV3VPiypVn9OY7SEMOOLKfx/ZkCKJCG7U1p4LNGjpbiChaVccygigS831JvcsQ3NCBbtfbrK6CdNSdHIDitvrKM9vjCVDxckK+Ba9vzXquFEop+4e2xNQYpxPliaPclWuxvi35uJ3pOYUSJoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ThCDQOdGyqNfFgR75z7EK2qX+Hlg1Jd7J4SJM6sZL8U=; b=ai7xz1oerwoBsOPzruOdXaiODmlmf5gQY/CzxaJuQwXVl/PSyYrbnEMBHmMRx9XkaaYgi4GQoqm+YMsRdr7t8l+W6GSyUPss1xINMBY+fs+JaR/xCL+UMVo83Yqkx0n7ENkshbDf1UdJOe75Sf5cEyx0pzxGgo5imnCE+8emvAA= Received: from BY5PR11MB4070.namprd11.prod.outlook.com (2603:10b6:a03:181::16) by BYAPR11MB2856.namprd11.prod.outlook.com (2603:10b6:a02:bd::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3261.16; Fri, 14 Aug 2020 01:05:14 +0000 Received: from BY5PR11MB4070.namprd11.prod.outlook.com ([fe80::e42f:216e:af3e:8ce5]) by BY5PR11MB4070.namprd11.prod.outlook.com ([fe80::e42f:216e:af3e:8ce5%7]) with mapi id 15.20.3261.026; Fri, 14 Aug 2020 01:05:14 +0000 From: "Bob Feng" To: "Gao, Liming" , "devel@edk2.groups.io" CC: "Chen, Christine" Subject: Re: [Patch] BaseTools: Fix the issue in VS2017/VS2019 setting Thread-Topic: [Patch] BaseTools: Fix the issue in VS2017/VS2019 setting Thread-Index: AQHWcUend8owXnTHGUOo6YP90Y7zr6k2y0/A Date: Fri, 14 Aug 2020 01:05:14 +0000 Message-ID: References: <20200813075905.1729-1-liming.gao@intel.com> In-Reply-To: <20200813075905.1729-1-liming.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 607c061e-b626-4e68-8ebb-08d83fee1a20 x-ms-traffictypediagnostic: BYAPR11MB2856: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cVxlT+i0ZBsB0SHnMenckMl6QONCpQsbzV3qcTidvS3jRJf4Os0uXC9AiI25NQhrkVBBS/9UG++HdS5Hu+9aR7lz8D49ebZvJNowGPHCtis9/T4kOhrkWEPkMYx/sO254vwCHPFHjgM7EIviLEjADmloXY3UWPmFp4Lkkico9uHpxDquQbn98p03UwF02qjDkRsLGdRnmIQhjGD4fHMKOhmxrppeTcnWjD3PU3JBXenhXGPK2R6BTaOkMnLMJ8CLNlyQyxrRiMPOSukzl4w+IIfWJD4WQ6Wclx/7bWE4v+pxlvbChLrTtS82iP6r+5gB1h021a+vfgVtoSaXPCO+5ArEhaGIWVxtTKvdRPiqF0YUu9C1x68XaqADXnsBnm38Ig/mVioh0DlJl7jJZFNwQg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR11MB4070.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(396003)(366004)(39860400002)(136003)(376002)(64756008)(6506007)(53546011)(7696005)(4326008)(66446008)(66556008)(66476007)(86362001)(186003)(76116006)(66946007)(83380400001)(52536014)(26005)(316002)(71200400001)(5660300002)(110136005)(8676002)(8936002)(33656002)(107886003)(966005)(9686003)(55016002)(2906002)(478600001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 5l8Up7iL6qIGRZif1HLbnV7P+/jPHxL6w2QKoyG30kGTUF558or3UEzYSPqbJ/BuTEMxMmtdLXgBgV16ZTx9/xVVzoLtJMwJTxfybzEbXqW+nyv1y5PkDneDOKw9gyX+DS+g7w0r/IIpPUlAlDtEi12jtc2TyfyoZJng8OSzJco8G75UZ2fm4MMwcCeS98+1tPyQESvfUQTldrc9T0Sa/z/JT1YVKjXb+YES0oUj9NHGa1o+UEA2m06pvDb9ufoBelYlTofLqHWtnjRmnUZof8SJD9zxvLgen/XU79mC6jjSPdwdUI8uVqh6yodN1Bm+8hSqcde8Rekw6ePKH5zYbW9WzNkCRa/l4CCQMLQRSfytYorzVYx9Abh7AGbUwK/Zay3WRrSg3f1bi9Uq4fBZmthwu4EMGjUfDspRY+IGM3PK5XdV1hIxNh3QGb+Eoo//F1/mlRf0+lUez3uQcZE7UL1pTzrQpuLexUYZ63qs1THSFI6+zHFVBb3mjhwC7LYpIXq4UeXF9dUZ/P0yhYEY8ex2ezHO5qOENGujI7DrEIiYIj0OZDmfOhPuNZPZAlXz0ARTw0fa3yhTEZFaet0IaPaPQHkIKH5Ha/RBjRwUO+WlCv7Zi7hEXi8VwNgEQwBPl8B4qhfI1S6bIGSA0qbB/g== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4070.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 607c061e-b626-4e68-8ebb-08d83fee1a20 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Aug 2020 01:05:14.4783 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pegO/6UMXuf3IgqgPU5JXQ6ARHfZDczl/QRGgLPWYxtGeDxvEjxD8oCRBqH7qCxeHMWGW/jJc7MJz+Uc/a9RvQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2856 Return-Path: bob.c.feng@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bob Feng -----Original Message----- From: Gao, Liming =20 Sent: Thursday, August 13, 2020 3:59 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Chen, Christine Subject: [Patch] BaseTools: Fix the issue in VS2017/VS2019 setting edksetup.bat VS2017 should set VS2017 only. But now, it will set VS2017/VS2= 019 both. This patch corrects it. Signed-off-by: Liming Gao Cc: Bob Feng Cc: Yuwei Chen --- This patch bases on the change https://edk2.groups.io/g/devel/message/6413= 8 BaseTools/set_vsprefix_envs.bat | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/BaseTools/set_vsprefix_envs.bat b/BaseTools/set_vsprefix_envs.= bat index 2627587ba3..d4eb84f064 100644 --- a/BaseTools/set_vsprefix_envs.bat +++ b/BaseTools/set_vsprefix_envs.bat @@ -167,6 +167,8 @@ if not defined WINSDK_PATH_FOR_RC_EXE ( ) ) =20 +if /I "%1"=3D=3D"VS2017" goto SetWinDDK + :SetVS2019 if not defined VS160COMNTOOLS ( @REM clear two envs so that vcvars32.bat can run successfully. @@ -226,6 +228,8 @@ if not defined WINSDK_PATH_FOR_RC_EXE ( ) ) =20 +if /I "%1"=3D=3D"VS2019" goto SetWinDDK + :SetWinDDK if not defined WINDDK3790_PREFIX ( set WINDDK3790_PREFIX=3DC:\WINDDK\3790.1830\bin\ -- 2.27.0.windows.1