* [Patch] BaseTools: Fix the issue in VS2017/VS2019 setting
@ 2020-08-13 7:59 Liming Gao
2020-08-14 1:05 ` Bob Feng
0 siblings, 1 reply; 2+ messages in thread
From: Liming Gao @ 2020-08-13 7:59 UTC (permalink / raw)
To: devel; +Cc: Bob Feng, Yuwei Chen
edksetup.bat VS2017 should set VS2017 only. But now,
it will set VS2017/VS2019 both. This patch corrects it.
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Yuwei Chen <yuwei.chen@intel.com>
---
This patch bases on the change https://edk2.groups.io/g/devel/message/64138
BaseTools/set_vsprefix_envs.bat | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/BaseTools/set_vsprefix_envs.bat b/BaseTools/set_vsprefix_envs.bat
index 2627587ba3..d4eb84f064 100644
--- a/BaseTools/set_vsprefix_envs.bat
+++ b/BaseTools/set_vsprefix_envs.bat
@@ -167,6 +167,8 @@ if not defined WINSDK_PATH_FOR_RC_EXE (
)
)
+if /I "%1"=="VS2017" goto SetWinDDK
+
:SetVS2019
if not defined VS160COMNTOOLS (
@REM clear two envs so that vcvars32.bat can run successfully.
@@ -226,6 +228,8 @@ if not defined WINSDK_PATH_FOR_RC_EXE (
)
)
+if /I "%1"=="VS2019" goto SetWinDDK
+
:SetWinDDK
if not defined WINDDK3790_PREFIX (
set WINDDK3790_PREFIX=C:\WINDDK\3790.1830\bin\
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Patch] BaseTools: Fix the issue in VS2017/VS2019 setting
2020-08-13 7:59 [Patch] BaseTools: Fix the issue in VS2017/VS2019 setting Liming Gao
@ 2020-08-14 1:05 ` Bob Feng
0 siblings, 0 replies; 2+ messages in thread
From: Bob Feng @ 2020-08-14 1:05 UTC (permalink / raw)
To: Gao, Liming, devel@edk2.groups.io; +Cc: Chen, Christine
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
-----Original Message-----
From: Gao, Liming <liming.gao@intel.com>
Sent: Thursday, August 13, 2020 3:59 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Chen, Christine <yuwei.chen@intel.com>
Subject: [Patch] BaseTools: Fix the issue in VS2017/VS2019 setting
edksetup.bat VS2017 should set VS2017 only. But now, it will set VS2017/VS2019 both. This patch corrects it.
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Yuwei Chen <yuwei.chen@intel.com>
---
This patch bases on the change https://edk2.groups.io/g/devel/message/64138
BaseTools/set_vsprefix_envs.bat | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/BaseTools/set_vsprefix_envs.bat b/BaseTools/set_vsprefix_envs.bat index 2627587ba3..d4eb84f064 100644
--- a/BaseTools/set_vsprefix_envs.bat
+++ b/BaseTools/set_vsprefix_envs.bat
@@ -167,6 +167,8 @@ if not defined WINSDK_PATH_FOR_RC_EXE (
)
)
+if /I "%1"=="VS2017" goto SetWinDDK
+
:SetVS2019
if not defined VS160COMNTOOLS (
@REM clear two envs so that vcvars32.bat can run successfully.
@@ -226,6 +228,8 @@ if not defined WINSDK_PATH_FOR_RC_EXE (
)
)
+if /I "%1"=="VS2019" goto SetWinDDK
+
:SetWinDDK
if not defined WINDDK3790_PREFIX (
set WINDDK3790_PREFIX=C:\WINDDK\3790.1830\bin\
--
2.27.0.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-14 1:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-13 7:59 [Patch] BaseTools: Fix the issue in VS2017/VS2019 setting Liming Gao
2020-08-14 1:05 ` Bob Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox