From: "Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>
To: "Fu, Siyuan" <siyuan.fu@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Ni, Ray" <ray.ni@intel.com>
Subject: Re: [Patch] IntelSiliconPkg: Declare zero array explicitly to avoid compiler error.
Date: Wed, 26 Feb 2020 01:39:09 +0000 [thread overview]
Message-ID: <BY5PR11MB41512383987B20B4D5620A97B6EA0@BY5PR11MB4151.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200226010753.44716-1-siyuan.fu@intel.com>
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>
-----Original Message-----
From: Fu, Siyuan <siyuan.fu@intel.com>
Sent: Tuesday, February 25, 2020 5:08 PM
To: devel@edk2.groups.io
Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
Subject: [Patch] IntelSiliconPkg: Declare zero array explicitly to avoid compiler error.
This patch fixes a potential compiler error introduced by commit b0099a39bd since not all compiler can support empty array member.
BZ: https://tianocore.acgmultimedia.com/show_bug.cgi?id=2449
Cc: Ray Ni <ray.ni@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Signed-off-by: Siyuan Fu <siyuan.fu@intel.com>
---
.../Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h b/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h
index d1a9d79a51..d887b39123 100644
--- a/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.h
+++ b/Silicon/Intel/IntelSiliconPkg/Include/Guid/MicrocodeShadowInfoHob.
+++ h
@@ -33,7 +33,7 @@ typedef struct {
// An array with MicrocodeCount elements that stores
// the shadowed microcode patch address in memory.
//
- UINT64 MicrocodeAddrInMemory[];
+ UINT64 MicrocodeAddrInMemory[0];
//
// A buffer which contains details about the storage information
// specific to StorageType.
--
2.19.1.windows.1
next prev parent reply other threads:[~2020-02-26 1:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 1:07 [Patch] IntelSiliconPkg: Declare zero array explicitly to avoid compiler error Siyuan, Fu
2020-02-26 1:09 ` [edk2-devel] " Liming Gao
2020-02-26 1:39 ` Chaganty, Rangasai V [this message]
2020-02-26 2:33 ` Ni, Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR11MB41512383987B20B4D5620A97B6EA0@BY5PR11MB4151.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox