From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web12.566.1582615226491703480 for ; Mon, 24 Feb 2020 23:20:26 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=wTxqX6RU; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: rangasai.v.chaganty@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Feb 2020 23:20:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,483,1574150400"; d="scan'208";a="237588474" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga003.jf.intel.com with ESMTP; 24 Feb 2020 23:20:25 -0800 Received: from fmsmsx162.amr.corp.intel.com (10.18.125.71) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 24 Feb 2020 23:20:25 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx162.amr.corp.intel.com (10.18.125.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 24 Feb 2020 23:20:24 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 24 Feb 2020 23:20:25 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eAuzT+iz4Ipia+eN6bWkTBV1ExhFy3eemCg+aOQBUNbLhh87XfCyMpRcP5oSv70zQUsZxhrQlY4oAC8FWFwaAEPAfPj7nz2f8t1yE4rH/x1ZX6EMa5iLRIASJqRBQez+Jn11ig7rud+UtTXxcK4+KrMN/9G2lEDf9UVDXY/CygIEngL7ZeO/lelNix5eLgCcJ7euB/bpdyMWlY3cbml7JlAVRg90wE8iUiRw9SB8Ad8+JvZ8RHgmIXrhoQKk3YVI7nueTkU5lVsv/6ply6ShWovJVzC1cfkgi8Wgmlj0NSGYz/cS9zFcSXj/6EPAYIWk4aQ8NKKRRe8V+4eIIBQyIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S0rKLU6CEk37X8pPfd3vMKk8tSfWBEPn4nTtiPDCWy4=; b=mMoZxsHjif4KyPxDBOYwlUjA4DfJS/LXgpYteULtQlV75xGchSYCk5CBmAFyMAs2n8Wumlxtn+SixRClD1y4iOW0ztptxaC2fJ6EtZA/UA1zIYsQJs3dVydt4NaYUgYAzNvzTb1LQBfI448eRy/js7g0avMNjQtycdiMeNBJg8CWL4NCLCdDUI9hWwk4FhfEXNqFbjhT+b7UfgHlNLduqRZ+bTUejJel4B85VdRmLNuCFYTC+PDr02f3H8WLLIEHFHi2Ewv1I250bcifm5cO6Mm4HVWqIuc+x0MwwyO3G+jvthXXgWj/RQ6AKGJRiYzhyEpsJY1izG2YqVcT+ICJ1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S0rKLU6CEk37X8pPfd3vMKk8tSfWBEPn4nTtiPDCWy4=; b=wTxqX6RUzzpTftWax3jm5C69CwaWMj2kXE7p+lNuGB3owywdYM+Vu/zsL0wh0cNpoiYW/Rmb07FM4KWchAv3L20hhTBFuSYB+HTiL0t5Nu6pFnfgXCDSbDl8ZkJ15/a1ILyl5dPbsA4ISOFofzbugr5+H2F/XuwSZfyn4SWpNuM= Received: from BY5PR11MB4151.namprd11.prod.outlook.com (2603:10b6:a03:18f::22) by BY5PR11MB4372.namprd11.prod.outlook.com (2603:10b6:a03:1bb::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2750.17; Tue, 25 Feb 2020 07:20:22 +0000 Received: from BY5PR11MB4151.namprd11.prod.outlook.com ([fe80::85c1:670e:7f34:6ca9]) by BY5PR11MB4151.namprd11.prod.outlook.com ([fe80::85c1:670e:7f34:6ca9%6]) with mapi id 15.20.2750.021; Tue, 25 Feb 2020 07:20:22 +0000 From: "Chaganty, Rangasai V" To: "Shindo, Miki" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "Agyeman, Prince" Subject: Re: [edk2-platforms: PATCH] MinPlatformPkg/PeiReportFvLib: Install FvFspT in PeiReportFvLib Thread-Topic: [edk2-platforms: PATCH] MinPlatformPkg/PeiReportFvLib: Install FvFspT in PeiReportFvLib Thread-Index: AQHV6SDfCqH/5/aBD0aDW6HmgZiMAKgrhb5Q Date: Tue, 25 Feb 2020 07:20:22 +0000 Message-ID: References: <20200222013731.16204-1-miki.shindo@intel.com> In-Reply-To: <20200222013731.16204-1-miki.shindo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjc5OTNlZTItMzM5Ni00ODJhLTgzNzctMGEzMjE4YTM5NjAwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZnZCMUk5OTBEc0RlVkl0Z012RTh4angrQ2NhRkhzZ1E0akxRZEJmT2RmYTd3a1RteFJzQkRENUpkK2E2bDcxcyJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=rangasai.v.chaganty@intel.com; x-originating-ip: [134.134.136.201] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5d7aa927-0181-4481-fcc2-08d7b9c32d6e x-ms-traffictypediagnostic: BY5PR11MB4372: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0324C2C0E2 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6029001)(366004)(136003)(346002)(376002)(396003)(39860400002)(189003)(199004)(33656002)(26005)(2906002)(54906003)(110136005)(19627235002)(55016002)(71200400001)(5660300002)(316002)(52536014)(7696005)(9686003)(966005)(4326008)(81156014)(478600001)(66556008)(81166006)(107886003)(6506007)(8676002)(66446008)(64756008)(86362001)(8936002)(186003)(66476007)(76116006)(66946007)(53546011)(40753002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY5PR11MB4372;H:BY5PR11MB4151.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8yWz7xJcLpmBR+EHOI1pyiNRbmCYLHym0nOhCJ1+hW5gi+RVMH3ubO+oAXwYmnSEgWbzWi1VimuB5v5aJPq5V9BQurPStAY0Z87TatcU4s2uC7WapcTHMfg55Gw2MxOav5y7JVY4HNNjnitE8vDArw14RWSj+omGH8SlAB3RdqOFRVz49JJ9gGZj8hsFEAHPOAIEnKQjGCL90fysT0Na3JKimtCrX56UQaThNP6X/rTJjtyVinZv52IMRccjSIhXVU+0cv05KdU71B5T1gVsUVblYj+ByDCOUByE0+dKIuWx4SaGf8oY55rQZjdg93/QVQiOj72l5wfxru6mTpj0txXeLQkkkpTQFKms14LQu4d8gpScTfE0cD9Vg+rcTXacwexQjwQEkMFblFp521gwrTHPwvyco4c+LNcdCeZ4YugPMEmnzXIZWlo8b3oNwKrtLhJVvVpBGViPk6hlYndljOdRJacjH8xNywKrURgX0EVQ2VlFa0wyo3G4+yqhRF8DsMKUpSJpIgjxN3OirTn/pKi1tx6br5ta+GveVIpMUAb7AdkMuNu8o1WyK/RiW2fJ x-ms-exchange-antispam-messagedata: MTLh+FUB76PVeUGaPITjNi4Vo0VFOsSu/fJYJBtgJ9cLBmpmRICnmk9Gc6+YJYI5hylE8T+SgJ+uRUIgZRzmnnaGbt3bcFO5baGK1L/AXEBgmmyx/BIoTBK0Pc0NLhQ1KS7Utv3Pj3xf5LnvPzqUnw== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 5d7aa927-0181-4481-fcc2-08d7b9c32d6e X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Feb 2020 07:20:22.6665 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vGb66Q+d1nvjz/TpAv+dk2rq+A4CIMh6N7aWVMF/0ACpEBF4XBu09v26xsiTL+yTsnzy+A1U2pQm7YTYhPSSVMICmNXCQxEny2NsmNUpYa4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4372 Return-Path: rangasai.v.chaganty@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sai Chaganty -----Original Message----- From: Shindo, Miki =20 Sent: Friday, February 21, 2020 5:38 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L = ; Agyeman, Prince Subject: [edk2-platforms: PATCH] MinPlatformPkg/PeiReportFvLib: Install FvF= spT in PeiReportFvLib REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2410 TPM measurements in PEI runs on FV_INFO_PPI notification function. Currently FvFspT is not installed so it is not measured by TPM. This commit makes FvFspT installed by FV_INFO_PPI so the measurement would = run for FvFspT. FvFspT code actually runs, it has to be measured. Signed-off-by: Miki Shindo Cc: Sai Chaganty Cc: Chasel Chiu Cc: Nate DeSimone Cc: Prince Agyeman --- .../Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiReportFvLi= b.c | 13 ++++++++++++- .../Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiReportFvLi= b.inf | 4 +++- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFv= Lib/PeiReportFvLib.c b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/P= eiReportFvLib/PeiReportFvLib.c index 0d805d6fe7..6158fc9412 100644 --- a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/Pei= ReportFvLib.c +++ b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/ +++ PeiReportFvLib.c @@ -1,7 +1,7 @@ /** @file Source code file for Report Firmware Volume (FV) library =20 -Copyright (c) 2018 - 2019, Intel Corporation. All rights reserved.
+Copyright (c) 2018 - 2020, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -31,6 +31,17 @@ ReportPreMemFv ( 0 ); } + if (PcdGetBool(PcdFspWrapperBootMode)) { + DEBUG ((DEBUG_INFO, "Install FlashFvFspT - 0x%x, 0x%x\n", PcdGet32 (Pc= dFlashFvFspTBase), PcdGet32 (PcdFlashFvFspTSize))); + PeiServicesInstallFvInfo2Ppi ( + &(((EFI_FIRMWARE_VOLUME_HEADER *) (UINTN) PcdGet32 (PcdFlashFvFspTBa= se))->FileSystemGuid), + (VOID *) (UINTN) PcdGet32 (PcdFlashFvFspTBase), + PcdGet32 (PcdFlashFvFspTSize), + NULL, + NULL, + 0 + ); + } DEBUG ((DEBUG_INFO, "Install FlashFvSecurity - 0x%x, 0x%x\n", PcdGet32 (= PcdFlashFvSecurityBase), PcdGet32 (PcdFlashFvSecuritySize))); PeiServicesInstallFvInfo2Ppi ( &(((EFI_FIRMWARE_VOLUME_HEADER *) (UINTN) PcdGet32 (PcdFlashFvSecurity= Base))->FileSystemGuid), diff --git a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFv= Lib/PeiReportFvLib.inf b/Platform/Intel/MinPlatformPkg/PlatformInit/Library= /PeiReportFvLib/PeiReportFvLib.inf index ef03e110bd..79cd5ee1f7 100644 --- a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/Pei= ReportFvLib.inf +++ b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/ +++ PeiReportFvLib.inf @@ -1,7 +1,7 @@ ### @file # Component information file for the Report Firmware Volume (FV) library. # -# Copyright (c) 2018 - 2019, Intel Corporation. All rights reserved.
+# Copyright (c) 2018 - 2020, Intel Corporation. All rights=20 +reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -36,6 +36,8 @@ gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaSize ## CONSU= MES gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspMBase ## CONSU= MES gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspMSize ## CONSU= MES + gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspTBase ## CONSU= MES + gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspTSize ## CONSU= MES gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSBase ## CONSU= MES gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSSize ## CONSU= MES gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspUBase ## CONSU= MES -- 2.16.2.windows.1