From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web09.1051.1614130166131554831 for ; Tue, 23 Feb 2021 17:29:26 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=lFrZ3EvN; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: jiewen.yao@intel.com) IronPort-SDR: nF5wH0rJbD7GfwglfwhajPgGCIv1dRGOhvWbs3qIFeYTSeEGwQ0/WxibAtZKaJqlPJ8I9xKSP5 0uUw0ZovMBTA== X-IronPort-AV: E=McAfee;i="6000,8403,9904"; a="204464074" X-IronPort-AV: E=Sophos;i="5.81,201,1610438400"; d="scan'208";a="204464074" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2021 17:29:25 -0800 IronPort-SDR: d7P3K23Djp/PBws8UuGynGWO5hUZbHdTBdfL7RdPYLXBtgluFxFa+vS5rnYHHZk0eLrjdOFWcU F0e05wwaZp0A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,201,1610438400"; d="scan'208";a="441917667" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga001.jf.intel.com with ESMTP; 23 Feb 2021 17:29:12 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 23 Feb 2021 17:24:37 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 23 Feb 2021 17:24:37 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 23 Feb 2021 17:24:37 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 23 Feb 2021 17:24:37 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c5xc08DUJOeo5Hz5mkUCca4X+ys2FTsu/Qm3nijv4KA89Wd158yN+dUNlLNOxqG8P9fhC8e1baSQxtVyZriDHOcxRfdpcRrDgKawIVB0Mk1N210wuUcghFubcFmEGk4qUodX5MMzkF4p56wX6f/+FqPLomEvMO4mhzzWt8zuLGYsixIdaqK4hFlXezy2K810rwJSF95F9/e+IEcJMZi+XoZYok7ZqBdHBWUqW6IcNxGHk6Lxs7iChpXJ3DoHkVXJLfw41FtLH68OMOalOseaLItxCYi0l42y6yVaZfesF4mc13VgXfTjcQFCkJbJnuwnz8FCnVj5cB3ZB9cly9+Zgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bu7hLTqBmUg4d5hrwhhafWRvkebTJKB4iGOuU7mPoQc=; b=axhOdXhOLlMf28VBbSoMSbhq/CsDZC+SKfajR3EXxeqg7dTtKS+JDPqjWS5fs6xUlSE5yzS/w95qyjbKt7fTdpAzYeRQgo8oTxMpqfhwC/WDinlYNmyx/mOj1Vh3jbwTtK0vf5qWS9AVzX/DT8Zyr5y3ZXd0q+Uju1glsKndUCm/upQkQmiJCTvIOezQ7Y5kjNt0R7kBqjAbC+IHWP1y8nGQ83/t6zhMD/IoXbxm9uRsS3x0FDAAfgLikCFRhvoMGiYRS06VYrckm5Fe5WiS/YH9+GXTf3jN6WSkreCFXT8/0B3yNe8ViJZICnjT+dL7GcY+GhfaEc9y+kVsJJtOxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bu7hLTqBmUg4d5hrwhhafWRvkebTJKB4iGOuU7mPoQc=; b=lFrZ3EvNNllS/FSDH5Nv5G/v8D6CgRZmlxSKk8w4dGDA0iBeMa0TUCof9//M279W/RSGhxmKMsfs7IdOiDX0qpmbiZEewYxIznxPluOMKCwhGTq2yxC4Rr6oVaVcmEpvJ5v+bTUtpcTi722g1u8+s3MJSwy1yqskqALbT8DATJE= Received: from BY5PR11MB4166.namprd11.prod.outlook.com (2603:10b6:a03:191::25) by BY5PR11MB3928.namprd11.prod.outlook.com (2603:10b6:a03:188::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.27; Wed, 24 Feb 2021 01:24:36 +0000 Received: from BY5PR11MB4166.namprd11.prod.outlook.com ([fe80::5983:f233:56d6:8132]) by BY5PR11MB4166.namprd11.prod.outlook.com ([fe80::5983:f233:56d6:8132%4]) with mapi id 15.20.3868.033; Wed, 24 Feb 2021 01:24:35 +0000 From: "Yao, Jiewen" To: Kun Qin , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Zhang, Qi1" , "Kumar, Rahul1" Subject: Re: [PATCH v2 6/6] SecurityPkg: Tcg2Acpi: Added unblock memory interface for NVS region Thread-Topic: [PATCH v2 6/6] SecurityPkg: Tcg2Acpi: Added unblock memory interface for NVS region Thread-Index: AQHW/0uj1/lhEekOy0OjKU2O1G3Zr6pmmPZA Date: Wed, 24 Feb 2021 01:24:35 +0000 Message-ID: References: <20210210012457.315-1-kun.q@outlook.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: outlook.com; dkim=none (message not signed) header.d=none;outlook.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [101.87.139.49] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 511b6a9e-9faa-44d4-acce-08d8d862f27f x-ms-traffictypediagnostic: BY5PR11MB3928: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vBDd5zYYqvr4QjllQ6a8U8RuN9GPNOOgdxzFsdlYhP/btnYByFiZNmrevaeFCH8Ufx5VYwF0zmVxgKUWdNKDS0VSxR0UNgW/7E8tdpXU34whRbsjcoRaFSPkvlO7Vg+ey6RQ1Iultzg7KVXC+AFY4STYTnyWpC9hxOBPzj+/FiEAU8a2ZO3D7lJoxSPxcmWiwBk+k6vuUv2JDjmcpcvfuCxUdVOhG8Py3RLT4Mn6cNDJCGfCIMDdgu3pbrUC0c6ZSRnT1//yi/WwrknQY6HxiAiV/P18NqgOA9LpeNh8smos+uHBlhj1kZjDVPOEsMn/Y1iUfAq20LPmPmHKUcPa41vSuzCGhyosGyHp+jJZKp/wdjwZN8GRVLnyGukAoefX385g0my0htx+gyOiZz6NYr72GXeaap7AP0R/TjeLwLT8HQI6SrvHuFBA/xcag+bXbmiGVP1mBSqvoEDHxw2DAqXEFzbR5/mbTfQwn9DhGtPXUJNeNrgDPw1ufHJp6HZTlyXfT0yC96MiulLTiN/yhQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR11MB4166.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(396003)(136003)(366004)(39860400002)(346002)(52536014)(186003)(478600001)(8676002)(76116006)(15650500001)(33656002)(7696005)(2906002)(53546011)(8936002)(86362001)(64756008)(66556008)(19627235002)(110136005)(6506007)(107886003)(55016002)(66446008)(5660300002)(66476007)(66946007)(9686003)(316002)(83380400001)(4326008)(26005)(71200400001)(54906003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?ZX4gL2fOx8rdGSQLdRZ/OAzR1YxqvB4aqG8v7DiY90hXG/HL7YkhJA67mMBj?= =?us-ascii?Q?mMwzUa/8uJ+YQU1hG+xR3WLaJGZxL3C2XuiX/0Sq29wIKKxj6fD5q/hDmjfd?= =?us-ascii?Q?1baB+GISO7vjWpaJks9LJmo0LwydN1MbMVQC480TWMsSYWMiWFR1asXnLQOZ?= =?us-ascii?Q?KUJUwwCH5ZhKusbAfa6EDI8PCc/VAuh3E3gATRf5fBuvf0UHLnScpxCT4YFR?= =?us-ascii?Q?HqzMhQj2ZF11IrYShrgzRxdlOqqQoDnkuQelhbZioG0pv9AX8I32fjsYIo4G?= =?us-ascii?Q?LvCsehe1W0/DoOXSxIDLWB2ORjJJ3C6cfG+cJtyKl3Vh5rtk/bbUsuKnX0TT?= =?us-ascii?Q?bS0pGZfiBE4i2wSQ4lcxFXIBMpGHKbugr/ykxi6QU2sT9Be7rUbNdx8kiFtv?= =?us-ascii?Q?KUDu6RROAIE/mWsBE6sdZ+DRaWXdou4LN3K32oVvhZspaETo/tVjpEjm+GrM?= =?us-ascii?Q?eK26hzBbDq5IIM5Zr3NqFPq1B6Xi+Nzi2w81Lp6RNpd1qTeu62qTkOaYurzh?= =?us-ascii?Q?txYv/6F4mDga9yspXpbUl1JzF4TIf3hxIkVeAhUcSE4TrmU8CvKftAD9npYN?= =?us-ascii?Q?bEMA2/5/f9Gj8xwvfT0QOo2F7iJQiBEP2XOt2INaU061eFbMGCC6R5t0Y+NW?= =?us-ascii?Q?O3hnjMvzj9FTEJqOpOoIgRP2Ya5CedVrlaYjQKPVmMNqyzngRPmkEJQmQoLU?= =?us-ascii?Q?GkRd0wq8QIHeh6fR8IlHJghNS8s9hFN5SL0hIGRi46sJFQqEPi1UkXFc6pSg?= =?us-ascii?Q?PPbjM3Ism0PnEWY/aJaW4QMynDsG0XKHsmGDS8WkqH7l7WIeWWhtr5vhnjbW?= =?us-ascii?Q?atzXkb1MT6bxSk8+/mA3GoWnkXViy50U7+AyLs9yvkXuFOPFSyEMT95/qFsx?= =?us-ascii?Q?uqWP1gG/yACq/GtwvONBSUdCm1l4kh+mfj1V/Hv1mi0vRbF/zlMYBikJ6gwC?= =?us-ascii?Q?+ohb4WsQSJOr6zUdDeZDH6SE5mngB8JAgQtNwER6uR7RmCux4AaPYlPKpc8C?= =?us-ascii?Q?WOTELJ6k0i6qG8Dp+EJc532Qg/u3wKzUyTHShweufQZ0+FON7RCPOrv1sIsC?= =?us-ascii?Q?lbxlorVziky/f4JU5FzpX8CwhxhJdKczKCWKdb/1ubsxrUk2CWb1cstdZ7FY?= =?us-ascii?Q?KV4a8PoUYJL56CG3FFC5cOn9rgubsoPYtKprfrHJwFdZ58XolLpAx6/n8S3k?= =?us-ascii?Q?sSAOVGN09Cr0xQv8MwfdoKKDmOrq/qVqu3CJ5G31ReDV4ev7t1nGmQZqWHT7?= =?us-ascii?Q?bRsvRZDMDJx3y7vA+QQ3YR7iJrKLS7gCUR9buIeam1G0Z66srJmCWAkM3bhJ?= =?us-ascii?Q?lnfiDQDq7m7eJ8qx4kA/rDNe?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4166.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 511b6a9e-9faa-44d4-acce-08d8d862f27f X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2021 01:24:35.8823 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dXGDdJrXzgMaM7uGSEuGmWPgQvfTsnLeVtIar/PdTN948CbLlY3z4enqilym1n3VGC+cKRbBRZuFCj+0D7+JFA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB3928 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen Yao > -----Original Message----- > From: Kun Qin > Sent: Wednesday, February 10, 2021 9:25 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Zhang, Qi1 ; Kumar, Rahul1 > Subject: [PATCH v2 6/6] SecurityPkg: Tcg2Acpi: Added unblock memory inter= face > for NVS region >=20 > This changes added usage of DxeMmUnblockMemoryLib to explicitly request > allocated NVS region to be accessible from MM environment. It will bring > in compatibility with architectures that supports full memory blockage > inside MM. >=20 > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Qi Zhang > Cc: Rahul Kumar >=20 > Signed-off-by: Kun Qin > --- >=20 > Notes: > v2: > - Newly added in v2. >=20 > SecurityPkg/Tcg/Tcg2Acpi/Tcg2Acpi.c | 6 ++++++ > SecurityPkg/SecurityPkg.dsc | 1 + > SecurityPkg/Tcg/Tcg2Acpi/Tcg2Acpi.inf | 1 + > 3 files changed, 8 insertions(+) >=20 > diff --git a/SecurityPkg/Tcg/Tcg2Acpi/Tcg2Acpi.c > b/SecurityPkg/Tcg/Tcg2Acpi/Tcg2Acpi.c > index 7080df81efe7..cc37a8d5b9d9 100644 > --- a/SecurityPkg/Tcg/Tcg2Acpi/Tcg2Acpi.c > +++ b/SecurityPkg/Tcg/Tcg2Acpi/Tcg2Acpi.c > @@ -36,6 +36,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > #include > #include > #include > +#include >=20 > // > // Physical Presence Interface Version supported by Platform > @@ -145,6 +146,11 @@ AssignOpRegion ( > ZeroMem ((VOID *)(UINTN)MemoryAddress, Size); > OpRegion->RegionOffset =3D (UINT32) (UINTN) MemoryAddress; > OpRegion->RegionLen =3D (UINT8) Size; > + // Request to unblock this region from MM core > + Status =3D DxeMmUnblockMemoryRequest (MemoryAddress, > EFI_SIZE_TO_PAGES (Size)); > + if (Status !=3D EFI_UNSUPPORTED && EFI_ERROR (Status)) { > + ASSERT_EFI_ERROR (Status); > + } > break; > } > } > diff --git a/SecurityPkg/SecurityPkg.dsc b/SecurityPkg/SecurityPkg.dsc > index 37242da93f3d..d937521db388 100644 > --- a/SecurityPkg/SecurityPkg.dsc > +++ b/SecurityPkg/SecurityPkg.dsc > @@ -67,6 +67,7 @@ [LibraryClasses] > VariableKeyLib|SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNu= ll.inf > RpmcLib|SecurityPkg/Library/RpmcLibNull/RpmcLibNull.inf >=20 > TcgEventLogRecordLib|SecurityPkg/Library/TcgEventLogRecordLib/TcgEventLo > gRecordLib.inf > + > DxeMmUnblockMemoryLib|MdeModulePkg/Library/DxeMmUnblockMemoryLib > /DxeMmUnblockMemoryLibNull.inf >=20 > [LibraryClasses.ARM] > # > diff --git a/SecurityPkg/Tcg/Tcg2Acpi/Tcg2Acpi.inf > b/SecurityPkg/Tcg/Tcg2Acpi/Tcg2Acpi.inf > index d8e06881c01d..60455610f9f6 100644 > --- a/SecurityPkg/Tcg/Tcg2Acpi/Tcg2Acpi.inf > +++ b/SecurityPkg/Tcg/Tcg2Acpi/Tcg2Acpi.inf > @@ -55,6 +55,7 @@ [LibraryClasses] > Tpm2CommandLib > Tcg2PhysicalPresenceLib > PcdLib > + DxeMmUnblockMemoryLib >=20 > [Guids] > gEfiTpmDeviceInstanceTpm20DtpmGuid ## PRODU= CES ## > GUID # TPM device identifier > -- > 2.30.0.windows.1