Re: [Patch 3/3] CryptoPkg/Private/Protocol/Crypto.h: Remove duplicate function type

["Yao, Jiewen" <jiewen.yao@intel.com>]

Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

> -----Original Message-----
> From: Michael D Kinney <michael.d.kinney@intel.com>
> Sent: Wednesday, March 31, 2021 7:04 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>;
> Lu, XiaoyuX <xiaoyux.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>
> Subject: [Patch 3/3] CryptoPkg/Private/Protocol/Crypto.h: Remove duplicate
> function type
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3287
> 
> Remove duplicate declaration of the function prototype
> EDKII_CRYPTO_RSA_GET_PUBLIC_KEY_FROM_X509.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  CryptoPkg/Private/Protocol/Crypto.h | 28 +---------------------------
>  1 file changed, 1 insertion(+), 27 deletions(-)
> 
> diff --git a/CryptoPkg/Private/Protocol/Crypto.h
> b/CryptoPkg/Private/Protocol/Crypto.h
> index c399e0d67ae0..17930a77a60e 100644
> --- a/CryptoPkg/Private/Protocol/Crypto.h
> +++ b/CryptoPkg/Private/Protocol/Crypto.h
> @@ -2,7 +2,7 @@
>    This Protocol provides Crypto services to DXE modules
> 
>    Copyright (C) Microsoft Corporation. All rights reserved.
> -  Copyright (c) 2020, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2020 - 2021, Intel Corporation. All rights reserved.<BR>
>    SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  **/
> @@ -1106,32 +1106,6 @@ BOOLEAN
>    IN  UINTN                         SigSize
>    );
> 
> -/**
> -  Retrieve the RSA Public Key from one DER-encoded X509 certificate.
> -
> -  If Cert is NULL, then return FALSE.
> -  If RsaContext is NULL, then return FALSE.
> -  If this interface is not supported, then return FALSE.
> -
> -  @param[in]  Cert         Pointer to the DER-encoded X509 certificate.
> -  @param[in]  CertSize     Size of the X509 certificate in bytes.
> -  @param[out] RsaContext   Pointer to new-generated RSA context which
> contain the retrieved
> -                           RSA public key component. Use RsaFree() function to free the
> -                           resource.
> -
> -  @retval  TRUE   RSA Public Key was retrieved successfully.
> -  @retval  FALSE  Fail to retrieve RSA public key from X509 certificate.
> -  @retval  FALSE  This interface is not supported.
> -
> -**/
> -typedef
> -BOOLEAN
> -(EFIAPI *EDKII_CRYPTO_RSA_GET_PUBLIC_KEY_FROM_X509) (
> -  IN   CONST UINT8  *Cert,
> -  IN   UINTN        CertSize,
> -  OUT  VOID         **RsaContext
> -  );
> -
>  /**
>    Allocates and initializes one RSA context for subsequent use.
> 
> --
> 2.31.1.windows.1