From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.1553.1617146067831718696 for ; Tue, 30 Mar 2021 16:14:28 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=qk2flvT0; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: jiewen.yao@intel.com) IronPort-SDR: 4CZDHcDR/5K50lXQn+mMkTYvUAyL6w2h1pTxfGDYSiXLxMdTT1XvQwYxCBaJj1QQlvhnLt0tAW aHwsGobLKH7g== X-IronPort-AV: E=McAfee;i="6000,8403,9939"; a="191351115" X-IronPort-AV: E=Sophos;i="5.81,291,1610438400"; d="scan'208";a="191351115" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2021 16:14:26 -0700 IronPort-SDR: eYiqV2n5jVy/t0jdGCwWqDrIDUb7nwzVBEn+kkhchQ3+Xv7jzaOsWOJrQ+Hmj69C2xe/KrPhJ1 SEHHkXLeiUpQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,291,1610438400"; d="scan'208";a="455226117" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga001.jf.intel.com with ESMTP; 30 Mar 2021 16:14:26 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 30 Mar 2021 16:14:25 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 30 Mar 2021 16:14:25 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 30 Mar 2021 16:14:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P2Bs+X6d8RJaQbdS/lya3oAZyAVlvFh4dgbj8a4csDxBFaD9dhH8yVADRppd8scp+yC8LeUN/N3rC2wF43ZmeuEf/SmMlgmN743pmR265xuw3fwi6BgZeL6Ldb+ggP6J5NqFXkgsZw4pA/Bc7FuV149f7a0AqhrnaO6DwPzRXGvA8QSbaVxeJ+xF6E5LuV0jmzduC6t8LGRx/yyGwyqLDYdbtZJPE8htEnxZ496at5N8SQrOr+MFVaAP3RmJTBRRaMnaJ8i7rTGutBmPsH6HqKX1tr0bLY4lXl0Y0ef59GnA21P2krAeNdFYUUFGvlRVU8D/Ass5awbpL6ygnLRxhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5RpJqqYFij7s+1i3hu4J4mjJluTI5wHc2QBLpxtxnMA=; b=klOGO7VFqvIHftzmo+URsHlhSGeO0P+aUNzZXXzZBhyUoc0eAVs+jzD2Y6QtVsr9SRitYBY8TVDc1HV4ilte3X2GprahVOhY3Wvsf4XMEKh40MdjsXYxPEm7fYrcnN0BIIoZLdTbaOiigsjf0KHIZtyqXhjhZdVaaqnI+y82ZLQ5gI4h5kJjsHI5uMItXh4Mjsb54PuF1+tJPKjQLHjHDtaAQejw6MBGCbGEs6v///fH9EEXRjXNdYX3YYOPMPdgU0V4Ob7mZq4n8rtWPHZeLo3X/P/dnZoy5q4y4GqB28QzR21fLPE+rCkfbPGX4YsrJEJszuZtFLPurKxEmOWMAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5RpJqqYFij7s+1i3hu4J4mjJluTI5wHc2QBLpxtxnMA=; b=qk2flvT0QoS9o2nQxRcH0F99agRGeAesSjEydPP68nlx1F7VgTPshkPzFHBy5eRVER6ymdVQgBuoZSDiPcGg7+CZjuKZvCp5IOSP+soXEcJPSA7MLbJveJ+jIoEG9A+xKPyFU2RBIFA4byRJMVIfUGBiM2dIgvSmlFFhJi5jyTI= Received: from BY5PR11MB4166.namprd11.prod.outlook.com (2603:10b6:a03:191::25) by BY5PR11MB4196.namprd11.prod.outlook.com (2603:10b6:a03:1ce::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.31; Tue, 30 Mar 2021 23:14:23 +0000 Received: from BY5PR11MB4166.namprd11.prod.outlook.com ([fe80::5983:f233:56d6:8132]) by BY5PR11MB4166.namprd11.prod.outlook.com ([fe80::5983:f233:56d6:8132%4]) with mapi id 15.20.3977.033; Tue, 30 Mar 2021 23:14:23 +0000 From: "Yao, Jiewen" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Lu, XiaoyuX" , "Jiang, Guomin" Subject: Re: [Patch 3/3] CryptoPkg/Private/Protocol/Crypto.h: Remove duplicate function type Thread-Topic: [Patch 3/3] CryptoPkg/Private/Protocol/Crypto.h: Remove duplicate function type Thread-Index: AQHXJbkKmaJ65IBIKEahnV+U4LqctKqdKVVg Date: Tue, 30 Mar 2021 23:14:23 +0000 Message-ID: References: <20210330230405.1162-1-michael.d.kinney@intel.com> <20210330230405.1162-4-michael.d.kinney@intel.com> In-Reply-To: <20210330230405.1162-4-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [101.87.139.49] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ad591175-2d05-46af-e4a2-08d8f3d18e29 x-ms-traffictypediagnostic: BY5PR11MB4196: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:49; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BKc6iDCzBd1sdQ2Y2p2nc+Woj+hD2z7RJsZvgQmgFIdsbFgS4FSxP5k/Ap3JvrY9DrsL3R9niGXRllylwfl/1+IdL9/ihm5rHqsqRKfzOxSHzOA+ki2fCbbTT0N26nqVjztvnrvy6m9uAKGVWBz9Ec1Mgrrt8S/cTNhAya0C+UNxY8SZYGmFM+2bl4M5FdWYHUzmZs4bt9uzBQISdxq26L2oqZ0HSiIVALFwteVh84cc6NzBiDQZvQ78tivV3/ukYvtSMd4U8d0iPIkPP6hDXykBDtHwaMKsLaQ5WMQVq5JGAyU712oOMfPUWA+7/MWNIiv1CiZeiczoUX1eAIY+I1zqaUUJTHqzkASyaV6i+/gItX6Oy2Wv4u5YB6B4z9EvqWuzVGcAfBgrTiU/BiIl1iVwpmb3EEuh/3srGcCsqm4PucLNKajGe6dhefWcH3dmT+FF8B2jMmemAMnl/10B6EpHjJKCBfTa+JHLSJ5p8ubMQtAywQ2uUsoM5N1hdRAunSzzMlNRP0PRa8ci3WVi+XlrIxjW9u5ArUHcuMIROrxIveJMEm/XIc+sJjbaiNibcbP32ST5AT4jnt7tQx27rrHwDIRMeUtqQtG77O7pc1ImXaw9CtGEzjTlhaUvr264IJsnlH3JxiMMA1dkzwYip/vkjH4zh/03PaAu3LxrW4xctI/tlyo8f92vtHG02OTXI/46Hf143sCfM3hmCL3bzLvv8cMjxDyvYzKy9+5XkZBt0RT/+l0+gaZYd7ovy+YL x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR11MB4166.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(366004)(346002)(376002)(396003)(136003)(76116006)(83380400001)(5660300002)(966005)(478600001)(4326008)(52536014)(316002)(45080400002)(2906002)(53546011)(66446008)(33656002)(107886003)(110136005)(6506007)(64756008)(66946007)(71200400001)(38100700001)(7696005)(9686003)(8936002)(54906003)(66556008)(55016002)(8676002)(86362001)(186003)(26005)(66476007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?CNGTPHqqOOBJ1SoNcDEG9TTETqprEAoa72goZR00HVb0RGJ7GYmsUc0cCz3R?= =?us-ascii?Q?6+VSEVJO0MCFTVbJpU31YhQGm4P7PeEz5LOHO9moeQBXqnC1MR64h5P/rDff?= =?us-ascii?Q?f7A7MOz3/3dL18q5rkd3Ne639JVxoITvX4BsKnEdS3uxMYYAnwW3Uz9zmLhx?= =?us-ascii?Q?lozBzkS0zKQJEPNi/2NVzyuBvdsnI/Nk4tVciF7d6Gge8lQZmHkp4NSpijhL?= =?us-ascii?Q?MmofO6O41iQbh2LrJ7dwb1KcZzgiOKpW4q/zyXDkh4H0o+t20y5Nw7L+ynYK?= =?us-ascii?Q?uhmLBTeojl6fMU72OYsKbfK4LiMzuQITUzlmzoy/zWUqCoOizcAeX/lvDBtH?= =?us-ascii?Q?rUT6Mc8rJ0HIDqgZAYDupc7o82BFaXNuiyRoYxkwsIWDjaDnEqNm8Rvxyugu?= =?us-ascii?Q?1ma5Yi3cIN6JFYdwY83tQqntK8Sjxps27ORYDQu0LI2RsMHXcbQsJ5HPfwfu?= =?us-ascii?Q?p+UEFnWQhlOpfgRcFuxHpt5igzQOkYpc6Q+aI7POodaSFTUdi+C27kJZyxhJ?= =?us-ascii?Q?jvaBq2/WI5LVwmaLVq3AaHwShSV+7ENvkM6ZNp/guI+ApPzDymjcFJCer7zb?= =?us-ascii?Q?PQiUoaroKRSYH3cCw4dEmOh3+w+H+ygtuoDzdLwwwSmm20MYrVMMeyvXRa6H?= =?us-ascii?Q?yR3iMGoyEmS0uMT50bhm9Hrl7kIMM5XShYnhSzap/xXGdyL1Azl7sSZb8lVe?= =?us-ascii?Q?FpnwrvubsIZSN1S+9j8pzpSTtoIcgVEFgLqbUtRzCfTKZhva0O9Nwe2t/3Pr?= =?us-ascii?Q?jxy7lRq1vyvw5odwsr4s2mzQe+ooQWPJcz8DFGNZwSXEL7oY+SHQv3JWMU8N?= =?us-ascii?Q?irlE6L16lmRORwsPBa7O5WumegqrcgDqH8TPfUt4WSo2jOeP05Kx68vEQ/dA?= =?us-ascii?Q?rZkHfpPKxErk5jzhzgc9pD4CmkoFmaZ8bGz4bZTba65F+uIBApgnXJ2K3Yhs?= =?us-ascii?Q?i/xedDdGH0UXGFn2bU0OSRSf0pcQ8sYygqENrtCZtUuXN+BhkDMfzPVkG+GE?= =?us-ascii?Q?lGAZyJcMDlsb3VqMwiCNNk6Dcda2m+0lW/Oq55EyowlOurR+6IpePqAJUAx7?= =?us-ascii?Q?B3Jfh9fFIIrS8JTNVgVVp/z8vZQRWkkFZHqqMxSTOQv3RKbr3YEgVPyjRklx?= =?us-ascii?Q?2EfdUygz72jCs5PDQ9SjgF+qImVglCR1riMcqO6Uk9vqV/bQwKh4oK3042Zk?= =?us-ascii?Q?emSRTqYqxF1QvvTfp3V80VL5UJ9CP3BA3LOYhN9pkZNGT8eKTcJwHyRKAVEX?= =?us-ascii?Q?OjgkSCXsT9D5tstEtGwGZxxK2RjlCZmbW1CMTpslU4Zl37ri69YTzox10sM2?= =?us-ascii?Q?j+8EGwlvjEvI1u1Hx9+7WokC?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4166.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad591175-2d05-46af-e4a2-08d8f3d18e29 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2021 23:14:23.0810 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sOQ23sZBxYSm15U/xOFqTmt8tAWmUA1yg632omnyEoiZX9EtXTA94Cb7X/p43oyI/uUh0QRDZSELssWYNnitgA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4196 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen Yao > -----Original Message----- > From: Michael D Kinney > Sent: Wednesday, March 31, 2021 7:04 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Lu, XiaoyuX ; Jiang, Guomin > Subject: [Patch 3/3] CryptoPkg/Private/Protocol/Crypto.h: Remove duplicat= e > function type >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3287 >=20 > Remove duplicate declaration of the function prototype > EDKII_CRYPTO_RSA_GET_PUBLIC_KEY_FROM_X509. >=20 > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Xiaoyu Lu > Cc: Guomin Jiang > Signed-off-by: Michael D Kinney > --- > CryptoPkg/Private/Protocol/Crypto.h | 28 +--------------------------- > 1 file changed, 1 insertion(+), 27 deletions(-) >=20 > diff --git a/CryptoPkg/Private/Protocol/Crypto.h > b/CryptoPkg/Private/Protocol/Crypto.h > index c399e0d67ae0..17930a77a60e 100644 > --- a/CryptoPkg/Private/Protocol/Crypto.h > +++ b/CryptoPkg/Private/Protocol/Crypto.h > @@ -2,7 +2,7 @@ > This Protocol provides Crypto services to DXE modules >=20 > Copyright (C) Microsoft Corporation. All rights reserved. > - Copyright (c) 2020, Intel Corporation. All rights reserved.
> + Copyright (c) 2020 - 2021, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -1106,32 +1106,6 @@ BOOLEAN > IN UINTN SigSize > ); >=20 > -/** > - Retrieve the RSA Public Key from one DER-encoded X509 certificate. > - > - If Cert is NULL, then return FALSE. > - If RsaContext is NULL, then return FALSE. > - If this interface is not supported, then return FALSE. > - > - @param[in] Cert Pointer to the DER-encoded X509 certificate. > - @param[in] CertSize Size of the X509 certificate in bytes. > - @param[out] RsaContext Pointer to new-generated RSA context which > contain the retrieved > - RSA public key component. Use RsaFree() funct= ion to free the > - resource. > - > - @retval TRUE RSA Public Key was retrieved successfully. > - @retval FALSE Fail to retrieve RSA public key from X509 certificate. > - @retval FALSE This interface is not supported. > - > -**/ > -typedef > -BOOLEAN > -(EFIAPI *EDKII_CRYPTO_RSA_GET_PUBLIC_KEY_FROM_X509) ( > - IN CONST UINT8 *Cert, > - IN UINTN CertSize, > - OUT VOID **RsaContext > - ); > - > /** > Allocates and initializes one RSA context for subsequent use. >=20 > -- > 2.31.1.windows.1