From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Sheng, W" <w.sheng@intel.com>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
"Liu, Zhiguang" <zhiguang.liu@intel.com>
Subject: Re: [edk2-devel] [PATCH v5 1/2] MdePkg/Include: Add CET instructions to Nasm.inc
Date: Fri, 26 Feb 2021 01:47:21 +0000 [thread overview]
Message-ID: <BY5PR11MB416625693C5F4833EEFB50B78C9D9@BY5PR11MB4166.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210220031501.24284-2-w.sheng@intel.com>
Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sheng Wei
> Sent: Saturday, February 20, 2021 11:15 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Yao,
> Jiewen <jiewen.yao@intel.com>
> Subject: [edk2-devel] [PATCH v5 1/2] MdePkg/Include: Add CET instructions to
> Nasm.inc
>
> This is to add instruction SAVEPREVSSP, CLRSSBSY and RSTORSSP_RAX in Nasm.
> The open CI is using NASM 2.14.02.
> CET instructions are supported since NASM 2.15.01.
>
> DB-encoded CET instructions need to be removed after open CI update to
> NASM 2.15.01.
> The BZ ticket is https://bugzilla.tianocore.org/show_bug.cgi?id=3227 .
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3192
>
> Signed-off-by: Sheng Wei <w.sheng@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> ---
> MdePkg/Include/Ia32/Nasm.inc | 12 ++++++++++++
> MdePkg/Include/X64/Nasm.inc | 12 ++++++++++++
> 2 files changed, 24 insertions(+)
>
> diff --git a/MdePkg/Include/Ia32/Nasm.inc b/MdePkg/Include/Ia32/Nasm.inc
> index 31ce861f1e..fa42f9d3e9 100644
> --- a/MdePkg/Include/Ia32/Nasm.inc
> +++ b/MdePkg/Include/Ia32/Nasm.inc
> @@ -9,6 +9,18 @@
> ;
> ;------------------------------------------------------------------------------
>
> +%macro SAVEPREVSSP 0
> + DB 0xF3, 0x0F, 0x01, 0xEA
> +%endmacro
> +
> +%macro CLRSSBSY_EAX 0
> + DB 0x67, 0xF3, 0x0F, 0xAE, 0x30
> +%endmacro
> +
> +%macro RSTORSSP_EAX 0
> + DB 0x67, 0xF3, 0x0F, 0x01, 0x28
> +%endmacro
> +
> %macro SETSSBSY 0
> DB 0xF3, 0x0F, 0x01, 0xE8
> %endmacro
> diff --git a/MdePkg/Include/X64/Nasm.inc b/MdePkg/Include/X64/Nasm.inc
> index 42412735ea..e57a803c81 100644
> --- a/MdePkg/Include/X64/Nasm.inc
> +++ b/MdePkg/Include/X64/Nasm.inc
> @@ -9,6 +9,18 @@
> ;
> ;------------------------------------------------------------------------------
>
> +%macro SAVEPREVSSP 0
> + DB 0xF3, 0x0F, 0x01, 0xEA
> +%endmacro
> +
> +%macro CLRSSBSY_RAX 0
> + DB 0xF3, 0x0F, 0xAE, 0x30
> +%endmacro
> +
> +%macro RSTORSSP_RAX 0
> + DB 0xF3, 0x0F, 0x01, 0x28
> +%endmacro
> +
> %macro SETSSBSY 0
> DB 0xF3, 0x0F, 0x01, 0xE8
> %endmacro
> --
> 2.16.2.windows.1
>
>
>
>
>
next prev parent reply other threads:[~2021-02-26 1:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-20 3:14 [PATCH v5 0/2] Fix CET shadow stack token busy bit clear issue Sheng Wei
2021-02-20 3:15 ` [PATCH v5 1/2] MdePkg/Include: Add CET instructions to Nasm.inc Sheng Wei
2021-02-20 5:35 ` 回复: [edk2-devel] " gaoliming
2021-02-22 2:12 ` Sheng Wei
2021-02-22 2:22 ` Zhiguang Liu
2021-02-23 1:01 ` 回复: " gaoliming
2021-02-23 2:21 ` Michael D Kinney
2021-02-25 1:53 ` 回复: " gaoliming
2021-02-25 5:48 ` Sheng Wei
2021-02-25 13:44 ` 回复: " gaoliming
2021-02-26 1:45 ` Sheng Wei
2021-03-01 5:20 ` Sheng Wei
2021-03-01 8:07 ` 回复: " gaoliming
[not found] ` <16682970DB33FFC1.25260@groups.io>
2021-03-02 1:42 ` gaoliming
2021-03-02 4:53 ` Sheng Wei
2021-02-26 1:47 ` Yao, Jiewen [this message]
2021-02-20 3:15 ` [PATCH v5 2/2] UefiCpuPkg/CpuExceptionHandlerLib: Clear CET shadow stack token busy bit Sheng Wei
2021-02-26 1:47 ` [edk2-devel] " Yao, Jiewen
[not found] ` <1665564E9CEC9D4A.5517@groups.io>
2021-02-22 2:15 ` Sheng Wei
[not found] ` <1665F02F00621E09.19946@groups.io>
2021-02-23 7:51 ` Sheng Wei
[not found] ` <166651222AB8BC36.9724@groups.io>
2021-02-25 5:57 ` Sheng Wei
2021-02-26 1:48 ` Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR11MB416625693C5F4833EEFB50B78C9D9@BY5PR11MB4166.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox