From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web12.6169.1616719988510767468 for ; Thu, 25 Mar 2021 17:53:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=TqeqJrIx; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: jiewen.yao@intel.com) IronPort-SDR: 0faKo0jyxEUTHhRk2057/MKWRIhFBTS1vIG+JUkFdhyNq3zPHBjSRsJOaKudFlSYK2I0nnns3t B3iRNXC7dyVA== X-IronPort-AV: E=McAfee;i="6000,8403,9934"; a="276178142" X-IronPort-AV: E=Sophos;i="5.81,278,1610438400"; d="scan'208";a="276178142" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2021 17:53:07 -0700 IronPort-SDR: Ai4+AaQ9yZN3KycpPuCQz2pnv9mFvox4BKWwS7ckDMId+6j1otxxD7zXrXoPcU+k/o73AI/z45 7swVLN5uzMUw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,278,1610438400"; d="scan'208";a="453299327" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga001.jf.intel.com with ESMTP; 25 Mar 2021 17:53:07 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 25 Mar 2021 17:53:06 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 25 Mar 2021 17:53:06 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Thu, 25 Mar 2021 17:53:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NQLjyi2BxJfiNmzkQY5l5VC5Dl2s80243Vh6n8XoNwxj5YaWnHY3zSi/ErpCKYac4Nd3w2tND/FusT/48iXAKjhnShrBGc1em3m0p/xts0R1YZaeGqHyCo/XAlxSF0JoZuLR1OfUimuCYIxqB+hnfMuTNLr2CWfvzSN89OHHOzeM/4OktLHraZl9TQxiebu85zbW1Ri7rxYxu60tUP94qCLqprsnB53nrImh3/Vf1oXKyH1NmchJtLJe8XbVkOd9gAizn0srmWV6RYIa5Ib9tXE+xnF95zLqaGHRXRbBt6jovga8OhtzPYX4pirZ2e460V64thJK7iFeOS73H+PBYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qTWgGOZEfRPEZUqY/nHXUM7XRo/mq9xRjK6N8HycZc8=; b=H9WTxJND3OF/piJ7H8rdNGbqUHajhS6evQmfRtmSgCAgKDIZ5+YtUfw0ug2Sbvriz1pXrJAg3ufX/9H1x5uC0gMUQn+UIC01kcubTbYTxHSZTtGe/9//VL9tXBJGjh6cwKynrtPK93ahYLESkQJCEhEz7Kdv0goUZmD2qdohq+fyXjl/LpUcODsfVxgcZkIp7dvFm8PI2wlMn+xpDmpqEXXVw5KDsDx2htgVKRfVY1L71aQTxs1PJXQZ+eRi0bjylwC9LPbcLsXwMd+oauTs0vzSM2CtqrWWJNlnvX6smWvHDPWh1TzXyLv51PSK6vh9GS5sSEU583eVrexiw5zsCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qTWgGOZEfRPEZUqY/nHXUM7XRo/mq9xRjK6N8HycZc8=; b=TqeqJrIxRJgMJt7LlskHYZDnzGQQC+dE63uS9+71jqN+M93VjWqkI/aEMA9Epx1DHZPH06VZU1kA8/HDTw8YRjoAQ5w9pfK+hOZxg+zTiCTGy64Jrd/wG5D4A26Bqhn/pQpWsgDn0lMrgCdQwc7Awe5juzL4F3NfIwTwiGJ9nGI= Received: from BY5PR11MB4166.namprd11.prod.outlook.com (2603:10b6:a03:191::25) by SJ0PR11MB4992.namprd11.prod.outlook.com (2603:10b6:a03:2d4::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.29; Fri, 26 Mar 2021 00:53:06 +0000 Received: from BY5PR11MB4166.namprd11.prod.outlook.com ([fe80::5983:f233:56d6:8132]) by BY5PR11MB4166.namprd11.prod.outlook.com ([fe80::5983:f233:56d6:8132%4]) with mapi id 15.20.3977.024; Fri, 26 Mar 2021 00:53:05 +0000 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "mikuback@linux.microsoft.com" CC: "Wang, Jian J" , "Zhang, Qi1" , "Kumar, Rahul1" , Kun Qin Subject: Re: [edk2-devel] [PATCH v1 1/1] SecurityPkg/Tcg2Smm: Initialize local Status variable Thread-Topic: [edk2-devel] [PATCH v1 1/1] SecurityPkg/Tcg2Smm: Initialize local Status variable Thread-Index: AQHXIdjv6Hlu2pnN6EaO7WqtTLN8wqqVcP8Q Date: Fri, 26 Mar 2021 00:53:05 +0000 Message-ID: References: <20210326004210.1305-1-mikuback@linux.microsoft.com> In-Reply-To: <20210326004210.1305-1-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [101.87.139.49] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 667f2483-b301-4732-d9a0-08d8eff1845f x-ms-traffictypediagnostic: SJ0PR11MB4992: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:449; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5c0JYA9ILzrY/7/opU0/HSvflaSEIbbKr+utWaK3umrQMri4VcZwOU/ljMu16Bg4SmP+YA+zWr7ja1+tf+vA/AYUTHePBGacveVNJsuNtQzy+POQMsOgnNwLzZ8uTdWQnyy8uv/YdIHWhfwMC5Ul/5KCy1+WK9qEp2sQJqMChcjkG136nJvA7UlgkXWQomSRJO19X3jtHmEHQqk6+faQlTFRLU17SGRCoHl1tqjZHCRTcjlQAop9+44x7YVkamlnnWKYpw4Q4AHiZiVkZbN/jhCZ/6kt5YnRDJ0Ovv6NYbh4Her41kb29IHLY2viZ/RRPf4+iyHsfJdTpZkfp5YdKJGeBR2bixr02BZcR3xzd5WvtIBWCO50ApFIEuo23oWpqiVcTc0GAorilA4ncVkXZz454R7boO6GYL3P4BZhb6A2zOWjRq8z7pROqh1CR4NGfrMUcSbjVgVTXGR1r8J5unr9KGgDxg45OSJ+qNe6Y2z3yFoTIFWb+JcIZjo1EKyap94/jQYFDWoWrgb3BGbKhThjJPHWbDu9KGIyBnXY6Y5fdNT7rbwtjeRiRZYfXsZwuxAwUUAc0GyhkTiPiSbHrkhHqo6WtXL5u41FGVgNfIMldI/v9XiOy/khd5j7gVFtEvY4aQ9Ss2JW1+mxLD9peY/GQTvxKUqbFQYP+F058QozutuvhzpqlF8S2sMhzozDeMg9twfeKGXh/8ov2RGGNzOapixyB3ypJLsjQI+S228= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR11MB4166.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(346002)(39860400002)(136003)(376002)(366004)(19627235002)(316002)(54906003)(26005)(4326008)(8676002)(110136005)(52536014)(86362001)(478600001)(8936002)(33656002)(66446008)(64756008)(66556008)(66476007)(5660300002)(76116006)(66946007)(966005)(55016002)(71200400001)(15650500001)(9686003)(53546011)(6506007)(186003)(7696005)(38100700001)(83380400001)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?0/O2EvqYUmMEadgyB3fUHVyG9nw7+56zf/CVsaV1DE3/tMwXILZF7qwN1QkR?= =?us-ascii?Q?JAkaHfM62oz6041CVpGn8H55WUh2qFAGU5Wtwj+BviLFk1JDj2bMt5mzt/Hj?= =?us-ascii?Q?Qfl0G063LR1zHt2DhrxtxzuYHEQDM8XB20wmA/+RtiJ9mhOuw0KE0EkWjzkZ?= =?us-ascii?Q?ONmsEPJgH7I4ECcUa5jEpuV0H+B9U7wW2Hh9AkKArGnzFnM3gu4IRdWHWuS9?= =?us-ascii?Q?4TWqZX+qgyUJgTXEP9PMPy8lb3y70TssD+VPWBdsl6rUmcn+9cvORvjz0l3s?= =?us-ascii?Q?TG4RurwirWE4uhGL/bHqnNvomIswz4nkdzHfJEwhO6t6XxZJxkFuicAUFI3g?= =?us-ascii?Q?c1VdRcOZmoBS6l/uBoBb2YmsFu+fS9MgJKaTKM1RqtRyVWkplLYSJNKn8wib?= =?us-ascii?Q?/8gqCyatVaOKYJ/OR6NjSiogLUicbF6GH25iIEq2DLplp37ckknApDNqGu92?= =?us-ascii?Q?f/dAg52o+x5R5oA256aDfB+OmD4UuL4TvBgSF2poKMUVPOcPSIJFqqeGlScr?= =?us-ascii?Q?axHOjyfUsaVj7Jk4tfCc8D9SB8iWJlts5Yw2ctKN5RLwbOnakbuQntXl6fkR?= =?us-ascii?Q?7fSWol1+DXtnPh1zVApgcdVQOiqY+EGvSXCeafbXGEEErHTuOTPXd2bugMUC?= =?us-ascii?Q?jpCPIXcLFxo/LnWjigfBa6gr3eRRtPtJoai0PaqZee1S82wBkgsMIQOvLkyn?= =?us-ascii?Q?2G8kPqJksg4tgLjxNuPFR6rVUZo0u71/Upf/+dTUmYrrH5QHFmIuDfqV0j26?= =?us-ascii?Q?c6UDlV2Sua7tuJ7UyKHYqL4M2waS5WY0TmoK4D/iUjJbbyOOrufir3sIHcbk?= =?us-ascii?Q?BvimNpgev4JwHolCPAoRhL+3exXsG4gH4yhlf1iXpYyo/wLHazTRCXp9x11L?= =?us-ascii?Q?LbI5ZHZ+pesDrK51F86IhWc62CrCEKXGkkXbYX/Wuu5Oq+Nqew/UdxF/SQAg?= =?us-ascii?Q?sMRmDnTqMxnt1IwTHor+QTpG8pgOJzVJwP/DfgAPXe4gaP5R4LFGMA7lHlGm?= =?us-ascii?Q?TRx3J5opQY5FKJ7FRn+lAgDw2VDLEl6dMMxpG7caFLuPCjDXNDY/Gg/5+ifx?= =?us-ascii?Q?yCaqjCQQu2UhyxHHjba9iSMW+557W1BK9QIuZmJ91W0nIJc+GEV5m799d7Xc?= =?us-ascii?Q?q45pmig3zJq7hg+5WCAx9W2KcmAhT/6RP1R+LYWwvrYV0dnErWCUIn2/hMBg?= =?us-ascii?Q?XKL3C7YkkzPJRWdbjk9t71j8y9RV9QTetjIqwWittYkDl2tYN9symlR4yJL/?= =?us-ascii?Q?+pi3Ky1lsB2zOo5C2a1yeGpV9Hpwk29pkFACH1Ifru4YyPSZt8ASkV+T7stW?= =?us-ascii?Q?eG6M9eQM8mz98Vdc8/pzbJDQ?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4166.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 667f2483-b301-4732-d9a0-08d8eff1845f X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Mar 2021 00:53:05.8846 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: t9N1p2hwPQZapL/MTKgi5Q4+eThZUQ7GvAm9KjJcxUl1z9LFHXvUBZTXI0E3MviDS+MpBCd3vTTm8G1/U4PCjw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4992 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jiewen Yao > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Michael > Kubacki > Sent: Friday, March 26, 2021 8:42 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Zhang, Qi1 ; Kumar, Rahul1 ; > Kun Qin > Subject: [edk2-devel] [PATCH v1 1/1] SecurityPkg/Tcg2Smm: Initialize loca= l > Status variable >=20 > From: Michael Kubacki >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3277 >=20 > Initializes the Status variable in TcgMmReadyToLock(). >=20 > Fixes a Clang build failure: > Tcg2Smm.c - SecurityPkg\Tcg\Tcg2Smm\Tcg2Smm.c:254:7: error: > variable 'Status' is used uninitialized whenever 'if' > condition is false [-Werror,-Wsometimes-uninitialized] >=20 > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Qi Zhang > Cc: Rahul Kumar > Cc: Kun Qin > Signed-off-by: Michael Kubacki > --- > SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c > b/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c > index 589c08794bcf..f49eccb0bdf4 100644 > --- a/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c > +++ b/SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c > @@ -253,6 +253,8 @@ TcgMmReadyToLock ( > { > EFI_STATUS Status; >=20 > + Status =3D EFI_SUCCESS; > + > if (mReadyToLockHandle !=3D NULL) { > Status =3D gMmst->MmiHandlerUnRegister (mReadyToLockHandle); > mReadyToLockHandle =3D NULL; > -- > 2.28.0.windows.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#73301): https://edk2.groups.io/g/devel/message/73301 > Mute This Topic: https://groups.io/mt/81617668/1772286 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [jiewen.yao@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20