From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web12.6197.1611902140997236431 for ; Thu, 28 Jan 2021 22:35:41 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=DD7axZp5; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: jiewen.yao@intel.com) IronPort-SDR: FRXLOACPubwUXhmWEjwfvtoYUJz8Q7d7rcdMwb4DWMUCgj69OklrU9bZ6rBRZMWcDoqslCb/5X c5uh15/tcJfA== X-IronPort-AV: E=McAfee;i="6000,8403,9878"; a="167474479" X-IronPort-AV: E=Sophos;i="5.79,384,1602572400"; d="scan'208";a="167474479" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2021 22:35:39 -0800 IronPort-SDR: B2rKF0wdF0SpIZWsULeevm9Y9DZTMWaeQCilo65TkzlLnFHe4V8LJYIsJ9u+bzK9QUGYUk2Sqh z42ruBE41NSA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,384,1602572400"; d="scan'208";a="389178748" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga008.jf.intel.com with ESMTP; 28 Jan 2021 22:35:39 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 28 Jan 2021 22:35:39 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 28 Jan 2021 22:35:39 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 28 Jan 2021 22:35:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ThPRZ45CRK1hHVLgsslZjB55jPM49KPGcG/r+1gUnVcpvwIckWZPWG+tLhZYkg/QdUeeouZBxYB2kzrEL/MuNOOnke+4Kls9oogoxCVLI1iZZyMo+Avx+kOGUheMhSjBb5ZBAFil1G5xIfau4+GoGkOnC3WDW8AZlxmJhnWDfCZ9Q3E4nqjvpGiKZk4HQoT2UR0RICZB/sMOv3g4aHqAklKLJSo+qOhpuqzcSIZRmjsAEG68zhKN5EYwSMiYRuMwEPPpCEF4IsLDtfieseqrtDmSk8r8sbQrK9MLRcGCFDznloPAGQqcMD2kjhVcvilQFy5gDXegiO4kkcsVmpAzhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jdoLf3UZYYvMzCQuGDW60dJczwPP6IOOIzZAr+z/cYY=; b=ZHcqqrszn44nGtIlRWAPtV+AHI2y7kous+9QG85TfDmWviGY7wIby3JBxgmUTuQQlP2n173O1zh0xh9DlwP6I+onqrOezr5nhPvNrTjs6kmYZOOUJIQAjbbA7sS5sHsDxHd5BVl8Bi1W6I9y1e0HhRXzjc7oAQRNbHL2wcAhJ5V7Wjc49A/IFpu52vLdyop0VPtZGdIHTmOP0uIYNBn8PIUwPj32itX3c6ng/f9lI7FsSRcCnjqZR6HchsPMhO75lqiABK7S3u8v4slxYJj5hZJx3gh9TJA4ZnACJemRBAFNAeSQdh5BAzTrfIW3wr6myXn+pgkkeLab0WW4nDVu+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jdoLf3UZYYvMzCQuGDW60dJczwPP6IOOIzZAr+z/cYY=; b=DD7axZp5BHtGxx3vPn1hG5GdP+xpxtPEJCo9EtBsiVrDkBZbOc+TL+gT991ygqlW0toxCZhRoxK2fMc/hKfUGsxoOnby7TRmGBVqLfK/k/fulIG7jX9nK3g11LMpN3s9sJjd58aO4ej6QrHf49qNl0XO3MYR1W0//oDE2s43IOI= Received: from BY5PR11MB4166.namprd11.prod.outlook.com (2603:10b6:a03:191::25) by BYAPR11MB2792.namprd11.prod.outlook.com (2603:10b6:a02:c3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.13; Fri, 29 Jan 2021 06:35:38 +0000 Received: from BY5PR11MB4166.namprd11.prod.outlook.com ([fe80::5983:f233:56d6:8132]) by BY5PR11MB4166.namprd11.prod.outlook.com ([fe80::5983:f233:56d6:8132%4]) with mapi id 15.20.3805.017; Fri, 29 Jan 2021 06:35:38 +0000 From: "Yao, Jiewen" To: "Sheng, W" , "devel@edk2.groups.io" CC: "Kinney, Michael D" , Liming Gao , "Liu, Zhiguang" Subject: Re: [PATCH] MdePkg/Include: Add CET instructions to Nasm.inc Thread-Topic: [PATCH] MdePkg/Include: Add CET instructions to Nasm.inc Thread-Index: AQHW9edV5HyCMOuSy06wo4n1pXl186o+JdKg Date: Fri, 29 Jan 2021 06:35:37 +0000 Message-ID: References: <20210129023448.30348-1-w.sheng@intel.com> In-Reply-To: <20210129023448.30348-1-w.sheng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [101.87.139.49] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4eed519b-6dd7-44f2-2f4c-08d8c4201731 x-ms-traffictypediagnostic: BYAPR11MB2792: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eMyzmbSzUM1rQkxq7GJW2o6zKLhwN/WltaB51RvlDMZzopQSCo7QlqGdw4cmaoRZDqE2KEBb11+k3n5hz+hnH9dMjeTFgbWzP6gRGmVzJErBfZlWady7jtkt4odpnwfEa0vObAnP3FOIyhR3sHNtYz9hAVxXlUXydZ9xpIfRbd7e1wesIj6fR6MQ5v3BOI23tGW0kHAcx6Gulmy/ebNl4HrORxV/Xy5c6Qz1YNk/q3RDHFbIMjk+wMDyGLmygh6CZI/ANCaRKPYPv/UpbqczYXnK56pcgT3MCahMb46RnoQvOfAYEDyw6n7ZGHXh8DKTS6F/iIhH0qATFhVLzt1qlI5ZJvl1g4RXC0KSrMKLFaHh57XrHPwOwWCL0sxl2rP2+6temP6U9UUH58QESXsUhCrA+52dl+3248v+rfXo0jzSpXEFbZJLiXoOF6FKLqDBFliE22eLKvxRgwl9E2ykP6eCUYymZ1r394WTCQD0JkeO4TltjKPXYskyowvZPcM4GfY0nlzVLHtzMKJPAwibxvo/StEy6jTMB+/lp9jwG+riELA6exkixr0yG9GCPswXjjTv22LWeFKQqDVTSfW50TjH/BS6dUBHr4akad575mk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR11MB4166.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(136003)(396003)(376002)(346002)(366004)(66476007)(6506007)(186003)(66446008)(64756008)(52536014)(66556008)(2906002)(5660300002)(107886003)(8676002)(54906003)(55016002)(19627235002)(26005)(9686003)(86362001)(33656002)(8936002)(110136005)(83380400001)(4326008)(966005)(7696005)(316002)(66946007)(76116006)(71200400001)(53546011)(478600001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?BRD72vJq74jaivn041jzTM6xc6CPjcCCsN5LJCUcJckPsLxY9JNzYzh+m4LX?= =?us-ascii?Q?D33IKH34V0qjUWOkTKF79XPs0QHNt0ePEU3X711zFbjKjJFZFRAC5eekyr93?= =?us-ascii?Q?sTR1YpPdFa24tJZlnirtDGveMP66T39lWx5XVDxF49fAVb197k7E6ojq3fE2?= =?us-ascii?Q?JUtcEEwilXVes4fdlR7xlEpY65RFWQYfOhTjv5GFwsmZtADBWQZCFolB3nMB?= =?us-ascii?Q?NJ6jFEfl3HK7TX1r/aVAA5tJoWhajxXtbge97ZR91sF0EX6Xr6Ne/HpHlCcT?= =?us-ascii?Q?FGynac/4X+/SQOpKrLerQy1bEeZYBk6KHOiprzUA5IbmhljdHpTkY9E+GHPO?= =?us-ascii?Q?DY0VN2R8XRrH/kLD8v49aiZSm4rvgaFZGXvcEVIZow0vEMkJY+WWAfizndd2?= =?us-ascii?Q?J7Vc4TmYLf9YSOY/qPVv8hQUntwpd0Qe9DMyTQmUpYcH90poWRWfHMBO/Xiy?= =?us-ascii?Q?SaKuV5062BnNauXk0k6YKkjLU/ReZ6keoYo0nfvs3GCTqmclCkLbaFU3ZNMx?= =?us-ascii?Q?Zqh/Udgbz+fiyi3fQYiPA/N3XSsA8/KWgf1GzJjinTdAEuhycr6TY8AXoMBT?= =?us-ascii?Q?DAXx9B05KxliVLW0DhC6nviYO4QT8zkLZomlf9sVJsLBK/5QsbmN6AB93/2K?= =?us-ascii?Q?vqRptzTAfIIdC1+wUHf4y99irwj5c1CsjpuG9as4T1bApqC993wTJ+cM+X/o?= =?us-ascii?Q?JlF3Gb7wGc8oVYWhod79GhThRWEEAip8UeJEuwsTTlMww3n6ZknEwIxwheNC?= =?us-ascii?Q?/g8MxxF5/p5I4LPY8B5fywwlE11YffB8EWJzxjMhAQS+AmhA2zksUtpnFL21?= =?us-ascii?Q?FV3MhIxUMpwH9P8cYxS9i74JkCBpEtbhLvQWak0CA4nOeNXKHYH3Y9QYc1wj?= =?us-ascii?Q?qsjSuLyapJ7lx1zWupWivU+0W+/WA4YwhZ99TIMfYg488O+HapVh71+kMAVr?= =?us-ascii?Q?Q8jRqacZ8Qd8qcYmJXhNTPFElrPxJ3SD+SU2YtCavHqj1O8kT9JlmfFYyd2P?= =?us-ascii?Q?W1heRV22uiklsLoN2sGFwyu8MNHjD3fWltYTL0q8a8wf96c9NG3ewzJapdms?= =?us-ascii?Q?ndYQvjrK?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4166.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4eed519b-6dd7-44f2-2f4c-08d8c4201731 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jan 2021 06:35:37.9342 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FeZ7XfaFpjowyNN6aHEQ94hOzPHFaZvjznOGTvnX59ci+gBdhxXGw0SytU0vwDdFaZAaCd18+ykI0F+HyyI+Rg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2792 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Wei Would you please send out the second patch to consume these instruction? As such people can have a full picture on what the issue is and what the so= lution is. Thank you Yao Jiewen > -----Original Message----- > From: Sheng, W > Sent: Friday, January 29, 2021 10:35 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Liming Gao > ; Liu, Zhiguang ; Yao, > Jiewen > Subject: [PATCH] MdePkg/Include: Add CET instructions to Nasm.inc >=20 > This is to add instruction SAVEPREVSSP, CLRSSBSY and RSTORSSP_RAX in > Nasm, > because these instructions are not supported yet. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3192 >=20 > Signed-off-by: Sheng Wei > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Jiewen Yao > --- > MdePkg/Include/Ia32/Nasm.inc | 14 +++++++++++++- > MdePkg/Include/X64/Nasm.inc | 14 +++++++++++++- > 2 files changed, 26 insertions(+), 2 deletions(-) >=20 > diff --git a/MdePkg/Include/Ia32/Nasm.inc > b/MdePkg/Include/Ia32/Nasm.inc > index 31ce861f1e..9c1b7796ea 100644 > --- a/MdePkg/Include/Ia32/Nasm.inc > +++ b/MdePkg/Include/Ia32/Nasm.inc > @@ -1,6 +1,6 @@ > ;-----------------------------------------------------------------------= ------- > ; > -; Copyright (c) 2019, Intel Corporation. All rights reserved.
> +; Copyright (c) 2019 - 2021, Intel Corporation. All rights reserved.
> ; SPDX-License-Identifier: BSD-2-Clause-Patent > ; > ; Abstract: > @@ -20,3 +20,15 @@ > %macro INCSSP_EAX 0 > DB 0xF3, 0x0F, 0xAE, 0xE8 > %endmacro > + > +%macro SAVEPREVSSP 0 > + DB 0xF3, 0x0F, 0x01, 0xEA > +%endmacro > + > +%macro CLRSSBSY_EAX 0 > + DB 0x67, 0xF3, 0x0F, 0xAE, 0x30 > +%endmacro > + > +%macro RSTORSSP_EAX 0 > + DB 0x67, 0xF3, 0x0F, 0x01, 0x28 > +%endmacro > diff --git a/MdePkg/Include/X64/Nasm.inc > b/MdePkg/Include/X64/Nasm.inc > index 42412735ea..c5189982bb 100644 > --- a/MdePkg/Include/X64/Nasm.inc > +++ b/MdePkg/Include/X64/Nasm.inc > @@ -1,6 +1,6 @@ > ;-----------------------------------------------------------------------= ------- > ; > -; Copyright (c) 2019, Intel Corporation. All rights reserved.
> +; Copyright (c) 2019 - 2021, Intel Corporation. All rights reserved.
> ; SPDX-License-Identifier: BSD-2-Clause-Patent > ; > ; Abstract: > @@ -20,3 +20,15 @@ > %macro INCSSP_RAX 0 > DB 0xF3, 0x48, 0x0F, 0xAE, 0xE8 > %endmacro > + > +%macro SAVEPREVSSP 0 > + DB 0xF3, 0x0F, 0x01, 0xEA > +%endmacro > + > +%macro CLRSSBSY_RAX 0 > + DB 0xF3, 0x0F, 0xAE, 0x30 > +%endmacro > + > +%macro RSTORSSP_RAX 0 > + DB 0xF3, 0x0F, 0x01, 0x28 > +%endmacro > -- > 2.16.2.windows.1