From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web10.5310.1615272258454956657 for ; Mon, 08 Mar 2021 22:44:18 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=jHXMuNkc; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: jiewen.yao@intel.com) IronPort-SDR: 68lzhCfFl1FtST7EovyaLx4AI7/VweXP+6qPnN7vh573RS6SLN8YXcts4o8aBGm0b/R39PLt+E DTWq6bN2eRxw== X-IronPort-AV: E=McAfee;i="6000,8403,9917"; a="207946792" X-IronPort-AV: E=Sophos;i="5.81,234,1610438400"; d="scan'208";a="207946792" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2021 22:44:17 -0800 IronPort-SDR: NwN0AD3lKBPQw4rmN9GrfwDyJs/+tnqtQ9VwGUj37+L8cAVZtE5gAvXNFRb+WBDWVFBij5tCsX EWW5bFTSK7dA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,234,1610438400"; d="scan'208";a="509182574" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga001.fm.intel.com with ESMTP; 08 Mar 2021 22:44:16 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 8 Mar 2021 22:44:16 -0800 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 8 Mar 2021 22:44:16 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Mon, 8 Mar 2021 22:44:16 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Mon, 8 Mar 2021 22:44:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WXyzZgaPTJtTuo5PBubYI3YKKrXCS+M1hJ1DWFJM9jr8KWoQffpVTdPXJFAK+27nG/aUnjQywGJoCzCqcJUbmSGstZLOOArPsD89ZFmQv2FrJ6LE40ImXLPthiyOTTmcPOkzEnipJJDlu7BlW0kkOdm/AEZMsABqw35FcWLBlI/7wbgQYK2tpMQbGJRiI5v1sK+sKitPrDCPhdw2D2KMMKF7dCbDnNlV3Rvhwxie/ricrr+RXi9vvYDE+61Xplc9TBCyA/kMPyxqakSubsQONcpS0ZtEhzQnLRVMVEhmzmIkGfsu5a7dKj+JF9Y1yCj/PglkTjbKicSEtKiGDHeiyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XEIOdhutWSqoAlO2m2Q5vR8ts55qbRgmjl581VXO0QU=; b=dbTMe02wNci6LsMg4oo5uqXAEXVOEtXAm3qhWAdTq9hiebcPA+A+fBaLMYh3SbrjIwpM+L4P8Bpkyk4ITksJoj4DfEmx4fcgIv5rZ601MfBj9iZE34Sx+UdCpan5dhb6voNo5rKwUMDMRmOzCDCMmQtNiY9OmDAYCwyv4w1tzVfGMi+JrctLrkHJZDy2nArsdidzdPaCAtRTcxMAkUzjr6IOSNj3uiOmdWW1+00LDys80kvHfKzoRbO8aZPaNRgW96Or1RmK8M6Aceh/lPOAB1j508YjOmJUjG7IfFTbaV61MOumPuvkgialJedzBUZN5u1Rvwy5t8aTpXipT/ctNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XEIOdhutWSqoAlO2m2Q5vR8ts55qbRgmjl581VXO0QU=; b=jHXMuNkctauKw92YzKV9PawIxYy6eUoUWbui6ZyTo3ujH+6BJ1+FZqldJmBhSkOEX1NNCkgxI6TJ61PcFKjQlawQiO+2eKY6tSbooiV1MhYDWRXUIhbTYCJLbTNbv6vC67XJ+8or77CM3uYUEd+Cd7nqnMGKLV8DaOFXJpWnZc4= Received: from BY5PR11MB4166.namprd11.prod.outlook.com (10.255.163.89) by SJ0PR11MB4797.namprd11.prod.outlook.com (20.182.113.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.19; Tue, 9 Mar 2021 06:44:13 +0000 Received: from BY5PR11MB4166.namprd11.prod.outlook.com ([fe80::5983:f233:56d6:8132]) by BY5PR11MB4166.namprd11.prod.outlook.com ([fe80::5983:f233:56d6:8132%4]) with mapi id 15.20.3912.027; Tue, 9 Mar 2021 06:44:13 +0000 From: "Yao, Jiewen" To: "Xu, Min M" , "devel@edk2.groups.io" CC: "Justen, Jordan L" , Laszlo Ersek , "Reiland, Doug" Subject: Re: [PATCH V3 2/3] OvmfPkg: Add PCDs for TdxLib Thread-Topic: [PATCH V3 2/3] OvmfPkg: Add PCDs for TdxLib Thread-Index: AQHXFKtoac6bfaWmi0CHIcf7filZFKp7NZVQ Date: Tue, 9 Mar 2021 06:44:13 +0000 Message-ID: References: <6ae7e4da528afc7c06599cac98131495ee31e511.1615269637.git.min.m.xu@intel.com> In-Reply-To: <6ae7e4da528afc7c06599cac98131495ee31e511.1615269637.git.min.m.xu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.206] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8aeb1ebf-1bab-4ea4-c36a-08d8e2c6c0c5 x-ms-traffictypediagnostic: SJ0PR11MB4797: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DiY56X9P/U+FBxw8A5My05tTiZnnWjFREH2S2zB3v+xVFE4cDJ90tPiyySLCJNthoG3O/G+DYlUeTEb9bTZGxg+mDmmiONODBGGsiRy7+QTVdQTw3HX7MG7Bfdvl0HRQyNgn7AIGXgi2Rn2DjzUUnOnAppSxl7sT481nQuYDFVhF9FqojV6aRxem4KUCMsihenHIy905FnlfHZ1oRWGWKiuD1RMjMyfSU21yx2aDllsPvgV57SQc0t5QDdGyV9176NDihKOcSAOqeNT1kf5uVL9GeAo0+u7AJ11cx1e9+Ya8TMDRMwO3XyrX5qwPD8B93UHkY1G4RSLUmP2yMIM4WpSVOuIDAucPPoZcckpSsSR7AG+TBUzh4YtHUWxpuXEdzbal6Mg1+wlKvWuAEWKvbiZ9MOchQgF68rSlsFhufBj/b/m9ja0jqiBLQbE42qH/x5j1RrpBiKkSPkysd598hG3N4/6qGeBp/d0Khd7PMCX4EPLQ+OYRQOBC6nzOFY18UlEva4jgr+f7tJntWalyrw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR11MB4166.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(396003)(376002)(366004)(136003)(39860400002)(55016002)(316002)(66476007)(53546011)(71200400001)(110136005)(8676002)(6506007)(64756008)(66446008)(66946007)(2906002)(9686003)(52536014)(8936002)(7696005)(26005)(83380400001)(5660300002)(76116006)(478600001)(86362001)(33656002)(66556008)(4326008)(186003)(107886003)(54906003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?tc9fQkUSK8mAu2gIas28zKETmEKvEtYCflzouwoL2Fv9L4u3gC81UDXo9aw2?= =?us-ascii?Q?5D7S+bsl8nyfTJIeAOSHIvppvqn6Y6atkixtgWk44EV1o3hhISSv/4kcwzYz?= =?us-ascii?Q?HI+vys2QipJPxr4n4UNTcNJZ8oPWpyfzbUhojyaWEKMuyluD8aEITU5NEHMJ?= =?us-ascii?Q?dev42f2DJKUvSRIFhk1IQ4Xn4BWXSqgyGsdsJ2d8MLpGNQSuVnbCDJWKh13D?= =?us-ascii?Q?7Ly37NHKuNkdpiqHwW4sKBLtB3KjIqmpy/U0IuPUK6zsujWeVThlPAWJzrjz?= =?us-ascii?Q?aa1yAQ328Md7hFPVNLdYUZm5qjTDRADIU4TD0oSW4y0To2dASNi1TjRmfE45?= =?us-ascii?Q?fFnBbtPB1X75dmErlg1kPDp/uFNBQ5ue3DKshWPcbg9B8paEoSTzoPYkMQHT?= =?us-ascii?Q?upzZm+pT7dQrNLqiv4YCrUD8pG2r99yuIcCh3Bz7Lzvq+5wNAcSRxrlro65i?= =?us-ascii?Q?ILDAf+Ztx7K8gqqk9Ag+xf1A/wk0ezNwUnDSA835pYdkfrqcq+KUNHLP6bL+?= =?us-ascii?Q?hXoMgBxpWmkISi7KpwfqwlVhWP2aVzaDf0AO/RXTCmnfh/PcfYwyJRt0QRkf?= =?us-ascii?Q?q5USTZG3lFp/r0W/U+GIS4/yIutd/UJZvAj0KTt3z2o+W9YmzS3HixaLJw+D?= =?us-ascii?Q?0LNk1gSNuIU3UTrl/E1psYuBKz9BeKqVj+Bv+AqcqoYNTJ7wnh1BwNYV9i97?= =?us-ascii?Q?jsGtbzDZrHR060rooBel3xm3GpkuxfYXRP7CKbE+QNUneM/42pKqcH24WPJT?= =?us-ascii?Q?kqwlNEAbI03zWEFNqODqwZeul33JDj1mR1QTmuP/CGvBFGuxZbCTfWAHTEzd?= =?us-ascii?Q?1laGyEgFfdBm90VxhLIq2Ed4XYPkmUN+8Lf8ex7n4skYnxu3eD3Ob0jIVYpA?= =?us-ascii?Q?yp9lYfGIwWYl11vSrtrJZtD/tFuwqtTXvuJQ6cwdvZegcSVEjKaR22W0+Lv1?= =?us-ascii?Q?l772NnJs8X89WmSxH5EsLT3CsviI8dnRObgo96w3HFnovV93B8l5L9bMl0Kc?= =?us-ascii?Q?/wP1mgenkLUpU1TgAueYbf3XGbLPQ69IWNGXWN9bLZg+Hf+mp5kPLa8f50Hb?= =?us-ascii?Q?62LIAmFn5TZ0Y3NaAtE/HOLDAVQDi5Hpue4xQA2SXrC7S6PiNgu/fcM4hVmA?= =?us-ascii?Q?yWFxzRn55+Bsa310SYNoHhvMCKHpGp0wt8oruwE+Su1Cm2+LHT7yCed1hKYK?= =?us-ascii?Q?+toOuAKtQ5X1xnSkEHSI7SOl4T1NWVBEps/XaZOMO1ppNwYPlvDzqGqgW4Ds?= =?us-ascii?Q?30xCOYfmHPlG/26r9aB5X2ZhPg72il/U48ieOfD3txGHqMg7XPnIeenkq+PK?= =?us-ascii?Q?CoYaUvXeYThnhbUKw7m6xowS?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4166.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8aeb1ebf-1bab-4ea4-c36a-08d8e2c6c0c5 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Mar 2021 06:44:13.7683 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uzDuRQotELhFfICOBk69v0CAbSADDOwWp8ENpMB4LcBLu3CcPMY0ce8y6/fRuudXccfzY0NWrOf9760y/gK+nA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4797 Return-Path: jiewen.yao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi May I understand why we need this : PcdUseTdxAcceptPage ? I think accepting page is always required. For PcdUseTdxEmulation, This is only for pre-production. For real production, I don't think we need this one, right? > -----Original Message----- > From: Xu, Min M > Sent: Tuesday, March 9, 2021 2:13 PM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Justen, Jordan L > ; Laszlo Ersek ; Yao, Jiewe= n > ; Reiland, Doug > Subject: [PATCH V3 2/3] OvmfPkg: Add PCDs for TdxLib >=20 > TdxLib for OvmfPkg depends on the below PCDs > - PcdUseTdxAcceptPage > Indicate whether TdCall(AcceptPage) is used. > - PcdUseTdxEmulation > Indicate whether TdxEmulation is used. >=20 > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Jiewen Yao >=20 > Signed-off-by: Min Xu > Signed-off-by: Doug Reiland > --- > OvmfPkg/OvmfPkg.dec | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec > index 4348bb45c64a..68b3fd86d516 100644 > --- a/OvmfPkg/OvmfPkg.dec > +++ b/OvmfPkg/OvmfPkg.dec > @@ -317,6 +317,12 @@ > gUefiOvmfPkgTokenSpaceGuid.PcdSevLaunchSecretBase|0x0|UINT32|0x42 > gUefiOvmfPkgTokenSpaceGuid.PcdSevLaunchSecretSize|0x0|UINT32|0x43 >=20 > + ## Indicate whether TdCall(AcceptPage) is used. > + gUefiOvmfPkgTokenSpaceGuid.PcdUseTdxAcceptPage|TRUE|BOOLEAN|0x44 > + ## Indicate whether TdxEmulation is used. > + gUefiOvmfPkgTokenSpaceGuid.PcdUseTdxEmulation|0x1|UINT32|0x45 > + > + > [PcdsDynamic, PcdsDynamicEx] > gUefiOvmfPkgTokenSpaceGuid.PcdEmuVariableEvent|0|UINT64|2 >=20 > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashVariablesEnable|FALSE|BOOLEAN > |0x10 > -- > 2.29.2.windows.2