From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web12.1019.1662480414122299058 for ; Tue, 06 Sep 2022 09:06:54 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=gENaTA4L; spf=permerror, err=too many SPF records (domain: intel.com, ip: 134.134.136.20, mailfrom: sebastien.boeuf@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662480414; x=1694016414; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=UTvhkPf2yJC6dRewMWWwRwmjIqdBa+qC6D+/N5vyvqw=; b=gENaTA4Lo+Keq9o+xIsHnkJyEGGlExRvI2aZ0XUB/jTBZOyZW7bh90UV sLQhCS/hetASoS3nH58J3PpiRuLDLOZ4tZv2uj+pq1FQvBkgC/pArRJFm j3/FT0fU0YdU6rK0e0uRD0oM8TBQD3XCEEAha0RAMQW1VMJ08MMFbVzp2 HqXUEtxU34Uf/nGs/0Xw54Q8CY7P5FHbv8nGp8NM+7NjvNU9F1i9MBKVx TPIT9Z8OjlTo9k1E2KyY6htOJpP1cY3RY50apjlODeUGVezzjDs16sL9L Hx5HRSXRFty8kYkT1js6pujDa3X5nBThgdOepj+/8aoKPn/vtT5ryVdhd w==; X-IronPort-AV: E=McAfee;i="6500,9779,10462"; a="283629571" X-IronPort-AV: E=Sophos;i="5.93,294,1654585200"; d="scan'208,217";a="283629571" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2022 09:06:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,294,1654585200"; d="scan'208,217";a="739947982" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga004.jf.intel.com with ESMTP; 06 Sep 2022 09:06:53 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 6 Sep 2022 09:06:52 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 6 Sep 2022 09:06:52 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 6 Sep 2022 09:06:52 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.174) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 6 Sep 2022 09:06:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ce4duLfA/3osA0SksZJ2cv6var1RyqDfYidwXjhiMWGNnN/evoC23Nthnhr5aKn3FqMGMofm9oZqsb5ViFsrhGMZ+uesSD/ZNJqoEoxyCNhdZ8knFlRmJ6MvhmMiJqfQOkE77IyPJcBP7KR+tVwQhGOzShOdHJvh3b+RahpU19z54+d0YuSFF0r9ZcNwo3C5BGS3gpF/8S+jXej/XcS1lnHvMUTQDfnUXtElc8XhruW0qSZT93n36y8jJakJ/YcDwr02bJMw3nnypsPiAqQRYlDWuEYKOQPZF8IBUawg4I3Zz68MChawFXVBfKWCYSzVRN0MzZid71nHLahdh/4RKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CSBo+trjs6ygYpprC7cESbqOy/I6bzjDwp4oXtSUw9U=; b=kcVy6AFCeTHmEGRD5oHDsb2AZzoNGJyJVqmj7Reoln/VeE5aQuflAZpA1YlfGomMs6KBM2sZZi3FtF+vL+zvmc4dhNQ2EJyQuZS2um72tSNHKSmL2YWtp1Aq3lW4Kty/yhkSa2fVbr77WqfuQPvUySi499d85peoNZTKz5LSDbigvCKrYgLYs7hEl13El8OztZWCxD5fspjQykHjvro4q+ZzHEV/TcrN8u1kYmT2UOMbRH79aCYuQxp73buxrXifHeXYwVg/iPNqFqof14/JNzE/xpjKBjY4N+tqbncC6G5z6DHmDnz/XWVWszoC89B91PmWeCywwrrRAa2qqIWpuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BY5PR11MB4401.namprd11.prod.outlook.com (2603:10b6:a03:1be::13) by DM6PR11MB3305.namprd11.prod.outlook.com (2603:10b6:5:5f::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.17; Tue, 6 Sep 2022 16:06:49 +0000 Received: from BY5PR11MB4401.namprd11.prod.outlook.com ([fe80::112d:cc6b:6802:545b]) by BY5PR11MB4401.namprd11.prod.outlook.com ([fe80::112d:cc6b:6802:545b%7]) with mapi id 15.20.5588.018; Tue, 6 Sep 2022 16:06:49 +0000 From: "Boeuf, Sebastien" To: "Yao, Jiewen" CC: "Justen, Jordan L" , "kraxel@redhat.com" , "devel@edk2.groups.io" Subject: Re: [PATCH v2] OvmfPkg: Update I/O port related to ACPI devices for CloudHv Thread-Topic: [PATCH v2] OvmfPkg: Update I/O port related to ACPI devices for CloudHv Thread-Index: AQHYs7JjLp5GrBU090uWJK28qKRdWa3SjIOmgAAFtYCAAAs7pIAADdQAgAACfMg= Date: Tue, 6 Sep 2022 16:06:49 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6934ca6f-8895-476f-4193-08da9021ce54 x-ms-traffictypediagnostic: DM6PR11MB3305:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zK+pzdHATSk2Ab9WF7ER2F4+EHVG0cTaWyogvQILvobBJ/5KryiJQYbGgvEu0RKLvRD/bxnYT+6eGdfnsGsDg4qaMhHdJVx3mtyuBQC6QJVescMF6FujLOT/GBCTNu5jesXwLXbVqCKoycuQkOjgbCMi2mNpUS57M2w1golnM8tNcUeQr4n7h+utSBjg3klNYCjJLT7SznI9jC1nkuLJrRYhMrmqi5ToEddHPpyZAJo8B+SwXBDcGnNLnFF6FMZGEs6jz16/mpuBcIRd36M/4/4JEF/szqAlDBEYB6q+ljPiyD+/Hm2jraKetc9GSCigvDEIw4lSFpd85itgLq4/8ofxROIwz36XlYtqMkc/e45AiJqXAJCc0h+pgGtd4iurD4fePSSdmsiescksQZTBJUb8SaO42AaYN0QM8qV+5fshAKdUmm5UkCqgyP03CBljh/VYVnF/M8p7X2pD2vGOM70H3l7JMi+tVYYcYnoo8Ym+UW+Zs4Ym4ZP/RbswYGC3xxfutYcNLLIF8QJ2tIID1hZD+/LCiJFeWndNqV9On4rks4TV303xhUxvgTYGrFS7qp4uKZPGyyTMqUXN6WfRlgh4evce3DEMmepGhec86WENKqiVb30mUwEQrwti68xAO/LW63yzI3KRv6F4sRLi7CxRHphbQ+AG5468Tbu9Ozn8VJ2m+sUQOw4aTvGoZVp6gwQGXn+C4itJ452kIgXPm7dHAMQz2y0IxuULKsq/ZG1nYvhCzc7pR+Ksruf9CFvdz1Rj4DolFxrAWElpkeMRBa9NzVztuB+qw8gtdM7pT7zi3HT2+pdxHWfa5eIx/uaJTIf13fa95JKQirOPB4tG8w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR11MB4401.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(366004)(346002)(396003)(136003)(376002)(6506007)(7696005)(41300700001)(71200400001)(26005)(53546011)(9686003)(5660300002)(83380400001)(8936002)(52536014)(6862004)(15650500001)(4326008)(8676002)(64756008)(186003)(55016003)(66476007)(966005)(2906002)(19627235002)(76116006)(91956017)(478600001)(66556008)(6636002)(66946007)(54906003)(316002)(66446008)(86362001)(166002)(82960400001)(38100700002)(38070700005)(122000001)(33656002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qh2utZ9isVyF+DbrjYu3z8c2ynbXQeiTliYSfu9pnuP4FqT5LGb+MX1YTMj9?= =?us-ascii?Q?gfpmc4pDR0pHWldstokwu8Aac+vFCYY6zKjePFKe2rNahHZwLLzPvjnI5gFs?= =?us-ascii?Q?ArvhQv2haNyIqFdbMoW48CvKDzpgD5sY0yOccpH03+8N3TG6X+Pp0YNR61hD?= =?us-ascii?Q?c3vDbBY04Hv0n68j1ZQVieivTSjFq9/rYczWCBOTz1c8b+h/PzoOnTldxqhd?= =?us-ascii?Q?NZBHh6eGRc56OJFRULC6CFxylfpH4vxTCY0bv5ApkAE290pKnD0+Kw9EzVHT?= =?us-ascii?Q?7wVKVheVSL49rWCtgOlisAXXI6mvuW7dwYTTT/fmhYDVqSaHJPKer7aeaQ33?= =?us-ascii?Q?objmckOcOUYsa5b3r4SDCcCFTbgOcfq18o749FKK+fcZbm/RbZ7hFTOJdIG1?= =?us-ascii?Q?XR4k0WAd6eIMq4kW2z7sD4uYVomQZMuvehCrKFl6c2YmfOqiKDWEDsv2ex+F?= =?us-ascii?Q?BMl82ZQnvi8KdcATogM/JeNMiNDB75RX/MOTFtIFY6CrapornuN16HmD3yw+?= =?us-ascii?Q?rNJcE3bR+7V/cZlp2aOhZZ47HBc8xz1RVeyIYRcYnvIOortalwf6VAy1wGjw?= =?us-ascii?Q?iLBg+pKxTgEzbfgiHKL8VTBcqni/2k063mXeV/zt0iDyUQan3vtMVz2awJfo?= =?us-ascii?Q?BrDOrvjQAOlPPdT4Dzd0yd51aUfGVJhA6fHmxVKS7q5JYRcZQMZmFYypI5YP?= =?us-ascii?Q?RmS5NMlHwijC9XKnsib19tc5UYi8EeuB637cVzL5PZZ60ljZ7UdokOBOnzbq?= =?us-ascii?Q?TVW5b0qBJU19rhTmu1zUTYIyA5v3k2TMGtZw6kSaIqk3y+pi0oWpY03mFkqr?= =?us-ascii?Q?mtipCpK/hFldFEzBqZ4FAJdhJ/fDkI4uEXgiW59kx38h+aGe0RyQk8SXQF5a?= =?us-ascii?Q?TkPKF/KEq3T0Ppn3ZfgAOWdI6yw8Z/JxSKKi3axV8Ytalb8I9Mdusxj8pwsj?= =?us-ascii?Q?pUcL2qZUcuPbEJzKnqBFykxwHlVZOjIbMGmu/y09T6LARDUOlgSH2/b8hd4x?= =?us-ascii?Q?BgDaxN6fs81H0Y8B0q5H3wD1PZ9yIbulqg4Lzzwgav5MAb03CGSh1zk51HkY?= =?us-ascii?Q?qFdWWn4QPJ/sRzKYj0/ATBQPKj8hFKlpPn+zW6OubqnNBzMPzFMr7XRbDiCn?= =?us-ascii?Q?0gvNvltvMrQtZXWUQ00FE6yvMGOpjaUlliKGheuU2X/2Km3xZNpWtoSXO+tz?= =?us-ascii?Q?xoCJR72jtVxTNB9jYDd0Gn1H5S55Cz6YzgIKOxyCZUS71DKImUc8PJQLmgio?= =?us-ascii?Q?x5Rw3zVKGv2xb+p5nFMpFG8J05rQ68ZABiU5u1zNJv6eJAkmSSU8LCPsn3mo?= =?us-ascii?Q?360mhcKS6vSwClK9e+BJPWpo68KdMMaLDkjbVdPPA/vKAUG52Buw6D5rvVOb?= =?us-ascii?Q?85r6orKbxJWOWIRH+ZdQnpufTn/PqIUBznYspkTEjT/Af3G6uURfQaL2E9ug?= =?us-ascii?Q?AjcEGQLrPIhKpj4xAC62ZD43ecvEuivtJy0Z1BlalRUXgowbF4WTLVzx3gxA?= =?us-ascii?Q?ue3kg2EmUQOEJBvi5NcywHdnZtDC6w6E/pFg3c05VsjLklyZLrXzROrp6m4j?= =?us-ascii?Q?Sp16bUIBAx9FfYsaHmMGv21j2RUBpQ29ZcQSoO8oovoQlRrIJRda9DngRdty?= =?us-ascii?Q?Rg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4401.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6934ca6f-8895-476f-4193-08da9021ce54 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Sep 2022 16:06:49.5826 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NQoCfgHGEvCRgvZ26mEuoBK0NoLb1Kux9/Ylkgt06fw0dTpGvA/rgf/jflvSPfFtSm3CDvcl/vZ9K7jjOLHuJDlxnHjjzOWMGIzTmMpYcmM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3305 Return-Path: sebastien.boeuf@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BY5PR11MB440133CDA3DB31D3171D1F69EA7E9BY5PR11MB4401namp_" --_000_BY5PR11MB440133CDA3DB31D3171D1F69EA7E9BY5PR11MB4401namp_ Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sounds good, I'll have a look at these tomorrow and I'll try to come up wit= h a proper patch :) Thanks, Sebastien ________________________________ From: Yao, Jiewen Sent: Tuesday, September 6, 2022 5:57:16 PM To: Boeuf, Sebastien Cc: Justen, Jordan L ; kraxel@redhat.com ; devel@edk2.groups.io Subject: RE: [PATCH v2] OvmfPkg: Update I/O port related to ACPI devices fo= r CloudHv One good example is in UefiPayloadPkg. 1. At entrypoint, the UefiPayload parses the ACPI table and build gUefiA= cpiBoardInfoGuid. https://github.com/tianocore/edk2/blob/master/UefiPayload= Pkg/UefiPayloadEntry/AcpiTable.c#L23 1. Later, AcpiTimer driver uses the ACPI data in gUefiAcpiBoardInfoGuid.= https://github.com/tianocore/edk2/blob/master/UefiPayloadPkg/Library/AcpiT= imerLib/AcpiTimerLib.c#L49 1. Other driver may also use the ACPI data, such as PciExpressAddress. (= from MCFG). https://github.com/tianocore/edk2/blob/master/UefiPayloadPkg/Li= brary/PciSegmentInfoLibAcpiBoardInfo/PciSegmentInfoLibAcpiBoardInfo.c#L55 Thank you Yao Jiewen From: Boeuf, Sebastien Sent: Tuesday, September 6, 2022 11:41 PM To: Yao, Jiewen Cc: Justen, Jordan L ; kraxel@redhat.com; devel@= edk2.groups.io Subject: Re: [PATCH v2] OvmfPkg: Update I/O port related to ACPI devices fo= r CloudHv Hi Jiewen, We patched Cloud Hypervisor to support both I/O ports for at least two vers= ions. And of course at some point users will have to rely on latest CloudHv= binary (which we always build). One improvement could be to retrieve the I/O ports addresses from the FADT = table. Do you know if there's some code already doing that in OVMF? Thanks, Sebastien ________________________________ From: Yao, Jiewen > Sent: Tuesday, September 6, 2022 4:27 PM To: Boeuf, Sebastien > Cc: Justen, Jordan L >; kraxel@redhat.com >; devel@edk2.groups.io = > Subject: RE: [PATCH v2] OvmfPkg: Update I/O port related to ACPI devices fo= r CloudHv This seems a big incompatible change. I feel this is weird to hardcode the configuration here. How the OVMF binary knows it runs on a new CloudHv or old CloudHv? Can we have a mechanism to detect the data at runtime? E.g. read some PCI r= egister ? From: Boeuf, Sebastien > Sent: Tuesday, September 6, 2022 10:08 PM To: Yao, Jiewen > Cc: Justen, Jordan L >; kraxel@redhat.com; devel@edk2.groups.io<= mailto:devel@edk2.groups.io> Subject: Re: [PATCH v2] OvmfPkg: Update I/O port related to ACPI devices fo= r CloudHv Hi Jiewen, Do you think this could be merged? Thanks, Sebastien ________________________________ From: Boeuf, Sebastien > Sent: Friday, August 19, 2022 11:59 AM To: devel@edk2.groups.io > Cc: Yao, Jiewen >; Justen= , Jordan L >; k= raxel@redhat.com >; Boeuf, Sebastien > Subject: [PATCH v2] OvmfPkg: Update I/O port related to ACPI devices for Cl= oudHv From: Sebastien Boeuf > Both ACPI shutdown and ACPI PM timer devices has been moved to different port addresses in the latest version of Cloud Hypervisor. These changes need to be reflected on the OVMF firmware. Acked-by: Gerd Hoffmann > Signed-off-by: Sebastien Boeuf > --- OvmfPkg/Include/IndustryStandard/CloudHv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/OvmfPkg/Include/IndustryStandard/CloudHv.h b/OvmfPkg/Include/I= ndustryStandard/CloudHv.h index d31ecc9eec..527c236f48 100644 --- a/OvmfPkg/Include/IndustryStandard/CloudHv.h +++ b/OvmfPkg/Include/IndustryStandard/CloudHv.h @@ -16,12 +16,12 @@ // // ACPI timer address // -#define CLOUDHV_ACPI_TIMER_IO_ADDRESS 0xb008 +#define CLOUDHV_ACPI_TIMER_IO_ADDRESS 0x0608 // // ACPI shutdown device address // -#define CLOUDHV_ACPI_SHUTDOWN_IO_ADDRESS 0x03c0 +#define CLOUDHV_ACPI_SHUTDOWN_IO_ADDRESS 0x0600 // // 32-bit MMIO memory hole base address -- 2.34.1 --------------------------------------------------------------------- Intel Corporation SAS (French simplified joint stock company) Registered headquarters: "Les Montalets"- 2, rue de Paris, = 92196 Meudon Cedex, France Registration Number: 302 456 199 R.C.S. NANTERRE Capital: 5 208 026.16 Euros This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. --_000_BY5PR11MB440133CDA3DB31D3171D1F69EA7E9BY5PR11MB4401namp_ Content-Type: text/html; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
Sounds good, I'll have a look at these tomorrow and I'll try to come up wit= h a proper patch :)

Thanks,
Sebastien 
From: Yao, Jiewen <jiewe= n.yao@intel.com>
Sent: Tuesday, September 6, 2022 5:57:16 PM
To: Boeuf, Sebastien <sebastien.boeuf@intel.com>
Cc: Justen, Jordan L <jordan.l.justen@intel.com>; kraxel@redha= t.com <kraxel@redhat.com>; devel@edk2.groups.io <devel@edk2.groups= .io>
Subject: RE: [PATCH v2] OvmfPkg: Update I/O port related to ACPI dev= ices for CloudHv
 

One good example is in UefiPayloadPkg.

 

  1. At entrypoint, t= he UefiPayload parses the ACPI table and build gUefiAcpiBoardInfoGuid. https://github.com/tianocore/edk2/blob/master/UefiPayloadPkg/UefiPayloadEnt= ry/AcpiTable.c#L23

 

  1. Later, AcpiTimer= driver uses the ACPI data in gUefiAcpiBoardInfoGuid. https://github.com/tianocore/edk2/blob/master/UefiPayloadPkg/Library/AcpiTi= merLib/AcpiTimerLib.c#L49

 

  1. Other driver may= also use the ACPI data, such as PciExpressAddress. (from MCFG). https://github.com/tianocore/edk2/blob/master/UefiPayloadPkg/Library/PciSeg= mentInfoLibAcpiBoardInfo/PciSegmentInfoLibAcpiBoardInfo.c#L55

 

 

Thank you

Yao Jiewen

 

 

From: Boeuf, Sebastien <sebastien.boeuf@= intel.com>
Sent: Tuesday, September 6, 2022 11:41 PM
To: Yao, Jiewen <jiewen.yao@intel.com>
Cc: Justen, Jordan L <jordan.l.justen@intel.com>; kraxel@redha= t.com; devel@edk2.groups.io
Subject: Re: [PATCH v2] OvmfPkg: Update I/O port related to ACPI dev= ices for CloudHv

 

Hi J= iewen,

&nbs= p;

We p= atched Cloud Hypervisor to support both I/O ports for at least two versions= . And of course at some point users will have to rely on latest CloudHv bin= ary (which we always build).

&nbs= p;

One = improvement could be to retrieve the I/O ports addresses from the FADT tabl= e. Do you know if there's some code already doing that in OVMF?

&nbs= p;

Than= ks,

Seba= stien

From: Yao, Jiewen <jiewen.yao@intel.com>
Sent: Tuesday, September 6, 2022 4:27 PM
To: Boeuf, Sebastien <sebastien.boeuf@intel.com>
Cc: Justen, Jordan L <jordan.l.justen@intel.com>; kraxel@redhat.com <kraxel@redhat.com>; devel@edk2.groups.io <devel@edk2.groups.io>
Subject: RE: [PATCH v2] OvmfPkg: Update I/O port related to ACPI dev= ices for CloudHv

 

This seems a big incompatible change.

 

I feel this is weird to hardcode the configuratio= n here.

 

How the OVMF binary knows it runs on a new CloudH= v or old CloudHv?

 

Can we have a mechanism to detect the data at run= time? E.g. read some PCI register ?

 

 

 

 

From: Boeuf, Sebastien <sebastien.boeuf@intel.com>
Sent: Tuesday, September 6, 2022 10:08 PM
To: Yao, Jiewen <jiewen.y= ao@intel.com>
Cc: Justen, Jordan L <jordan.l.justen@intel.com>; kraxel@redhat.com; devel@edk2.groups.io
Subject: Re: [PATCH v2] OvmfPkg: Update I/O port related to ACPI dev= ices for CloudHv

 

Hi = Jiewen,

&nb= sp;

Do = you think this could be merged?

&nb= sp;

Tha= nks,

Seb= astien

From: Boeuf, Sebastien <sebastien.boeuf@intel.com>
Sent: Friday, August 19, 2022 11:59 AM
To: devel@edk2.groups.io= <devel@edk2.groups.io> Cc: Yao, Jiewen <jiewen.y= ao@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>; kraxel@redhat.com <kraxel@redhat.com>; Boeuf, Sebastien <sebastien.boeuf@intel.com>= ;
Subject: [PATCH v2] OvmfPkg: Update I/O port related to ACPI devices= for CloudHv

 

From: Sebastien Bo= euf <sebastien.boeuf@intel.= com>

Both ACPI shutdown and ACPI PM timer devices has been moved to different
port addresses in the latest version of Cloud Hypervisor. These changes
need to be reflected on the OVMF firmware.

Acked-by: Gerd Hoffmann <kraxel@red= hat.com>
Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
---
 OvmfPkg/Include/IndustryStandard/CloudHv.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/OvmfPkg/Include/IndustryStandard/CloudHv.h b/OvmfPkg/Include/I= ndustryStandard/CloudHv.h
index d31ecc9eec..527c236f48 100644
--- a/OvmfPkg/Include/IndustryStandard/CloudHv.h
+++ b/OvmfPkg/Include/IndustryStandard/CloudHv.h
@@ -16,12 +16,12 @@
 //

 // ACPI timer address

 //

-#define CLOUDHV_ACPI_TIMER_IO_ADDRESS  0xb008

+#define CLOUDHV_ACPI_TIMER_IO_ADDRESS  0x0608

 

 //

 // ACPI shutdown device address

 //

-#define CLOUDHV_ACPI_SHUTDOWN_IO_ADDRESS  0x03c0

+#define CLOUDHV_ACPI_SHUTDOWN_IO_ADDRESS  0x0600

 

 //

 // 32-bit MMIO memory hole base address

--
2.34.1

---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris,
92196 Meudon Cedex, France
Registration Number:  302 456 199 R.C.S. NANTERRE
Capital: 5 208 026.16 Euros

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

--_000_BY5PR11MB440133CDA3DB31D3171D1F69EA7E9BY5PR11MB4401namp_--