Re: [edk2-devel] [PATCH v2 0/3] OvmfPkg: Make IntelTdx work with Cloud Hypervisor

["Boeuf, Sebastien" <sebastien.boeuf@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 5396 bytes --]

Hi folks,

Sorry I was on vacation.

Min, did you figure out how to fix that issue? Please let me know if/how I can help with that.

Thanks,
Sebastien
________________________________
From: Xu, Min M <min.m.xu@intel.com>
Sent: Thursday, December 22, 2022 2:08 PM
To: Ard Biesheuvel <ardb@kernel.org>; devel@edk2.groups.io <devel@edk2.groups.io>; Boeuf, Sebastien <sebastien.boeuf@intel.com>
Cc: Yao, Jiewen <jiewen.yao@intel.com>; kraxel@redhat.com <kraxel@redhat.com>
Subject: RE: [edk2-devel] [PATCH v2 0/3] OvmfPkg: Make IntelTdx work with Cloud Hypervisor

I am looking at the issue and will provide the fix soon.

BTW, the previous patch-set passed the EDK2 CI. It seems there is something missed in the EDK2 CI.

Thanks
Min

> -----Original Message-----
> From: Ard Biesheuvel <ardb@kernel.org>
> Sent: Thursday, December 22, 2022 7:05 PM
> To: devel@edk2.groups.io; Boeuf, Sebastien <sebastien.boeuf@intel.com>
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Xu, Min M <min.m.xu@intel.com>;
> kraxel@redhat.com
> Subject: Re: [edk2-devel] [PATCH v2 0/3] OvmfPkg: Make IntelTdx work with
> Cloud Hypervisor
>
> This series has broken all platforms that incorporate
> OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf but do not provide a
> resolution for CcProbeLib
>
> Please provide a fix
>
> https://ci.linaro.org/job/leg-virt-tianocore-edk2-upstream/4748/console
>
>
>
> On Fri, 16 Dec 2022 at 09:46, Boeuf, Sebastien <sebastien.boeuf@intel.com>
> wrote:
> >
> > Thank you Jiewen :)
> > ________________________________
> > From: Yao, Jiewen <jiewen.yao@intel.com>
> > Sent: Friday, December 16, 2022 4:03:00 AM
> > To: Boeuf, Sebastien <sebastien.boeuf@intel.com>; devel@edk2.groups.io
> > <devel@edk2.groups.io>
> > Cc: Xu, Min M <min.m.xu@intel.com>; kraxel@redhat.com
> > <kraxel@redhat.com>
> > Subject: RE: [PATCH v2 0/3] OvmfPkg: Make IntelTdx work with Cloud
> > Hypervisor
> >
> > Merged: https://github.com/tianocore/edk2/pull/3778
> >
> > > -----Original Message-----
> > > From: Boeuf, Sebastien <sebastien.boeuf@intel.com>
> > > Sent: Thursday, December 15, 2022 11:10 PM
> > > To: devel@edk2.groups.io
> > > Cc: Yao, Jiewen <jiewen.yao@intel.com>; Xu, Min M
> > > <min.m.xu@intel.com>; kraxel@redhat.com; Boeuf, Sebastien
> > > <sebastien.boeuf@intel.com>
> > > Subject: [PATCH v2 0/3] OvmfPkg: Make IntelTdx work with Cloud
> > > Hypervisor
> > >
> > > From: Sebastien Boeuf <sebastien.boeuf@intel.com>
> > >
> > > The IntelTdxX64 OVMF target wasn't working with Cloud Hypervisor on
> > > TDX platform. This was due to the way the OVMF code expects Cloud
> > > Hypervisor to rely on PVH to retrieve information like memory below
> > > 4GiB as well as the ACPI tables.
> > >
> > > This is why this series takes care of identifying when running on
> > > TDX in order to handle things differently. For the memory below
> > > 4GiB, it falls back onto the CMOS to retrieve the correct
> > > information, and for the ACPI tables, it relies on the HOB to obtain
> > > every table individually before to expose them to the guest OS.
> > >
> > > With these two use cases properly handled by this series, it is now
> > > possible to use the IntelTdxX64 target to build an OVMF binary that
> > > works both for QEMU and Cloud Hypervisor on a TDX platform.
> > >
> > > Sebastien Boeuf (3):
> > >   OvmfPkg/PlatformInitLib: Differentiate TDX case for Cloud Hypervisor
> > >   OvmfPkg/PlatformInitLib: Transfer GUID Extension HOB
> > >   OvmfPkg/AcpiPlatformDxe: Differentiate TDX case for Cloud
> > > Hypervisor
> > >
> > >  ArmVirtPkg/ArmVirtQemu.dsc                  |  1 +
> > >  OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c      |  8 +-
> > >  OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h      |  6 ++
> > >  OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf |  3 +
> > >  OvmfPkg/AcpiPlatformDxe/CloudHvAcpi.c       | 87
> +++++++++++++++++++++
> > >  OvmfPkg/Library/PlatformInitLib/IntelTdx.c  |  5 ++
> > > OvmfPkg/Library/PlatformInitLib/MemDetect.c |  5 +-
> > >  OvmfPkg/OvmfPkg.dec                         |  1 +
> > >  8 files changed, 114 insertions(+), 2 deletions(-)
> > >
> > > --
> > > 2.34.1
> >
> > ---------------------------------------------------------------------
> > Intel Corporation SAS (French simplified joint stock company)
> > Registered headquarters: "Les Montalets"- 2, rue de Paris,
> > 92196 Meudon Cedex, France
> > Registration Number:  302 456 199 R.C.S. NANTERRE
> > Capital: 5 208 026.16 Euros
> >
> > This e-mail and any attachments may contain confidential material for
> > the sole use of the intended recipient(s). Any review or distribution
> > by others is strictly prohibited. If you are not the intended
> > recipient, please contact the sender and delete all copies.
> >
> > 
---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris, 
92196 Meudon Cedex, France
Registration Number:  302 456 199 R.C.S. NANTERRE
Capital: 5 208 026.16 Euros

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

[-- Attachment #2: Type: text/html, Size: 9065 bytes --]