From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com []) by mx.groups.io with SMTP id smtpd.web09.3088.1576895837724761218 for ; Fri, 20 Dec 2019 18:37:18 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Tp2c+vjC; spf=fail (domain: intel.com, ip: , mailfrom: michael.a.kubacki@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Dec 2019 18:37:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,338,1571727600"; d="scan'208";a="222607884" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 20 Dec 2019 18:37:17 -0800 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 20 Dec 2019 18:37:17 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 20 Dec 2019 18:37:17 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 20 Dec 2019 18:37:17 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fBZrcrvoxom9GRI8pH7KOP32zFACKA7JASAuoJf1U4cDQRgxBh7aWMciNc0RzExY7PhUwCxQme7J9T39neNzYzjtSg9Qu/NJGW3cCP0xg3OaQWIXwWvuoAPknPWrPbPZcVXVrgo+B+L77naYbxa+aHhzV98cAf+3BgvZe2uA3y4SSzWu+tztvmBKrgfNUt+T0sX3YIVjxUCOPhQI/ftmJKJB0Xf7EfRvwTPgd0raEmQjan5tUwXIgtTIlQib+7luDZlr6ZX3JI6FZ81PJ+8ZR9wQ0YFiEqZVKo5gx1vk6Y3Hizl9kiYWFXF9x3kY1eFkBa50pVhPd20tNfF5nPCtEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xnz3ty5BiK0bExMnLnEDlc9On0upaly7CVK8Dy45SA8=; b=ZwvOmLZKUMofKSTSAqdJpAFoZPimHtPn26DJDZPIKA7R6R65yrv8k+cCNcpiBuliCra1tbHMMJ0yb6HfFj/Tpor34FOV28n4u+Bzcv+HfEeZqzN7EpRKqQzWtFMq9UMxZasxvKY6oLpmzJyLhMCe+lTKvwDwkSfdlPJBCf+dFcjXVZypWTJ3s1iPlL72CnEiSKU2w14Ht5aSQ9EXfGxg8hu94mJ+SVBTaaURCCgx7i60xFKHWbB1nAx4wV7EmBiZQSDD6olLvSZk+qoTsAH12F9+i4uE58zToZNGgCvWch6eN9dUflMiQJEtE+dEpJl4LUP5yIJ9K5w4FeMte+XU2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xnz3ty5BiK0bExMnLnEDlc9On0upaly7CVK8Dy45SA8=; b=Tp2c+vjCQYZhCEZbvjrvn8wVlOqpFxKF48LyQls3GQYtd3qBdonTn/nhGd7v3/C4FN5Od5UUE6iPDfg5qzpHL0QEhrhk0Qa8GzUaxOe0Pa/YEZ7nhndxLtWNh0ehByJfIXY8TrYEmJWPDgX2se4nK4bAaeHGEbW2ST9N1R6iXzE= Received: from BY5PR11MB4484.namprd11.prod.outlook.com (52.132.254.155) by BY5PR11MB4482.namprd11.prod.outlook.com (52.132.255.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2559.14; Sat, 21 Dec 2019 02:37:11 +0000 Received: from BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::bc80:2ec3:11ba:2f8a]) by BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::bc80:2ec3:11ba:2f8a%3]) with mapi id 15.20.2559.017; Sat, 21 Dec 2019 02:37:11 +0000 From: "Kubacki, Michael A" To: "Agyeman, Prince" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" Subject: Re: [edk2-platforms] [PATCH 11/11] SimicsOpenBoardPkg: Add Bds Hook Points Thread-Topic: [edk2-platforms] [PATCH 11/11] SimicsOpenBoardPkg: Add Bds Hook Points Thread-Index: AQHVsh50RIiLtGuSYkiIejKeHLRCKKfD56Sg Date: Sat, 21 Dec 2019 02:37:11 +0000 Message-ID: References: <3ef9d5be91ce7f2442cec09dd93c66bcb9a03447.1576282834.git.prince.agyeman@intel.com> In-Reply-To: <3ef9d5be91ce7f2442cec09dd93c66bcb9a03447.1576282834.git.prince.agyeman@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDY2MjQzMjAtZjQ3OC00MDU2LTkzNzEtOTRjZGM4ZWMyZDlkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNnpmQWM1Q1pvdW1UWTA2VzVzaW5WS2pIZ3RFK3ZudnpOQ0pCNGxmem8rK3JpVjF0cWYrWFRXMmh1OE5qb1hoYSJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: baf7ee70-42c2-4286-0183-08d785beae7b x-ms-traffictypediagnostic: BY5PR11MB4482: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-forefront-prvs: 0258E7CCD4 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(136003)(396003)(346002)(366004)(376002)(39860400002)(13464003)(189003)(199004)(8676002)(86362001)(55016002)(478600001)(316002)(33656002)(81156014)(53546011)(81166006)(54906003)(966005)(26005)(66476007)(66446008)(186003)(76116006)(66946007)(9686003)(64756008)(66556008)(6506007)(2906002)(5660300002)(4326008)(71200400001)(7696005)(107886003)(110136005)(8936002)(52536014);DIR:OUT;SFP:1102;SCL:1;SRVR:BY5PR11MB4482;H:BY5PR11MB4484.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NPVoYUv5wsjdFHCEyGfj3zAoZmU4jIcNJ7FF0bIQv2In65jeyNf5kAkF8jBdaOascWM6p0Dwuoda6F7Augvpvv2ndDb78KRPNP7VVXQ5mVL5MxZgEO6UridhsRS6ozxEW+ARZ29A2TJN2dN+zIGTvFT9xJnCuji9J1wl47JL+Y8qQq6bM39qMpOeywWJTZpJA5iBw6ufzzUz07EyL6fGBRX6iz0dGoSzpkR6c0Lo26a2GuPzSokUzKgpUF+Hp0TG/3G1WVYR1rC+EGn4rNjFR77p8n/25B3uE9bI7DouCJLrlDohPMCHOzxL7fZcgMLLmpmonEQXoYUmpldCT1e6YUpwQIi4j1UEMX+APwEEGaX8+pLP7ZUYEEGEage6tRfivjlhECDNTwHiTZHmG9kSgI0A5/eVtdMjfTixMvgYFGYFpYQ69fJSbsD0MJP0ZIgy7m0WtE0WVGXwnmmCU2IMsDwYqC0v8dw07gVpjYlkRqVMBstL87K/h5Q6uzeizVeuZBR045IUTbNqhcaKsLJLdSTt5hjKIUdg56foGMNCxTs= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: baf7ee70-42c2-4286-0183-08d785beae7b X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2019 02:37:11.1823 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: i8E4VqFvHbK5BaBKfce9yqEgmjxRd9OyzRq2UC0rLL7ljXGtVABU8H5g/qjNd2zTCX9eQMH+qA3uQbyu0a7186Qt7NUzlHnFm0qUxx9WYtE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4482 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Michael Kubacki > -----Original Message----- > From: Agyeman, Prince > Sent: Friday, December 13, 2019 5:33 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject: [edk2-platforms] [PATCH 11/11] SimicsOpenBoardPkg: Add Bds > Hook Points >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2336 >=20 > Added a DXE driver that registers the minimum platform BDS hook points, t= o > BoardX58Ich10 board. > These hooks are triggered on the BDS hook events >=20 > What was done: >=20 > * Included a board specific instance of BoardBdsHookLib and > BoardBootManagerLib >=20 > * Included Minplatforms PlatformBootManagerLib instance. > This Library instance signals the Bds event groups >=20 > * Included BoardBdsHookDxe to register the callbacks implemented in > BoardBdsHookLib >=20 > Cc: Michael Kubacki > Cc: Chasel Chiu > Cc: Nate DeSimone >=20 > Signed-off-by: Prince Agyeman > --- > .../SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 10 > +++++++++- .../SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf | > 1 + > 2 files changed, 10 insertions(+), 1 deletion(-) >=20 > diff --git > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > index 7576648d57..350a75a313 100644 > --- > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > +++ > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > @@ -146,10 +146,17 @@ >=20 > SetCacheMtrrLib|$(PLATFORM_PACKAGE)/Library/SetCacheMtrrLib/SetCac > heMtrrLib.inf >=20 > [LibraryClasses.common.DXE_DRIVER] > + > + ##################################### > + # Platform Package > + ##################################### > + > + > PlatformBootManagerLib|$(PLATFORM_PACKAGE)/Bds/Library/DxePlatfor > mBoot > + ManagerLib/DxePlatformBootManagerLib.inf > + > ####################################### > # Board Package > ####################################### > - > PlatformBootManagerLib|$(BOARD_PKG)/Library/PlatformBootManagerLib/ > PlatformBootManagerLib.inf > + > + > BoardBdsHookLib|$(BOARD_PKG)/Library/BoardBdsHookLib/BoardBdsHook > Lib.i > + nf > + > BoardBootManagerLib|$(BOARD_PKG)/Library/BoardBootManagerLib/Boar > dBoot > + ManagerLib.inf >=20 > [LibraryClasses.common.DXE_SMM_DRIVER] > ####################################### > @@ -294,3 +301,4 @@ > $(BOARD_PKG)/SimicsVideoDxe/SimicsVideoDxe.inf > $(BOARD_PKG)/SmbiosPlatformDxe/SmbiosPlatformDxe.inf > BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > + BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf > diff --git > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf > index e0a1daddee..99bf607775 100644 > --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf > +++ > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf > @@ -213,6 +213,7 @@ INF > MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf > INF MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf > INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > INF BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > +INF BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf >=20 > INF MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf >=20 > -- > 2.19.1.windows.1