From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.949.1573872815108924267 for ; Fri, 15 Nov 2019 18:53:35 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=tU9lCuGy; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: michael.a.kubacki@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Nov 2019 18:53:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,310,1569308400"; d="scan'208";a="288734051" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga001.jf.intel.com with ESMTP; 15 Nov 2019 18:53:34 -0800 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 15 Nov 2019 18:53:33 -0800 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 15 Nov 2019 18:53:33 -0800 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.52) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 15 Nov 2019 18:53:33 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XlF/e3WLVuOHZO6UR1SLN2Jf55rHgcBdD12ggsSVto4PUYwrUGbxO8oRg+OqMIqrjYHVUG3kC3IP3tMOZWjaF0QDD72zup8pSS/oiUjZ0MV6P9I2Tzo2DBT/kMryWNG8YbRUVe0ME8ulFxalzumdPhp3WCpJOeEd4ywKrrYSlM52bklaTlyuqDEVHxxIeZ5EeTCvtJ1jc69U+l0AUVRpTm0rCFhywJixe2ojYcVx+Wy2b6gefbnq9yVtD8hvx3zyqGVCBJFHhpL1oey1NpzFY9pEZEaR9IYJW8zxAo4ncDvKMDsPLxOILvJwrDIxyp0lF9uy5atXkPjTx71qhV7BZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=knVEZHrmcFMqCNkNsed9TtEb0uMJh+pM3JTPZ4/U0a8=; b=fT0jvg5fS2C1SERwd5n+pefi37UdiyKOVC0OSGoZvzCC2PFj6LCdxbkjYEp5KVHsDHPvqeLucvnCoq4wVagtNURSDyiOdRkjrL05ixbULPGAI86CzdYOXEsFHDE3nAr/h/86z7Eu6bgVS3ZBtlUAHXeYnHADJfiAE8dHFQ/JUj/putJpbF0bhBjM1g2J1g0U+LD5DjIG/j2+ef8I9zCLFBuy8R4fFg6oT7uqmi9xNCds44OD0AZL0VDwg9NBdUdp2h3KrZ3G3YcY5L0JPsqkkIdbMqeKHJBebhCk4GlkXzIPVhpxTvfJ0jM7OJ2kFHBCpvvjSCaaGP5XkZa6T+z4AA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=knVEZHrmcFMqCNkNsed9TtEb0uMJh+pM3JTPZ4/U0a8=; b=tU9lCuGyyjRjsqZjyf0BE+AgRnzJsZlKJukc4HFmWFijYK7mACVzAmb2XKzHBUnvmT1vw5dHn47m0KH5A43Lvb5eFvqit1T9lMO+OFSCUBjvuusoq2Vzex8zwzJ6wc1JxP2VwVWfSoNcGWVNRiareArVXL/bZeTDV7BDjgLX9uo= Received: from BY5PR11MB4484.namprd11.prod.outlook.com (52.132.254.155) by BY5PR11MB4226.namprd11.prod.outlook.com (52.132.253.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2451.23; Sat, 16 Nov 2019 02:53:29 +0000 Received: from BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::a114:604b:7ca3:5420]) by BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::a114:604b:7ca3:5420%7]) with mapi id 15.20.2451.027; Sat, 16 Nov 2019 02:53:29 +0000 From: "Kubacki, Michael A" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Chaganty, Rangasai V" Subject: Re: [edk2-platforms] [PATCH V1 03/13] KabylakeSiliconPkg: Cleanup old comments Thread-Topic: [edk2-platforms] [PATCH V1 03/13] KabylakeSiliconPkg: Cleanup old comments Thread-Index: AQHVmrP8F4kISIgaa0uCDtAlK3zMWaeNGUWA Date: Sat, 16 Nov 2019 02:53:28 +0000 Message-ID: References: <20191114060655.5161-1-nathaniel.l.desimone@intel.com> <20191114060655.5161-4-nathaniel.l.desimone@intel.com> In-Reply-To: <20191114060655.5161-4-nathaniel.l.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzNiMGEyNmQtMjM2OS00N2M1LWE4MzAtZTYxOWE5YzgxYTJhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVVZtY05oRmpCNXd0TitGNkFabnRwU3I1WFQwS2JqK2RTQ1IzWE1UdVFiV1VNZGVUTFdVYk11NnFwWnpmelRyQyJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5ce31540-b970-45e4-13c9-08d76a4028d4 x-ms-traffictypediagnostic: BY5PR11MB4226: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:363; x-forefront-prvs: 02234DBFF6 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(136003)(366004)(346002)(396003)(39860400002)(376002)(13464003)(189003)(199004)(76116006)(66946007)(55016002)(25786009)(66476007)(66556008)(52536014)(4326008)(14454004)(5660300002)(9686003)(64756008)(2906002)(3846002)(6116002)(66446008)(6436002)(229853002)(8936002)(81166006)(81156014)(8676002)(478600001)(6246003)(107886003)(256004)(2501003)(76176011)(74316002)(102836004)(53546011)(6506007)(486006)(7736002)(476003)(305945005)(71200400001)(71190400001)(7696005)(11346002)(446003)(110136005)(54906003)(66066001)(316002)(99286004)(33656002)(86362001)(186003)(26005);DIR:OUT;SFP:1102;SCL:1;SRVR:BY5PR11MB4226;H:BY5PR11MB4484.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4888fqqk984RgSFBsk8bv6tZCQrp8N6FqgxjQo2Qnqw8k4gVIPRxvYeqCva9UTt3ejaYF2X8jPG9WwVRa3DgqD7PXyeBPqcKaHBfRoqGGjpGoBuL482h5jyqX0S4MBc7lmNKIb5uBfQOQTY3NyGK5E3Lhe71P8CFlK0pDi0+eFBgHre338M2cbvHxpD2ZrMNbHdw5VFg82UWVczC64Z/fXpnuiozSXl80Dm8qv8EsLz2W+UKLt7s6ZkrtZtVRqmgckpy5RvcMgMym1BZbUaG7SbjG7UndlBLPnY9NtGcg6GyfNYHgNJ4WT6nI7qVNSUXPNu/UbMxPVUYZLIMS0HHygeD30bIbJ84QANZdRwQhcu0G78zApa8luOM5nZszh9+XdblZjYjb4vMd+BK7qYDvU1nR+I3A0/Cn8X/lsE8iDEvbUoTyq2vIILRipOkWf0S MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 5ce31540-b970-45e4-13c9-08d76a4028d4 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2019 02:53:28.9804 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: G6e/EZsYledySzjMLmtPGDdYTh3sjqx7lbgpnzYrvcPBv6Hr1O5ecGd/hauGc9GT9c3HAQQW5G8O6wCLmixkr6du2tcdSEL0hk49C9aZrbU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4226 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Michael Kubacki > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Wednesday, November 13, 2019 10:07 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Chaganty, Rangasai V > > Subject: [edk2-platforms] [PATCH V1 03/13] KabylakeSiliconPkg: Cleanup ol= d > comments >=20 > Cc: Chasel Chiu > Cc: Michael Kubacki > Cc: Sai Chaganty > Signed-off-by: Nate DeSimone > --- > .../Library/PeiSiliconInitLib/SiliconInitPreMem.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git > a/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitP= reMe > m.c > b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitP= reMe > m.c > index 65a67a6795..384877fba3 100644 > --- > a/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitP= reMe > m.c > +++ b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/Silicon > +++ InitPreMem.c > @@ -31,9 +31,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > #include - > //@todo it should be moved to Si Pkg. /**- Early Platform PCH initializa= tion+ > Early PCH initialization **/ VOID EarlySiliconInit (@@ -233,4 +232,3 @@ > SiliconInit ( > } }--- > 2.23.0.windows.1