public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Kubacki, Michael A" <michael.a.kubacki@intel.com>
To: "Agyeman, Prince" <prince.agyeman@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Chiu, Chasel" <chasel.chiu@intel.com>,
	"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>
Subject: Re: [edk2-platforms] [PATCH] BoardModulePkg: Remove unused variable
Date: Mon, 11 Nov 2019 18:21:01 +0000	[thread overview]
Message-ID: <BY5PR11MB44841B59C371B591E3E57BD6B5740@BY5PR11MB4484.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20191107064916.18892-1-prince.agyeman@intel.com>

Reviewed-by: Michael Kubacki <michael.a.kubacki@intel.com>

> -----Original Message-----
> From: Agyeman, Prince <prince.agyeman@intel.com>
> Sent: Wednesday, November 6, 2019 10:49 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>
> Subject: [edk2-platforms] [PATCH] BoardModulePkg: Remove unused
> variable
> 
> Removed unused variable 'RegEmptied' in BdsPs2KbcLib.c to avoid gcc 5 build
> error unused-but-set-variable.
> 
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> 
> Signed-off-by: Prince Agyeman <prince.agyeman@intel.com>
> ---
>  .../Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c    | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git
> a/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c
> b/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c
> index 3a885e0d71..eff10bddb4 100644
> --- a/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c
> +++
> b/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c
> @@ -47,13 +47,11 @@ DetectPs2Keyboard (
>    )
>  {
>    UINT32                TimeOut;
> -  UINT32                RegEmptied;
>    UINT8                 Data;
>    UINT32                SumTimeOut;
>    BOOLEAN               FoundPs2Kbc;
> 
>    TimeOut     = 0;
> -  RegEmptied  = 0;
>    FoundPs2Kbc       = FALSE;
> 
>    //
> --
> 2.19.1.windows.1


      reply	other threads:[~2019-11-11 18:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-07  6:49 [edk2-platforms] [PATCH] BoardModulePkg: Remove unused variable Agyeman, Prince
2019-11-11 18:21 ` Kubacki, Michael A [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BY5PR11MB44841B59C371B591E3E57BD6B5740@BY5PR11MB4484.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox