From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.1015.1573872811845091595 for ; Fri, 15 Nov 2019 18:53:32 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=gGQ/+0xN; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: michael.a.kubacki@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Nov 2019 18:53:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,310,1569308400"; d="scan'208";a="236287330" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 15 Nov 2019 18:53:31 -0800 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 15 Nov 2019 18:53:31 -0800 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.52) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 15 Nov 2019 18:53:31 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cK7oWinQvWN99Y59ymo/XJySLVQlJuLytErGxt9j3dF/SFQUWGqxu/kwno9fVtahcaTwivP/EtzRgtVskWQv9HwdDFEdkg7wSU1LZ1CRZAj+4dmdpRF5wkZLlcre8y14VjVxhg9jJNXwyYrmN7Vq2B/Sg19nFH9ZiuarwtBJRC0DrB/GsP1KAh7ctBv5FkDUyvyr5y0dHDa4+cf4/EoKNEYpfNPm9BDaNOnB8o7/vRRPB82CoijtrTtQVM5SibJoqgnsyXbVSNHjbxfKZmn6PYojS2q4eWJN3vgq4nRDi3yPcUIPSBJpIUCrqIOtE1LRB9LxK0//uDWjBw69QWMcoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vkXjEonjZWKzI9XXRbkNCVp2z7uASK1YMSvjLSlvSkk=; b=KMIH7uTxpVxqxcvZhWV416aiIZmuzVwnsOIeDF8SxrzSwYyOG/NFqhrb1LznXT0dgYQnAp8jmTvZqINtokAkih8PTYZVEs1w7S1fsW5YRFP2MHi6f2J7Khl3dfnrEsdhwpqeLsjbYM55wwtBehJ7rt1mK9czbVgD3FAfrR4z+R7d/o+DZfw5SpXd3CEy5tK3jYnFIImhq37+EfLjQBfpmiXSQgvisrtr+wX/XOhfuJTv/9pT/h5ggjWByn6M9a8/+vFjLX3Aj4IKvJxAz7o1pZkkv04FqBveyzxfmHuNiyghB2HVWb6a71a37pFmZQOOKXRc8FLHIMvOHjALL3D/zQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vkXjEonjZWKzI9XXRbkNCVp2z7uASK1YMSvjLSlvSkk=; b=gGQ/+0xN1DBwWaFBB+xqcbGN0h98+ZP2XaB4t2iVGebDgxKQVg8rpYk8DvRbkXkGt+Yu8wAPau+u6J78+ivwlFrqheQKUEEIwmR2gONrNQ6Wt5JUom7IA7yKzpTv6+ovIJtk5lss0n5vtTXrO3n5ys2ELlN+7XOLKdf79ZSSzRc= Received: from BY5PR11MB4484.namprd11.prod.outlook.com (52.132.254.155) by BY5PR11MB4226.namprd11.prod.outlook.com (52.132.253.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2451.23; Sat, 16 Nov 2019 02:53:20 +0000 Received: from BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::a114:604b:7ca3:5420]) by BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::a114:604b:7ca3:5420%7]) with mapi id 15.20.2451.027; Sat, 16 Nov 2019 02:53:20 +0000 From: "Kubacki, Michael A" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Chaganty, Rangasai V" Subject: Re: [edk2-platforms] [PATCH V1 01/13] KabylakeSiliconPkg: Change MODULE_TYPE of SiliconInitLib to PEIM Thread-Topic: [edk2-platforms] [PATCH V1 01/13] KabylakeSiliconPkg: Change MODULE_TYPE of SiliconInitLib to PEIM Thread-Index: AQHVmrP71Ar0AiHO2Ee9EG5G5ed9sKeNGS0A Date: Sat, 16 Nov 2019 02:53:20 +0000 Message-ID: References: <20191114060655.5161-1-nathaniel.l.desimone@intel.com> <20191114060655.5161-2-nathaniel.l.desimone@intel.com> In-Reply-To: <20191114060655.5161-2-nathaniel.l.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmI2MWM4NzMtNTMzNC00NThjLTkwMjUtMmNlOTEwYWVlYjA3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoic3YrUXk0WGlZMm5sUDFhRXlySjA0cldzVXFVUzlad0RCNDRyMlNVanl5emJGcnRJek1YTHJOeFwvQVwvUkxSeUc0In0= dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7e93ec2a-3b0e-4b66-3269-08d76a4023bb x-ms-traffictypediagnostic: BY5PR11MB4226: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 02234DBFF6 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(136003)(366004)(346002)(396003)(39860400002)(376002)(13464003)(189003)(199004)(76116006)(66946007)(55016002)(25786009)(66476007)(66556008)(52536014)(4326008)(14454004)(5660300002)(9686003)(64756008)(2906002)(3846002)(6116002)(66446008)(6436002)(229853002)(8936002)(81166006)(81156014)(8676002)(478600001)(6246003)(107886003)(14444005)(256004)(2501003)(76176011)(74316002)(102836004)(53546011)(6506007)(486006)(7736002)(476003)(305945005)(71200400001)(71190400001)(7696005)(11346002)(446003)(110136005)(54906003)(66066001)(316002)(99286004)(33656002)(86362001)(186003)(26005);DIR:OUT;SFP:1102;SCL:1;SRVR:BY5PR11MB4226;H:BY5PR11MB4484.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RG1orpcoRqUbFPz3aMtrXjz7vDbphPRwvhPSB81VskBj/R8mZ8bJ8/QpEeJ7ZvE585HfKsSr3yzxsy74Fw0i63YUfIBuuZcbYd6qAYZTElU2s+GAFiFSSwNMQXE/rbIbdIOZFNavzVTyI1VDQFrJR489j2jSfXOrdhjUaypqOJEeG2Uv2rI7q0xftDT5+SxLCrrJms/4wVrsxxBvDaNSWLw3BQowPOzPkmLmeI0pdyxF1o3DSch3cAckaxGoBC1k2Mx1maiqXYGaCqrQpRPAxHj3VF0NvO+gkm6kp68W0YlYshi7T60ucvc18b5IzliEktWIfsYry/IuiDYOSV0IRd+Odl3uRMeIXWirbKjB7yu727td0I5Wx9noxIG91fT2t/mvfgQlFSIlZlpsjg6/QfQ2+HXDvy5h0EZwXIInEYWLlyqwB49kvbUTLdNg/sY6 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 7e93ec2a-3b0e-4b66-3269-08d76a4023bb X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2019 02:53:20.4587 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ED6rxN5a+q3CGepjx3s6ZU+fO+YkKa66Pbx1a25R0LEQe93V5TuB5gzOZtVuDX68YsIjRsebMzjj5CKiMeihoUqXva8mAf4rGiDiJriGNU0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4226 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Michael Kubacki > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Wednesday, November 13, 2019 10:07 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Chaganty, Rangasai V > > Subject: [edk2-platforms] [PATCH V1 01/13] KabylakeSiliconPkg: Change > MODULE_TYPE of SiliconInitLib to PEIM >=20 > This library contains PEI phase only code. For example, > ClearIchSmiAndWake() calls PeiServicesGetBootMode(). > Accordingly, this library should have never been marked as a BASE library= . >=20 > Cc: Chasel Chiu > Cc: Michael Kubacki > Cc: Sai Chaganty > Signed-off-by: Nate DeSimone > --- > .../PeiSiliconInitLib.inf} | 3 ++- > .../{SiliconInitLib =3D> PeiSiliconInitLib}/SiliconInit.c | 0 > .../{SiliconInitLib =3D> PeiSiliconInitLib}/SiliconInitPreMem.c | 0 > 3 files changed, 2 insertions(+), 1 deletion(-) rename > Silicon/Intel/KabylakeSiliconPkg/Library/{SiliconInitLib/SiliconInitLib.i= nf =3D> > PeiSiliconInitLib/PeiSiliconInitLib.inf} (91%) rename > Silicon/Intel/KabylakeSiliconPkg/Library/{SiliconInitLib =3D> > PeiSiliconInitLib}/SiliconInit.c (100%) rename > Silicon/Intel/KabylakeSiliconPkg/Library/{SiliconInitLib =3D> > PeiSiliconInitLib}/SiliconInitPreMem.c (100%) >=20 > diff --git > a/Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInitLib.= inf > b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/PeiSiliconIn= itLib.in > f > similarity index 91% > rename from > Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInitLib.in= f > rename to > Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/PeiSiliconInit= Lib.inf > index 132080e876..ff83bf2835 100644 > --- a/Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInit= Lib.inf > +++ b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/PeiSili > +++ conInitLib.inf > @@ -11,8 +11,9 @@ > BASE_NAME =3D SiliconInitLib FILE_GUID = =3D 72CD3A7B- > FEA5-4F5E-9165-4DD12187BB13 VERSION_STRING =3D 1.0- > MODULE_TYPE =3D BASE+ MODULE_TYPE = =3D PEIM > LIBRARY_CLASS =3D SiliconInitLib+ # # The following info= rmation is for > reference only and not required by the build tools. #diff --git > a/Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInit.c > b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInit.= c > similarity index 100% > rename from > Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInit.c > rename to > Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInit.c > diff --git > a/Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInitPreM= em.c > b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitP= reMe > m.c > similarity index 100% > rename from > Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInitPreMem= .c > rename to > Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitPre= Mem.c > -- > 2.23.0.windows.1