From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web10.27573.1574358693584791783 for ; Thu, 21 Nov 2019 09:51:33 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=dOT7J0Vx; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: michael.a.kubacki@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2019 09:51:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,226,1571727600"; d="scan'208";a="205222908" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by fmsmga007.fm.intel.com with ESMTP; 21 Nov 2019 09:51:33 -0800 Received: from orsmsx114.amr.corp.intel.com (10.22.240.10) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 21 Nov 2019 09:51:32 -0800 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX114.amr.corp.intel.com (10.22.240.10) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 21 Nov 2019 09:51:32 -0800 Received: from NAM05-CO1-obe.outbound.protection.outlook.com (104.47.48.54) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 21 Nov 2019 09:51:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CkU6RkXTGd9h8xk4R/7uW92MlfPItHoO9XCtfGv+FbgFGAp5UWhYPqVWuilXqLwsHaNy1VHqxU6mbYsnzkouFj7/NcYlr6Gb657CRfgqxtDOnbitPPb199/tCEfY7pYvh5iIU+mDIjQYWrlUFL/q7uBeV0eCfA7lXi9//EKlkTJsgpS2cUxedcWFYK6sxEQCM2+yICg5+a7U0MFrIp0V+zqPL72flZARfKLPMYGGoIAH7kjjuHGL6U/dYkJAyJLzIdzRYWOuwFg8UWjF6U9ssl8N8RBnBEFWr8b0oEbYOumM+/JzrGGWxgXuzf8NUe0wvURBQlhbxpnX0biUMuObcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W27jyXJceXUrpZ3oexuCp9DlV3+PLIW5JhPI9gauTFo=; b=bRtDaMitr2CrKZh0UXlv2kHAypWMCKpeJ56cD7SGnCZWG9IxjJZHK4BIK1WNLZZDXYxnZibbXJwXUJ8/RAXB4bZWgPRVFnl6hfiSAa/3TfcW0UEorUWKikmhn0h0+G+ES9TjDDMcnm2I5Uh6SSjGFaHvaZ9y92Xo2/YHREAwzMwXtj5GdnmpqNsPg1X3e1s950kY2SIchnLoO2sqW/2DvvQB8+JomahBEsz3KH4aieacyvZ6liqAcU+JHayqOkLbcK8VbfGPhzI1nBUhjQq5b0AESMMacVMaIPUHkBuYx8Edo1yXa/fQBtseYhe4xng7pfa/tQP2cVJUQx1i25tJwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W27jyXJceXUrpZ3oexuCp9DlV3+PLIW5JhPI9gauTFo=; b=dOT7J0VxHSg0fC7sC2tWnXpjE6NPi97KUFXWdrA/Id2xE4QUuqgwcuBvBaqjYqjTDFRkOvuanhc387zIiz09I0aE9CMjZqsleoAxPjLbRbzbg2CZd+2/KYHnxd6ZY6UHx6gBj3aBsjljJPyZniT/XqZxsTIi4iuYL6cQEN5KB5E= Received: from BY5PR11MB4484.namprd11.prod.outlook.com (52.132.254.155) by BY5PR11MB4274.namprd11.prod.outlook.com (52.132.254.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.16; Thu, 21 Nov 2019 17:51:31 +0000 Received: from BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::a114:604b:7ca3:5420]) by BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::a114:604b:7ca3:5420%7]) with mapi id 15.20.2474.019; Thu, 21 Nov 2019 17:51:31 +0000 From: "Kubacki, Michael A" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Chaganty, Rangasai V" , "Gao, Liming" , "Oram, Isaac W" , Jeremy Soller Subject: Re: [edk2-platforms] [PATCH V2 00/14] SecFspWrapperPlatformSecLib Cleanup Thread-Topic: [edk2-platforms] [PATCH V2 00/14] SecFspWrapperPlatformSecLib Cleanup Thread-Index: AQHVoEoJoRHkSxmnxUuI4Y+/GMjwFqeV5tew Date: Thu, 21 Nov 2019 17:51:31 +0000 Message-ID: References: <20191121085853.2626-1-nathaniel.l.desimone@intel.com> In-Reply-To: <20191121085853.2626-1-nathaniel.l.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmE4YTU4MTctY2IzYi00ZTRiLTk5YmYtOGY4YjJkNTM1NWY3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiXC9qVVJNdU1sOXZFRm10bkxodFBaRndJXC9EWktmcjNlaEVrK3lwVW9aVTZMSGtsTm9raDMzaEwxdUtqb1wvRlFZUCJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 57dfa10c-c9c8-4c9f-2c5f-08d76eab712d x-ms-traffictypediagnostic: BY5PR11MB4274: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-forefront-prvs: 0228DDDDD7 x-forefront-antispam-report: SFV:SPM;SFS:(10019020)(376002)(136003)(39850400004)(366004)(396003)(346002)(189003)(199004)(13464003)(71190400001)(81156014)(81166006)(33656002)(5660300002)(478600001)(229853002)(256004)(14444005)(7736002)(8936002)(19627235002)(9686003)(86362001)(11346002)(66946007)(55016002)(99286004)(25786009)(66066001)(8676002)(71200400001)(446003)(76116006)(26005)(66446008)(316002)(64756008)(66556008)(66476007)(74316002)(2906002)(6436002)(2501003)(54906003)(110136005)(102836004)(4326008)(6246003)(6506007)(305945005)(53546011)(52536014)(7696005)(14454004)(3846002)(6116002)(186003)(76176011)(175924003)(213903007)(989001);DIR:OUT;SFP:1501;SCL:6;SRVR:BY5PR11MB4274;H:BY5PR11MB4484.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BPyP0K0NsU/DXznS2YxFvRg1R/MHrEUoZCVqyoCmlQ98qTYRZD2allVSgAUpc8P/dIUbR9PJqSCN0dFeQCFreYcNV8Zq/gHEofO9kPigB/ARD+NW7Emefq81yWGQlFBOB2MHNxPoZsEpdP47sYSJ0PCY9u8q0s3NrHIVFNOff7uthiTa/z0CV/9B+CDmhQOdhvjf1dZzGLX/pIjbeVeVUPdkZBlJ/ME16PSu4PSualHZ6UPd9wOkNVmwX5FXoYda7qlqMSRjSjmBilbHr07mCwRDRdTYZfngu/OU90qGj6EW/L4Vanavw3joI31CMgHYesGYDtgEDvujEEQD4ml2EBcau12ADieJND1K9AXk2AjHUJK6JqlSYB1TnJL4EEOih6u1P4P8roSrBb0GhiLVGeBh4UUSBkVsxMARopT4gKD7ABWo8vUmvp9EwIr4XDdoLXDlnniFLm7pCWITE/PNZr4BmKxhqvwJs7oQ/aiz6iXn+gICCoRHFuxCiRtDYVHfv+ptVT9DGJ3x2Ur+AxI3sh5dTv2+jhogSKITHuxtViUtEho5Ytk+DM5wZUoZVnjCa6cfZwVNoe+APo83lAvbggk20FLFbJQ5qFrhx4CuaXPzZeLHcgieyQek3pSYdkXNrlzCn5SguUkg1WrndCVjItAp8wm1j4Jc9KrjpsD3+7sBOuEOz8b0f5b9WolIxWg7PUkHoURF6DU1ArTuuJOQ6Q== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 57dfa10c-c9c8-4c9f-2c5f-08d76eab712d X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Nov 2019 17:51:31.1084 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8D7kI4fJ8ZNE6PRdtalRGgVgrZFCSbMIAAgIuNcvbOV7pdJeUyIKC9Xja8yKSbJ1cB3yUIF972qScho4eD8KnZlR1xP62nHd1efjH+pHos8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4274 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Can you please summarize the changes in V2 of the series? Thanks, Michael > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Thursday, November 21, 2019 12:59 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Chaganty, Rangasai V > ; Gao, Liming ; > Oram, Isaac W ; Jeremy Soller > > Subject: [edk2-platforms] [PATCH V2 00/14] SecFspWrapperPlatformSecLib > Cleanup >=20 > This patch series cleans up two outstanding problems with > SecFspWrapperPlatformSecLib: >=20 > 1. There are several copies of SecFspWrapperPlatformSecLib > thoughout the codebase, this patch series consolidates > the various implementations down to a single implementation > contained in MinPlatformPkg. >=20 > The WhiskeylakeOpenBoardPkg implementation of > SecFspWrapperPlatformSecLib diverged from MinPlatformPkg by halting the > TCO watch dog timer early in SEC instead of early in PEI. Analysis of thi= s > change has shown that it is unnessesary, so this patch series move that c= ode > back to PEI. >=20 > The KabylakeOpenBoardPkg implementation of > SecFspWrapperPlatformSecLib contains support for FSP dispatch mode. This > was integrated into MinPlatformPkg, eliminating the need for > KabylakeOpenBoardPkg version. >=20 > 2. Due to EFI_PEI_TEMPORARY_RAM_DONE_PPI being implemented > by SecMain, the BoardInitLib event callbacks for > BeforeTempRamExit() and AfterTempRamExit() are currently > linked by PlatformSecLib. Linking BoardInitLib in SEC > phase places a lot of restrictions on how BoardInitLib > is implemented. To mitigate this, the BoardInitLib calls > have been moved to a PlatformInitPreMem. > PlatformInitPreMem is invoked by PlatformSecLib using the > new PLATFORM_INIT_TEMP_RAM_EXIT_PPI, which then invokes > the BoardInitLib event callbacks. >=20 > This patch series also includes some general cleanup. >=20 > Cc: Chasel Chiu > Cc: Michael Kubacki > Cc: Sai Chaganty > Cc: Liming Gao > Cc: Isaac W Oram > Cc: Jeremy Soller > Signed-off-by: Nate DeSimone >=20 > Nate DeSimone (14): > KabylakeSiliconPkg: Change MODULE_TYPE of SiliconInitLib to PEIM > KabylakeOpenBoardPkg: Update location of SiliconInitLib > KabylakeSiliconPkg: Cleanup old comments > CoffeeLakeSiliconPkg: Move TcoWdtHob.h > CoffeeLakeSiliconPkg: TcoWdtHob.h Cleanup > CoffeelakeSiliconPkg: Add SiliconInitLib > WhiskeylakeOpenBoardPkg: Add SiliconInitLib APIs to BoardInitLib > WhiskeylakeOpenBoardPkg: Whitespace cleanup in BoardInitLib > WhiskeylakeOpenBoardPkg: Remove SecFspWrapperPlatformSecLib > override > MinPlatformPkg: FSP Dispatch Mode Support for PlatformSecLib > MinPlatformPkg: Coding style cleanups in MinPlatformPkg.dec > KabylakeOpenBoardPkg: Add support for > PcdFspDispatchModeUseFspPeiMain > KabylakeOpenBoardPkg: Remove SecFspWrapperPlatformSecLib override > MinPlatformPkg: Remove BoardInitLib dependency from PlatformSecLib >=20 > .../FspWrapperPlatformSecLib.c | 186 --------- > .../SecFspWrapperPlatformSecLib/FsptCoreUpd.h | 40 -- > .../SecFspWrapperPlatformSecLib/Ia32/Fsp.h | 42 -- > .../Ia32/PeiCoreEntry.nasm | 130 ------- > .../Ia32/SecEntry.nasm | 361 ------------------ > .../Ia32/Stack.nasm | 72 ---- > .../PlatformInit.c | 47 --- > .../SecFspWrapperPlatformSecLib.inf | 97 ----- > .../SecGetPerformance.c | 89 ----- > .../SecPlatformInformation.c | 78 ---- > .../SecRamInitData.c | 36 -- > .../SecTempRamDone.c | 73 ---- > .../GalagoPro3/OpenBoardPkg.dsc | 4 +- > .../KabylakeRvp3/OpenBoardPkg.dsc | 4 +- > .../KabylakeRvp3/OpenBoardPkg.fdf | 5 +- > .../KabylakeRvp3/OpenBoardPkgPcd.dsc | 20 + > .../FspWrapperPlatformSecLib.c | 34 +- > .../SecFspWrapperPlatformSecLib.inf | 9 +- > .../SecTempRamDone.c | 72 +++- > .../Include/Ppi/PlatformInitTempRamExitPpi.h | 55 +++ > .../Intel/MinPlatformPkg/MinPlatformPkg.dec | 313 ++++++++------- > .../PlatformInitPei/PlatformInitPreMem.c | 76 +++- > .../PlatformInitPei/PlatformInitPreMem.inf | 1 + > .../FspWrapperPlatformSecLib.c | 163 -------- > .../SecFspWrapperPlatformSecLib/FsptCoreUpd.h | 40 -- > .../SecFspWrapperPlatformSecLib/Ia32/Fsp.h | 43 --- > .../Ia32/PeiCoreEntry.nasm | 130 ------- > .../Ia32/SecEntry.nasm | 361 ------------------ > .../Ia32/Stack.nasm | 72 ---- > .../PlatformInit.c | 54 --- > .../SecFspWrapperPlatformSecLib.inf | 97 ----- > .../SecGetPerformance.c | 90 ----- > .../SecPlatformInformation.c | 79 ---- > .../SecRamInitData.c | 37 -- > .../SecTempRamDone.c | 48 --- > .../Include/Guid/TcoWdtHob.h | 41 -- > .../BoardInitLib/PeiBoardInitPostMemLib.inf | 1 + > .../BoardInitLib/PeiBoardInitPreMemLib.inf | 1 + > .../PeiMultiBoardInitPostMemLib.inf | 1 + > .../PeiMultiBoardInitPreMemLib.inf | 2 +- > .../PeiWhiskeylakeURvpInitPostMemLib.c | 191 +++++---- > .../PeiWhiskeylakeURvpInitPreMemLib.c | 346 +++++++---------- > .../BoardInitLib/WhiskeylakeURvpInit.h | 1 + > .../WhiskeylakeURvp/OpenBoardPkg.dsc | 7 +- > .../Include/Guid/TcoWdtHob.h | 22 ++ > .../Include/Library/SiliconInitLib.h | 28 ++ > .../PeiSiliconInitLib/PeiSiliconInitLib.inf | 46 +++ > .../Library/PeiSiliconInitLib/SiliconInit.c | 19 + > .../PeiSiliconInitLib/SiliconInitPreMem.c | 109 ++++++ > .../PeiSiliconInitLib.inf} | 5 +- > .../SiliconInit.c | 3 + > .../SiliconInitPreMem.c | 4 +- > 52 files changed, 890 insertions(+), 2995 deletions(-) delete mode 1006= 44 > Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper > PlatformSecLib/FspWrapperPlatformSecLib.c > delete mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper > PlatformSecLib/FsptCoreUpd.h > delete mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper > PlatformSecLib/Ia32/Fsp.h > delete mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper > PlatformSecLib/Ia32/PeiCoreEntry.nasm > delete mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper > PlatformSecLib/Ia32/SecEntry.nasm > delete mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper > PlatformSecLib/Ia32/Stack.nasm > delete mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper > PlatformSecLib/PlatformInit.c > delete mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper > PlatformSecLib/SecFspWrapperPlatformSecLib.inf > delete mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper > PlatformSecLib/SecGetPerformance.c > delete mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper > PlatformSecLib/SecPlatformInformation.c > delete mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper > PlatformSecLib/SecRamInitData.c > delete mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper > PlatformSecLib/SecTempRamDone.c > create mode 100644 > Platform/Intel/MinPlatformPkg/Include/Ppi/PlatformInitTempRamExitPpi.h > delete mode 100644 > Platform/Intel/WhiskeylakeOpenBoardPkg/FspWrapper/Library/SecFspWra > pperPlatformSecLib/FspWrapperPlatformSecLib.c > delete mode 100644 > Platform/Intel/WhiskeylakeOpenBoardPkg/FspWrapper/Library/SecFspWra > pperPlatformSecLib/FsptCoreUpd.h > delete mode 100644 > Platform/Intel/WhiskeylakeOpenBoardPkg/FspWrapper/Library/SecFspWra > pperPlatformSecLib/Ia32/Fsp.h > delete mode 100644 > Platform/Intel/WhiskeylakeOpenBoardPkg/FspWrapper/Library/SecFspWra > pperPlatformSecLib/Ia32/PeiCoreEntry.nasm > delete mode 100644 > Platform/Intel/WhiskeylakeOpenBoardPkg/FspWrapper/Library/SecFspWra > pperPlatformSecLib/Ia32/SecEntry.nasm > delete mode 100644 > Platform/Intel/WhiskeylakeOpenBoardPkg/FspWrapper/Library/SecFspWra > pperPlatformSecLib/Ia32/Stack.nasm > delete mode 100644 > Platform/Intel/WhiskeylakeOpenBoardPkg/FspWrapper/Library/SecFspWra > pperPlatformSecLib/PlatformInit.c > delete mode 100644 > Platform/Intel/WhiskeylakeOpenBoardPkg/FspWrapper/Library/SecFspWra > pperPlatformSecLib/SecFspWrapperPlatformSecLib.inf > delete mode 100644 > Platform/Intel/WhiskeylakeOpenBoardPkg/FspWrapper/Library/SecFspWra > pperPlatformSecLib/SecGetPerformance.c > delete mode 100644 > Platform/Intel/WhiskeylakeOpenBoardPkg/FspWrapper/Library/SecFspWra > pperPlatformSecLib/SecPlatformInformation.c > delete mode 100644 > Platform/Intel/WhiskeylakeOpenBoardPkg/FspWrapper/Library/SecFspWra > pperPlatformSecLib/SecRamInitData.c > delete mode 100644 > Platform/Intel/WhiskeylakeOpenBoardPkg/FspWrapper/Library/SecFspWra > pperPlatformSecLib/SecTempRamDone.c > delete mode 100644 > Platform/Intel/WhiskeylakeOpenBoardPkg/Include/Guid/TcoWdtHob.h > create mode 100644 > Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h > create mode 100644 > Silicon/Intel/CoffeelakeSiliconPkg/Include/Library/SiliconInitLib.h > create mode 100644 > Silicon/Intel/CoffeelakeSiliconPkg/Library/PeiSiliconInitLib/PeiSiliconIn= itLib.in > f > create mode 100644 > Silicon/Intel/CoffeelakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInit.= c > create mode 100644 > Silicon/Intel/CoffeelakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitP= reMem > .c > rename > Silicon/Intel/KabylakeSiliconPkg/Library/{SiliconInitLib/SiliconInitLib.i= nf =3D> > PeiSiliconInitLib/PeiSiliconInitLib.inf} (86%) rename > Silicon/Intel/KabylakeSiliconPkg/Library/{SiliconInitLib =3D> > PeiSiliconInitLib}/SiliconInit.c (95%) rename > Silicon/Intel/KabylakeSiliconPkg/Library/{SiliconInitLib =3D> > PeiSiliconInitLib}/SiliconInitPreMem.c (95%) >=20 > -- > 2.24.0.windows.2