From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.1205.1573087823332660598 for ; Wed, 06 Nov 2019 16:50:23 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=DbFTC+co; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: michael.a.kubacki@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2019 16:50:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,276,1569308400"; d="scan'208";a="205513717" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by orsmga003.jf.intel.com with ESMTP; 06 Nov 2019 16:50:22 -0800 Received: from orsmsx113.amr.corp.intel.com (10.22.240.9) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 Nov 2019 16:50:22 -0800 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX113.amr.corp.intel.com (10.22.240.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 Nov 2019 16:50:22 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.57) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 Nov 2019 16:50:22 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jm9Xn8I92xFIGo0F8Uduz3sZThFEKF3lG0weHFKXGndE1+7ywrxpDHaNzi0BuvLOgjcBZhl/lcxDI19aSyzFsZztuaX/dNpxIQJkWq8qRG/4y5au4XXUpUcuKRBWNfwXn68ppeJmkWdzMCKzGWLO5+qGxD8jbaxCToSz/ju21CuSIJzNsBIi0BpO7+W0AGQg9OOKSWgGV4f1BV5eKw+dCb4axT5ullwudP8OqrubDiJE745h9tzLp3HzE81LMrMtxWFSvvvh1B8daJriIvaSBMdk9IAF770bd7ZcAnwPY5qNGhDXqR9YGNwM5hE4Ibu4ntzZqMgDGJ73oK2ad4M/4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fRrd3iSK7PPV6eleqkMND8KaUNs3AVVx61RXEcODHDM=; b=EvRo4wbaEMEfxVzGuT77xh5eV685Jc0cWE7bPphVPk0mMLFacnxlKZImauRKhPTRW5UvdIyLJOcf7j0V4Jlw+IYOvBt/RfCUoxGdlr933CkYSFKy9GUfTOTDsB0gSs9hCvU+VQhvlwLaw9TNdM0dCKfrpQg5lIIHYGHxmQ0ny4jeC/NIY0bfRClPPaZ2Juw2nF0CcE0PJB2873/la6vCTUInwCQarszAfZDvDb0NM9AXYi5Ir1L+p+8U/1Zg2vexHxNTktcRmiY1P/KZ6L2BOTvCk5DlnGO8OLJQ9BYFbDsiCbB8Zr35/zTrQpR8MDz/fxPvwenSd9IIfq7ffVPzeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fRrd3iSK7PPV6eleqkMND8KaUNs3AVVx61RXEcODHDM=; b=DbFTC+co+eBHeBBSxN+KPuIkE0E7S2quwN0dw44pjr0YQZ5nvEPy9syZUcYWlo/BerG8vo9YiybVhepQ7Bz2Ke5/Kr5muxhKe8mdzjNS1GGoiqjVRPIX+vcg5VsNRkKG7qTpHmKWk41tbqCgHe8lIXSRf/yymWV8p0gGHracb9c= Received: from BY5PR11MB4484.namprd11.prod.outlook.com (52.132.254.155) by BY5PR11MB3976.namprd11.prod.outlook.com (10.255.160.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.24; Thu, 7 Nov 2019 00:50:20 +0000 Received: from BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::c1ef:6e0b:90c8:55e2]) by BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::c1ef:6e0b:90c8:55e2%7]) with mapi id 15.20.2430.020; Thu, 7 Nov 2019 00:50:20 +0000 From: "Kubacki, Michael A" To: "Agyeman, Prince" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" Subject: Re: [edk2-platforms] [Patch v2 9/9] WhiskeylakeOpenBoardPkg: Add Ps2 Keyboard Support Thread-Topic: [edk2-platforms] [Patch v2 9/9] WhiskeylakeOpenBoardPkg: Add Ps2 Keyboard Support Thread-Index: AQHVlEE6i8xR78h1bk2VbYu/xyAdGad+24Tw Date: Thu, 7 Nov 2019 00:50:20 +0000 Message-ID: References: <20191106012603.4724-1-prince.agyeman@intel.com> <20191106012603.4724-10-prince.agyeman@intel.com> In-Reply-To: <20191106012603.4724-10-prince.agyeman@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmI2Y2I1MDYtZDJlOS00MzUzLWFlODAtODQ5ZTJlYTI3MTFlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMUgrZGlGMVpPZGtRaXVBNXlEQVAwRWdMdjJack5sQkk4SkpIcnVBK3NKV3UrVllySVJ0aHZRM2RaelhxZDlPNyJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1ee3f565-0552-4c83-af80-08d7631c771e x-ms-traffictypediagnostic: BY5PR11MB3976: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2331; x-forefront-prvs: 0214EB3F68 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(1496009)(39860400002)(136003)(376002)(396003)(346002)(366004)(13464003)(199004)(189003)(486006)(11346002)(6436002)(305945005)(66066001)(55016002)(6246003)(2501003)(14454004)(2906002)(4326008)(86362001)(6116002)(14444005)(3846002)(33656002)(110136005)(7736002)(71190400001)(478600001)(25786009)(99286004)(446003)(8676002)(107886003)(52536014)(81166006)(81156014)(8936002)(54906003)(9686003)(316002)(256004)(66946007)(53546011)(66446008)(6506007)(64756008)(26005)(66556008)(7696005)(74316002)(76176011)(102836004)(476003)(186003)(71200400001)(66476007)(76116006)(229853002)(5660300002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY5PR11MB3976;H:BY5PR11MB4484.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Xqr2VEjO/v33vPVE+0EaFfICUUCrrvydm7jFw5Rx1WYJcjpaglMmpPHVgOO+cfTSWU15famrrjPa5n3jLWELfYMXjc2zlZT/TUDMBBSLPOTmI3GabfDvOWlHP1YQ+SWiXQuU+ugWMmvCFiHMZAfQ8OINZdSQ/q4aIsbcrTxc29F4+ntFvIPanzPCs0LWFWrBMT84/UJO5Yc7cB7iFmoNS8YXS5boztmEvuQJh3QrMEJIDIgoMXrDDXmpMvXtwc2lHiY2xA8NG2af+nlV4AOKs9qCcuQAizBo22/QPvhIvEpa0lHvcNwDQP/zTmSrVVp0Ljm7vOIIuyWBZ8tUPojK4ik7iBTD5J91sQYmyOH0AqXp+le4KAzVHA4ccIDBRiuWgMbt6WgUNHfvsSYDhqMcZFGIPta2fXTaGyPWY4xFO9bZtOL4f2+HKh7n+FjP5sEG MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 1ee3f565-0552-4c83-af80-08d7631c771e X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Nov 2019 00:50:20.3848 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AmxVgjJR3smE7w81oWUUJp2PRgvoKdkz8wVNacwNGpBPTM7JdcsaAiKIQgmM0Tksu+qKWbm6M9T2OwXAYTfoMllRpc3wNm1lI3pkYsGNhPk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB3976 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Michael Kubacki > -----Original Message----- > From: Agyeman, Prince > Sent: Tuesday, November 5, 2019 5:26 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject: [edk2-platforms] [Patch v2 9/9] WhiskeylakeOpenBoardPkg: Add > Ps2 Keyboard Support >=20 > What was done: >=20 > * Added BDS Ps2 keyboard DXE driver. >=20 > * Included Super I/O DXE driver to publish the SIO protocol needed by the > Ps2 keyboard DXE driver. >=20 > * Included a Ps2 Library to BdsDxe driver to add the Ps2 device path to = ConIn > and ConInDev variables >=20 > * Configured the Super I/O Pci to Isa bridge bus, device, function devic= e info > PCD. This will help the Super I/O driver identify which bridge the Super= I/O is > connected to. >=20 > * Removed duplicate Ps2 enable PCDs >=20 > Cc: Michael Kubacki > Cc: Chasel Chiu > Cc: Nate DeSimone >=20 > Signed-off-by: Prince Agyeman > --- > Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec | 1 - > .../WhiskeylakeURvp/OpenBoardPkg.dsc | 6 ++++++ > .../WhiskeylakeURvp/OpenBoardPkg.fdf | 2 ++ > .../WhiskeylakeURvp/OpenBoardPkgPcd.dsc | 6 ++++++ > 4 files changed, 14 insertions(+), 1 deletion(-) >=20 > diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec > b/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec > index 34494d0168..fbb9549e44 100644 > --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec > +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec > @@ -271,7 +271,6 @@ > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdAcpiHibernate|1|UINT8|0 > x40000003 >=20 > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdLowPowerS0Idle|0|UINT8 > |0x40000004 >=20 > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdPciExpNative|0|UINT8|0x > 40000005 >=20 > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdNativeAspmEnable|1|UIN > T8|0x40000006 > - > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdPs2KbMsEnable|0|UINT8| > 0x40000009 >=20 > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdDisableActiveTripPoints|1| > UINT8|0x4000000A >=20 > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdDisablePassiveTripPoints|0 > |UINT8|0x4000000B >=20 > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdDisableCriticalTripPoints|1 > |UINT8|0x4000000C > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > Pkg.dsc > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > Pkg.dsc > index 8e0ea2d5ce..1c7c12696c 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > Pkg.dsc > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > Pk > +++ g.dsc > @@ -335,6 +335,11 @@ > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf > MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf >=20 > MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDx > e.inf > + MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf > + MdeModulePkg/Universal/BdsDxe/BdsDxe.inf{ > + > + NULL|BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.inf > + } > UefiCpuPkg/CpuDxe/CpuDxe.inf >=20 > ShellPkg/Application/Shell/Shell.inf { @@ -428,3 +433,4 @@ !if > gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly =3D=3D FALSE > $(PLATFORM_BOARD_PACKAGE)/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf > !endif > + BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > Pkg.fdf > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > Pkg.fdf > index 140e6260c9..8a4fd973b4 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > Pkg.fdf > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > Pk > +++ g.fdf > @@ -340,6 +340,8 @@ INF > MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf > INF MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf > INF > MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDx > e.inf > INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > +INF BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > +INF MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf >=20 > INF ShellPkg/Application/Shell/Shell.inf >=20 > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > PkgPcd.dsc > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > PkgPcd.dsc > index adbd48f6d7..52471cb25b 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > PkgPcd.dsc > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > Pk > +++ gPcd.dsc > @@ -296,6 +296,12 @@ > gMinPlatformPkgTokenSpaceGuid.PcdTestPointIbvPlatformFeature|{0x03, > 0x0F, 0x07, 0x1F, 0x1F, 0x0F, 0x0F, 0x07, 0x03, 0x00, 0x00, 0x00, 0x00, 0= x00, > 0x00, 0x00} !endif >=20 > + ###################################### > + # Board Configuration > + ###################################### > + gBoardModulePkgTokenSpaceGuid.PcdPs2KbMsEnable|1 > + gBoardModulePkgTokenSpaceGuid.PcdSuperIoPciIsaBridgeDevice|{0x00, > + 0x00, 0x1F, 0x00} > + > [PcdsFixedAtBuild.IA32] > ###################################### > # Edk2 Configuration > -- > 2.19.1.windows.1