From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.954.1573872839432792657 for ; Fri, 15 Nov 2019 18:53:59 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=V/nvnsIf; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: michael.a.kubacki@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Nov 2019 18:53:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,310,1569308400"; d="scan'208";a="405533376" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga005.fm.intel.com with ESMTP; 15 Nov 2019 18:53:53 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 15 Nov 2019 18:53:53 -0800 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.57) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 15 Nov 2019 18:53:54 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oKHPO2pzGZGubWp6EEPrdTWjLTW4S/GTsdPWeVlTDEAoNiEXGNV9HhitAkXM3+kJXNR5Hano6jpW70BeLPyrlz+9t2nYfE0Mx6NRL857LwMmR02zQ0dQeNeuWgNCBhvhqxQI42oeK7+MdqjQV6LsokzLVCbwEPCQRcM+T4JsVfx7S9s+shhDRshqyJw72nMNl5g4GLpDHHp+Eu65Q2n+vfPM9Cq0g4LkZBCHZWf2OZTpRhMHJNmymyDRUuTmbLcIA5dsPytuROVLfnSbF7jPbm5qA6owAEZqwNGQwrGvDbUY3CW6Ut+PdJO5k7mnRL/pXugxeviO8jKjlHPeV3hJjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xF+VkhmzworXHLgfDQblQ3L4ty6dqm8uwesi9FZRw/c=; b=gwFZqg2EoD22HAPkx1Li0GsaU8v6++wQAUZZbYZZ9ppxGg12sVr0w8m2AYypFeXS/64fptHfxcmCO3sg8J4SUtRwrzP6pV8csVzQCfdOk1FHF+pMTM/v+cbcn5SziaOx49cgfhexYYyDh47SgsAjOTC32bwtILY6Je0U6gANnGGqfiSfN7InOY5TpJZ5TobsReK6/tE+75zBuWWZMZFz8WHJZ+UrwqrpquzxQwmUnw0NOB9NJE38aXe1G3B7bVsISNmk8x+2YRB7LzRy7ZvNCv2R5/HWMDLIBUszaM9YzIq30wtXfXn1p+SEA+AuFAmh/59SRF+Xi+xqJWJTyTUF7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xF+VkhmzworXHLgfDQblQ3L4ty6dqm8uwesi9FZRw/c=; b=V/nvnsIfkBWWZmPI5wGyOXEi8cTWQRaIHTYpHTVKGmhHGf98I943/5aYIHyEJ5LdJCkGdaYKXE9j+cVk+PXOgyc9zbA6RnobPDQJtHlCVd1VrH8FRvDllq/P72pmBH8g89Stm5TjscLL485OsUpEVWcJj/lbTch46l4p12CcdmU= Received: from BY5PR11MB4484.namprd11.prod.outlook.com (52.132.254.155) by BY5PR11MB4226.namprd11.prod.outlook.com (52.132.253.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2451.23; Sat, 16 Nov 2019 02:53:51 +0000 Received: from BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::a114:604b:7ca3:5420]) by BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::a114:604b:7ca3:5420%7]) with mapi id 15.20.2451.027; Sat, 16 Nov 2019 02:53:51 +0000 From: "Kubacki, Michael A" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Chiu, Chasel" Subject: Re: [edk2-platforms] [PATCH V1 07/13] WhiskeylakeOpenBoardPkg: Whitespace cleanup in BoardInitLib Thread-Topic: [edk2-platforms] [PATCH V1 07/13] WhiskeylakeOpenBoardPkg: Whitespace cleanup in BoardInitLib Thread-Index: AQHVmrP//hGXpTb2nEinruDhRPGu/qeNGX9w Date: Sat, 16 Nov 2019 02:53:51 +0000 Message-ID: References: <20191114060655.5161-1-nathaniel.l.desimone@intel.com> <20191114060655.5161-8-nathaniel.l.desimone@intel.com> In-Reply-To: <20191114060655.5161-8-nathaniel.l.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmJjMDRhOGQtNTEyMy00NTFiLThhM2UtOTcyZGU1NDE2OGI4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTFE3bDJUaVN2amdTUkdQWkdTR2VCdGZDdWtLQW5nMm02M2R1a2w2Yzl6R2EwZ25xQWNOdzBDbEFRenc5aWtGdCJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 454c3a83-f9d0-44a6-17a2-08d76a4035ff x-ms-traffictypediagnostic: BY5PR11MB4226: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:130; x-forefront-prvs: 02234DBFF6 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(136003)(366004)(346002)(396003)(39860400002)(376002)(13464003)(189003)(199004)(76116006)(66946007)(55016002)(25786009)(66476007)(66556008)(52536014)(4326008)(14454004)(5660300002)(9686003)(64756008)(2906002)(3846002)(6116002)(66446008)(6436002)(229853002)(8936002)(30864003)(81166006)(81156014)(8676002)(478600001)(6246003)(107886003)(14444005)(256004)(19627235002)(2501003)(76176011)(74316002)(102836004)(53546011)(6506007)(486006)(7736002)(476003)(305945005)(71200400001)(71190400001)(7696005)(11346002)(446003)(110136005)(66066001)(316002)(99286004)(33656002)(86362001)(186003)(26005)(334744003)(569006);DIR:OUT;SFP:1102;SCL:1;SRVR:BY5PR11MB4226;H:BY5PR11MB4484.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DQ+PlpwNiNyJnczBXdorQJRtOKAotrTZw78UMyOr0XnkZP1RVRj5SGWDkcR69qxKuTCDYflBa2eKVVCRNtPaN7Rff2V68nk8z+WRHwoaSJ0EZ1rqAgSF8eCEcZ7EgRiU/MqD14WKcGPYkElSGWJe7WnOB5+pOp27aXjt2PsWIt29tTSZATqGMmBzD52/j/63xjzkgzm92IKTjFS6AQ7SIxyFB4s0hmLG4hFGTRdU4rBCYCgsoPwztSW4aB2UndnPYD9mfnEJQAbsYh9WTIeG3RxTyFkhdUApVh1ZNKcTabCmIVP1o4W60O9Ujc9adf0LusQetxU65g6G+ZezSxvwI38DZbL3VnNHlMnXR4gpy7pUbzxJ9/cl1a+74xqu13G6odC+HrH9PHIqo8boDY6Khn4oTUzddTBj61VsilMj1HF6OKTE7NLIccxZnwHX4YuY MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 454c3a83-f9d0-44a6-17a2-08d76a4035ff X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2019 02:53:51.1056 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: u/UXMWpGHUQ6oTgLN7VPvBbPDgNw1W1REr3c9AC0hqFhSuMLTgmr7rqyx5qxriQ/cwDJTs4WrJKlwGS0qfDGq6wF1X9MQ6V7sCLJDv1mYz0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4226 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Michael Kubacki > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Wednesday, November 13, 2019 10:07 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > > Subject: [edk2-platforms] [PATCH V1 07/13] WhiskeylakeOpenBoardPkg: > Whitespace cleanup in BoardInitLib >=20 > Cc: Chasel Chiu > Cc: Michael Kubacki > Signed-off-by: Nate DeSimone > --- > .../PeiWhiskeylakeURvpInitPostMemLib.c | 185 ++++++------- > .../PeiWhiskeylakeURvpInitPreMemLib.c | 257 +++++++++--------- > 2 files changed, 216 insertions(+), 226 deletions(-) >=20 > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/PeiWhiskeylakeURvpInitPostMemLib.c > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/PeiWhiskeylakeURvpInitPostMemLib.c > index 248a6657d5..827af6bb57 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/PeiWhiskeylakeURvpInitPostMemLib.c > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/PeiWhiskeylakeURvpInitPostMemLib.c > @@ -33,16 +33,16 @@ > #include "WhiskeylakeURvpInit.h" >=20 >=20 >=20 > EFI_STATUS >=20 > -BoardFunctionInit( >=20 > +BoardFunctionInit ( >=20 > IN UINT16 BoardId >=20 > -); >=20 > + ); >=20 >=20 >=20 > /** >=20 > -GPIO init function for PEI post memory phase. >=20 > + GPIO init function for PEI post memory phase. >=20 >=20 >=20 > -@param[in] BoardId An unsigned integrer represent the board id. >=20 > + @param[in] BoardId An unsigned integrer represent the board id. >=20 >=20 >=20 > -@retval EFI_SUCCESS The function completed successfully. >=20 > + @retval EFI_SUCCESS The function completed successfully. >=20 > **/ >=20 > EFI_STATUS >=20 > BoardGpioInit( >=20 > @@ -72,48 +72,48 @@ BoardGpioInit( > } >=20 >=20 >=20 > /** >=20 > -Touch panel GPIO init function for PEI post memory phase. >=20 > + Touch panel GPIO init function for PEI post memory phase. >=20 >=20 >=20 > -@param[in] BoardId An unsigned integrer represent the board id. >=20 > + @param[in] BoardId An unsigned integrer represent the board id. >=20 >=20 >=20 > -@retval EFI_SUCCESS The function completed successfully. >=20 > + @retval EFI_SUCCESS The function completed successfully. >=20 > **/ >=20 > EFI_STATUS >=20 > -TouchPanelGpioInit( >=20 > +TouchPanelGpioInit ( >=20 > IN UINT16 BoardId >=20 > -) >=20 > + ) >=20 > { >=20 > switch (BoardId) { >=20 > default: >=20 > - PcdSet32S(PcdBoardGpioTableTouchPanel, 0); >=20 > + PcdSet32S (PcdBoardGpioTableTouchPanel, 0); >=20 > break; >=20 > } >=20 > return EFI_SUCCESS; >=20 > } >=20 >=20 >=20 > /** >=20 > -Misc. init function for PEI post memory phase. >=20 > + Misc. init function for PEI post memory phase. >=20 >=20 >=20 > -@param[in] BoardId An unsigned integrer represent the board id. >=20 > + @param[in] BoardId An unsigned integrer represent the board id. >=20 >=20 >=20 > -@retval EFI_SUCCESS The function completed successfully. >=20 > + @retval EFI_SUCCESS The function completed successfully. >=20 > **/ >=20 > EFI_STATUS >=20 > -BoardMiscInit( >=20 > +BoardMiscInit ( >=20 > IN UINT16 BoardId >=20 > -) >=20 > + ) >=20 > { >=20 > - PcdSetBoolS(PcdDebugUsbUartEnable, FALSE); >=20 > + PcdSetBoolS (PcdDebugUsbUartEnable, FALSE); >=20 >=20 >=20 > switch (BoardId) { >=20 >=20 >=20 > case BoardIdWhiskeyLakeRvp: >=20 >=20 >=20 > - PcdSetBoolS(PcdMipiCamGpioEnable, TRUE); >=20 > + PcdSetBoolS (PcdMipiCamGpioEnable, TRUE); >=20 > break; >=20 >=20 >=20 > default: >=20 > - PcdSetBoolS(PcdMipiCamGpioEnable, FALSE); >=20 > + PcdSetBoolS (PcdMipiCamGpioEnable, FALSE); >=20 > break; >=20 > } >=20 >=20 >=20 > @@ -121,25 +121,22 @@ BoardMiscInit( > } >=20 >=20 >=20 > /** >=20 > -Security GPIO init function for PEI post memory phase. >=20 > + Security GPIO init function for PEI post memory phase. >=20 >=20 >=20 > -@param[in] BoardId An unsigned integrer represent the board id. >=20 > + @param[in] BoardId An unsigned integrer represent the board id. >=20 >=20 >=20 > -@retval EFI_SUCCESS The function completed successfully. >=20 > + @retval EFI_SUCCESS The function completed successfully. >=20 > **/ >=20 > EFI_STATUS >=20 > BoardSecurityInit ( >=20 > IN UINT16 BoardId >=20 > -) >=20 > + ) >=20 > { >=20 > switch (BoardId) { >=20 > - >=20 > case BoardIdWhiskeyLakeRvp: >=20 > - >=20 > // TPM interrupt connects to GPIO_CNL_H_GPP_A_7 >=20 > PcdSet32S (PcdTpm2CurrentIrqNum, 0x1F); >=20 > break; >=20 > - >=20 > } >=20 >=20 >=20 > return EFI_SUCCESS; >=20 > @@ -147,7 +144,6 @@ BoardSecurityInit ( >=20 >=20 > /** >=20 > Board configuration initialization in the post-memory boot phase. >=20 > - >=20 > **/ >=20 > VOID >=20 > BoardConfigInit ( >=20 > @@ -178,27 +174,26 @@ BoardConfigInit ( > ASSERT_EFI_ERROR (Status); >=20 > } >=20 >=20 >=20 > -//@todo Review this functionality and if it is required for WHL SDS >=20 > /** >=20 > -Create the HOB for hotkey status for 'Attempt USB First' feature >=20 > + Create the HOB for hotkey status for 'Attempt USB First' feature >=20 >=20 >=20 > -@retval EFI_SUCCESS HOB Creating successful. >=20 > -@retval Others HOB Creating failed. >=20 > + @retval EFI_SUCCESS HOB Creating successful. >=20 > + @retval Others HOB Creating failed. >=20 > **/ >=20 > EFI_STATUS >=20 > -CreateAttemptUsbFirstHotkeyInfoHob( >=20 > +CreateAttemptUsbFirstHotkeyInfoHob ( >=20 > VOID >=20 > -) >=20 > + ) >=20 > { >=20 > EFI_STATUS Status; >=20 > ATTEMPT_USB_FIRST_HOTKEY_INFO AttemptUsbFirstHotkeyInfo; >=20 >=20 >=20 > Status =3D EFI_SUCCESS; >=20 >=20 >=20 > - ZeroMem( >=20 > + ZeroMem ( >=20 > &AttemptUsbFirstHotkeyInfo, >=20 > - sizeof(AttemptUsbFirstHotkeyInfo) >=20 > - ); >=20 > + sizeof (AttemptUsbFirstHotkeyInfo) >=20 > + ); >=20 >=20 >=20 > AttemptUsbFirstHotkeyInfo.RevisonId =3D 0; >=20 > AttemptUsbFirstHotkeyInfo.HotkeyTriggered =3D FALSE; >=20 > @@ -206,29 +201,29 @@ CreateAttemptUsbFirstHotkeyInfoHob( > /// >=20 > /// Build HOB for Attempt USB First feature >=20 > /// >=20 > - BuildGuidDataHob( >=20 > + BuildGuidDataHob ( >=20 > &gAttemptUsbFirstHotkeyInfoHobGuid, >=20 > &(AttemptUsbFirstHotkeyInfo), >=20 > - sizeof(ATTEMPT_USB_FIRST_HOTKEY_INFO) >=20 > - ); >=20 > + sizeof (ATTEMPT_USB_FIRST_HOTKEY_INFO) >=20 > + ); >=20 >=20 >=20 > return Status; >=20 > } >=20 >=20 >=20 > /** >=20 > -Search and identify the physical address of a >=20 > -file module inside the FW_BINARIES_FV_SIGNED FV >=20 > + Search and identify the physical address of a >=20 > + file module inside the FW_BINARIES_FV_SIGNED FV >=20 >=20 >=20 > -@retval EFI_SUCCESS If address has been found >=20 > -@retval Others If address has not been found >=20 > + @retval EFI_SUCCESS If address has been found >=20 > + @retval Others If address has not been found >=20 > **/ >=20 > EFI_STATUS >=20 > -FindModuleInFlash2( >=20 > +FindModuleInFlash2 ( >=20 > IN EFI_FIRMWARE_VOLUME_HEADER *FvHeader, >=20 > IN EFI_GUID *GuidPtr, >=20 > IN OUT UINT32 *ModulePtr, >=20 > IN OUT UINT32 *ModuleSize >=20 > -) >=20 > + ) >=20 > { >=20 > EFI_FFS_FILE_HEADER *FfsHeader; >=20 > EFI_FV_FILE_INFO FileInfo; >=20 > @@ -246,57 +241,57 @@ FindModuleInFlash2( > // >=20 > // Locate FV_IMAGE file type in the FW_BINARIES_FV_SIGNED firmware > volume >=20 > // >=20 > - Status =3D > PeiServicesFfsFindNextFile(EFI_FV_FILETYPE_FIRMWARE_VOLUME_IMAGE, > FvHeader, &FileHandle); >=20 > - if (EFI_ERROR(Status)) { >=20 > + Status =3D PeiServicesFfsFindNextFile > (EFI_FV_FILETYPE_FIRMWARE_VOLUME_IMAGE, FvHeader, &FileHandle); >=20 > + if (EFI_ERROR (Status)) { >=20 > // unable to find FV_IMAGE file in this FV >=20 > break; >=20 > } >=20 >=20 >=20 > FfsHeader =3D (EFI_FFS_FILE_HEADER*)FileHandle; >=20 > - DEBUG((DEBUG_INFO, "FfsHeader 0x%X:\n", FfsHeader)); >=20 > - DEBUG((DEBUG_INFO, " Name =3D 0x%g\n", &FfsHeader->Name)); >=20 > - DEBUG((DEBUG_INFO, " Type =3D 0x%X\n", FfsHeader->Type)); >=20 > - if (IS_FFS_FILE2(FfsHeader)) { >=20 > - DEBUG((DEBUG_INFO, " Size =3D 0x%X\n", FFS_FILE2_SIZE(FfsHeader)))= ; >=20 > + DEBUG ((DEBUG_INFO, "FfsHeader 0x%X:\n", FfsHeader)); >=20 > + DEBUG ((DEBUG_INFO, " Name =3D 0x%g\n", &FfsHeader->Name)); >=20 > + DEBUG ((DEBUG_INFO, " Type =3D 0x%X\n", FfsHeader->Type)); >=20 > + if (IS_FFS_FILE2 (FfsHeader)) { >=20 > + DEBUG ((DEBUG_INFO, " Size =3D 0x%X\n", FFS_FILE2_SIZE(FfsHeader))= ); >=20 > } >=20 > else { >=20 > - DEBUG((DEBUG_INFO, " Size =3D 0x%X\n", FFS_FILE_SIZE(FfsHeader))); >=20 > + DEBUG ((DEBUG_INFO, " Size =3D 0x%X\n", FFS_FILE_SIZE(FfsHeader)))= ; >=20 > } >=20 >=20 >=20 > // >=20 > // Locate FW_BINARIES_FV FV_IMAGE Section >=20 > // >=20 > - Status =3D > PeiServicesFfsFindSectionData(EFI_SECTION_FIRMWARE_VOLUME_IMAGE, > FileHandle, &FileBuffer); >=20 > - if (EFI_ERROR(Status)) { >=20 > + Status =3D PeiServicesFfsFindSectionData > (EFI_SECTION_FIRMWARE_VOLUME_IMAGE, FileHandle, &FileBuffer); >=20 > + if (EFI_ERROR (Status)) { >=20 > // continue to search for the next FV_IMAGE file >=20 > - DEBUG((DEBUG_INFO, "FW_BINARIES_FV section not found. Status =3D > %r\n", Status)); >=20 > + DEBUG ((DEBUG_INFO, "FW_BINARIES_FV section not found. Status =3D > %r\n", Status)); >=20 > continue; >=20 > } >=20 >=20 >=20 > SectionHeader =3D (EFI_COMMON_SECTION_HEADER *)FileBuffer; >=20 > - DEBUG((DEBUG_INFO, "GUIDED SectionHeader 0x%X:\n", >=20 > + DEBUG ((DEBUG_INFO, "GUIDED SectionHeader 0x%X:\n", >=20 > (UINT32)(UINT8 *)SectionHeader)); >=20 > if (IS_SECTION2(SectionHeader)) { >=20 > - DEBUG((DEBUG_INFO, " Guid =3D 0x%g\n", >=20 > + DEBUG ((DEBUG_INFO, " Guid =3D 0x%g\n", >=20 > &((EFI_GUID_DEFINED_SECTION2 *)SectionHeader)- > >SectionDefinitionGuid)); >=20 > - DEBUG((DEBUG_INFO, " DataOfset =3D 0x%X\n", >=20 > + DEBUG ((DEBUG_INFO, " DataOfset =3D 0x%X\n", >=20 > ((EFI_GUID_DEFINED_SECTION2 *)SectionHeader)->DataOffset)); >=20 > } >=20 > else { >=20 > - DEBUG((DEBUG_INFO, " Guid =3D 0x%g\n", >=20 > + DEBUG ((DEBUG_INFO, " Guid =3D 0x%g\n", >=20 > &((EFI_GUID_DEFINED_SECTION *)SectionHeader)- > >SectionDefinitionGuid)); >=20 > - DEBUG((DEBUG_INFO, " DataOfset =3D 0x%X\n", >=20 > + DEBUG ((DEBUG_INFO, " DataOfset =3D 0x%X\n", >=20 > ((EFI_GUID_DEFINED_SECTION *)SectionHeader)->DataOffset)); >=20 > } >=20 > - DEBUG((DEBUG_INFO, " Type =3D 0x%X\n", SectionHeader->Type)); >=20 > + DEBUG ((DEBUG_INFO, " Type =3D 0x%X\n", SectionHeader->Type)); >=20 >=20 >=20 > // >=20 > // Locate Firmware File System file within Firmware Volume >=20 > // >=20 > - Status =3D PeiServicesFfsFindFileByName(GuidPtr, FileBuffer, (VOID > **)&FfsHeader); >=20 > - if (EFI_ERROR(Status)) { >=20 > + Status =3D PeiServicesFfsFindFileByName (GuidPtr, FileBuffer, (VOID > **)&FfsHeader); >=20 > + if (EFI_ERROR (Status)) { >=20 > // continue to search for the next FV_IMAGE file >=20 > - DEBUG((DEBUG_INFO, "Module not found. Status =3D %r\n", Status)); >=20 > + DEBUG ((DEBUG_INFO, "Module not found. Status =3D %r\n", Status)); >=20 > continue; >=20 > } >=20 >=20 >=20 > @@ -305,10 +300,10 @@ FindModuleInFlash2( > // >=20 > // Get File Information >=20 > // >=20 > - Status =3D PeiServicesFfsGetFileInfo(FfsHeader, &FileInfo); >=20 > - if (!EFI_ERROR(Status)) { >=20 > + Status =3D PeiServicesFfsGetFileInfo (FfsHeader, &FileInfo); >=20 > + if (!EFI_ERROR (Status)) { >=20 > *ModuleSize =3D (UINT32)FileInfo.BufferSize; >=20 > - DEBUG((DEBUG_INFO, "Module {0x%g} found at =3D 0x%X, Size =3D 0x%X= \n", >=20 > + DEBUG ((DEBUG_INFO, "Module {0x%g} found at =3D 0x%X, Size =3D > 0x%X\n", >=20 > &FfsHeader->Name, *ModulePtr, *ModuleSize)); >=20 > return Status; >=20 > } >=20 > @@ -318,15 +313,15 @@ FindModuleInFlash2( > } >=20 >=20 >=20 > /** >=20 > -Get the ChipsetInit Binary pointer. >=20 > + Get the ChipsetInit Binary pointer. >=20 >=20 >=20 > -@retval EFI_SUCCESS - ChipsetInit Binary found. >=20 > -@retval EFI_NOT_FOUND - ChipsetInit Binary not found. >=20 > + @retval EFI_SUCCESS - ChipsetInit Binary found. >=20 > + @retval EFI_NOT_FOUND - ChipsetInit Binary not found. >=20 > **/ >=20 > EFI_STATUS >=20 > -UpdateChipsetInitPtr( >=20 > +UpdateChipsetInitPtr ( >=20 > VOID >=20 > -) >=20 > + ) >=20 > { >=20 > EFI_STATUS Status; >=20 > PCH_STEPPING PchStep; >=20 > @@ -339,18 +334,18 @@ UpdateChipsetInitPtr( >=20 >=20 > ModuleAddr =3D 0; >=20 > ModuleSize =3D 0; >=20 > - PchStep =3D PchStepping(); >=20 > + PchStep =3D PchStepping (); >=20 >=20 >=20 > - Status =3D PeiServicesLocatePpi( >=20 > + Status =3D PeiServicesLocatePpi ( >=20 > &gSiPolicyPpiGuid, >=20 > 0, >=20 > NULL, >=20 > (VOID **)&SiPolicyPpi >=20 > - ); >=20 > - ASSERT_EFI_ERROR(Status); >=20 > + ); >=20 > + ASSERT_EFI_ERROR (Status); >=20 >=20 >=20 > - Status =3D GetConfigBlock((VOID *)SiPolicyPpi, &gHsioConfigGuid, (VOID > *)&HsioConfig); >=20 > - ASSERT_EFI_ERROR(Status); >=20 > + Status =3D GetConfigBlock ((VOID *)SiPolicyPpi, &gHsioConfigGuid, (VOI= D > *)&HsioConfig); >=20 > + ASSERT_EFI_ERROR (Status); >=20 >=20 >=20 > ChipsetInitBinaryGuidPtr =3D NULL; >=20 > if (IsPchLp()) { >=20 > @@ -358,22 +353,20 @@ UpdateChipsetInitPtr( > case PCH_D0: >=20 > case PCH_D1: >=20 > ChipsetInitBinaryGuidPtr =3D &gCnlPchLpChipsetInitTableDxGuid; >=20 > - DEBUG((DEBUG_INFO, "Using CnlPchLpChipsetInitTable_Dx table \n")= ); >=20 > + DEBUG ((DEBUG_INFO, "Using CnlPchLpChipsetInitTable_Dx table > \n")); >=20 > break; >=20 > default: >=20 > return EFI_NOT_FOUND; >=20 > } >=20 > - } >=20 > - else { >=20 > + } else { >=20 > return EFI_NOT_FOUND; >=20 > } >=20 >=20 >=20 > // >=20 > // Locate Firmware Volume header >=20 > // >=20 > - // FvHeader =3D (EFI_FIRMWARE_VOLUME_HEADER > *)(UINTN)GetFvBinaryBase(); >=20 > - FvHeader =3D (EFI_FIRMWARE_VOLUME_HEADER *) > FixedPcdGet32(PcdFlashFvPostMemoryBase); >=20 > - Status =3D FindModuleInFlash2(FvHeader, ChipsetInitBinaryGuidPtr, > &ModuleAddr, &ModuleSize); >=20 > + FvHeader =3D (EFI_FIRMWARE_VOLUME_HEADER *) FixedPcdGet32 > (PcdFlashFvPostMemoryBase); >=20 > + Status =3D FindModuleInFlash2 (FvHeader, ChipsetInitBinaryGuidPtr, > &ModuleAddr, &ModuleSize); >=20 > // >=20 > // Get ChipsetInit Binary Pointer >=20 > // >=20 > @@ -384,8 +377,8 @@ UpdateChipsetInitPtr( > // >=20 > HsioConfig->ChipsetInitBinLen =3D ModuleSize; >=20 >=20 >=20 > - DEBUG((DEBUG_INFO, "ChipsetInit Binary Location: %x\n", HsioConfig- > >ChipsetInitBinPtr)); >=20 > - DEBUG((DEBUG_INFO, "ChipsetInit Binary Size: %x\n", HsioConfig- > >ChipsetInitBinLen)); >=20 > + DEBUG ((DEBUG_INFO, "ChipsetInit Binary Location: %x\n", HsioConfig- > >ChipsetInitBinPtr)); >=20 > + DEBUG ((DEBUG_INFO, "ChipsetInit Binary Size: %x\n", HsioConfig- > >ChipsetInitBinLen)); >=20 >=20 >=20 > return Status; >=20 > } >=20 > @@ -401,34 +394,34 @@ WhiskeylakeURvpBoardInitBeforeSiliconInit ( > VOID >=20 > ) >=20 > { >=20 > - EFI_STATUS Status; >=20 > - UINT8 FwConfig; >=20 > + EFI_STATUS Status; >=20 > + UINT8 FwConfig; >=20 >=20 >=20 > - BoardConfigInit(); >=20 > + BoardConfigInit (); >=20 > // >=20 > // Configure GPIO and SIO >=20 > // >=20 > - Status =3D BoardInit(); >=20 > - ASSERT_EFI_ERROR(Status); >=20 > + Status =3D BoardInit (); >=20 > + ASSERT_EFI_ERROR (Status); >=20 >=20 >=20 > FwConfig =3D FwConfigProduction; >=20 > - PeiPolicyInit(FwConfig); >=20 > + PeiPolicyInit (FwConfig); >=20 >=20 >=20 > // >=20 > // Create USB Boot First hotkey information HOB >=20 > // >=20 > - CreateAttemptUsbFirstHotkeyInfoHob(); >=20 > + CreateAttemptUsbFirstHotkeyInfoHob (); >=20 >=20 >=20 > // >=20 > // Initializing Platform Specific Programming >=20 > // >=20 > - Status =3D PlatformSpecificInit(); >=20 > + Status =3D PlatformSpecificInit (); >=20 > ASSERT_EFI_ERROR(Status); >=20 >=20 >=20 > // >=20 > // Update ChipsetInitPtr >=20 > // >=20 > - Status =3D UpdateChipsetInitPtr(); >=20 > + Status =3D UpdateChipsetInitPtr (); >=20 >=20 >=20 > /// >=20 > /// Do Late PCH init >=20 > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/PeiWhiskeylakeURvpInitPreMemLib.c > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/PeiWhiskeylakeURvpInitPreMemLib.c > index 055d731651..75813ff351 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/PeiWhiskeylakeURvpInitPreMemLib.c > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/PeiWhiskeylakeURvpInitPreMemLib.c > @@ -68,84 +68,84 @@ GLOBAL_REMOVE_IF_UNREFERENCED const UINT16 > RcompResistorSklRvp1[SA_MRC_MAX_RCOMP > GLOBAL_REMOVE_IF_UNREFERENCED const UINT16 > RcompTargetSklRvp1[SA_MRC_MAX_RCOMP_TARGETS] =3D { 100, 40, 40, 23, > 40 }; >=20 >=20 >=20 > GLOBAL_REMOVE_IF_UNREFERENCED MEMORY_MAP MmioMap[] =3D { >=20 > - { FixedPcdGet64(PcdApicLocalAddress), > FixedPcdGet32(PcdApicLocalMmioSize) }, >=20 > - { FixedPcdGet64(PcdMchBaseAddress), FixedPcdGet32(PcdMchMmioSize) > }, >=20 > - { FixedPcdGet64(PcdDmiBaseAddress), FixedPcdGet32(PcdDmiMmioSize) > }, >=20 > - { FixedPcdGet64(PcdEpBaseAddress), FixedPcdGet32(PcdEpMmioSize) }, >=20 > - { FixedPcdGet64(PcdGdxcBaseAddress), > FixedPcdGet32(PcdGdxcMmioSize) } >=20 > + { FixedPcdGet64 (PcdApicLocalAddress), FixedPcdGet32 > (PcdApicLocalMmioSize) }, >=20 > + { FixedPcdGet64 (PcdMchBaseAddress), FixedPcdGet32 > (PcdMchMmioSize) }, >=20 > + { FixedPcdGet64 (PcdDmiBaseAddress), FixedPcdGet32 > (PcdDmiMmioSize) }, >=20 > + { FixedPcdGet64 (PcdEpBaseAddress), FixedPcdGet32 (PcdEpMmioSize) > }, >=20 > + { FixedPcdGet64 (PcdGdxcBaseAddress), FixedPcdGet32 > (PcdGdxcMmioSize) } >=20 > }; >=20 >=20 >=20 > EFI_STATUS >=20 > -MrcConfigInit( >=20 > +MrcConfigInit ( >=20 > IN UINT16 BoardId >=20 > -); >=20 > + ); >=20 >=20 >=20 > EFI_STATUS >=20 > -SaGpioConfigInit( >=20 > +SaGpioConfigInit ( >=20 > IN UINT16 BoardId >=20 > -); >=20 > + ); >=20 >=20 >=20 > EFI_STATUS >=20 > - SaMiscConfigInit( >=20 > -IN UINT16 BoardId >=20 > -); >=20 > +SaMiscConfigInit ( >=20 > + IN UINT16 BoardId >=20 > + ); >=20 >=20 >=20 > EFI_STATUS >=20 > - RootPortClkInfoInit( >=20 > -IN UINT16 BoardId >=20 > -); >=20 > +RootPortClkInfoInit ( >=20 > + IN UINT16 BoardId >=20 > + ); >=20 >=20 >=20 > EFI_STATUS >=20 > - UsbConfigInit( >=20 > -IN UINT16 BoardId >=20 > -); >=20 > +UsbConfigInit ( >=20 > + IN UINT16 BoardId >=20 > + ); >=20 >=20 >=20 > EFI_STATUS >=20 > -GpioGroupTierInit( >=20 > +GpioGroupTierInit ( >=20 > IN UINT16 BoardId >=20 > -); >=20 > + ); >=20 >=20 >=20 > EFI_STATUS >=20 > -GpioTablePreMemInit( >=20 > +GpioTablePreMemInit ( >=20 > IN UINT16 BoardId >=20 > -); >=20 > + ); >=20 >=20 >=20 > EFI_STATUS >=20 > -PchPmConfigInit( >=20 > +PchPmConfigInit ( >=20 > IN UINT16 BoardId >=20 > -); >=20 > + ); >=20 >=20 >=20 > EFI_STATUS >=20 > -SaDisplayConfigInit( >=20 > +SaDisplayConfigInit ( >=20 > IN UINT16 BoardId >=20 > -); >=20 > + ); >=20 >=20 >=20 > EFI_STATUS >=20 > -BoardFunctionInitPreMem( >=20 > +BoardFunctionInitPreMem ( >=20 > IN UINT16 BoardId >=20 > -); >=20 > + ); >=20 >=20 >=20 > EFI_STATUS >=20 > EFIAPI >=20 > -PlatformInitPreMemCallBack( >=20 > +PlatformInitPreMemCallBack ( >=20 > IN CONST EFI_PEI_SERVICES **PeiServices, >=20 > IN EFI_PEI_NOTIFY_DESCRIPTOR *NotifyDescriptor, >=20 > IN VOID *Ppi >=20 > -); >=20 > + ); >=20 >=20 >=20 > EFI_STATUS >=20 > EFIAPI >=20 > -MemoryDiscoveredPpiNotify( >=20 > +MemoryDiscoveredPpiNotify ( >=20 > IN CONST EFI_PEI_SERVICES **PeiServices, >=20 > IN EFI_PEI_NOTIFY_DESCRIPTOR *NotifyDescriptor, >=20 > IN VOID *Ppi >=20 > -); >=20 > + ); >=20 >=20 >=20 > EFI_STATUS >=20 > EFIAPI >=20 > -PchReset( >=20 > +PchReset ( >=20 > IN CONST EFI_PEI_SERVICES **PeiServices >=20 > -); >=20 > + ); >=20 >=20 >=20 > static EFI_PEI_RESET_PPI mResetPpi =3D { >=20 > PchReset >=20 > @@ -172,16 +172,16 @@ static EFI_PEI_NOTIFY_DESCRIPTOR > mMemDiscoveredNotifyList =3D { > }; >=20 >=20 >=20 > /** >=20 > -Board misc init function for PEI pre-memory phase. >=20 > + Board misc init function for PEI pre-memory phase. >=20 >=20 >=20 > -@param[in] BoardId An unsigned integer represent the board id. >=20 > + @param[in] BoardId An unsigned integer represent the board id. >=20 >=20 >=20 > -@retval EFI_SUCCESS The function completed successfully. >=20 > + @retval EFI_SUCCESS The function completed successfully. >=20 > **/ >=20 > EFI_STATUS >=20 > -BoardMiscInitPreMem( >=20 > +BoardMiscInitPreMem ( >=20 > IN UINT16 BoardId >=20 > -) >=20 > + ) >=20 > { >=20 > PCD64_BLOB PcdData; >=20 >=20 >=20 > @@ -211,22 +211,22 @@ BoardMiscInitPreMem( > // power. An alternative way to contol modem power is to toggle > FCP_OFF via GPP_D13 >=20 > // but board rework is required. >=20 > // >=20 > - PcdSet32S(PcdWwanFullCardPowerOffGpio, GPIO_CNL_LP_GPP_D16); >=20 > - PcdSet32S(PcdWwanBbrstGpio, GPIO_CNL_LP_GPP_F1); >=20 > - PcdSet32S(PcdWwanPerstGpio, GPIO_CNL_LP_GPP_E15); >=20 > - PcdSet8S(PcdWwanPerstGpioPolarity, 1); >=20 > + PcdSet32S (PcdWwanFullCardPowerOffGpio, GPIO_CNL_LP_GPP_D16); >=20 > + PcdSet32S (PcdWwanBbrstGpio, GPIO_CNL_LP_GPP_F1); >=20 > + PcdSet32S (PcdWwanPerstGpio, GPIO_CNL_LP_GPP_E15); >=20 > + PcdSet8S (PcdWwanPerstGpioPolarity, 1); >=20 > break; >=20 >=20 >=20 > default: >=20 > break; >=20 > } >=20 >=20 >=20 > - PcdSet64S(PcdRecoveryModeGpio, PcdData.Blob); >=20 > + PcdSet64S (PcdRecoveryModeGpio, PcdData.Blob); >=20 >=20 >=20 > // >=20 > // Pc8374SioKbc Present >=20 > // >=20 > - PcdSetBoolS(PcdPc8374SioKbcPresent, FALSE); >=20 > + PcdSetBoolS (PcdPc8374SioKbcPresent, FALSE); >=20 >=20 >=20 > return EFI_SUCCESS; >=20 > } >=20 > @@ -279,23 +279,23 @@ BoardConfigInitPreMem ( > } >=20 >=20 >=20 > /** >=20 > -This function handles PlatformInit task after PeiReadOnlyVariable2 PPI > produced >=20 > + This function handles PlatformInit task after PeiReadOnlyVariable2 PPI > produced >=20 >=20 >=20 > -@param[in] PeiServices Pointer to PEI Services Table. >=20 > -@param[in] NotifyDesc Pointer to the descriptor for the Notification > event that >=20 > - caused this function to execute. >=20 > -@param[in] Ppi Pointer to the PPI data associated with this f= unction. >=20 > + @param[in] PeiServices Pointer to PEI Services Table. >=20 > + @param[in] NotifyDesc Pointer to the descriptor for the Notificati= on > event that >=20 > + caused this function to execute. >=20 > + @param[in] Ppi Pointer to the PPI data associated with this= function. >=20 >=20 >=20 > -@retval EFI_SUCCESS The function completes successfully >=20 > -@retval others >=20 > + @retval EFI_SUCCESS The function completes successfully >=20 > + @retval others Failure >=20 > **/ >=20 > EFI_STATUS >=20 > EFIAPI >=20 > -PlatformInitPreMemCallBack( >=20 > +PlatformInitPreMemCallBack ( >=20 > IN CONST EFI_PEI_SERVICES **PeiServices, >=20 > IN EFI_PEI_NOTIFY_DESCRIPTOR *NotifyDescriptor, >=20 > IN VOID *Ppi >=20 > -) >=20 > + ) >=20 > { >=20 > EFI_STATUS Status; >=20 > UINT8 FwConfig; >=20 > @@ -303,33 +303,33 @@ PlatformInitPreMemCallBack( > // >=20 > // Init Board Config Pcd. >=20 > // >=20 > - BoardConfigInitPreMem(); >=20 > + BoardConfigInitPreMem (); >=20 >=20 >=20 > - DEBUG((DEBUG_ERROR, "Fail to get System Configuration and set the > configuration to production mode!\n")); >=20 > + DEBUG ((DEBUG_ERROR, "Fail to get System Configuration and set the > configuration to production mode!\n")); >=20 > FwConfig =3D FwConfigProduction; >=20 > - PcdSetBoolS(PcdPcieWwanEnable, FALSE); >=20 > - PcdSetBoolS(PcdWwanResetWorkaround, FALSE); >=20 > + PcdSetBoolS (PcdPcieWwanEnable, FALSE); >=20 > + PcdSetBoolS (PcdWwanResetWorkaround, FALSE); >=20 >=20 >=20 > // >=20 > // Early Board Configuration before memory is ready. >=20 > // >=20 > - Status =3D BoardInitEarlyPreMem(); >=20 > - ASSERT_EFI_ERROR(Status); >=20 > + Status =3D BoardInitEarlyPreMem (); >=20 > + ASSERT_EFI_ERROR (Status); >=20 >=20 >=20 > /// >=20 > /// If there was unexpected reset but no WDT expiration and no resume > from S3/S4, >=20 > /// clear unexpected reset status and enforce expiration. This is to i= nform > Firmware >=20 > /// which has no access to unexpected reset status bit, that something > went wrong. >=20 > /// >=20 > - OcWdtResetCheck(); >=20 > + OcWdtResetCheck (); >=20 >=20 >=20 > - Status =3D OcWdtInit(); >=20 > - ASSERT_EFI_ERROR(Status); >=20 > + Status =3D OcWdtInit (); >=20 > + ASSERT_EFI_ERROR (Status); >=20 >=20 >=20 > // >=20 > // Initialize Intel PEI Platform Policy >=20 > // >=20 > - PeiPolicyInitPreMem(FwConfig); >=20 > + PeiPolicyInitPreMem (FwConfig); >=20 >=20 >=20 > /// >=20 > /// Configure GPIO and SIO >=20 > @@ -340,56 +340,55 @@ PlatformInitPreMemCallBack( > /// >=20 > /// Install Pre Memory PPIs >=20 > /// >=20 > - Status =3D PeiServicesInstallPpi(&mPreMemPpiList[0]); >=20 > - ASSERT_EFI_ERROR(Status); >=20 > + Status =3D PeiServicesInstallPpi (&mPreMemPpiList[0]); >=20 > + ASSERT_EFI_ERROR (Status); >=20 >=20 >=20 > return Status; >=20 > } >=20 >=20 >=20 > /** >=20 > -Provide hard reset PPI service. >=20 > -To generate full hard reset, write 0x0E to PCH RESET_GENERATOR_PORT > (0xCF9). >=20 > + Provide hard reset PPI service. >=20 > + To generate full hard reset, write 0x0E to PCH RESET_GENERATOR_PORT > (0xCF9). >=20 >=20 >=20 > -@param[in] PeiServices General purpose services available to ever= y > PEIM. >=20 > + @param[in] PeiServices General purpose services available to ev= ery > PEIM. >=20 >=20 >=20 > -@retval Not return System reset occured. >=20 > -@retval EFI_DEVICE_ERROR Device error, could not reset the system. >=20 > + @retval Not return System reset occured. >=20 > + @retval EFI_DEVICE_ERROR Device error, could not reset the system= . >=20 > **/ >=20 > EFI_STATUS >=20 > EFIAPI >=20 > -PchReset( >=20 > +PchReset ( >=20 > IN CONST EFI_PEI_SERVICES **PeiServices >=20 > -) >=20 > + ) >=20 > { >=20 > - DEBUG((DEBUG_INFO, "Perform Cold Reset\n")); >=20 > - IoWrite8(RESET_GENERATOR_PORT, 0x0E); >=20 > + DEBUG ((DEBUG_INFO, "Perform Cold Reset\n")); >=20 > + IoWrite8 (RESET_GENERATOR_PORT, 0x0E); >=20 >=20 >=20 > - CpuDeadLoop(); >=20 > + CpuDeadLoop (); >=20 >=20 >=20 > /// >=20 > /// System reset occured, should never reach at this line. >=20 > /// >=20 > - ASSERT_EFI_ERROR(EFI_DEVICE_ERROR); >=20 > - >=20 > + ASSERT_EFI_ERROR (EFI_DEVICE_ERROR); >=20 > return EFI_DEVICE_ERROR; >=20 > } >=20 >=20 >=20 > /** >=20 > -Install Firmware Volume Hob's once there is main memory >=20 > + Install Firmware Volume Hob's once there is main memory >=20 >=20 >=20 > -@param[in] PeiServices General purpose services available to ever= y > PEIM. >=20 > -@param[in] NotifyDescriptor Notify that this module published. >=20 > -@param[in] Ppi PPI that was installed. >=20 > + @param[in] PeiServices General purpose services available to ev= ery > PEIM. >=20 > + @param[in] NotifyDescriptor Notify that this module published. >=20 > + @param[in] Ppi PPI that was installed. >=20 >=20 >=20 > -@retval EFI_SUCCESS The function completed successfully. >=20 > + @retval EFI_SUCCESS The function completed successfully. >=20 > **/ >=20 > EFI_STATUS >=20 > EFIAPI >=20 > -MemoryDiscoveredPpiNotify( >=20 > +MemoryDiscoveredPpiNotify ( >=20 > IN CONST EFI_PEI_SERVICES **PeiServices, >=20 > IN EFI_PEI_NOTIFY_DESCRIPTOR *NotifyDescriptor, >=20 > IN VOID *Ppi >=20 > -) >=20 > + ) >=20 > { >=20 > EFI_STATUS Status; >=20 > EFI_BOOT_MODE BootMode; >=20 > @@ -400,12 +399,12 @@ MemoryDiscoveredPpiNotify( >=20 >=20 > Index =3D 0; >=20 >=20 >=20 > - Status =3D PeiServicesGetBootMode(&BootMode); >=20 > - ASSERT_EFI_ERROR(Status); >=20 > + Status =3D PeiServicesGetBootMode (&BootMode); >=20 > + ASSERT_EFI_ERROR (Status); >=20 >=20 >=20 > - AsmCpuid(0x80000000, &RegEax, NULL, NULL, NULL); >=20 > + AsmCpuid (0x80000000, &RegEax, NULL, NULL, NULL); >=20 > if (RegEax >=3D 0x80000008) { >=20 > - AsmCpuid(0x80000008, &RegEax, NULL, NULL, NULL); >=20 > + AsmCpuid (0x80000008, &RegEax, NULL, NULL, NULL); >=20 > PhysicalAddressBits =3D (UINT8)RegEax; >=20 > } >=20 > else { >=20 > @@ -415,69 +414,69 @@ MemoryDiscoveredPpiNotify( > /// >=20 > /// Create a CPU hand-off information >=20 > /// >=20 > - BuildCpuHob(PhysicalAddressBits, 16); >=20 > + BuildCpuHob (PhysicalAddressBits, 16); >=20 >=20 >=20 > /// >=20 > /// Build Memory Mapped IO Resource which is used to build E820 Table = in > LegacyBios. >=20 > /// >=20 > - PcieMmioMap.BaseAddress =3D FixedPcdGet64(PcdPciExpressBaseAddress); >=20 > - PcieMmioMap.Length =3D PcdGet32(PcdPciExpressRegionLength); >=20 > + PcieMmioMap.BaseAddress =3D FixedPcdGet64 > (PcdPciExpressBaseAddress); >=20 > + PcieMmioMap.Length =3D PcdGet32 (PcdPciExpressRegionLength); >=20 >=20 >=20 > - BuildResourceDescriptorHob( >=20 > + BuildResourceDescriptorHob ( >=20 > EFI_RESOURCE_MEMORY_MAPPED_IO, >=20 > - (EFI_RESOURCE_ATTRIBUTE_PRESENT | >=20 > - EFI_RESOURCE_ATTRIBUTE_INITIALIZED | >=20 > - EFI_RESOURCE_ATTRIBUTE_UNCACHEABLE), >=20 > + (EFI_RESOURCE_ATTRIBUTE_PRESENT | >=20 > + EFI_RESOURCE_ATTRIBUTE_INITIALIZED | >=20 > + EFI_RESOURCE_ATTRIBUTE_UNCACHEABLE), >=20 > PcieMmioMap.BaseAddress, >=20 > PcieMmioMap.Length >=20 > - ); >=20 > - BuildMemoryAllocationHob( >=20 > + ); >=20 > + BuildMemoryAllocationHob ( >=20 > PcieMmioMap.BaseAddress, >=20 > PcieMmioMap.Length, >=20 > EfiMemoryMappedIO >=20 > - ); >=20 > + ); >=20 > for (Index =3D 0; Index < sizeof(MmioMap) / (sizeof(MEMORY_MAP)); > Index++) { >=20 > - BuildResourceDescriptorHob( >=20 > + BuildResourceDescriptorHob ( >=20 > EFI_RESOURCE_MEMORY_MAPPED_IO, >=20 > - (EFI_RESOURCE_ATTRIBUTE_PRESENT | >=20 > - EFI_RESOURCE_ATTRIBUTE_INITIALIZED | >=20 > - EFI_RESOURCE_ATTRIBUTE_UNCACHEABLE), >=20 > + (EFI_RESOURCE_ATTRIBUTE_PRESENT | >=20 > + EFI_RESOURCE_ATTRIBUTE_INITIALIZED | >=20 > + EFI_RESOURCE_ATTRIBUTE_UNCACHEABLE), >=20 > MmioMap[Index].BaseAddress, >=20 > MmioMap[Index].Length >=20 > - ); >=20 > - BuildMemoryAllocationHob( >=20 > + ); >=20 > + BuildMemoryAllocationHob ( >=20 > MmioMap[Index].BaseAddress, >=20 > MmioMap[Index].Length, >=20 > EfiMemoryMappedIO >=20 > - ); >=20 > + ); >=20 > } >=20 >=20 >=20 > // >=20 > // Report resource HOB for flash FV >=20 > // >=20 > - BuildResourceDescriptorHob( >=20 > + BuildResourceDescriptorHob ( >=20 > EFI_RESOURCE_MEMORY_MAPPED_IO, >=20 > - (EFI_RESOURCE_ATTRIBUTE_PRESENT | >=20 > - EFI_RESOURCE_ATTRIBUTE_INITIALIZED | >=20 > - EFI_RESOURCE_ATTRIBUTE_UNCACHEABLE), >=20 > - (UINTN)FixedPcdGet32(PcdFlashAreaBaseAddress), >=20 > - (UINTN)FixedPcdGet32(PcdFlashAreaSize) >=20 > - ); >=20 > - BuildMemoryAllocationHob( >=20 > - (UINTN)FixedPcdGet32(PcdFlashAreaBaseAddress), >=20 > - (UINTN)FixedPcdGet32(PcdFlashAreaSize), >=20 > + (EFI_RESOURCE_ATTRIBUTE_PRESENT | >=20 > + EFI_RESOURCE_ATTRIBUTE_INITIALIZED | >=20 > + EFI_RESOURCE_ATTRIBUTE_UNCACHEABLE), >=20 > + (UINTN) FixedPcdGet32 (PcdFlashAreaBaseAddress), >=20 > + (UINTN) FixedPcdGet32 (PcdFlashAreaSize) >=20 > + ); >=20 > + >=20 > + BuildMemoryAllocationHob ( >=20 > + (UINTN) FixedPcdGet32 (PcdFlashAreaBaseAddress), >=20 > + (UINTN) FixedPcdGet32 (PcdFlashAreaSize), >=20 > EfiMemoryMappedIO >=20 > - ); >=20 > + ); >=20 >=20 >=20 > - BuildFvHob( >=20 > - (UINTN)FixedPcdGet32(PcdFlashAreaBaseAddress), >=20 > - (UINTN)FixedPcdGet32(PcdFlashAreaSize) >=20 > - ); >=20 > + BuildFvHob ( >=20 > + (UINTN)FixedPcdGet32 (PcdFlashAreaBaseAddress), >=20 > + (UINTN)FixedPcdGet32 (PcdFlashAreaSize) >=20 > + ); >=20 >=20 >=20 > return Status; >=20 > } >=20 >=20 >=20 > - >=20 > /** >=20 > Board configuration init function for PEI pre-memory phase. >=20 >=20 >=20 > @@ -495,26 +494,26 @@ WhiskeylakeURvpInitPreMem ( > /// >=20 > /// Install Stall PPI >=20 > /// >=20 > - Status =3D InstallStallPpi(); >=20 > - ASSERT_EFI_ERROR(Status); >=20 > + Status =3D InstallStallPpi (); >=20 > + ASSERT_EFI_ERROR (Status); >=20 >=20 >=20 > // >=20 > // Install PCH RESET PPI and EFI RESET2 PeiService >=20 > // >=20 > - Status =3D PchInitializeReset(); >=20 > - ASSERT_EFI_ERROR(Status); >=20 > + Status =3D PchInitializeReset (); >=20 > + ASSERT_EFI_ERROR (Status); >=20 >=20 >=20 > /// >=20 > /// Performing PlatformInitPreMemCallBack after PeiReadOnlyVariable2 > PPI produced >=20 > /// >=20 > - Status =3D PeiServicesNotifyPpi(&mPreMemNotifyList); >=20 > + Status =3D PeiServicesNotifyPpi (&mPreMemNotifyList); >=20 >=20 >=20 > /// >=20 > /// After code reorangized, memorycallback will run because the PPI is > already >=20 > /// installed when code run to here, it is supposed that the > InstallEfiMemory is >=20 > /// done before. >=20 > /// >=20 > - Status =3D PeiServicesNotifyPpi(&mMemDiscoveredNotifyList); >=20 > + Status =3D PeiServicesNotifyPpi (&mMemDiscoveredNotifyList); >=20 >=20 >=20 > return EFI_SUCCESS; >=20 > } >=20 > @@ -561,5 +560,3 @@ WhiskeylakeURvpBoardBootModeDetect ( > { >=20 > return BOOT_WITH_FULL_CONFIGURATION; >=20 > } >=20 > - >=20 > - >=20 > -- > 2.23.0.windows.1