From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web12.3265.1574404337670427860 for ; Thu, 21 Nov 2019 22:32:17 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=aZFd52Gp; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: michael.a.kubacki@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2019 22:32:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,228,1571727600"; d="scan'208";a="201406212" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga008.jf.intel.com with ESMTP; 21 Nov 2019 22:32:15 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 21 Nov 2019 22:32:16 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 21 Nov 2019 22:32:16 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 21 Nov 2019 22:32:16 -0800 Received: from NAM05-DM3-obe.outbound.protection.outlook.com (104.47.49.51) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 21 Nov 2019 22:32:15 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AE2xqJgnsOspuqeVHOzI+Kui6uo/yBmuojFWuHtMIoJrgZCyA2x7n2XkQwR3aFN9qVXzhGeJrNN0hDjDyFR6rFZpaAjO9WUBHgDS8pSzedF7USMjv7RJWcJF+v65CkpoXS9+0G3E7d7BPVNTghMdWJbA7470GlornzdiSMrW8GjUqdOOMsad6Ssujcl3tQm4jfU7YFOUwE67kXMLkq/GLYUxFStT/gQoPS+NXQTwlXeIlwWX+FjRajPEiGi12G8ViAAvSztMqRzaadVf6KZhxIO57rUQ83PlDVDNFDz7jzkBzW12iK31DSXpC8Je4tudvRvjQDxEfXx+5R0p9v6EJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SORrHDUrXzfJx5zZl/p4Q7nsLL5/w396cW+urXJsEq8=; b=mhdEl4TkdnoLSTWA6F+rlfJIJoOoZ/w4jN+ybpWKKUSEyTfL0BDSsSoA2FRn5Vnzqnyyd2VcReLGWJcXEKj0zvVyem2MqgidhmdJM+no8enzXSDWu1FrxlbE1RnJKhaMXgbv+4YTZi/5d7Yaumt5klQIuRogtC4RDy8QhDKUSmWTSEeB74ofwCoe9G8p17IRckSYAwJA9ci1gHssI0AvcuZvrMk92c2JAUtGz9ZD2EkM5nHFDM4IXnUn35VIpMb07b3DVcxS3AZCgB3ie+5ppkGr07s5EKNid6nAiC4S37RVkljorGoKIhvZooIgPUvxzK4AxhEstpycfyv1pjbt0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SORrHDUrXzfJx5zZl/p4Q7nsLL5/w396cW+urXJsEq8=; b=aZFd52GpAgmPgg7EBCdOf9T3sjfclNn4AsjpZp476fGSWnlcsDdi0T8Njupbhj1zwHiimzn+hU5xo93/im5pUl4eZ/A4lMhzv3DsxIxCXyVvjP2VwozttZPZ0yE5rTXzKRnPHbFRyGjiVWbXgw/uBkGUucZi2MpMsWgt57yeDQY= Received: from BY5PR11MB4484.namprd11.prod.outlook.com (52.132.254.155) by BY5PR11MB4053.namprd11.prod.outlook.com (10.255.72.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.19; Fri, 22 Nov 2019 06:32:03 +0000 Received: from BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::a114:604b:7ca3:5420]) by BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::a114:604b:7ca3:5420%7]) with mapi id 15.20.2474.019; Fri, 22 Nov 2019 06:32:03 +0000 From: "Kubacki, Michael A" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Chaganty, Rangasai V" Subject: Re: [edk2-platforms] [PATCH V2 03/14] KabylakeSiliconPkg: Cleanup old comments Thread-Topic: [edk2-platforms] [PATCH V2 03/14] KabylakeSiliconPkg: Cleanup old comments Thread-Index: AQHVoEoKmMX8yEZ40kSHKVZ8/qPIUqeWt44g Date: Fri, 22 Nov 2019 06:32:03 +0000 Message-ID: References: <20191121085853.2626-1-nathaniel.l.desimone@intel.com> <20191121085853.2626-4-nathaniel.l.desimone@intel.com> In-Reply-To: <20191121085853.2626-4-nathaniel.l.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODg2OTQ5NWItOGMxZi00MmUzLWE4NmYtZjNmM2NlODYwOTJiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUFBxbTVnaEJkMTdQamg3d1pmbTJTNFJnNGZ1OVRCQ2VhWXJXaFYwXC9oN2ZHVTdQUTdnVmpLcEdQTyt6SnU4SUQifQ== dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4520157b-2dce-43ab-ab6d-08d76f15b02a x-ms-traffictypediagnostic: BY5PR11MB4053: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:439; x-forefront-prvs: 02296943FF x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(376002)(346002)(136003)(396003)(39860400002)(199004)(189003)(13464003)(71200400001)(71190400001)(14454004)(25786009)(2501003)(52536014)(33656002)(508600001)(5660300002)(54906003)(186003)(7696005)(55016002)(4326008)(6246003)(316002)(99286004)(110136005)(6436002)(66066001)(102836004)(9686003)(6506007)(86362001)(6116002)(76116006)(7736002)(76176011)(3846002)(26005)(229853002)(81156014)(446003)(81166006)(66476007)(8676002)(8936002)(107886003)(256004)(11346002)(66946007)(305945005)(74316002)(66446008)(64756008)(53546011)(66556008)(2906002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY5PR11MB4053;H:BY5PR11MB4484.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fxfHvhqLbFKt1xP/2T0pHiU8sc4uNQeiArWv4CSTv1GG1uHgqc9E/vGFHnjZcx14tinMQ0vO9bRBIz45LXwMJGCD9QzaoCqJvwTqhRGCIcTUEIFRlr2TS4eBsyqVkfRGeh0F0wenA5GzilqFBXR8ZPEdNKfysD0DyjfLsNfzhvdDtDuhz+rsEwVpkSwGS5oU/fOqxVhd7lldLhN1qP0v5pmcwdfRxFLj+cDt6O1lhLGHO1LWe5oU0wWS7mVFr36D7n6BXvP5viWjj8WqSXTbEHKJlM7yuDTraIGIf+HqEqleWMsT4iSO0MISgsxZft66ioJsSJhB7eajvF8kwXJC4KAxQUtBlvDk5VHSpNqvpqDhbUBPJo2eRSyT4S3aA2ILaJAykLVd1ZV5u2W2eWBbtr/UqRok16IlQTOlWkgUQ4IjLwjUKp9eCYJSExGhlv1d MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 4520157b-2dce-43ab-ab6d-08d76f15b02a X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2019 06:32:03.5198 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Jv0O11Ec3sV5/z1zgqGpA6bSvQhOldGlHCZFCTmfTzu92MOLIjqhchksocw2Z6jyGdw3YpN5y0IHHmbpzHsNlUmuRnRYDCh97JXAYebdhoM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4053 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The copyright year should be updated in SiliconInit.c With that change: Reviewed-by: Michael Kubacki > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Thursday, November 21, 2019 12:59 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Chaganty, Rangasai V > > Subject: [edk2-platforms] [PATCH V2 03/14] KabylakeSiliconPkg: Cleanup ol= d > comments >=20 > Cc: Chasel Chiu > Cc: Michael Kubacki > Cc: Sai Chaganty > Signed-off-by: Nate DeSimone > --- > .../Library/PeiSiliconInitLib/SiliconInit.c | 3 +++ > .../Library/PeiSiliconInitLib/SiliconInitPreMem.c | 4 +--- > 2 files changed, 4 insertions(+), 3 deletions(-) >=20 > diff --git > a/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInit.= c > b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInit.= c > index d09bec0489..2057973d4b 100644 > --- a/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconI= nit.c > +++ b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/Silicon > +++ Init.c > @@ -199,6 +199,9 @@ ClearIchSmiAndWake ( > return EFI_SUCCESS; } +/**+ Late Silicon Initialization+**/ VOID > LateSiliconInit ( VOIDdiff --git > a/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitP= reMe > m.c > b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitP= reMe > m.c > index 65a67a6795..6af9e0fcfc 100644 > --- > a/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitP= reMe > m.c > +++ b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/Silicon > +++ InitPreMem.c > @@ -31,9 +31,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > #include - > //@todo it should be moved to Si Pkg. /**- Early Platform PCH initializa= tion+ > Early Silicon initialization **/ VOID EarlySiliconInit (@@ -233,4 +232,3 = @@ > SiliconInit ( > } }--- > 2.24.0.windows.2