From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web09.1204.1573087782396406911 for ; Wed, 06 Nov 2019 16:49:42 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=ZmE6CguI; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: michael.a.kubacki@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2019 16:49:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,276,1569308400"; d="scan'208";a="214433173" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by orsmga002.jf.intel.com with ESMTP; 06 Nov 2019 16:49:41 -0800 Received: from orsmsx163.amr.corp.intel.com (10.22.240.88) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 Nov 2019 16:49:41 -0800 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX163.amr.corp.intel.com (10.22.240.88) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 Nov 2019 16:49:41 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.51) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 Nov 2019 16:49:41 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W8wdl8f0T3Jte96CQbt+gJWYUYGpg9v7NtY0twaw71plwzRHdiGQ3ERCitOs6LLEMMNPJZTqChUiGXWupyfTA2GuzdmPqE3x/a/EceX8F355xP//HfyajtyNSVLwAsSLBYuWpd3XiFH9GAuKtaDWTRAy9swICTTh0JFJeet6i/1Abk59fSLFzac5knYODDg4uIKKSVrPXAQ3BXlitht/Vziu+2sAmT0z/OL47BxILNwpCI/k+v4BWhWx7snYRtDRXTVFz3RK/fMHGSX4BE/JnEBDGbf8Y1XALX/qjpcOOFHFbxn4WyUpWHYppB8NnPW6Z0jlSH/fBFkjej9BsgL5sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gkIw/f3ff8t/tCk8Nq5JbmnkZhiNUbQbwQeIg/3liPo=; b=nw+YsYMtjr14WdLFfbwxRzolFUvx/xqNJPxQl7wfgQ/y098nTjcbO1lxdInMq6M8MLixs/LZJq9TGVTo6S3gTy9OpNjPNvVljG19fT0rxKcnH+eDsuuW3bwPLECRlTqRmyYNafuHF8KtxtUYNXspTVaig6mz4p8Tv1M92ydwVqGijOBt8JIZF+Yag49ePHeId66mTohtF+/5iKSdTT4x41sbIKRu4RJRhYznz6gWTuxWmb0R+1umZCR99mC7lf0E75/YV3Yz0Sdl/yenPuRF6C5/M7Wkqu+Ix6eSyUakZpXhaDcKoVan4IkZTw8Ei34JkHykSmKPFpD9vPI/orYojg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gkIw/f3ff8t/tCk8Nq5JbmnkZhiNUbQbwQeIg/3liPo=; b=ZmE6CguI0zqlAwLSqy1C2Yx3ewryuuADPHuZplaKaLCV+eBE4FKcVw8LVNiI1dGLn4FcCFKN8ELn6k3VBHYzI+KB5JVl5Dbhs56suCvsxzXfIpDAiEusD7a9ItwZVCTK0BRBoqOwsO+8sAQPoQ9VP/PtOARwf7mA48kPRqGWJnU= Received: from BY5PR11MB4484.namprd11.prod.outlook.com (52.132.254.155) by BY5PR11MB3976.namprd11.prod.outlook.com (10.255.160.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.24; Thu, 7 Nov 2019 00:49:39 +0000 Received: from BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::c1ef:6e0b:90c8:55e2]) by BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::c1ef:6e0b:90c8:55e2%7]) with mapi id 15.20.2430.020; Thu, 7 Nov 2019 00:49:39 +0000 From: "Kubacki, Michael A" To: "Agyeman, Prince" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" Subject: Re: [edk2-platforms] [Patch v2 4/9] BoardModulePkg: Add fix at build Pcds Thread-Topic: [edk2-platforms] [Patch v2 4/9] BoardModulePkg: Add fix at build Pcds Thread-Index: AQHVlEE5HKaUxFb4iEaSgAhza+Nu56d+22Cw Date: Thu, 7 Nov 2019 00:49:39 +0000 Message-ID: References: <20191106012603.4724-1-prince.agyeman@intel.com> <20191106012603.4724-5-prince.agyeman@intel.com> In-Reply-To: <20191106012603.4724-5-prince.agyeman@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjNkZGQ5YjQtZTUzYS00ZjJkLWE3MTktN2MxMGQzZjgwMTAxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZFhveEQ4NjBRcGdjRTZTa3Z4ajhRWWVaaktUYlwvb3VkOVRBTlRXQndZXC9vUzhpXC9XeFdpcFkzZnhOa3pQenRoTyJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 065ee48a-6125-477f-b87d-08d7631c5ec3 x-ms-traffictypediagnostic: BY5PR11MB3976: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-forefront-prvs: 0214EB3F68 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39860400002)(136003)(376002)(396003)(346002)(366004)(13464003)(199004)(189003)(486006)(11346002)(6436002)(305945005)(66066001)(55016002)(6246003)(2501003)(14454004)(2906002)(4326008)(86362001)(6116002)(3846002)(33656002)(110136005)(7736002)(71190400001)(478600001)(25786009)(99286004)(446003)(8676002)(107886003)(52536014)(81166006)(81156014)(8936002)(54906003)(9686003)(316002)(256004)(66946007)(53546011)(66446008)(6506007)(64756008)(26005)(66556008)(7696005)(74316002)(76176011)(102836004)(476003)(186003)(71200400001)(66476007)(76116006)(229853002)(5660300002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY5PR11MB3976;H:BY5PR11MB4484.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zJag1TReg1TFGAUBLZTFN0Nvi+hAwx6Xezk6rKN7D0/SUnWDa0eWYnccRD6ZkIxFpiQIx0y+oC8ZhZpPcK0qqgmApGrk5r5lVwlMJ0th+xq3p0Pyt4tyaTo6+q+Qw/B2J2KcgU1j+QP9axps7gEC8jZ9QagyuT4TCdCNmhh3lqqD1iaJdIvcXpLUup3YY/j9Nu4lXumNfReyC4HmnVbEJUUPXzmYtCgRdJr2T1VdtNURV7Vpfkp6K7s2Ex6j7LIm6KBcue941SBLLNrO9E+eH168+5CV7NZ5M10AEg+DPT9+7bpN4pf8vWJUkfhTiwnZCCt6rkC5Az9JM3AfZimH5Ti7fbMNBqBDZ1vcCSlvaOfwVCWDqzghrZcjiOCR4JYmW1UT8u2jqecGT5Ci37AzS5LJRwKG3RlNf7DbYzWgDsXWm1cD5yIEa2OifvKKgdEa MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 065ee48a-6125-477f-b87d-08d7631c5ec3 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Nov 2019 00:49:39.5154 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NKTC9Zh/WkRrYDi61HjJeN0zpNR1PveGEpidX+TAAuGB0RyoShqhNzGIhC1R41aofE5hYVGEDXGtKCyejuKLLu98kW4aK7vw2cI8wnrrAqw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB3976 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Michael Kubacki > -----Original Message----- > From: Agyeman, Prince > Sent: Tuesday, November 5, 2019 5:26 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject: [edk2-platforms] [Patch v2 4/9] BoardModulePkg: Add fix at build > Pcds >=20 > * Added ps2 keyboard and Uart enable PCDs. > * Added PCDs to define IO ports for Uart1 and Uart2 >=20 > Cc: Michael Kubacki > Cc: Chasel Chiu > Cc: Nate DeSimone >=20 > Signed-off-by: Prince Agyeman > --- > .../Intel/BoardModulePkg/BoardModulePkg.dec | 21 > +++++++++++++++++++ > 1 file changed, 21 insertions(+) >=20 > diff --git a/Platform/Intel/BoardModulePkg/BoardModulePkg.dec > b/Platform/Intel/BoardModulePkg/BoardModulePkg.dec > index 8a811602e6..26e662f711 100644 > --- a/Platform/Intel/BoardModulePkg/BoardModulePkg.dec > +++ b/Platform/Intel/BoardModulePkg/BoardModulePkg.dec > @@ -46,3 +46,24 @@ > ## {7F4EE1A3-C1F3-43E4-BA1A-39DCDE46C343} > gBoardModulePkgTokenSpaceGuid =3D { 0x7f4ee1a3, 0xc1f3, 0x43e4, { 0xba= , > 0x1a, 0x39, 0xdc, 0xde, 0x46, 0xc3, 0x43 } } >=20 > +[PcdsFixedAtBuild] > + ## PcdPs2KbMsEnable 0x0:Disable, 0x1:Enable > + > gBoardModulePkgTokenSpaceGuid.PcdPs2KbMsEnable|0x00|UINT8|0x0000 > 0001 > + > + ## SuperIo Pci ISA Bridge info. It is an array that contains the > + Segment, Bus, Device and Function # information describing the PCI > + Device Info. The first byte is the segment number, # the second is > + the bus number, third byte is the device number, the fourth byte # is= the > Function. > + gBoardModulePkgTokenSpaceGuid.PcdSuperIoPciIsaBridgeDevice|{0xFF, > + 0xFF, 0xFF, 0xFF}|VOID*|0x00000002 > + > + ## PcdUart1Enable 0x0:Disable, 0x1:Enable > + > gBoardModulePkgTokenSpaceGuid.PcdUart1Enable|0x00|UINT8|0x0000000 > 3 > + > + > gBoardModulePkgTokenSpaceGuid.PcdUart1IrqMask|0x0010|UINT16|0x000 > 00004 > + > gBoardModulePkgTokenSpaceGuid.PcdUart1IoPort|0x03F8|UINT16|0x0000 > 0005 > + > gBoardModulePkgTokenSpaceGuid.PcdUart1Length|0x08|UINT8|0x0000000 > 6 > + > + ## PcdUart2Enable 0x0:Disable, 0x1:Enable > + > gBoardModulePkgTokenSpaceGuid.PcdUart2Enable|0x00|UINT8|0x0000000 > 7 > + > + > gBoardModulePkgTokenSpaceGuid.PcdUart2IrqMask|0x0008|UINT16|0x000 > 00008 > + > gBoardModulePkgTokenSpaceGuid.PcdUart2IoPort|0x02F8|UINT16|0x0000 > 0009 > + > gBoardModulePkgTokenSpaceGuid.PcdUart2Length|0x08|UINT8|0x0000000 > A > -- > 2.19.1.windows.1