From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.10266.1576174426600828289 for ; Thu, 12 Dec 2019 10:13:46 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=ni12EROP; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: michael.a.kubacki@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Dec 2019 10:13:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,306,1571727600"; d="scan'208";a="388400487" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga005.jf.intel.com with ESMTP; 12 Dec 2019 10:13:45 -0800 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 12 Dec 2019 10:13:45 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 12 Dec 2019 10:13:45 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 12 Dec 2019 10:13:45 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XhQYama9EDjMztbEWJrP5tkvcueIQCA3C3MF2iI4Z+Db5Gld9nRJxIJ1JUnUmDbUjzlFI06UfebAfwOPptVzZA2nDx5Ce1OAgUBIAM7jnOvmABYP6atRSvcjN6KB+htQZVOmMeHmGQWdPKOOf499hbkGZXGPxL5ejiISMhUS5OsOqG6b7ngXZAPO4ehduTdAs7uTsRGWYUz9IH2QQBEodU2Tp1U5zejiWVOWmDhUZDimhtAcF2L/1rLCrXcR0LLg1OMIGGTN6xNLxEN7dVGOPaA9CzYCTol2Cb/RzxRJ9emhBgcZ2OwKvoAhOwhir9VmpFg4s792S215NKEjuQPlTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dFxCNqwM7X61UnItYO2qh+BqeZKcLgEUKCmXZA3QqU4=; b=RvqvJ18D8sMY81U5U9rCt1JPSnA3baLjm0BzbJfBxbYbQZ/bgN4vPcgtKBcW/YnkbZ9LagfxYOZ/See5bqMGZWXYtimpem6Gel0rttdqlibWU2TFH9BVXV4m5mdk58n/jw+SjMB7LGxEIzwM6pK6L6xhRemNdim9+V9JaUe59TRK7g4USf8CBHKxygyLkEs2VknIVkdcUiSJRpkjyY1aIWap14eBQ194N941KN1ciLgSVOzDqO5nrPOBMOQ574r95ccrpBw2NdfssqZEwFcTUigensfzEx5jDu/wg6aSWmBs6hKS+Rd2mPSNJ0UoLN0VAJSfInIBD/gHQv+ReJ0EYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dFxCNqwM7X61UnItYO2qh+BqeZKcLgEUKCmXZA3QqU4=; b=ni12EROPejkD16qbIqSDLKNJMKzlunZGNfgHP0Rxd3a7+i5Ip61UFBbiJ7naw6aD1HIYJK/e6AxGV2vIk2bJ6BoQA78A2463ad6u0GeB+s3fgXYKvmITpgHO7XktMcfk52JWGUtQTydNgu/ktGGH3+Kw2ngbyCgrtOmR/lcSedE= Received: from BY5PR11MB4484.namprd11.prod.outlook.com (52.132.254.155) by BY5PR11MB4195.namprd11.prod.outlook.com (52.132.253.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2516.14; Thu, 12 Dec 2019 18:13:43 +0000 Received: from BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::a114:604b:7ca3:5420]) by BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::a114:604b:7ca3:5420%7]) with mapi id 15.20.2516.018; Thu, 12 Dec 2019 18:13:43 +0000 From: "Kubacki, Michael A" To: "Agyeman, Prince" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" Subject: Re: [edk2-platforms] [PATCH] WhiskeylakeOpenBoardPkg: Update PCDs to enable stack sharing Thread-Topic: [edk2-platforms] [PATCH] WhiskeylakeOpenBoardPkg: Update PCDs to enable stack sharing Thread-Index: AQHVsIlk6G//kguZxkKBaIT8BGCq86e2znTw Date: Thu, 12 Dec 2019 18:13:43 +0000 Message-ID: References: <20191212011314.6860-1-prince.agyeman@intel.com> In-Reply-To: <20191212011314.6860-1-prince.agyeman@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjhmMTk1MWItZWZmYy00YTFmLTk0NTctZmQ1MGVhNWZlYjVjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQXYxWm1Zdm8xRFdjWjN3RWNlY2NEMFwvVys3QkxhRXFCMWNHNWFZYVk2YWNka1pcL0t2QXhpNW9rQmZcL1MyUW1sZSJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3c09cc90-ca0d-46b1-9a2d-08d77f2f0611 x-ms-traffictypediagnostic: BY5PR11MB4195: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-forefront-prvs: 0249EFCB0B x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(136003)(376002)(39860400002)(396003)(346002)(199004)(189003)(13464003)(66476007)(186003)(4326008)(81156014)(55016002)(71200400001)(26005)(66556008)(66946007)(81166006)(5660300002)(8936002)(66446008)(64756008)(15650500001)(76116006)(52536014)(6506007)(7696005)(110136005)(107886003)(316002)(54906003)(86362001)(53546011)(966005)(8676002)(9686003)(33656002)(478600001)(2906002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY5PR11MB4195;H:BY5PR11MB4484.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mTPB0D5VW20yQXaEVovZoCDF9ltLzxmEEk5EmLlDQ2j4SvJWya5/qLNDytgCBUpo9nk/0PB785gZ9DNFegF3znIsQDtKLIt6u8U0ZdP/2/3odxDyopn83VVEvBtL4kNWHIK7pPX1hf/u47TgTG4iHMAfXT62tccLGZ9vvIZKnB/L93tkxH/kXUeoLfBW4u3Zey8cIxtFbLirJUSUeylMst1mAdhf92g2FtWGeyJ2uFxGXoHcqXEoh0Th++S30B3cHjLhOykDOfANA7vBoX/bphGpKogp3Njr6DPNgymhCLc+orrk1uYfZyAPrRQ8KLVwK1svgiQJG0885ytAdRhMKDytN57BLcxcSpdrRzDb7pW4MYKLHnQGc2JCcFnxUGl2CJkJA2DZ4TqdMNqvL6OG1MB7oaUDEnaORHf+SzYbiPqL1CRjRaODXDT4aqF7fdfwBz2taTECSU84gUOjVBXOLH9AtxM+kaMQZCAIu0svpSlaEBYRXF6NZt68De7fKZ65 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 3c09cc90-ca0d-46b1-9a2d-08d77f2f0611 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Dec 2019 18:13:43.6812 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: s3J0hmug5RJwEGWzcfqmOYbZAYPbJa2Hhe6tcyf9ZBs68YRVno2N0fM9Ldnuiix18pbEaNIs/VGaEwD0FSMxw3C6nJaG1lj3YRus/iYRsos= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4195 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Michael Kubacki > -----Original Message----- > From: Agyeman, Prince > Sent: Wednesday, December 11, 2019 5:13 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Kubacki, Michael A > > Subject: [edk2-platforms] [PATCH] WhiskeylakeOpenBoardPkg: Update PCDs > to enable stack sharing >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2409 >=20 > Updated WhiskeylakeURvp PCDs to enable FSP/BL stack sharing. > This fixes the boot failure seen with the latest Coffee Lake (CFL) FSP bi= nary (v > 7.0.68.41) >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Michael Kubacki >=20 > Signed-off-by: Prince Agyeman > --- > .../WhiskeylakeURvp/OpenBoardPkgPcd.dsc | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) >=20 > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > PkgPcd.dsc > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > PkgPcd.dsc > index 906f7b7ade..b3e1da3970 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > PkgPcd.dsc > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > Pk > +++ gPcd.dsc > @@ -54,15 +54,14 @@ > gSiPkgTokenSpaceGuid.PcdTsegSize|0x1000000 >=20 > # > - # FSP API mode does not share stack with the boot loader, > - # so FSP needs more temporary memory for FSP heap + stack size. > + # When sharing stack with boot loader, FSP only needs small temp ram > + for heap > # > - gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize|0x26000 > + gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize|0x10000 > + > # > - # FSP API mode does not need to enlarge the boot loader stack size > - # since the stacks are separate. > + # Boot loader stack size has to be big enough to executing FSP > # > - gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x20000 > + gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x40000 >=20 > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xE0000000 > gMinPlatformPkgTokenSpaceGuid.PcdPciExpressRegionLength|0x10000000 > -- > 2.19.1.windows.1