From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com []) by mx.groups.io with SMTP id smtpd.web09.3078.1576895796697402450 for ; Fri, 20 Dec 2019 18:36:38 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=bq9AHaR+; spf=fail (domain: intel.com, ip: , mailfrom: michael.a.kubacki@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Dec 2019 18:36:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,338,1571727600"; d="scan'208";a="248877308" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 20 Dec 2019 18:36:38 -0800 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 20 Dec 2019 18:36:37 -0800 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 20 Dec 2019 18:36:37 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 20 Dec 2019 18:36:37 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CaaZGq8KiWZGjxVDEmc3tQTX2u4qD2mOsZnxHF+uK66jS/rT+ywKswfPqlOIqgax+swAJrxGiNd2uLuHWp4Bw3X7f4eP81bKc3VS1bnQ8Dz/jy/az3gXd1Gc/VA0erz66aobWTy27LupN+6XWjazlT7y5XQ2KOiWYDVk+uavpN/G9TrEKwU4QuBCbRSK51axV9il3vZfpTMshsHxFy6P0uriJxV7jBdgH9q9nxr9WZ08fIj6hKnLpsIdqjbrsKPaeV75VWDxKRD4SVs/kCQPlV2AJUunIcamWwpph4pf5pIx//+zM421ad0S+tjr/GJnN4O/svBk4i+ZcfsBYtZSAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j2hepXC8Aiu2zBO5iPXdjwrbq1JipT37ecblXwmJteQ=; b=KWICMsQHD2YuTgeLTqF47UQkd87oH/mCAuf1EMt7TXU99fWy3hnZkxJS3EYQjYS5N64kGn85TA1ijkDGFWHteGNdUd3gdgKAZQhGtzQau9Srcv62t9BHFZr0a0252Ojbuf1ih2Yw9swLynkXI7wI56xGlsA/pSIkamrnU5oU99lrRkbFDkAXw/xb2QUZm1w4FkoWPNjpMq35GTPRSuWdWfOhoTwOcBwWxIaOBe94xNqLJpyai0uHL0M4c2KdXAnSe44RjHHPfsBaivVjW6yLmrvfRYXmrXEEKPNDWT6GIaE0+uaAY0J+02GR7LeiKJpoJaC98ITMonnlkWJosUrZxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j2hepXC8Aiu2zBO5iPXdjwrbq1JipT37ecblXwmJteQ=; b=bq9AHaR+JPu+uhEEjxoS3kzlkuF2gm1z5C1wQDA60HaAqnNAwvkncDNffTj6D8PwaA127a6omUbFs83EIdtbXtau3MLWLVQd4NJQsa5LbwYkt/WVrk3npbBEy3IB8I5+7htejer27K73LsF5u+qm5Wp9AC8hxwQhkhnZt+11gXI= Received: from BY5PR11MB4484.namprd11.prod.outlook.com (52.132.254.155) by BY5PR11MB4482.namprd11.prod.outlook.com (52.132.255.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2559.14; Sat, 21 Dec 2019 02:36:36 +0000 Received: from BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::bc80:2ec3:11ba:2f8a]) by BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::bc80:2ec3:11ba:2f8a%3]) with mapi id 15.20.2559.017; Sat, 21 Dec 2019 02:36:36 +0000 From: "Kubacki, Michael A" To: "Agyeman, Prince" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" Subject: Re: [edk2-platforms] [PATCH 04/11] MinPlatformPkg: Add BDS Board Boot Manager library Thread-Topic: [edk2-platforms] [PATCH 04/11] MinPlatformPkg: Add BDS Board Boot Manager library Thread-Index: AQHVsh5tvfM8K3iDskaHSFR4OmKSkafD52XQ Date: Sat, 21 Dec 2019 02:36:36 +0000 Message-ID: References: <1a09aca176f54fff55f69ad40935d01d7330350a.1576282834.git.prince.agyeman@intel.com> In-Reply-To: <1a09aca176f54fff55f69ad40935d01d7330350a.1576282834.git.prince.agyeman@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2M1YzFiZTItNzAxNy00MTFiLTg0Y2MtN2EwODRhMTJmZDc1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWXdlK2RYaHg3YW0xeUVjNXVqM3EwWjVyb2paRmQyMlNNTlN1NklzUUFYQW9tdUNLKzlWUUZFZitnNFBQSEVubSJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: adcc58ce-869a-46dc-4459-08d785be999f x-ms-traffictypediagnostic: BY5PR11MB4482: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0258E7CCD4 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(136003)(396003)(346002)(366004)(376002)(39860400002)(13464003)(189003)(199004)(8676002)(86362001)(55016002)(478600001)(316002)(33656002)(81156014)(53546011)(81166006)(54906003)(966005)(26005)(66476007)(66446008)(186003)(76116006)(66946007)(9686003)(64756008)(66556008)(6506007)(2906002)(5660300002)(4326008)(71200400001)(7696005)(107886003)(110136005)(8936002)(52536014);DIR:OUT;SFP:1102;SCL:1;SRVR:BY5PR11MB4482;H:BY5PR11MB4484.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5SjX/KMGUPH8LT37GhQRgIyyxXfQmiBoQa5CWIamilQC6UKdc9iphAVdU4pfgnNMbfB28tfT5weEqSYB376HLMsd2N0zwCsTOXaMt+KwLIv5dc3vb/Ouiz/1Ifu/3po0MGU0vakyrIwQSktJhmvEPh2r9mv71NtgMDJL2zVb+B0eUzEz2DpN4idh31wloC23hnZDze4Nj9QONOYMRP06rJFp5wFeQml3TZgBCgrEqp9LwXlo4aQjVOIIJCjE4flXnCzJzj+RBhIJtdjzzwKEpZFfzPiNPFRXB63iQ6ndQQsyOJApBtrod92DdgTz3cwv5Pa8f+0yF/luWe20u63TFMlfGqRayJXUa2/aI/gElyw1O3+6ti42ZjCRdfdYukfmoNtKqBLKJ/H1y7MJiflGW8cOC6hUXTJN773ZXCqWw2kld91LxfdmxzpIkXLlsJXgqcDSQdugto3I/+w4WFV4VjsetbTYND2E1gFgRVp6Xapi12RFztn4zPWkpeqRdypoNc3ZY8l2RQlCvpxhG2NiE/trP29TzR01b2h4h1ITGdo= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: adcc58ce-869a-46dc-4459-08d785be999f X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2019 02:36:36.1937 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iJGAQoYizVLxKuLpynZ1q3kTz47S7X7HgTEkKq+goMoIXhwBJrOAmAiq/mjZG01SbrAW1qsUvm2/g5whq4ZQVWRvjaGcgWrGnZ4GeRkUE+I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4482 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Since BoardBootManagerWaitCallback () is a new function, please add @param[= in] for the TimeoutRemain parameter. With that change - Reviewed-by: Michael Kubacki > -----Original Message----- > From: Agyeman, Prince > Sent: Friday, December 13, 2019 5:33 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject: [edk2-platforms] [PATCH 04/11] MinPlatformPkg: Add BDS Board > Boot Manager library >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2336 >=20 > As Minplatform's PlatformBootManager library instance implements event > signals (as specified in the minimum platform specification) to trigger b= oard > actions, some of its functions namely PlatformBootManagerWaitCallback and > PlatformBootManagerUnableToBoot will not have events signaled for boards > to take action. >=20 > This library implements PlatformBootManagerWaitCallback and > PlatformBootManagerUnableToBoot which will be linked to Minplatform's > PlatformBootManager libary instance. >=20 > Added is an interface/header file that defines the board boot manager > library. >=20 > Also added is a NULL implementation of the board boot manager library >=20 > Cc: Michael Kubacki > Cc: Chasel Chiu > Cc: Nate DeSimone >=20 > Signed-off-by: Prince Agyeman > --- > .../BoardBootManagerLib.c | 38 ++++++++++++++++++ > .../BoardBootManagerLibNull.inf | 31 +++++++++++++++ > .../Include/Library/BoardBootManagerLib.h | 39 +++++++++++++++++++ > 3 files changed, 108 insertions(+) > create mode 100644 > Platform/Intel/MinPlatformPkg/Bds/Library/BoardBootManagerLibNull/Boar > dBootManagerLib.c > create mode 100644 > Platform/Intel/MinPlatformPkg/Bds/Library/BoardBootManagerLibNull/Boar > dBootManagerLibNull.inf > create mode 100644 > Platform/Intel/MinPlatformPkg/Include/Library/BoardBootManagerLib.h >=20 > diff --git > a/Platform/Intel/MinPlatformPkg/Bds/Library/BoardBootManagerLibNull/Bo > ardBootManagerLib.c > b/Platform/Intel/MinPlatformPkg/Bds/Library/BoardBootManagerLibNull/Bo > ardBootManagerLib.c > new file mode 100644 > index 0000000000..46fce8f59f > --- /dev/null > +++ > b/Platform/Intel/MinPlatformPkg/Bds/Library/BoardBootManagerLibNull/ > +++ BoardBootManagerLib.c > @@ -0,0 +1,38 @@ > +/** @file > + This file include board specific boot manager callbacks > + > + Copyright (c) 2018, Intel Corporation. All rights reserved.
> + SPDX-License-Identifier: BSD-2-Clause-Patent **/ > + > +#include > + > +/** > + This function is called each second during the boot manager waits time= out. > + > + @param TimeoutRemain The remaining timeout. > +**/ > +VOID > +EFIAPI > +BoardBootManagerWaitCallback ( > + IN UINT16 TimeoutRemain > + ) > +{ > + return; > +} > + > +/** > + The function is called when no boot option could be launched, > + including platform recovery options and options pointing to > +applications > + built into firmware volumes. > + > +**/ > +VOID > +EFIAPI > +BoardBootManagerUnableToBoot ( > + VOID > + ) > +{ > + return; > +} > + > diff --git > a/Platform/Intel/MinPlatformPkg/Bds/Library/BoardBootManagerLibNull/Bo > ardBootManagerLibNull.inf > b/Platform/Intel/MinPlatformPkg/Bds/Library/BoardBootManagerLibNull/Bo > ardBootManagerLibNull.inf > new file mode 100644 > index 0000000000..084207b111 > --- /dev/null > +++ > b/Platform/Intel/MinPlatformPkg/Bds/Library/BoardBootManagerLibNull/ > +++ BoardBootManagerLibNull.inf > @@ -0,0 +1,31 @@ > +## @file > +# The module definition file for BoardBootManagerLib. > +# > +# Copyright (c) 2019, Intel Corporation. All rights reserved.
# > +SPDX-License-Identifier: BSD-2-Clause-Patent # ## > + > +[Defines] > + INF_VERSION =3D 0x00010005 > + BASE_NAME =3D BoardBootManagerLib > + FILE_GUID =3D 7BA684A4-5B32-4F0C-B0FF-581F143E606= C > + MODULE_TYPE =3D DXE_DRIVER > + VERSION_STRING =3D 1.0 > + LIBRARY_CLASS =3D BoardBootManagerLib|DXE_DRIVER > + > + > +# > +# The following information is for reference only and not required by th= e > build tools. > +# > +# VALID_ARCHITECTURES =3D IA32 X64 EBC > +# > + > +[Sources] > + BoardBootManagerLib.c > + > + > +[Packages] > + MdePkg/MdePkg.dec > + MdeModulePkg/MdeModulePkg.dec > + MinPlatformPkg/MinPlatformPkg.dec > diff --git > a/Platform/Intel/MinPlatformPkg/Include/Library/BoardBootManagerLib.h > b/Platform/Intel/MinPlatformPkg/Include/Library/BoardBootManagerLib.h > new file mode 100644 > index 0000000000..4240142073 > --- /dev/null > +++ > b/Platform/Intel/MinPlatformPkg/Include/Library/BoardBootManagerLib. > +++ h > @@ -0,0 +1,39 @@ > +/** @file > + Board Boot Manager library definition. A platform can implement > + instances to support platform-specific behavior. > + > + Copyright (c) 2019, Intel Corporation. All rights reserved.
> + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > + > +#ifndef __BOARD_BOOT_MANAGER_LIB_H_ > +#define __BOARD_BOOT_MANAGER_LIB_H_ > +#include > + > + > +/** > + This function is called each second during boot manager waits the time= out. > + > + @param TimeoutRemain The remaining timeout. > +**/ > +VOID > +EFIAPI > +BoardBootManagerWaitCallback ( > + IN UINT16 TimeoutRemain > + ); > + > +/** > + The function is called when no boot option could be launched, > + including platform recovery options and options pointing to > +applications > + built into firmware volumes. > + > +**/ > +VOID > +EFIAPI > +BoardBootManagerUnableToBoot ( > + VOID > + ); > + > +#endif > -- > 2.19.1.windows.1