From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web09.3232.1574404374518397508 for ; Thu, 21 Nov 2019 22:32:54 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=F0Fl764d; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: michael.a.kubacki@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2019 22:32:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,228,1571727600"; d="scan'208";a="210343247" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga006.jf.intel.com with ESMTP; 21 Nov 2019 22:32:53 -0800 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 21 Nov 2019 22:32:27 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 21 Nov 2019 22:32:26 -0800 Received: from NAM05-DM3-obe.outbound.protection.outlook.com (104.47.49.59) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 21 Nov 2019 22:32:26 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KPiY5aL9WkGn3qDDk5p1KeCWsDpAg3Ix2ZA10RTwm9tMv3gRhelZ6Wag/HrLdt2z/XpVFEuG1iYeJTjpItlZ69c+Nru9FQ9cAq3JmmvFDprnnMkyOy7g0ge02nDnqXHh7TJ+Dms2OB68NUXrU4Ny64b9YnheqkjdohlMk1aTlHUj4omiXDD/FKeJSJXzvK3+0B/dTWCAdFk2i6A55RZOHIrzuM+yvalPW0W64F4dCFn84cj/X4Oax7Oc95S9tkwH2E6QUT0AKrOBUlj0nslPG5jaBVToA+RsXGzWMhC5ORjdUvzzJK235X3Uj8c7Mqpp7DeQl6TC80OjY/cdgteyUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+FaVOvHzs1H9WHTjgEaH3STedWu7+g1/LuvJmKYKcKA=; b=ewOHQGoe9QKzp1903TRGp/r2aIkw7n4q+s/fvC9njiEXTrZOhCkno5xlwUDi5y2ISrIKDV/n1u1H428ud62/jtCnoLGFL5b+rbJshRYeWMkI/9nubqJ7CKMLlIulKhUqUZFzAt+aUzYHMFA3mBVsY8mjGDYu2f8iJbXERraoE4BwT9i5A5ARek9OBHR8nXird2zcitiT1LCYA97xPhTYUep1U0tmnwTRO2jJMzo7yKZdtjibaWf+310IsB09mQCwjnBQa0q3gaJEmw6WUUjVoVILDrS3O6GhMQ/qTjBiIrDf+tyIXunyHoTR4c06BEjRtS7Jq81rZsVG9gri44UQEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+FaVOvHzs1H9WHTjgEaH3STedWu7+g1/LuvJmKYKcKA=; b=F0Fl764deMgsIxBGxmiA2W+u9PJuGiMthZDV91mm/sS69lYQEJu9oh3LxP89iEDaXLlFd/+feztoRIYYXGMcjR0qmASjM8Ub7ObHcIFE2eCPuu87UUiwk0mP1b5zC9u94XDJWS7NUHJCeW5IkHE2sCdA+Pk74kxfdmdyaTqWgIg= Received: from BY5PR11MB4484.namprd11.prod.outlook.com (52.132.254.155) by BY5PR11MB4053.namprd11.prod.outlook.com (10.255.72.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.19; Fri, 22 Nov 2019 06:32:25 +0000 Received: from BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::a114:604b:7ca3:5420]) by BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::a114:604b:7ca3:5420%7]) with mapi id 15.20.2474.019; Fri, 22 Nov 2019 06:32:25 +0000 From: "Kubacki, Michael A" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Chiu, Chasel" Subject: Re: [edk2-platforms] [PATCH V2 07/14] WhiskeylakeOpenBoardPkg: Add SiliconInitLib APIs to BoardInitLib Thread-Topic: [edk2-platforms] [PATCH V2 07/14] WhiskeylakeOpenBoardPkg: Add SiliconInitLib APIs to BoardInitLib Thread-Index: AQHVoEoKL3hBownOfEakx/HZXsTB36eWt8CA Date: Fri, 22 Nov 2019 06:32:24 +0000 Message-ID: References: <20191121085853.2626-1-nathaniel.l.desimone@intel.com> <20191121085853.2626-8-nathaniel.l.desimone@intel.com> In-Reply-To: <20191121085853.2626-8-nathaniel.l.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjJiOTU3NDQtMWJkYS00MzgwLTlmMjItOGNhZDc0MDY3Y2Q1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiM3lyOHV6bWpDbWU0RkJFTGwyWXRoM1lZM24zSFFhWmFqNVwvVUpBcVVETldMRmoyTUVrM2JJbDVhanhWN2hzTEIifQ== dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ababe060-acf7-409f-5be8-08d76f15bcf1 x-ms-traffictypediagnostic: BY5PR11MB4053: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 02296943FF x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(376002)(346002)(136003)(396003)(39860400002)(199004)(189003)(13464003)(71200400001)(71190400001)(14454004)(25786009)(2501003)(52536014)(33656002)(508600001)(5660300002)(186003)(7696005)(55016002)(4326008)(6246003)(316002)(99286004)(110136005)(6436002)(66066001)(102836004)(9686003)(6506007)(86362001)(6116002)(76116006)(7736002)(76176011)(3846002)(26005)(229853002)(81156014)(446003)(81166006)(66476007)(8676002)(8936002)(107886003)(256004)(11346002)(66946007)(14444005)(305945005)(74316002)(66446008)(64756008)(53546011)(66556008)(2906002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY5PR11MB4053;H:BY5PR11MB4484.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LebFU0Xmw+0+RTeY52jFV1f6Yv1gOMp6FyzTxB2+Zm9naOSfqd2y734BPSytUEl0k/4dvldrK0M6xjzzwbv0oTTdOaUtxYreAz3xSZ7wDSIixRR/9UYQBPrsBiZ4pEG6XZefz7vUJ6U6UCZnSTliK2CgwNRgfJpG+WKmJupagth6y/t6lRWP3G0Ygay8K+bilH51gHMtMM0eE2P4N4J5AjRT8szIUB5bUGa5goi3VVUk2VEPvH5xHnI7C6JocC8KcXAeHSXGyu6QEMRnHNwzbLa49weR6Std+gzeVuRm41ZIQgtqQfCjabowxku1nWNrK77vHmn69wkirZXXkEP67/a6scB4AKYnD4/pK9y3Jmw+4UBg08Bdc3TNbCJjhYstJJXDQ8IMyZG10gpSFSIzi3lO7bySZoKdJXBG5AmdPMrAtJfmhPgs67swtdB4EzFK MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: ababe060-acf7-409f-5be8-08d76f15bcf1 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2019 06:32:25.0125 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5KCLlHOM2BTLnzw9CKiy4gGKhtXpq7n5WiwvfZlRa29gF49fkK14+2NWGbMpy57KCdNw6wl6KgVTeA7g7ryRgf+ZqdA3LbI2UPlEl+Ho9ZQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4053 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Michael Kubacki > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Thursday, November 21, 2019 12:59 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > > Subject: [edk2-platforms] [PATCH V2 07/14] WhiskeylakeOpenBoardPkg: > Add SiliconInitLib APIs to BoardInitLib >=20 > Cc: Chasel Chiu > Cc: Michael Kubacki > Signed-off-by: Nate DeSimone > --- > .../BoardInitLib/PeiBoardInitPostMemLib.inf | 1 + > .../BoardInitLib/PeiBoardInitPreMemLib.inf | 1 + > .../PeiMultiBoardInitPostMemLib.inf | 1 + > .../PeiMultiBoardInitPreMemLib.inf | 2 +- > .../PeiWhiskeylakeURvpInitPostMemLib.c | 6 +- > .../PeiWhiskeylakeURvpInitPreMemLib.c | 89 ++----------------- > .../BoardInitLib/WhiskeylakeURvpInit.h | 1 + > .../WhiskeylakeURvp/OpenBoardPkg.dsc | 5 ++ > 8 files changed, 24 insertions(+), 82 deletions(-) >=20 > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/PeiBoardInitPostMemLib.inf > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/PeiBoardInitPostMemLib.inf > index 9bf4d127c5..affc5c56ad 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/PeiBoardInitPostMemLib.inf > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/PeiBoardInitPostMemLib.inf > @@ -26,6 +26,7 @@ > HdaVerbTableLib >=20 > MemoryAllocationLib >=20 > PcdLib >=20 > + SiliconInitLib >=20 >=20 >=20 > [Packages] >=20 > MinPlatformPkg/MinPlatformPkg.dec >=20 > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/PeiBoardInitPreMemLib.inf > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/PeiBoardInitPreMemLib.inf > index 4ab80f9eb3..40e20285e0 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/PeiBoardInitPreMemLib.inf > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/PeiBoardInitPreMemLib.inf > @@ -23,6 +23,7 @@ > BaseMemoryLib >=20 > MemoryAllocationLib >=20 > PcdLib >=20 > + SiliconInitLib >=20 >=20 >=20 > [Packages] >=20 > MinPlatformPkg/MinPlatformPkg.dec >=20 > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/PeiMultiBoardInitPostMemLib.inf > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/PeiMultiBoardInitPostMemLib.inf > index c043e32638..21dc2f70c0 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/PeiMultiBoardInitPostMemLib.inf > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/PeiMultiBoardInitPostMemLib.inf > @@ -30,6 +30,7 @@ > PeiPlatformHookLib >=20 > PeiPolicyInitLib >=20 > PchInfoLib >=20 > + SiliconInitLib >=20 >=20 >=20 > [Packages] >=20 > MinPlatformPkg/MinPlatformPkg.dec >=20 > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/PeiMultiBoardInitPreMemLib.inf > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/PeiMultiBoardInitPreMemLib.inf > index cd0315377a..7389f1dfcd 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/PeiMultiBoardInitPreMemLib.inf > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/PeiMultiBoardInitPreMemLib.inf > @@ -31,6 +31,7 @@ > PeiPlatformHookLib >=20 > PeiPolicyInitLib >=20 > PlatformHookLib >=20 > + SiliconInitLib >=20 > StallPpiLib >=20 >=20 >=20 > [Packages] >=20 > @@ -57,7 +58,6 @@ >=20 >=20 > [Guids] >=20 > gPchGeneralPreMemConfigGuid ## CONSUMES >=20 > - gTcoWdtHobGuid ## CONSUMES >=20 >=20 >=20 > [Pcd] >=20 > gWhiskeylakeOpenBoardPkgTokenSpaceGuid.PcdLpcSioConfigDefaultPort >=20 > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/PeiWhiskeylakeURvpInitPostMemLib.c > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/PeiWhiskeylakeURvpInitPostMemLib.c > index 9413620a4a..248a6657d5 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/PeiWhiskeylakeURvpInitPostMemLib.c > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/PeiWhiskeylakeURvpInitPostMemLib.c > @@ -430,6 +430,10 @@ WhiskeylakeURvpBoardInitBeforeSiliconInit ( > // >=20 > Status =3D UpdateChipsetInitPtr(); >=20 >=20 >=20 > + /// >=20 > + /// Do Late PCH init >=20 > + /// >=20 > + LateSiliconInit (); >=20 > + >=20 > return EFI_SUCCESS; >=20 > } >=20 > - >=20 > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/PeiWhiskeylakeURvpInitPreMemLib.c > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/PeiWhiskeylakeURvpInitPreMemLib.c > index 0124888244..055d731651 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/PeiWhiskeylakeURvpInitPreMemLib.c > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/PeiWhiskeylakeURvpInitPreMemLib.c > @@ -45,7 +45,6 @@ > #include >=20 > #include >=20 > #include >=20 > -#include >=20 > #include >=20 >=20 >=20 > /// >=20 > @@ -232,50 +231,8 @@ BoardMiscInitPreMem( > return EFI_SUCCESS; >=20 > } >=20 >=20 >=20 > -//@todo it should be moved to Si Pkg. >=20 > -/** >=20 > -Early Platform PCH initialization >=20 > -**/ >=20 > -VOID >=20 > -EarlyPlatformPchInit( >=20 > - VOID >=20 > -) >=20 > -{ >=20 > - UINT8 Data8; >=20 > - UINT8 TcoRebootHappened; >=20 > - TCO_WDT_HOB *TcoWdtHobPtr; >=20 > - EFI_STATUS Status; >=20 > - >=20 > - /// >=20 > - /// Read the Second TO status bit >=20 > - /// >=20 > - Data8 =3D IoRead8(PcdGet16(PcdTcoBaseAddress) + R_TCO_IO_TCO2_STS); >=20 > - if ((Data8 & B_TCO_IO_TCO2_STS_SECOND_TO) =3D=3D > B_TCO_IO_TCO2_STS_SECOND_TO) { >=20 > - TcoRebootHappened =3D 1; >=20 > - DEBUG((DEBUG_INFO, "PlatformInitPreMem - TCO Second TO status bit is > set. This might be a TCO reboot\n")); >=20 > - } >=20 > - else { >=20 > - TcoRebootHappened =3D 0; >=20 > - } >=20 > - >=20 > - /// >=20 > - /// Create HOB >=20 > - /// >=20 > - Status =3D PeiServicesCreateHob(EFI_HOB_TYPE_GUID_EXTENSION, > sizeof(TCO_WDT_HOB), (VOID **)&TcoWdtHobPtr); >=20 > - if (!EFI_ERROR(Status)) { >=20 > - TcoWdtHobPtr->Header.Name =3D gTcoWdtHobGuid; >=20 > - TcoWdtHobPtr->TcoRebootHappened =3D TcoRebootHappened; >=20 > - } >=20 > - >=20 > - /// >=20 > - /// Clear the Second TO status bit >=20 > - /// >=20 > - IoWrite8(PcdGet16(PcdTcoBaseAddress) + R_TCO_IO_TCO2_STS, > B_TCO_IO_TCO2_STS_SECOND_TO); >=20 > -} >=20 > - >=20 > /** >=20 > Board configuration initialization in the pre-memory boot phase. >=20 > - >=20 > **/ >=20 > VOID >=20 > BoardConfigInitPreMem ( >=20 > @@ -341,7 +298,6 @@ PlatformInitPreMemCallBack( > ) >=20 > { >=20 > EFI_STATUS Status; >=20 > - UINT16 ABase; >=20 > UINT8 FwConfig; >=20 >=20 >=20 > // >=20 > @@ -378,16 +334,8 @@ PlatformInitPreMemCallBack( > /// >=20 > /// Configure GPIO and SIO >=20 > /// >=20 > - Status =3D BoardInitPreMem(); >=20 > - ASSERT_EFI_ERROR(Status); >=20 > - >=20 > - ABase =3D PmcGetAcpiBase(); >=20 > - >=20 > - /// >=20 > - /// Clear all pending SMI. On S3 clear power button enable so it will = not > generate an SMI. >=20 > - /// >=20 > - IoWrite16(ABase + R_ACPI_IO_PM1_EN, 0); >=20 > - IoWrite32(ABase + R_ACPI_IO_GPE0_EN_127_96, 0); >=20 > + Status =3D BoardInitPreMem (); >=20 > + ASSERT_EFI_ERROR (Status); >=20 >=20 >=20 > /// >=20 > /// Install Pre Memory PPIs >=20 > @@ -550,12 +498,6 @@ WhiskeylakeURvpInitPreMem ( > Status =3D InstallStallPpi(); >=20 > ASSERT_EFI_ERROR(Status); >=20 >=20 >=20 > - ///@todo it should be moved to Si Pkg. >=20 > - /// >=20 > - /// Do Early PCH init >=20 > - /// >=20 > - EarlyPlatformPchInit(); >=20 > - >=20 > // >=20 > // Install PCH RESET PPI and EFI RESET2 PeiService >=20 > // >=20 > @@ -588,6 +530,11 @@ WhiskeylakeURvpBoardInitBeforeMemoryInit ( > VOID >=20 > ) >=20 > { >=20 > + /// >=20 > + /// Do basic PCH init >=20 > + /// >=20 > + SiliconInit (); >=20 > + >=20 > WhiskeylakeURvpInitPreMem (); >=20 >=20 >=20 > return EFI_SUCCESS; >=20 > @@ -600,27 +547,9 @@ WhiskeylakeURvpBoardDebugInit ( > ) >=20 > { >=20 > /// >=20 > - /// LPC I/O Configuration >=20 > + /// Do Early PCH init >=20 > /// >=20 > - PchLpcIoDecodeRangesSet ( >=20 > - (V_LPC_CFG_IOD_LPT_378 << N_LPC_CFG_IOD_LPT) | >=20 > - (V_LPC_CFG_IOD_COMB_3E8 << N_LPC_CFG_IOD_COMB) | >=20 > - (V_LPC_CFG_IOD_COMA_3F8 << N_LPC_CFG_IOD_COMA) >=20 > - ); >=20 > - >=20 > - PchLpcIoEnableDecodingSet ( >=20 > - B_LPC_CFG_IOE_ME2 | >=20 > - B_LPC_CFG_IOE_SE | >=20 > - B_LPC_CFG_IOE_ME1 | >=20 > - B_LPC_CFG_IOE_KE | >=20 > - B_LPC_CFG_IOE_HGE | >=20 > - B_LPC_CFG_IOE_LGE | >=20 > - B_LPC_CFG_IOE_FDE | >=20 > - B_LPC_CFG_IOE_PPE | >=20 > - B_LPC_CFG_IOE_CBE | >=20 > - B_LPC_CFG_IOE_CAE >=20 > - ); >=20 > - >=20 > + EarlySiliconInit (); >=20 > return EFI_SUCCESS; >=20 > } >=20 >=20 >=20 > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/WhiskeylakeURvpInit.h > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/WhiskeylakeURvpInit.h > index 325bcb41df..d3a709b2a9 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/WhiskeylakeURvpInit.h > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Library/Boa > rdInitLib/WhiskeylakeURvpInit.h > @@ -15,6 +15,7 @@ > #include >=20 > #include >=20 > #include >=20 > +#include >=20 > #include >=20 > #include >=20 >=20 >=20 > diff --git > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > Pkg.dsc > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > Pkg.dsc > index cdaf47b6f7..3cd0478021 100644 > --- > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > Pkg.dsc > +++ > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > Pkg.dsc > @@ -154,6 +154,11 @@ >=20 > TimerLib|$(PLATFORM_BOARD_PACKAGE)/Library/AcpiTimerLib/BaseAcpiTi > merLib.inf >=20 >=20 >=20 > [LibraryClasses.common.PEIM] >=20 > + ####################################### >=20 > + # Silicon Initialization Package >=20 > + ####################################### >=20 > + > SiliconInitLib|$(PLATFORM_SI_PACKAGE)/Library/PeiSiliconInitLib/PeiSilico= nI > nitLib.inf >=20 > + >=20 > ####################################### >=20 > # Platform Package >=20 > ####################################### >=20 > -- > 2.24.0.windows.2