From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web09.3088.1576895837724761218 for ; Fri, 20 Dec 2019 18:37:17 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=cj6P9glA; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: michael.a.kubacki@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Dec 2019 18:37:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,338,1571727600"; d="scan'208";a="222607883" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 20 Dec 2019 18:37:17 -0800 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 20 Dec 2019 18:37:16 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 20 Dec 2019 18:37:16 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 20 Dec 2019 18:37:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iaoAJYck1POdKUNBRcaeJzw6L75Y7oxSwn6JvlMB+B0NRl/EkY2zSnCwX9IeeOReO9WlOoZN4Y/BcVwGsQbC7ZxxfFqBGKSZp4/2ZFYmWXdA+sToe17oajgjmp86LrSqdMpYKhZGUr37sPNt1XORgW+Y7/7VqeUH5bCjEW+xbdv9D0JHjfX9798lQ/n1D8hQ9y+zs+HQxgwyTneTvebIrl+zhmRTmDrhuNj7HmiO8cNTafA0w+nU38n2N96KxUY+wKr5RGHzAHoH5d2KZTgkTyQ0C20/ER9cNY0JNHiOzpkDpfHVKulx8xZt55Dez2YIQtkODZJici4F94F6HSJ3rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tmbsnH/45SeQ6dMT16a7OHKxv0SPHB4MJ87Ah5hp+XQ=; b=lyrEsYRG1PsjMF7fSG4RSkS6st27fKngy5sqgNZZd1ZqTxZo5aT0oyNZePGp7luWGJVdsRQfiaRZ5nFfLyjDvF6pbOSQK9Yqu5wStykVbrRVJwTp0zZcZvBBSc/Xf+KYoRe74eAsG+h4bclv7sNjgvvN0Hz619YhdR6zJgHGaQ+Re4PSjgbR1qPzXEp3+3jA4p49F/qaTNM3bZkJRoNG6c+aJOjBR5mmimqZ3Xr5EJE5TkYidXDo7n8XXXAy0dgqmSAAuNRaHbltNVB0609WcxHlj1KAHUV6nBDszHKAQqC5kvvmBcOyEkm0u00NatZFdZALeCBnmlTb03e/CFLbWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tmbsnH/45SeQ6dMT16a7OHKxv0SPHB4MJ87Ah5hp+XQ=; b=cj6P9glAGBfQpM5kC/aNnRfR2zjKt4HSBh4rUMpVLHxpW2B4fZuQD5HqrAE/hJPCt1SYEV4EYbnabBhzvGhvVd262iLn82IqXIsO4EIUbDQc6aSFaRQ2UV4D5e6HC44i36dn+kcSXZ4c+cGdOgMB1/xKvegKgxCQKRrVnxcBzVQ= Received: from BY5PR11MB4484.namprd11.prod.outlook.com (52.132.254.155) by BY5PR11MB4482.namprd11.prod.outlook.com (52.132.255.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2559.14; Sat, 21 Dec 2019 02:37:07 +0000 Received: from BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::bc80:2ec3:11ba:2f8a]) by BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::bc80:2ec3:11ba:2f8a%3]) with mapi id 15.20.2559.017; Sat, 21 Dec 2019 02:37:07 +0000 From: "Kubacki, Michael A" To: "Agyeman, Prince" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" Subject: Re: [edk2-platforms] [PATCH 10/11] SimicsOpenBoardPkg: Add BDS Board Boot Manager library Thread-Topic: [edk2-platforms] [PATCH 10/11] SimicsOpenBoardPkg: Add BDS Board Boot Manager library Thread-Index: AQHVsh5zw0gkhli930OOh0p+ox9jK6fD552g Date: Sat, 21 Dec 2019 02:37:07 +0000 Message-ID: References: <6c40c7b6ebde73fcaa110be9ff55de3e58f7bb47.1576282834.git.prince.agyeman@intel.com> In-Reply-To: <6c40c7b6ebde73fcaa110be9ff55de3e58f7bb47.1576282834.git.prince.agyeman@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODY0ZjgwMTgtNDM2NC00NmM0LWE1YTItMDNjYTk3ZGI0N2U0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWHZMTlFGK2F3Z3BJSmJZUk9FMWdYUWVHRitXNTVRcEszVnQ1Y1FvUzFYckZKbzM5MkdneDBoYWUrdHJIRGFWbiJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ec6fe77d-38d9-4601-4dff-08d785beac73 x-ms-traffictypediagnostic: BY5PR11MB4482: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 0258E7CCD4 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(136003)(396003)(346002)(366004)(376002)(39860400002)(13464003)(189003)(199004)(8676002)(86362001)(55016002)(478600001)(316002)(33656002)(81156014)(53546011)(81166006)(966005)(26005)(66476007)(66446008)(186003)(76116006)(66946007)(9686003)(64756008)(66556008)(6506007)(2906002)(5660300002)(4326008)(71200400001)(7696005)(107886003)(110136005)(8936002)(52536014);DIR:OUT;SFP:1102;SCL:1;SRVR:BY5PR11MB4482;H:BY5PR11MB4484.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Sq/jNe0Vc4Z6qRNyaO5AFlwqsUGcPWV1DokGHLC4Rgeq1bkiV2SFwT/3BFujRkynGaJoz4sQ3LRMYAF2gB3q8RNqx1EPqf0mFJR86BdFJn0IFM5BWymB4ymAAkhUBwLBTqGLNi0Z/cEKcTqVp5NKD/y/vhZ3snK9E6fRDykkFtd0d04xbUyzsyO3jm58pUM6Ib4U393hiQg/L6XNHOjl/JTa8h5XUXmxkFPxGq9bjZrGzcB1/X47xxl1jwF5I6Zkyil66nEquUCl1Ev+OzacW2bna0/7UgHXRJpOakuMgi4pzeQSn0bZg7+5+isP59e5fg7zYtUTzP64tDL/y7A/aLnyr1GvOIpZ2gZJESz5Ybv+v8AHMk8HDVTBTMxuHhfIV3y/UT84N7Ut3fEDBO8TuHenhOUigt71/4GVYwL/qI8UVrtJthXQRBlOmTRDgWswSmMnVsurrvpUvorx6cClqWuwW+mJjYtWFkFmn7cBaPxQgYawUHsPGGQZ8ysMAs1lI5JBRKWss3xptFUXoHZfMPhItOelLztv2Ph0gHbmb5M= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: ec6fe77d-38d9-4601-4dff-08d785beac73 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2019 02:37:07.7634 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 23uADx42jhQ9QpVzoYKYlJfBjdSB2LfdOpj1V7RR7618eGg+x9OdSf+MM5GvMCOGnp7npElqfzV0dPFBiG5FB2DjKNGsJfx4pA9jP0ZPzoY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4482 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Michael Kubacki > -----Original Message----- > From: Agyeman, Prince > Sent: Friday, December 13, 2019 5:33 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Kubacki, > Michael A > Subject: [edk2-platforms] [PATCH 10/11] SimicsOpenBoardPkg: Add BDS > Board Boot Manager library >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2336 >=20 > This library implements PlatformBootManagerWaitCallback and > PlatformBootManagerUnableToBoot which can be linked Minplatform's > PlatformBootManager libary instance. >=20 > Cc: Nate DeSimone > Cc: Michael Kubacki >=20 > Signed-off-by: Prince Agyeman > --- > .../BoardBootManagerLib/BoardBootManager.c | 67 > +++++++++++++++++++ > .../BoardBootManagerLib.inf | 45 +++++++++++++ > 2 files changed, 112 insertions(+) > create mode 100644 > Platform/Intel/SimicsOpenBoardPkg/Library/BoardBootManagerLib/BoardBo > otManager.c > create mode 100644 > Platform/Intel/SimicsOpenBoardPkg/Library/BoardBootManagerLib/BoardBo > otManagerLib.inf >=20 > diff --git > a/Platform/Intel/SimicsOpenBoardPkg/Library/BoardBootManagerLib/Board > BootManager.c > b/Platform/Intel/SimicsOpenBoardPkg/Library/BoardBootManagerLib/Board > BootManager.c > new file mode 100644 > index 0000000000..58035f2766 > --- /dev/null > +++ > b/Platform/Intel/SimicsOpenBoardPkg/Library/BoardBootManagerLib/Boar > +++ dBootManager.c > @@ -0,0 +1,67 @@ > +/** @file > + The Board Boot Manager Library implements > +BoardBootManagerWaitCallback > + and BoardBootManagerUnableToBoot callback, which is linked to the > + Platform Boot Manager Library > + > + Copyright (c) 2019 Intel Corporation. All rights reserved.
> + > + SPDX-License-Identifier: BSD-2-Clause-Patent **/ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +/** > + This function is called each second during the boot manager waits the > + timeout. > + > + @param TimeoutRemain The remaining timeout. > +**/ > +VOID > +EFIAPI > +BoardBootManagerWaitCallback ( > + UINT16 TimeoutRemain > + ) > +{ > + EFI_GRAPHICS_OUTPUT_BLT_PIXEL_UNION Black; > + EFI_GRAPHICS_OUTPUT_BLT_PIXEL_UNION White; > + UINT16 Timeout; > + > + Timeout =3D PcdGet16 (PcdPlatformBootTimeOut); > + > + Black.Raw =3D 0x00000000; > + White.Raw =3D 0x00FFFFFF; > + > + BootLogoUpdateProgress ( > + White.Pixel, > + Black.Pixel, > + L"Start boot option", > + White.Pixel, > + (Timeout - TimeoutRemain) * 100 / Timeout, > + 0 > + ); > +} > + > +/** > + The function is called when no boot option could be launched, > + including platform recovery options and options pointing to > +applications > + built into firmware volumes. > + > + If this function returns, BDS attempts to enter an infinite loop. > +**/ > +VOID > +EFIAPI > +BoardBootManagerUnableToBoot ( > + VOID > + ) > +{ > + > +} > diff --git > a/Platform/Intel/SimicsOpenBoardPkg/Library/BoardBootManagerLib/Board > BootManagerLib.inf > b/Platform/Intel/SimicsOpenBoardPkg/Library/BoardBootManagerLib/Board > BootManagerLib.inf > new file mode 100644 > index 0000000000..20778981bc > --- /dev/null > +++ > b/Platform/Intel/SimicsOpenBoardPkg/Library/BoardBootManagerLib/Boar > +++ dBootManagerLib.inf > @@ -0,0 +1,45 @@ > +## @file > +# Definition file for the Board Boot Manager Library. > +# > +# Copyright (c) 2019 Intel Corporation. All rights reserved.
# # > +SPDX-License-Identifier: BSD-2-Clause-Patent # ## > + > +[Defines] > + INF_VERSION =3D 0x00010005 > + BASE_NAME =3D BoardBootManagerLib > + FILE_GUID =3D EBBB176A-3883-4BA4-A74D-1510D0C35B3= 7 > + MODULE_TYPE =3D DXE_DRIVER > + VERSION_STRING =3D 1.0 > + LIBRARY_CLASS =3D BoardBootManagerLib|DXE_DRIVER > + > +# > +# The following information is for reference only and not required by th= e > build tools. > +# > +# VALID_ARCHITECTURES =3D IA32 X64 EBC > +# > + > +[Sources] > + BoardBootManager.c > + > +[Packages] > + MdePkg/MdePkg.dec > + MdeModulePkg/MdeModulePkg.dec > + MinPlatformPkg/MinPlatformPkg.dec > + > +[LibraryClasses] > + BaseLib > + UefiBootServicesTableLib > + DebugLib > + UefiLib > + HobLib > + UefiBootManagerLib > + TimerLib > + BoardBootManagerLib > + BootLogoLib > + PcdLib > + > +[Pcd] > + gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut > -- > 2.19.1.windows.1