From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web09.9760.1576517711445659434 for ; Mon, 16 Dec 2019 09:35:11 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=ixmuiYc2; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: michael.a.kubacki@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Dec 2019 09:35:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,322,1571727600"; d="scan'208";a="205183966" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by orsmga007.jf.intel.com with ESMTP; 16 Dec 2019 09:35:10 -0800 Received: from orsmsx162.amr.corp.intel.com (10.22.240.85) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 16 Dec 2019 09:35:10 -0800 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX162.amr.corp.intel.com (10.22.240.85) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 16 Dec 2019 09:35:10 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.108) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 16 Dec 2019 09:35:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YfxgANQDhSNU+kWlWWLoQiWXMV+TgGQgmpjhw0EP5E8IM7lJTudk2ZCG4hha8bvGU6VWF0jtCW6xBl1JPVq1TOoruvxCu1BkNjNy3oNb/gKd/vhtWLR1o3HJ2d3vcRlSXhjzjBp5/HS+WcbxnidVKMll/2ZjvTJ/CEeVhf8ANbzjMVMHlOO1xiVrQApHvVlU7W5vMjYs/BEZU6ZtfaYnrNuREWjrqt1RMEmCvTa3igAgkOxd6igY/mNszSluqBUl7YzlVs3CpR/jnGaMBtrFB1Hzi2oyXbSTd7ECcEjR4wZJ+d6JH41cuLkLpKf8g10LDZQ2ns0lqNRlU34QZYLlDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OZN7X59eDZrPlZYG1fvzfdh2gC6yT2GmCHCXBdWgmW0=; b=W3HCmMzx/HPfz6ZiKB8gyOylnA58nq4Wi8eCgKPhECOjDRyRkL/iADAfZfaVpitj0dMGYQSHUwHepg44GoVbRVWv87oTDLR1eaIBn/ioYUeWhz027cu5l8sO4e7CmAxmq+zUQa04wnPWOqvmXt2lqsfeNFSUadkY35L4nx+prv5P/M3cgz8l4iwmQKyNlNAsbsC0CaWjU6vt5lcQmYk66T6x8gh2/2EhoWAJx3bFe2/6neePuxxcLE+kCaN9sNPr3tomtzik/jDU0BU5RdHLHOuJ6UyOiuocpbq7+YsXLtjEuyDL+9ZfVc64NvnREx4mOG3/TNEQ+s98M5TNqjhDLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OZN7X59eDZrPlZYG1fvzfdh2gC6yT2GmCHCXBdWgmW0=; b=ixmuiYc2pcbStfipaTYBsUYfh1Y1dzi/h4oED0eCLtSRBT/AriYcStXOK1gRutclSGa/K8au8EhzCUU1y2u/NzExIf4gcvwyobJK4y5bNab3AAeGgs8W38CvEaJI0SCIp4vY/dpKHZ9cpZ1bgd4GJN8xdzy0VUjUhXayif8HeEs= Received: from BY5PR11MB4484.namprd11.prod.outlook.com (52.132.254.155) by BY5PR11MB3880.namprd11.prod.outlook.com (10.255.160.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.14; Mon, 16 Dec 2019 17:35:07 +0000 Received: from BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::a114:604b:7ca3:5420]) by BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::a114:604b:7ca3:5420%7]) with mapi id 15.20.2538.019; Mon, 16 Dec 2019 17:35:07 +0000 From: "Kubacki, Michael A" To: "Chiu, Chasel" , "Agyeman, Prince" , "Desimone, Nathaniel L" CC: "devel@edk2.groups.io" Subject: Re: [edk2-platforms] [PATCH v2] WhiskeylakeOpenBoardPkg: Update PCDs to enable stack sharing Thread-Topic: [edk2-platforms] [PATCH v2] WhiskeylakeOpenBoardPkg: Update PCDs to enable stack sharing Thread-Index: AQHVsh3tGCEE8uYcm0O70/e69ZJWZKe77FgAgAEbnMA= Date: Mon, 16 Dec 2019 17:35:06 +0000 Message-ID: References: <8d09f32eda0d6e8fdc40c7be6e8472323db4c1c5.1576286588.git.prince.agyeman@intel.com> <3C3EFB470A303B4AB093197B6777CCEC505CA6B9@PGSMSX111.gar.corp.intel.com> In-Reply-To: <3C3EFB470A303B4AB093197B6777CCEC505CA6B9@PGSMSX111.gar.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGQ3NWVhZWYtZTI2My00MTMzLWFhNGYtZTFjOWI3ODkxYjY1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRys0RzNHVTYwUW1tUUh4ME5ERlJCNEd5bXlyQmo3TWZaMEdkeklkSjFFU0RBTTNJVkFjYWNxVHFiUkxQZFd4cSJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f832b06c-4bca-4aec-35c5-08d7824e4ada x-ms-traffictypediagnostic: BY5PR11MB3880: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 02530BD3AA x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(39860400002)(366004)(396003)(346002)(136003)(199004)(189003)(13464003)(478600001)(52536014)(55016002)(6636002)(81156014)(81166006)(86362001)(316002)(8676002)(966005)(33656002)(64756008)(66446008)(66946007)(110136005)(9686003)(15650500001)(66556008)(2906002)(66476007)(53546011)(71200400001)(186003)(6506007)(76116006)(26005)(7696005)(5660300002)(4326008)(8936002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY5PR11MB3880;H:BY5PR11MB4484.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: trewrWsUxiIhyKZLNBp4h5dtm95A9j8Yage7AmHY/BVB4l+ispW0R2nHXokDq/dZ6nNUXrJ9IMogFatJU2om5+cnIVQNYwkuMAsz/Ej593SOA1CI7SlC2YXe0GPvgc595AxN5WLWINGEMNlKH2fBEkpk015pr/jJ3sJutm5yun+rkNR48DmDlO6le0lgiCy0veRvytGvdjlya6XfewxKUAjrFv1/Mt1TOD107ZEG49iqp0xLa9/Dy/qyXbmqMJu/o5Mo9+pKoqsRHO/ymTqweU4M44glXcNuy8KgflGHR1cmXR3+ngfcJ/g/PpEjX0eNWMCWer2KUMpRN7TJtjmYxxissqTvJfd+SV7ZdLV9Bg7k4Yxthf7GZAQL+OPnNiIwyJ4gf99XN3/VlNnHak7y7TblXpEPu+zTp3ExygwvOmcuR9QXt9qDrrvpwyHd9CMYyQtIV1mKzbUEGS1KXkUGlcFyesCYPUKIY1MHiwj9a5imKf/eRZMCelUExxAyd6DFJKxjrNcFPH2zElQIyg+icmlSss6ukc2MHGS2inqzNEs= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f832b06c-4bca-4aec-35c5-08d7824e4ada X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2019 17:35:06.8850 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nu9t8dTEI32gi6W+tjRknWDIyVFLT2DcNSYP5VCY6LYOSAgcbbkYOgv2CfgK7s16dA8CPy3FNAD1k8NrnJBns9dV/Xto+WHh3C2GMal4FUU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB3880 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I agree with Chasel. There should be enough T-RAM available to expand this = to 0x30000 without a problem and reduce potential thrash in the future. Thanks, Michael > -----Original Message----- > From: Chiu, Chasel > Sent: Sunday, December 15, 2019 4:32 PM > To: Agyeman, Prince ; Desimone, Nathaniel L > > Cc: Kubacki, Michael A ; > devel@edk2.groups.io > Subject: RE: [edk2-platforms] [PATCH v2] WhiskeylakeOpenBoardPkg: > Update PCDs to enable stack sharing >=20 >=20 > Hi Nate, Prince, >=20 > I would recommend that we set larger > gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize so we do not have to > update this again and again later when required temporary ram increased b= y > enabling some boot loader features. > How about set it to 0x30000? >=20 > Thanks, > Chasel >=20 > > -----Original Message----- > > From: Agyeman, Prince > > Sent: Saturday, December 14, 2019 9:29 AM > > To: devel@edk2.groups.io > > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > ; Kubacki, Michael A > > > > Subject: [edk2-platforms] [PATCH v2] WhiskeylakeOpenBoardPkg: Update > > PCDs to enable stack sharing > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2409 > > > > Updated WhiskeylakeURvp PCDs to enable FSP/BL stack sharing. > > This fixes the boot failure seen with the latest Coffee Lake (CFL) FSP > > binary (v > > 7.0.68.41) > > > > Cc: Chasel Chiu > > Cc: Nate DeSimone > > Cc: Michael Kubacki > > > > Signed-off-by: Prince Agyeman > > --- > > .../WhiskeylakeURvp/OpenBoardPkgPcd.dsc | 11 > > +++++------ > > 1 file changed, 5 insertions(+), 6 deletions(-) > > > > diff --git > > > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > P > > kgPcd.dsc > > > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > P > > kgPcd.dsc > > index 906f7b7ade..cfe42883be 100644 > > --- > > > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > P > > kgPcd.dsc > > +++ > > > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > P > > k > > +++ gPcd.dsc > > @@ -54,15 +54,14 @@ > > gSiPkgTokenSpaceGuid.PcdTsegSize|0x1000000 > > > > # > > - # FSP API mode does not share stack with the boot loader, > > - # so FSP needs more temporary memory for FSP heap + stack size. > > + # When sharing stack with boot loader, FSP only needs small temp > > + ram for heap > > # > > - gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize|0x26000 > > + gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize|0x10000 > > + > > # > > - # FSP API mode does not need to enlarge the boot loader stack size > > - # since the stacks are separate. > > + # Boot loader stack size has to be big enough to executing FSP > > # > > - gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x20000 > > + gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x28000 > > > > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xE0000000 > > > > > gMinPlatformPkgTokenSpaceGuid.PcdPciExpressRegionLength|0x10000000 > > -- > > 2.19.1.windows.1 >=20