From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.538.1574901089943187905 for ; Wed, 27 Nov 2019 16:31:30 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=YJyI+qxx; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: michael.a.kubacki@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Nov 2019 16:31:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,251,1571727600"; d="scan'208";a="203258321" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga008.jf.intel.com with ESMTP; 27 Nov 2019 16:31:29 -0800 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 27 Nov 2019 16:31:28 -0800 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 27 Nov 2019 16:31:28 -0800 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.57) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 27 Nov 2019 16:31:28 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kX8EGkso1j2nXSwZ8rYw2bLuErzdycnVKEN6syHAPNn0mmkJ+jWensJlF3SPwmk6mOVGkge6JFo0JkvFx8WleLf8ouQIiPK5nwUZ2FPAS+hhuH2Kyk45PcZPACGBkwigxi54KT+IIJyUdu3rgIg0sQq9CbodIxFSbTZYcrh6gS1zoJBZ7MzEInX8c3ZVJCy7myjYrWeVovmbcLWASWlwGMHXSZxMYCMIWqjTFlGvJzGpBwr+SgcQ+PoipTovHLSKeetF7WJXhonPBnlgtuqqXLbPvGELapCuUhObAnaGAn74hqZnvI/aD8LSzA6JsadLd/ZTRsuvHK8V9zuw7UkRug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WJFr117+E0KqwiiFcEXShoaatZL1Rz2kbXrzGoUEB4I=; b=oKcH53V4gBTL7yDN7So7VznElzv71SNrFrkHqnJrE9uzWC6IUuR8YRn0ITMHXEoJqWnwVIlhMVQmRw8WOuJZAT8u+oYkmUXUZBHWsP+6bSNx0Kz6FueWnLYdNmxrZRUNGGjMbaGF+R5UaehOGPiULNXaJaqI5gg/+PDfyP3cV6ka8JC93lCRaxAervr2VLNSz8gSH2wDfB6tGTPpSIteYtv/elfCXbN0sPQsLPvlkpGyr68u295Sj6Gz0gj5Y6uWCjk21qLe2zj05AZM7AelpD1MKdAhwpGYhv8Lutu0OFxWRDI/gC98W+nKMg/xMIRFpeJte5fI4stKJRyFLNgYbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WJFr117+E0KqwiiFcEXShoaatZL1Rz2kbXrzGoUEB4I=; b=YJyI+qxxDjFXlOowBIRZdCMGZny2f5hPE0ytpWOf4veJfefsrZ2kZBe+/UVCXRu8/rkYJTefCPMPMuLKiDz01Y6a8JovxWqsQ0SSK77CKHmGdQayrUtCdE47MutXVijdmSV3FsmHOEbkkqQ/O+TsjYlWDx+tMn07F2Z3Yu89ogQ= Received: from BY5PR11MB4484.namprd11.prod.outlook.com (52.132.254.155) by BY5PR11MB3957.namprd11.prod.outlook.com (10.255.72.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2495.20; Thu, 28 Nov 2019 00:31:27 +0000 Received: from BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::a114:604b:7ca3:5420]) by BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::a114:604b:7ca3:5420%7]) with mapi id 15.20.2474.023; Thu, 28 Nov 2019 00:31:27 +0000 From: "Kubacki, Michael A" To: "Chaganty, Rangasai V" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "Gao, Zhichao" Subject: Re: [edk2-platforms][PATCH V1 1/2] KabylakeSiliconPkg: Remove ResetSystemLib.h override Thread-Topic: [edk2-platforms][PATCH V1 1/2] KabylakeSiliconPkg: Remove ResetSystemLib.h override Thread-Index: AQHVpO3YpMrzX5i5tkG2OXdegGw2ZKefTdZggABtTAA= Date: Thu, 28 Nov 2019 00:31:26 +0000 Message-ID: References: <20191127025643.32056-1-michael.a.kubacki@intel.com> <20191127025643.32056-2-michael.a.kubacki@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmQ0NzRhYzYtY2RjYi00ODZkLWJlOWYtNGFmZGVhNWJiM2U3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVnVpM293MUNZV29IS0Zld1dcL0I0cnJWS0czSHdcLzliTjkzMmxpSDNpYVBYbzlaSmVEY1JqWm1aYjdCVkIrXC9BVCJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0527ddc4-ece8-42e6-b5e9-08d7739a4e3f x-ms-traffictypediagnostic: BY5PR11MB3957: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0235CBE7D0 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(136003)(346002)(376002)(366004)(396003)(39860400002)(85664002)(13464003)(189003)(199004)(53546011)(76176011)(6506007)(7696005)(102836004)(11346002)(446003)(186003)(26005)(54906003)(110136005)(33656002)(316002)(99286004)(71190400001)(71200400001)(86362001)(19627235002)(256004)(14444005)(55016002)(6306002)(9686003)(6436002)(14454004)(229853002)(6246003)(6116002)(3846002)(2906002)(8936002)(8676002)(81156014)(81166006)(107886003)(4326008)(478600001)(64756008)(74316002)(305945005)(7736002)(30864003)(5660300002)(25786009)(66556008)(66446008)(66476007)(76116006)(66946007)(52536014)(2501003)(66066001);DIR:OUT;SFP:1102;SCL:1;SRVR:BY5PR11MB3957;H:BY5PR11MB4484.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GKKufkpezKetfRmS0IvxU5jj6S/FMldqaBQMRPWnI2GSm38WYxXPoAZUqkFJVRrgfyJRWiR6S4DvrArldQj8C0WxOzdzlZNK93kZ3P5AlADQ+YBUQgWyhQTKDbyMkfU24FvEn2evm9N8H4a0+5YBW7qezxfXFsCHjo6MpgiCPUEH2GYj+F+Dao6s22GGtev+IBwhbNgDAzNT/hy+O2GuHUka905ddpWIk9siny50VYJciMjajAXWEUU1O2jJ/dUYzSF3UCzN0K0VnDgzweOTUS3Xdh06mNc9fmNIX8S9qjIq13QaxvGMxl5yM1cqoiseiBPLTLy7tXEUK5VIJzCYaaIUVl9BeWeCbblOMs1k4Upbvug2Vd1eh5UVnKi3Kofys4hXVZs1/1jKDqEHWKyM/RLBfmvo5Xl3Eb3HQC9SHZju9jaBGnqfLYMlJRgOR3p2ChAJepR+ImPu08YCW/3WaL0R+oorx3ehhZs8AuDdAOM= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 0527ddc4-ece8-42e6-b5e9-08d7739a4e3f X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Nov 2019 00:31:26.9661 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: De1oT2/KdTAv81hSsfdTtcsnmF8BNGztQ8pKnGQdy4MwVNNjSGkktWZhrs7Zy5IqidnhkXuFlTD+mHMaESW/ARIM4mhW6aKWN5vEBMhtAXM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB3957 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Sai, I'd like to fix the VS2017 build failure asap. What would you like done to = resolve this? I would prefer to eliminate the local ResetSystemLib.h file in KabylakeSili= conPkg but I'd be happy to revise the patch series based on your suggestion= . Thanks, Michael > -----Original Message----- > From: Kubacki, Michael A > Sent: Wednesday, November 27, 2019 10:42 AM > To: Chaganty, Rangasai V ; > devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Gao, Zhichao > Subject: RE: [edk2-platforms][PATCH V1 1/2] KabylakeSiliconPkg: Remove > ResetSystemLib.h override >=20 > This dependency existed prior to this change (and still does exist). It w= as > obfuscated in such a way that contributed to this problem. >=20 > See the previous library header path: >=20 > \Silicon\Intel\KabylakeSiliconPkg\SampleCode\MdeModulePkg\Include\Libr > ary\ResetSystemLib.h >=20 > The fact KabylakeSiliconPkg implements a MdeModulePkg library API > introduces the dependency on MdeModulePkg. Hiding a redundant > definition of the API locally does not eliminate the dependency in any > meaningful way. >=20 > I think the practice of "freezing" an API with a local copy only works if= the > codebase is locked onto a specific stable tag in which the upstream API i= s not > expected to change. Zhichao rightfully added the new function definition = to > the KabylakeSiliconPkg library class implementation because a board packa= ge > consumer would expect a ResetSystemLib library class instance to be > compliant with the API defined in MdeModulePkg and link the ResetSystem > () function. The only problem was a set of circumstances that led to the > duplicate symbol definition for ResetSystem () with PchResetLib. >=20 > So I view the task of eliminating the package dependency as a larger sepa= rate > effort outside the scope of this change. But I do not agree with maintain= ing > redundant local copies of edk2 APIs in packages in edk2-platforms. >=20 > Thanks, > Michael >=20 > > -----Original Message----- > > From: Chaganty, Rangasai V > > Sent: Tuesday, November 26, 2019 10:43 PM > > To: Kubacki, Michael A ; > > devel@edk2.groups.io > > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > ; Gao, Zhichao > > > Subject: RE: [edk2-platforms][PATCH V1 1/2] KabylakeSiliconPkg: Remove > > ResetSystemLib.h override > > > > This change is introducing SiliconPkg's dependency on MdeModulePkg. > > SiliconPkg dependencies should be limited to a selected few packages > > and this seems to be an unnecessary addition to the dependency list. > > The reset interfaces are providing generic reset services and perhaps > > better suited in packages like MdePkg. > > > > -----Original Message----- > > From: Kubacki, Michael A > > Sent: Tuesday, November 26, 2019 6:57 PM > > To: devel@edk2.groups.io > > Cc: Chaganty, Rangasai V ; Chiu, Chasel > > ; Desimone, Nathaniel L > > ; Gao, Zhichao > > > Subject: [edk2-platforms][PATCH V1 1/2] KabylakeSiliconPkg: Remove > > ResetSystemLib.h override > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2375 > > > > Removes a stale ResetSystemLib.h override in KabylakeSiliconPkg that > > does not contain the prototype for ResetSystem () and > ResetPlatformSpecific (). > > > > The ResetSystemLib.h file from MdeModulePkg will be used. Any INF > > files that did not include the MdeModulePkg.dec under [Packages] were > > updated to do so. > > > > Cc: Sai Chaganty > > Cc: Chasel Chiu > > Cc: Nate DeSimone > > Cc: Zhichao Gao > > Signed-off-by: Michael Kubacki > > --- > > > > > Silicon/Intel/KabylakeSiliconPkg/Pch/Library/DxeResetSystemLib/DxeResetS > > ystemLib.inf | 3 +- > > > > Silicon/Intel/KabylakeSiliconPkg/Pch/Library/DxeRuntimeResetSystemLib/ > > Dx > > eRuntimeResetSystemLib.inf | 3 +- > > > > > Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiPchResetLib/PeiPchResetLi= b. > > inf | 3 +- > > > > > Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiResetSystemLib/PeiResetSy= s > > temLib.inf | 3 +- > > > > > Silicon/Intel/KabylakeSiliconPkg/SampleCode/MdeModulePkg/Include/Libra > > ry/ResetSystemLib.h | 62 -------------------- > > 5 files changed, 8 insertions(+), 66 deletions(-) > > > > diff --git > > a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/DxeResetSystemLib/DxeRe > > se > > tSystemLib.inf > > b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/DxeResetSystemLib/DxeRe > > se > > tSystemLib.inf > > index aa8877140a..46313bf35f 100644 > > --- > > a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/DxeResetSystemLib/DxeRe > > se > > tSystemLib.inf > > +++ b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/DxeResetSystemLib/D > > +++ xe > > +++ ResetSystemLib.inf > > @@ -1,7 +1,7 @@ > > ## @file > > # Component description file for Intel Ich7 Reset System Library. > > # > > -# Copyright (c) 2017, Intel Corporation. All rights reserved.
> > +# Copyright (c) 2017 - 2019, Intel Corporation. All rights > > +reserved.
> > # > > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -35,6 +35,7 @@ > > PchCycleDecodingLib > > > > [Packages] > > MdePkg/MdePkg.dec > > +MdeModulePkg/MdeModulePkg.dec > > KabylakeSiliconPkg/SiPkg.dec > > > > > > diff --git > > a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/DxeRuntimeResetSystemLi > > b/ > > DxeRuntimeResetSystemLib.inf > > b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/DxeRuntimeResetSystemLi > > b/ > > DxeRuntimeResetSystemLib.inf > > index 6b27661603..c7fad31c71 100644 > > --- > > a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/DxeRuntimeResetSystemLi > > b/ > > DxeRuntimeResetSystemLib.inf > > +++ > > b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/DxeRuntimeResetSystem > > +++ Lib/DxeRuntimeResetSystemLib.inf > > @@ -1,7 +1,7 @@ > > ## @file > > # Component description file for Intel Ich7 Reset System Library. > > # > > -# Copyright (c) 2017, Intel Corporation. All rights reserved.
> > +# Copyright (c) 2017 - 2019, Intel Corporation. All rights > > +reserved.
> > # > > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -36,6 +36,7 @@ > > PchCycleDecodingLib > > > > [Packages] > > MdePkg/MdePkg.dec > > +MdeModulePkg/MdeModulePkg.dec > > KabylakeSiliconPkg/SiPkg.dec > > > > > > diff --git > > a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiPchResetLib/PeiPchRe > > setL > > ib.inf > > b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiPchResetLib/PeiPchRe > > setL > > ib.inf > > index b04f4006ef..29f69078a4 100644 > > --- > > a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiPchResetLib/PeiPchRe > > setL > > ib.inf > > +++ b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiPchResetLib/PeiP > > +++ ch > > +++ ResetLib.inf > > @@ -1,7 +1,7 @@ > > ## @file > > # Component description file for PCH Reset Lib Pei Phase # -# > > Copyright (c) 2017, Intel Corporation. All rights reserved.
> > +# Copyright (c) 2017 - 2019, Intel Corporation. All rights > > +reserved.
> > # > > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -28,6 +28,7 @@ > > ResetSystemLib > > > > [Packages] > > MdePkg/MdePkg.dec > > +MdeModulePkg/MdeModulePkg.dec > > KabylakeSiliconPkg/SiPkg.dec > > > > [Sources] > > diff --git > > a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiResetSystemLib/PeiRe > > setS > > ystemLib.inf > > b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiResetSystemLib/PeiRe > > set > > SystemLib.inf > > index 18a92a6f18..3c6ff78863 100644 > > --- > > a/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiResetSystemLib/PeiRe > > setS > > ystemLib.inf > > +++ b/Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiResetSystemLib/P > > +++ ei > > +++ ResetSystemLib.inf > > @@ -1,7 +1,7 @@ > > ## @file > > # Component description file for Intel Ich7 Reset System Library. > > # > > -# Copyright (c) 2017, Intel Corporation. All rights reserved.
> > +# Copyright (c) 2017 - 2019, Intel Corporation. All rights > > +reserved.
> > # > > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -32,6 +32,7 @@ > > PchCycleDecodingLib > > > > [Packages] > > MdePkg/MdePkg.dec > > +MdeModulePkg/MdeModulePkg.dec > > KabylakeSiliconPkg/SiPkg.dec > > > > > > diff --git > > > a/Silicon/Intel/KabylakeSiliconPkg/SampleCode/MdeModulePkg/Include/Lib > > rary/ResetSystemLib.h > > > b/Silicon/Intel/KabylakeSiliconPkg/SampleCode/MdeModulePkg/Include/Lib > > rary/ResetSystemLib.h > > deleted file mode 100644 > > index 75d3e15ed7..0000000000 > > --- > > > a/Silicon/Intel/KabylakeSiliconPkg/SampleCode/MdeModulePkg/Include/Lib > > rary/ResetSystemLib.h > > +++ /dev/null > > @@ -1,62 +0,0 @@ > > -/** @file > > - System reset Library Services. This library class defines a set of > > - methods that reset the whole system. > > - > > -Copyright (c) 2005 - 2010, Intel Corporation. All rights > > reserved.
> > -SPDX-License-Identifier: BSD-2-Clause-Patent > > - > > -**/ > > - > > -#ifndef __RESET_SYSTEM_LIB_H__ > > -#define __RESET_SYSTEM_LIB_H__ > > - > > -/** > > - This function causes a system-wide reset (cold reset), in which > > - all circuitry within the system returns to its initial state. This > > type of reset > > - is asynchronous to system operation and operates without regard to > > - cycle boundaries. > > - > > - If this function returns, it means that the system does not support > > cold reset. > > -**/ > > -VOID > > -EFIAPI > > -ResetCold ( > > - VOID > > - ); > > - > > -/** > > - This function causes a system-wide initialization (warm reset), in > > which all processors > > - are set to their initial state. Pending cycles are not corrupted. > > - > > - If this function returns, it means that the system does not support > > warm reset. > > -**/ > > -VOID > > -EFIAPI > > -ResetWarm ( > > - VOID > > - ); > > - > > -/** > > - This function causes the system to enter a power state equivalent > > - to the ACPI G2/S5 or G3 states. > > - > > - If this function returns, it means that the system does not support > > shutdown reset. > > -**/ > > -VOID > > -EFIAPI > > -ResetShutdown ( > > - VOID > > - ); > > - > > -/** > > - This function causes the system to enter S3 and then wake up > immediately. > > - > > - If this function returns, it means that the system does not support > > S3 feature. > > -**/ > > -VOID > > -EFIAPI > > -EnterS3WithImmediateWake ( > > - VOID > > - ); > > - > > -#endif > > -- > > 2.16.2.windows.1 > >