From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web09.546.1580344214956906608 for ; Wed, 29 Jan 2020 16:30:15 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=sQ54E+SH; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: michael.a.kubacki@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2020 16:30:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,379,1574150400"; d="scan'208";a="232689403" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga006.jf.intel.com with ESMTP; 29 Jan 2020 16:30:12 -0800 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Jan 2020 16:30:12 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Jan 2020 16:30:12 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Jan 2020 16:30:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JeGd/8Wy1QhTG+3ddaPJL6RLN95IE2m+E3qqClaPy2F7MdeFDjNhg1TbZjDbgSh62J8hkLww81/yH6FJw1TUZbqM4myVHqSNmVk5d4TOB5s5/RGFplIst385R83W8+scPoTs0aPnlJt+2sOIrx+k0A5OutI2cMfGG25qHmdczM6EAU2tUx/jlhsVRZMl0S5FmnK7yoziQpywUVJVC53Nten3MIvkICOSOT42+t/sEAhaOVClZp2MT8n6Z23gks3xLN8CLst3RSJRDuXRU3aiTO+adzl9XAkturQYA9eDTB8xn6ypN0j/3/JRCfKTLXKIt1MZygCrxP+SvSR+RZ+SQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hfAT9RDgkl+oT+iRfgfyyQ8oBI6Vis20yZQ2C+t/sMo=; b=izsL8GE6JdEbru3M8kDbApKhIUiCnHSLiPrNcTyIiX1vZUSE+aDzgd7HEbf1n1AlTI5h6RoCqKTEpG8v6Vb3e7ypXPreWVCjG3ToP12rDvcLhqpZaVQDn1BEAICnmp4mC/wKmfYef1YtA2Nk6CJuxRpAXNtcGGfThOU8YLlrCDD2v8S+/1MK9pOrf0VOhiunuze/UVWi8NlZk+BWDquzcuw9nBcIBtfgojLdJlj46sVjyqO6S11T2W2Wi3Z4EOU+ilk1h7I/eVNy2KqM3J5vGOGGQig9njs0H/GTu6JJmZk98gG3tkutzJeZgYRbjRVq66bLgfsmWaR/2ImLu/6raw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hfAT9RDgkl+oT+iRfgfyyQ8oBI6Vis20yZQ2C+t/sMo=; b=sQ54E+SHnEsPOMU0f+kdydI7SGXIAhQvXwsWB99hRMIrERdMsY52uF5zb4kUfARc3vElnYTwX7pa99jSUkaGZ6K+Ow8t48xu1cTMbu+ZX+baQaoGb5bGvfkGql6yEVQBM1aZcxVDKkLJ/MoeMX1Mbs0tEGtssiRo4F/G4JyOatk= Received: from BY5PR11MB4484.namprd11.prod.outlook.com (52.132.254.155) by BY5PR11MB4021.namprd11.prod.outlook.com (10.255.163.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.26; Thu, 30 Jan 2020 00:30:10 +0000 Received: from BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::b9de:29da:2b58:18b3]) by BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::b9de:29da:2b58:18b3%7]) with mapi id 15.20.2665.027; Thu, 30 Jan 2020 00:30:10 +0000 From: "Kubacki, Michael A" To: "Agyeman, Prince" , "devel@edk2.groups.io" CC: "Zhang, Shenglei" , "Chiu, Chasel" , "Desimone, Nathaniel L" Subject: Re: [edk2-platforms] [PATCH] BoardModulePkg: Fix ECC Coding Style Issues Thread-Topic: [edk2-platforms] [PATCH] BoardModulePkg: Fix ECC Coding Style Issues Thread-Index: AQHVywUGUFAlHcrc10a5QXDo2iBwnagCcp7g Date: Thu, 30 Jan 2020 00:30:09 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmNhZDUxMWYtYmJkYS00MTI4LWJiYjItYjFlNjZhYmEyOWY3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYnNVYWJEQlkybEhTXC9qRTU4Q0RpVG5oY0lhR214d0txQkpPc2FwMW45T2VlXC9DWHNoOG1BWGNZbm5uVEtOV2xxIn0= dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 96d296b5-01f7-4bbd-3c40-08d7a51b907e x-ms-traffictypediagnostic: BY5PR11MB4021: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-forefront-prvs: 02981BE340 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39860400002)(396003)(346002)(366004)(136003)(376002)(189003)(199004)(5660300002)(86362001)(316002)(54906003)(110136005)(52536014)(71200400001)(6506007)(53546011)(26005)(9686003)(186003)(966005)(7696005)(8936002)(19627235002)(55016002)(4326008)(33656002)(107886003)(76116006)(64756008)(66556008)(66946007)(66476007)(478600001)(81156014)(2906002)(66446008)(8676002)(81166006);DIR:OUT;SFP:1102;SCL:1;SRVR:BY5PR11MB4021;H:BY5PR11MB4484.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: k0IjWaBkK60Wd7ykrqgMTC5iX6SaFi3wwRY4QFbEFT/MX4C/02qZ4ouxfd4B6gUDw6xbEZM+IEMne0d0ALqkybHOMD3bEn2/U+alusQlBZSWGtOFmji4E2eD6oBoLePvsnfuVqcCd1KOxBFAqifPyQG/tAf1imAH50mCdKs9oYO+/gQcZyy64NhVs2aSh3L3+NqaR8g/zEGTDK49eCEzlxQvIHeNPcqO0/EYbra2aOrXkoGbnDWIvpwy8gKAVbtg0wWQnXHq4Z2Y0d55LeuGGfGLGQdHzUOJlqEHXD70LhP4lD/XkErdO1mhCye8XwyJf4CCKW0tGjDZJ0nF4pPmSTDb/VajciaDNl9W2NkVEUoQXCvxzbIj3Dm4+zh3L5/QmDVCnaQsEQjzElhtroTqt8vp4wle0G34H0zA/NLLOFaTk8m6mqAxKNfZlJBRruXJih93/652N29owscp6DvjWeifxYTI3jqgqp/mJPkDRuLbDuJESPVzt9G+ShbbX1JYAz32M7VD4cGPsYD57Im4/A== x-ms-exchange-antispam-messagedata: iA8g14t7mf7cDcApmyaSkkGoxqWlv4ZG/0mn6U9YueEy754WtKuIJQd1qBRvgUntrX8/y5MkYnhOWuLhQuNH2SFvGMkGDy5DtgJS6rbOoEkIiBdqnZU1ZMVZOuSFm5KmL+08AcZBaLIGyifiFnWDDw== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 96d296b5-01f7-4bbd-3c40-08d7a51b907e X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jan 2020 00:30:10.0867 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AGwX3qNGaeHPvu/5ZUYYlzwRv7F8N5KdJln0OaApxeLQM4/cAHtQFILYGYgnL5FIttx+VLCwU0kT04tApSapD+Tu3K0blA932AbVHWh1xK0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4021 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The copyright dates needed to be updated to 2020. I updated those locally b= efore being pushed. Reviewed-by: Michael Kubacki Thanks, Michael > -----Original Message----- > From: Agyeman, Prince > Sent: Tuesday, January 14, 2020 9:28 AM > To: devel@edk2.groups.io > Cc: Zhang, Shenglei ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Kubacki, Michael A > > Subject: [edk2-platforms] [PATCH] BoardModulePkg: Fix ECC Coding Style > Issues >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2453 >=20 > Fixed coding style issues as reported by the ECC tool >=20 > Cc: Shenglei Zhang > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Michael Kubacki >=20 > Signed-off-by: Prince Agyeman > --- > .../BoardModulePkg/LegacySioDxe/ComponentName.h | 5 +++++ > .../BoardModulePkg/LegacySioDxe/LegacySioDxe.inf | 2 ++ > .../Intel/BoardModulePkg/LegacySioDxe/SioChip.c | 5 +++-- > .../Intel/BoardModulePkg/LegacySioDxe/SioDriver.c | 15 ++++++++------- > .../Library/BdsPs2KbcLib/BdsPs2KbcLib.c | 6 +++--- > .../Library/BdsPs2KbcLib/BdsPs2KbcLib.h | 4 ++-- > 6 files changed, 23 insertions(+), 14 deletions(-) >=20 > diff --git > a/Platform/Intel/BoardModulePkg/LegacySioDxe/ComponentName.h > b/Platform/Intel/BoardModulePkg/LegacySioDxe/ComponentName.h > index 85ca348701..91bc245f3a 100644 > --- a/Platform/Intel/BoardModulePkg/LegacySioDxe/ComponentName.h > +++ b/Platform/Intel/BoardModulePkg/LegacySioDxe/ComponentName.h > @@ -6,6 +6,9 @@ > SPDX-License-Identifier: BSD-2-Clause-Patent **/ >=20 > +#ifndef _LEGACY_SIO_DXE_COMPONENT_NAME_H_ #define > +_LEGACY_SIO_DXE_COMPONENT_NAME_H_ > + > /** > Retrieves a Unicode string that is the user-readable name of the EFI D= river. >=20 > @@ -85,3 +88,5 @@ SioComponentNameGetControllerName ( > IN CHAR8 *Language, > OUT CHAR16 **ControllerName > ); > + > +#endif > diff --git a/Platform/Intel/BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > b/Platform/Intel/BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > index 1d7cd92604..698d406450 100644 > --- a/Platform/Intel/BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > +++ b/Platform/Intel/BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > @@ -44,6 +44,8 @@ > SioDriver.c > SioDriver.h > ComponentName.c > + ComponentName.h > + Register.h >=20 > [Pcd] > gBoardModulePkgTokenSpaceGuid.PcdPs2KbMsEnable > diff --git a/Platform/Intel/BoardModulePkg/LegacySioDxe/SioChip.c > b/Platform/Intel/BoardModulePkg/LegacySioDxe/SioChip.c > index b9a84ca51c..846dddf739 100644 > --- a/Platform/Intel/BoardModulePkg/LegacySioDxe/SioChip.c > +++ b/Platform/Intel/BoardModulePkg/LegacySioDxe/SioChip.c > @@ -145,7 +145,7 @@ DEVICE_INFO mDeviceInfo[] =3D { >=20 >=20 > /** > - Gets the number of devices in Table of SIO Controllers mDeviceInfo > + Gets the number of devices in Table of SIO Controllers mDeviceInfo. >=20 > @retval Number of enabled devices in Table of SIO Controllers. > **/ > @@ -153,7 +153,8 @@ UINTN > EFIAPI > GetDeviceCount ( > VOID > -){ > + ) > +{ > UINTN Count; > // Get mDeviceInfo item count > // -1 to account for for the end device info diff --git > a/Platform/Intel/BoardModulePkg/LegacySioDxe/SioDriver.c > b/Platform/Intel/BoardModulePkg/LegacySioDxe/SioDriver.c > index 5bfdc94681..484c53e953 100644 > --- a/Platform/Intel/BoardModulePkg/LegacySioDxe/SioDriver.c > +++ b/Platform/Intel/BoardModulePkg/LegacySioDxe/SioDriver.c > @@ -118,13 +118,14 @@ BOOLEAN > EFIAPI > SioDeviceEnabled ( > IN SIO_PCI_ISA_BRIDGE_DEVICE_INFO *CurrentDevice -){ > - SIO_PCI_ISA_BRIDGE_DEVICE_INFO *Device =3D \ > - (SIO_PCI_ISA_BRIDGE_DEVICE_INFO *) FixedPcdGetPtr > (PcdSuperIoPciIsaBridgeDevice); > - if(CompareMem (Device, CurrentDevice, sizeof > (SIO_PCI_ISA_BRIDGE_DEVICE_INFO)) =3D=3D 0) { > - return TRUE; > - } > - return FALSE; > + ) > +{ > + SIO_PCI_ISA_BRIDGE_DEVICE_INFO *Device; > + Device =3D (SIO_PCI_ISA_BRIDGE_DEVICE_INFO *) FixedPcdGetPtr > +(PcdSuperIoPciIsaBridgeDevice); > + if(CompareMem (Device, CurrentDevice, sizeof > (SIO_PCI_ISA_BRIDGE_DEVICE_INFO)) =3D=3D 0) { > + return TRUE; > + } > + return FALSE; > } >=20 > /** > diff --git > a/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c > b/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c > index eff10bddb4..0cf4c4d262 100644 > --- a/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c > +++ > b/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.c > @@ -65,7 +65,7 @@ DetectPs2Keyboard ( > MicroSecondDelay (30); > } >=20 > - if (FoundPs2Kbc =3D=3D FALSE) { > + if (!FoundPs2Kbc) { > return FALSE; > } >=20 > @@ -126,7 +126,7 @@ IsPs2KeyboardConnected ( > BOOLEAN Result; > Result =3D DetectPs2Keyboard (); >=20 > - if (Result =3D=3D FALSE) { > + if (!Result) { > // > // If there is no ps2 keyboard detected for the 1st time, retry agai= n. > // > @@ -138,7 +138,7 @@ IsPs2KeyboardConnected ( >=20 > /** > Updates the ConIn variable with Ps2 Keyboard device path, > - if it doesn't already exists in ConIn and ConInDev > + if it doesn't already exists in ConIn and ConInDev. > **/ > VOID > AddPs2Keyboard ( > diff --git > a/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.h > b/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.h > index d9a27e6681..a96d53b98d 100644 > --- a/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.h > +++ > b/Platform/Intel/BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.h > @@ -6,8 +6,8 @@ >=20 > **/ >=20 > -#ifndef _PS2_KBC_LIB_H > -#define _PS2_KBC_LIB_H > +#ifndef _PS2_KBC_LIB_H_ > +#define _PS2_KBC_LIB_H_ >=20 > #include > #include > -- > 2.19.1.windows.1