From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web12.4286.1576627112378826504 for ; Tue, 17 Dec 2019 15:58:33 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=KXMxXoBb; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: michael.a.kubacki@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Dec 2019 15:58:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,327,1571727600"; d="scan'208";a="221878409" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga001.fm.intel.com with ESMTP; 17 Dec 2019 15:58:31 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Dec 2019 15:58:31 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 17 Dec 2019 15:58:31 -0800 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 17 Dec 2019 15:58:30 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Dec 2019 15:58:30 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aYkYyx4/yu3wzkjfuYIwDZ4+Ekzjc5DuibRpiHPUCD3AO6wtRG2rovUbj4wHIfHX2OBU01hVT/QK+FCoNFWp2UoiegQmG+tsu+ONwUtc4y9JZ61v+zIwbM68s67rvUN8aJSv4oJ+d6SuHlhLsC6rE8KIu82tOb6Yt8MXUv+oii0dtU/NB5v/xQ4nAFs3qb4Mu3hVXh55rXVjr+1K12kSpQkdOmh8cmkJRceqolhU/z72433rty9QUZ4jwMkOK9xsbBaBlfaciDWbUwQlQYto06h5RpYYdrOXvLE6tJm9IqDRbj+mGifMlYT9wPBJtxfLdYbTEBz/PMLsbgjBsHePbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J+E+9rMMsT97mB08ubaZzjCJ2R/aXvaG8aSZt8huy80=; b=hB7xq9hK8doAu/rMMGuGiliDiykJZOByCvzTR9POEQFd4FdrZIxBxvEvW3Pe0gHUO2XdeijJBACd34wLsYkeLTmqIPhKq7iknEFTG4CLykPe24jIP7aR1R/E4vOOZe6Kk059/GlXQhbBXdCwLiG18uDjFmPD08e6nsN3jNcUXCIS/dPSudvA+AxFALUT10c9qPx2NPowiah0xzF3GP5Abi2ESj0ZTAToZeIUrTadn7jb0948VFyH2RRLrwTJ54vmRtAszrHh+ETvD1W8P0y/Ht8ldT74Dmd8PRF3q9NFprRIBXeLBOxnoF55WWZfr1TdYWoBXRbS4e5fOlLI4/WWcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J+E+9rMMsT97mB08ubaZzjCJ2R/aXvaG8aSZt8huy80=; b=KXMxXoBblmgKdyKq3J0RNfcmd2lBO7e97Rd6OWAvA+4rz8tEgyGo/a9/JssEQ229FgT1ML4ed/KsxNsWnK4lAX1BUbQsU5nOivVzgrTd7LIaj1frRLmvtiu1ond4Y2AhEPhsUNZNTIUeSQJNmnxzI6PTJ+hJi94fSBJwootBf6M= Received: from BY5PR11MB4484.namprd11.prod.outlook.com (52.132.254.155) by BY5PR11MB4468.namprd11.prod.outlook.com (52.132.255.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.18; Tue, 17 Dec 2019 23:58:28 +0000 Received: from BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::a114:604b:7ca3:5420]) by BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::a114:604b:7ca3:5420%7]) with mapi id 15.20.2538.019; Tue, 17 Dec 2019 23:58:28 +0000 From: "Kubacki, Michael A" To: "Ni, Ray" CC: "Desimone, Nathaniel L" , "devel@edk2.groups.io" , "Chiu, Chasel" , "Agyeman, Prince" Subject: Re: [edk2-devel] [edk2-platforms] [PATCH 01/11] MinPlatformPkg: Add BDS Hook Point Guids Thread-Topic: [edk2-devel] [edk2-platforms] [PATCH 01/11] MinPlatformPkg: Add BDS Hook Point Guids Thread-Index: AQHVsh5riFql/5NoB0OChHlRmSVGBKe7/OIAgAB6nYCAAJOloA== Date: Tue, 17 Dec 2019 23:58:27 +0000 Message-ID: References: <20c55746e3b8e848cfff7b17b41a26207383d7e1.1576282834.git.prince.agyeman@intel.com> <3C3EFB470A303B4AB093197B6777CCEC505CA725@PGSMSX111.gar.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5C39ECCC@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C39ECCC@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2M0NGIwZTYtYTZmNC00ODIyLWJmNTMtMzNhNTMzYjVlYWEzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMmJmUjBQYkFNQ0dNaWpCem95RjcrRlE3TVwvbGY4aUtEUU5VRVpIYmo2Ym12eGFmbnh4OElzSFZTWVdkeVVNZU8ifQ== dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9d3ac163-9c2f-4dac-e356-08d7834d02f3 x-ms-traffictypediagnostic: BY5PR11MB4468: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 02543CD7CD x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(136003)(39860400002)(396003)(346002)(366004)(376002)(13464003)(189003)(199004)(66946007)(66556008)(66476007)(316002)(478600001)(66446008)(52536014)(81166006)(107886003)(64756008)(71200400001)(6506007)(53546011)(5660300002)(6862004)(6636002)(54906003)(186003)(8936002)(7696005)(76116006)(81156014)(8676002)(4326008)(966005)(9686003)(33656002)(55016002)(26005)(86362001)(2906002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY5PR11MB4468;H:BY5PR11MB4484.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /GHD2bq6dpfNokGCQqI2EQneBi6MIWqcqkC0r2sbE+PuyQK76oLkjicG7aA3goU0OtJKBBN4zvxoT1O9LYGeOxYJvgQ/dLa4Bj+b8OyZu7mHm1p9bWbTKYnJyCNq+/smIg0zz3aJTFBLsD9VdL2XohusbBix5SpkZtT1nTofuV2URnUeU1xAj9+5ggJzCb6LXUdTKHAr5l2Jvk+KaE8JirWUI7CZ3KDqu4VShdE/nQDI4kf6xt7ce9P9VODwgzCHr3dG4Ch40/jVeRx7TKtWGlqokr+NEFpUx1rypyopEq0PXqBQVgkCCTueYVo6vej6c8CaLNPyfbIZfNtpNiWjkPi/pLy+w4chu1XiR89OeKWYt7Fgi91yVX+gxo1b4r/NGjmvHYbwDjRxonfcdeXZYxrPmYf71kyxmbWGhDTzo7ovpJRD5LBgln2/yUMg3v0irbrsxQ4y9gTyvgNPUwCMPVSqmjlKj0ZaLOLNkMbkd2ojGFrdc4tmNYupPssILo3Y89LoEPhGd66G7O5GVrSeuOq8LkoIz6+aNTzIWH+XS2s= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 9d3ac163-9c2f-4dac-e356-08d7834d02f3 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2019 23:58:27.6935 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RQr6OVQbcT9iJHOtXEzGeE52SLOtQLWuK0xxKIEGNoH9lnqMPAay46p59sVZ1fGS8GqH3AG8AGdvz31MIXtnD2kn2UY9f6p1Rvj3coZFnnM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4468 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ray, There could be usage of SimpleTextIn->ReadKeyStroke () in PlatformBootMana= gerWaitCallback () and PlatformBootManagerUnableToBoot (). The PlatformBoot= ManagerLib instance introduced in MinPlatformPkg simply forwards those call= s to a library instance of BoardBootManagerLib implemented in the board pac= kage so they will still be invoked at TPL_APPLICATION. A specific use case that requires TPL_APPLICATION (the restriction is rela= tively minimal) has not been identified in the analysis of use cases that l= ed to the event hook points introduced in PlatformBootManagerLib. Thanks, Michael > -----Original Message----- > From: Ni, Ray > Sent: Monday, December 16, 2019 12:50 AM > To: Kubacki, Michael A > Cc: Desimone, Nathaniel L ; > devel@edk2.groups.io; Chiu, Chasel ; Agyeman, > Prince > Subject: RE: [edk2-devel] [edk2-platforms] [PATCH 01/11] MinPlatformPkg: > Add BDS Hook Point Guids >=20 > Using event for callbacks has a limitation: The event callback has to ru= n at TPL > >=3D TPL_CALLBACK. >=20 > Some of the services like gBS->LoadImage()/StartImage(), SimpleTextIn- > >ReadKeyStroke(), > FormBrowser->SendForm() can ONLY be called at TPL_APPLICATION. > So those services cannot be called from the event callback. >=20 > Is that ok to the min-platform? >=20 > Thanks, > Ray >=20 >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Chiu, > > Chasel > > Sent: Monday, December 16, 2019 9:32 AM > > To: Agyeman, Prince ; devel@edk2.groups.io > > Cc: Kubacki, Michael A ; Desimone, > > Nathaniel L > > Subject: Re: [edk2-devel] [edk2-platforms] [PATCH 01/11] MinPlatformPk= g: > > Add BDS Hook Point Guids > > > > > > Reviewed-by: Chasel Chiu > > > > > -----Original Message----- > > > From: Agyeman, Prince > > > Sent: Saturday, December 14, 2019 9:32 AM > > > To: devel@edk2.groups.io > > > Cc: Kubacki, Michael A ; Chiu, Chasel > > > ; Desimone, Nathaniel L > > > > > > Subject: [edk2-platforms] [PATCH 01/11] MinPlatformPkg: Add BDS Hook > > > Point Guids > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2336 > > > > > > Added BDS hook point guids as defined in the Minimum Platform > > > specification. These GUIDs shall be used in the identification of > > > three of the BDS hook point event groups. > > > > > > These event groups are Before Console After Trusted, Before Console > > Before > > > End Of Dxe and After Console Ready Before BootOption events. > > > > > > See > > > https://edk2-docs.gitbooks.io/edk-ii-minimum-platform-specification, > > > under Appendix A.3 BDS Hook Points, for more details > > > > > > Cc: Michael Kubacki > > > Cc: Chasel Chiu > > > Cc: Nate DeSimone > > > > > > Signed-off-by: Prince Agyeman > > > --- > > > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > > index 7f74ac9380..5bec4eee3a 100644 > > > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > > > @@ -46,6 +46,11 @@ > > > gDefaultDataFileGuid =3D {0x1ae42876, 0x008f, 0x4161= , > > > {0xb2, 0xb7, 0x1c, 0x0d, 0x15, 0xc5, 0xef, 0x43}} > > > gDefaultDataOptSizeFileGuid =3D {0x003e7b41, 0x98a2, 0x4be2= , > > > {0xb2, 0x7a, 0x6c, 0x30, 0xc7, 0x65, 0x52, 0x25}} > > > > > > + # BDS Hook point event Guids > > > + gBdsEventBeforeConsoleAfterTrustedConsoleGuid =3D {0x51e49ff5, > > > 0x28a9, 0x4159, { 0xac, 0x8a, 0xb8, 0xc4, 0x88, 0xa7, 0xfd, 0xee}} > > > + gBdsEventBeforeConsoleBeforeEndOfDxeGuid =3D {0xfcf26e41, > > > 0xbda6, 0x4633, { 0xb5, 0x73, 0xd4, 0xb8, 0x0e, 0x6d, 0xd0, 0x78}} > > > + gBdsEventAfterConsoleReadyBeforeBootOptionGuid =3D {0x8eb3d5dc, > > > 0xf4e7, > > > + 0x4b57, { 0xa9, 0xe7, 0x27, 0x39, 0x10, 0xf2, 0x18, 0x9f}} > > > + > > > [LibraryClasses] > > > > > > PeiLib|Include/Library/PeiLib.h > > > -- > > > 2.19.1.windows.1 > > > > > >=20 >=20