From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web10.3194.1574404338989673027 for ; Thu, 21 Nov 2019 22:32:19 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Y9aegduc; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: michael.a.kubacki@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2019 22:32:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,228,1571727600"; d="scan'208";a="407481007" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 21 Nov 2019 22:32:18 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 21 Nov 2019 22:32:18 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 21 Nov 2019 22:32:17 -0800 Received: from NAM05-DM3-obe.outbound.protection.outlook.com (104.47.49.51) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 21 Nov 2019 22:32:18 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fm/xJMguujFyJ1gfFZHu2ke7UYuble3Hao1ZRGCnLMUMpQtpOIDlhhHNk9zt4fpY5z8/oR5Iq7EEu3C2Hlk6ebEi+wckiNkA8qww0Vf0f4nlG7EXkORlZh6yFfyQezfhAwque8ig3VkiNoPHp0lQMVKvtj6DXEP/0rH/yylehSBMTGWjBc9P8cHFPXP6h/qtW4FuulS/b+rFfHTLT42xXUrg6JC7Ho6H313FxmzCS070E4jqVUNSUzziA73mzNZBVHXaSU73J2r+kB4PKnuxh1J1Wp7Ip3OLqWc8AGqC9h+FwDo2veYnYxp+8w4f7VibuhHSlHWaVVldjL0EeDWtcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zBIyjWVmwkipD+IczgFqaJOtWuX+vdZ2wtk3pU3pPYs=; b=CZ3DflJbp8TEzQbD6FJdMLW2JOnNQK2m/q0bePjlUTdrouz/xeqNziLtsXgWSk6WRjvLtqB5BFkfb/BipCHCXFk6BiB+scX0jqRv70GUN4EmrP1yxLPhlUZhN2Jk8nFHwK28ajOgvAYN4JnC6FRETBQ3833ESQKb3sdW9IMoS3Z6L8nRvYK2NWTS+xHK9Jr+lVYM9e3bISOzDwJcHrtDRpLlmcnSuPgMq/NlXaN6Eauwn6FzJDI33tdYHLWur2jNTTTAG0VZf9a3jJOE7gSAhtY0Dmjv/G6JmP6JCWkccFeVtmNc7t3Gnc+Z1r1KtTdLi/YRK0HCADczbyqkP9a60A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zBIyjWVmwkipD+IczgFqaJOtWuX+vdZ2wtk3pU3pPYs=; b=Y9aegducB/7ClM8uMGYX1Ljd3VjIP5YmHxe4Ef9NlDORBt6g6f4nngvBgxd1OzRb5SgzJWKW1RPAMgHBp4p5byAsM2+FqE0oz83FKiGciVowW1wUri3H+YTRrftFf110GUhRHMz+UKcVJgbHBUyYpUu1pUESHa/tLnUbA22U540= Received: from BY5PR11MB4484.namprd11.prod.outlook.com (52.132.254.155) by BY5PR11MB4053.namprd11.prod.outlook.com (10.255.72.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.19; Fri, 22 Nov 2019 06:32:13 +0000 Received: from BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::a114:604b:7ca3:5420]) by BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::a114:604b:7ca3:5420%7]) with mapi id 15.20.2474.019; Fri, 22 Nov 2019 06:32:13 +0000 From: "Kubacki, Michael A" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Chaganty, Rangasai V" Subject: Re: [edk2-platforms] [PATCH V2 05/14] CoffeeLakeSiliconPkg: TcoWdtHob.h Cleanup Thread-Topic: [edk2-platforms] [PATCH V2 05/14] CoffeeLakeSiliconPkg: TcoWdtHob.h Cleanup Thread-Index: AQHVoEoI2xW9B7gX50yYz+Xd2bZuRaeWt6Ww Date: Fri, 22 Nov 2019 06:32:13 +0000 Message-ID: References: <20191121085853.2626-1-nathaniel.l.desimone@intel.com> <20191121085853.2626-6-nathaniel.l.desimone@intel.com> In-Reply-To: <20191121085853.2626-6-nathaniel.l.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2JkMjZmMWEtZTc5Yy00OTExLWFkNDAtYWE0ZjNiODNmMzgzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicTBIN2x2MERuZ0RocFpmbitKQ3VpdnArd29EMU53amFnTHVBSDJaYWRjRWJWZVprVmlMNUk5c1BIQk5QK01xTCJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: caedfa8f-17f4-40aa-df76-08d76f15b646 x-ms-traffictypediagnostic: BY5PR11MB4053: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:110; x-forefront-prvs: 02296943FF x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(376002)(346002)(136003)(396003)(39860400002)(199004)(189003)(13464003)(71200400001)(71190400001)(14454004)(25786009)(2501003)(52536014)(33656002)(508600001)(5660300002)(54906003)(186003)(7696005)(55016002)(4326008)(6246003)(316002)(99286004)(110136005)(6436002)(66066001)(102836004)(9686003)(6506007)(86362001)(6116002)(76116006)(7736002)(76176011)(3846002)(26005)(229853002)(81156014)(446003)(81166006)(66476007)(8676002)(8936002)(107886003)(256004)(11346002)(66946007)(305945005)(74316002)(66446008)(64756008)(53546011)(66556008)(2906002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY5PR11MB4053;H:BY5PR11MB4484.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dbcmqcUoFWcVG2ky51K0JblktK+IUEZyFh6CXCVgOwDZA+Hk4hX3+FYrsifE6JnkV4xZXEE29n1vtBEL7so71pQyYgLLV/aJpfzR2xFO00px4oQz2MIHcWi4y5v2UUVfGhPMeSQ8Jq2KfLrhCdApwsO9X/r5mObpu2qCFvt9qJWQxtMZsza5+PqlAjnY1KtDxVVHTkjcGDOGYXV24OEjnhn1OhYPuen5h/a6VuLyF/q/8T5PcbwCDE+U9ZS8/uw4fUM5ct+d4N35X9+eKlL2sDBNI62hLICZVy9PRvfusiP2QXAtugkDTdwmbWYce8QyuLxNFlm/IrfcAATpVRpK0+VCM1G7guUap+5oxOi7lhOcNLot7SnkB8660QNws7j1Lk0ymfCNwYDH1ly8zI9qszSlgIPP4NPoRX1HlMDjhqwMPeupihj6gyMGW8eSbfYe MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: caedfa8f-17f4-40aa-df76-08d76f15b646 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2019 06:32:13.8209 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nxDBEcrqCdYw1KgyiZuohWKt90XwB2lv0UTv4EZ8yWo+xdKOeYyA71salq9EJpqI+XMdrLQXXlA++9STMVZhLFSbz+Nscz3zRF89JgABY2o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4053 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Michael Kubacki > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Thursday, November 21, 2019 12:59 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Chaganty, Rangasai V > > Subject: [edk2-platforms] [PATCH V2 05/14] CoffeeLakeSiliconPkg: > TcoWdtHob.h Cleanup >=20 > Removes duplicate EFI_HOB_GENERIC_HEADER and EFI_HOB_GUID_TYPE > definitions from TcoWdtHob.h >=20 > Cc: Chasel Chiu > Cc: Michael Kubacki > Cc: Sai Chaganty > Signed-off-by: Nate DeSimone > --- > .../Include/Guid/TcoWdtHob.h | 23 ++----------------- > 1 file changed, 2 insertions(+), 21 deletions(-) >=20 > diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h > b/Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h > index 5bf2527963..9e83ed49c1 100644 > --- a/Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h > +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h > @@ -7,35 +7,16 @@ > #ifndef __TCO_WDT_HOB_H__ #define __TCO_WDT_HOB_H__ +#include > + #define TCO_WDT_HOB_GUID \ { \ 0x3e405418, 0xd8c, 0x4f1a= , > { 0xb0, 0x55, 0xbe, 0xf9, 0x8, 0x41, 0x46, 0x8d } \ } -#ifndef _PEI_HOB= _H_- > #ifndef __HOB__H__-#ifndef __PI_HOB_H__-typedef struct > _EFI_HOB_GENERIC_HEADER {- UINT16 HobType;- UINT16 HobLength;- > UINT32 Reserved;-} EFI_HOB_GENERIC_HEADER;--typedef struct > _EFI_HOB_GUID_TYPE {- EFI_HOB_GENERIC_HEADER Header;- EFI_GUID > Name;- //- // Guid specific data goes here- //-} EFI_HOB_GUID_TYPE;- > #endif-#endif-#endif- typedef struct { EFI_HOB_GUID_TYPE Header; > UINT8 TcoRebootHappened; } TCO_WDT_HOB; #endif--- > 2.24.0.windows.2