From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.9282.1572891553755462639 for ; Mon, 04 Nov 2019 10:19:14 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=imqkc2Uo; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: michael.a.kubacki@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Nov 2019 10:19:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,267,1569308400"; d="scan'208";a="401691763" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 04 Nov 2019 10:19:13 -0800 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 4 Nov 2019 10:19:12 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 4 Nov 2019 10:19:12 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 4 Nov 2019 10:19:12 -0800 Received: from NAM03-DM3-obe.outbound.protection.outlook.com (104.47.41.51) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 4 Nov 2019 10:19:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W/IxRXAxtLV+6X9HoEkHWoas1yQdbEw8KG6YbJsEnJJmyDukVFymDSjI7G4MUXpe6uYfRHZCGici3BMp3UzsLMF0tNV2+UoenVA5TzDuVwcJ6SuqUw5QrxMnPA1qCeiPCNShj0mXkQytFSSF/HlJiU6aDFKUSJD6W+tE/LfSGJIL1tAYJ2YZ0ls33jh+c1UoDI22u227AxOvaz3wcYcWFJA73KVv8j7m0J1VkiWTvLFaKgtUE9QPk19RedmnTwvlTXK6dkxYXvS8tL/vjKQ0MSOPfwPscVXaJ+w6hjtb2UuW9QliCIN5icVyPNnyswQ79o6lcLHAezMdxz7rtfshtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LQiyf8JiB4k7edT19+ps/O8iRapklArRbGCn6sDcQxw=; b=IeTPaomV8H/QqzjZG3hjTR23r10ozcTqAcPo+M0FkJIEtXVBxU+kcZDSPCGZP5oxy+OeXwocUXaZ4Z2IixJXQU9XrhbCKqflOqDA3e+HRmDD+cfiO2Ydj70/aYzSVCRmw3u51kzXtOeluN1xAQ8MELz0iYm5ImoW9uH3oHHbTonraTqon9Gh/g3FjslCm7Rw3YrXaD7L4MO+QlMhz+8xxs+6hwKP17FM+1Bfb5XzcR/Vu1yAn1/ULxiuJ+YfGTMFchaXDez6JcIiNAkuuolzeOMwGR79vYSvGkoWK/2b0poaC5jHxtwl9M0g0asy3zOU25BxIudarPbW+J12lKYR6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LQiyf8JiB4k7edT19+ps/O8iRapklArRbGCn6sDcQxw=; b=imqkc2UogsEQ9/sFXYx5/mZEKAKZ/peWQXSGaCeMWXMCOZ3whZdIqwubuFejLNAzLbrmnKON5D3odiRcMZLAqNWd4wTE0f9bGUOD/6H+Qt/Pa54kP/ghaYKEfLUFc8ePCo9fyvUW6DYwmMHTYxVQW9y3eWC+pr6TlWf9lMR2Oa4= Received: from BY5PR11MB4484.namprd11.prod.outlook.com (52.132.254.155) by BY5PR11MB3926.namprd11.prod.outlook.com (10.255.160.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.24; Mon, 4 Nov 2019 18:18:48 +0000 Received: from BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::c1ef:6e0b:90c8:55e2]) by BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::c1ef:6e0b:90c8:55e2%7]) with mapi id 15.20.2408.024; Mon, 4 Nov 2019 18:18:48 +0000 From: "Kubacki, Michael A" To: "devel@edk2.groups.io" , "Agyeman, Prince" Subject: Re: [edk2-devel] [edk2-platforms] [PATCH 0/5] Enable Ps2 keyboard Thread-Topic: [edk2-devel] [edk2-platforms] [PATCH 0/5] Enable Ps2 keyboard Thread-Index: AQHVkO3MUuNX+Ji4KECjcRq7uBjszKd7R1jg Date: Mon, 4 Nov 2019 18:18:48 +0000 Message-ID: References: <20191101195116.23212-1-prince.agyeman@intel.com> In-Reply-To: <20191101195116.23212-1-prince.agyeman@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjRhYjZjM2YtNGRiNi00OWFkLTgyN2MtZTNhNDRhNDU5ZGJlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVHRFV3g4T01wTVZTT1dhU1wvd0sydVp6QzMyUTVqUDl3S3ZvNXR4SWROYVA4MnROUU9talJXRThXVWZcL21pN3BSIn0= dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2770ebbb-45d4-4ca7-1d27-08d76153702b x-ms-traffictypediagnostic: BY5PR11MB3926: x-ms-exchange-purlcount: 4 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0211965D06 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(346002)(39860400002)(396003)(136003)(366004)(189003)(13464003)(199004)(186003)(7736002)(229853002)(7696005)(486006)(476003)(86362001)(966005)(9686003)(52536014)(66066001)(478600001)(14454004)(6306002)(81156014)(81166006)(6246003)(8936002)(6436002)(25786009)(5660300002)(8676002)(102836004)(14444005)(99286004)(53546011)(6506007)(26005)(316002)(2501003)(3846002)(66556008)(6116002)(76116006)(66476007)(66946007)(66446008)(64756008)(2906002)(256004)(33656002)(19627235002)(71190400001)(71200400001)(55016002)(446003)(76176011)(74316002)(11346002)(6636002)(305945005)(110136005);DIR:OUT;SFP:1102;SCL:1;SRVR:BY5PR11MB3926;H:BY5PR11MB4484.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:3;A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /4Prz7fxOWPZiqVXhlh2jsLixluOiLSOn7xZU5gQ+R7IKoqvaWgDMgyFRrcvnaumGr3sAHHxX4fGcdhFt7sdPu/glUur4I1Njo6SpHvVo1OKa3eAxZTB56+JLYY1lYv953XKtyE26Q5DqYYESbMGD/0H8BvmebhBHhXxMWcn6zW6itwpKzjdhvNYXf/2PMaHhwlrN6mPUHFZJqz/H/PQHm4HdAJYFpUofsMWpv8d7xVzSToisMToi603ES2Abc9xWQ6Og0kUtcIW2W2T+n//Qe7M4O/ouBllg3gbMFQjpEqtlfemquFGWlaKy4Ng15X18R5CR0OlZ7l6TKKQ1YGtJ05Ol+1a4Ar2fpQ1ja5eZgt0XRp1GOuSOfPZm5kvkY2xkZN1i6QONfM8clesqtFkRmhSlzG+pkpb6KMrMqlWMVJi+nCgpuAHTZrfMYyMsocPk1YVxN7JGUxHrJS1yf2vBrGP/EIPKlZ/zhIg1aUYMv8= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 2770ebbb-45d4-4ca7-1d27-08d76153702b X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Nov 2019 18:18:48.6888 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: P2TiB1ucRNNfwNE29ZYdVhs35MK4nKRS/drH62LrboWQ7NVtZifOA/tdZADbh57MuBbdxHr1NIGLgQm0m1AWzW7xqwXdjSwp9+T9z6v6rKA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB3926 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Prince, There's some high-level changes I suggest to the patch series: 1. This patch series mixes changes across packages in single patches which should be avoided. 2. Some of the patches include unrelated changes that would make git revert difficult. 2.a. Example: In patch #1, one change is to add gBoardModulePkgTokenSpaceGuid. This is a pre-requisite for adding the PCDs to BoardModulePkg.dec but still an isolated change. If someone were to add more commits in the future that rely upon gBoardModulePkgTokenSpaceGuid and then wanted to revert the PS/2 keyboard change it would be difficult due to the coupling. 2.b. Example: In patch #3, a change is made that affects all driver consumers in BoardModulePkg/LegacySioDxe but the commit includes changes for enabling the driver in SimicsOpenBoardPkg. The change to enable PS/2 keyboard/mouse in SimicsOpenBoardPkg could not easily be reverted without affecting the overall driver. 3. The order of changes leaves some earlier commits incomplete. 3.a. For example, patch #1 exposes a PCD interface in BoardModulePkg that is effectively not used until later patches so using the PCDs at that point in the commit log would be misleading. As far as I can tell, there's a high-level order to do the following: 1. Define gBoardModulePkgTokenSpaceGuid in BoardModulePkg.dec 2. Remove the LegacySioDxe driver from SimicsOpenBoardPkg 3. Add the LegacySioDxe driver to BoardModulePkg 4. Add new PCDs to BoardModulePkg for usage with LegacySioDxe 5. Update relevant boards in KabylakeOpenBoardPkg to use the LegacySioDxe driver and PCDs from BoardModulePkg, remove the now redundant PCD gKabylakeOpenBoardPkgTokenSpaceGuid.PcdPs2KbMsEnable in KabylakeOpenBoardPkg/OpenBoardPkg.dec, configure the relevant PCDs in BoardModulePkg in the board DSC files to properly use the LegacySioDxe driver. 6. Add the Ps2KbcLib changes in KabylakeOpenBoardPkg as currently done in V1 patches #4 and #5. 7. Do the same as #5 for SimicsOpenBoardPkg. 8. Explicitly set gBoardModulePkgTokenSpaceGuid.PcdPs2KbMsEnable in WhiskeylakeOpenBoardPkg/WhiskeylakeURvp. Thanks, Michael > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > Agyeman, Prince > Sent: Friday, November 1, 2019 12:51 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [edk2-platforms] [PATCH 0/5] Enable Ps2 keyboard >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2228 >=20 > This patch series enables BIOS Ps2 keyboard in GalagoPro3 >=20 >=20 > What was done: > Patch 0001 adds PCDs to BoardModulePkg that will enable/disable, describ= e > Super I/O , Ps2 keyboard/mouse, uart1 and uart2 com ports >=20 > Patch 0002 moves the generic Super I/O driver from SimicsOpenBoardPkg to > BoardModulePkg in order for it to be shared. This driver publishes the > gEfiSioProtocolGuid consumed by edk2's > MdeModulePkg/Bus/Isa/Ps2KeyboardDxe > driver to enable Ps2 keyboard functions in BIOS >=20 > Patch 0003 adds PCDs defined in patch 0001 to enable/disable devices in = the > Super I/O driver added in patch 0002 >=20 > Patch 0004 adds a Null Ps2 Library that adds Ps2 keyboard device path to > ConIn and ConInDev >=20 > Patch 0005 enables Ps2 keyboard in BIOS by setting Ps2 keyboard related > PCDs Prince Agyeman (5): > Platform/Intel: Add gBoardModulePkgTokenSpaceGuid > Platform/Intel: Move Sio Dxe Driver > BoardModulePkg: Added Pcds Sio Driver > KabylakeOpenBoardPkg: Add Ps2 keyboard Null Library > KabylakeOpenBoardPkg: Add Ps2 Keyboard Support >=20 > .../Intel/BoardModulePkg/BoardModulePkg.dec | 25 +++ > .../Intel/BoardModulePkg/BoardModulePkg.dsc | 1 + > .../LegacySioDxe/ComponentName.c | 0 > .../LegacySioDxe/ComponentName.h | 0 > .../LegacySioDxe/LegacySioDxe.inf | 18 +- > .../LegacySioDxe/Register.h | 0 > .../LegacySioDxe/SioChip.c | 71 +++++- > .../LegacySioDxe/SioChip.h | 18 +- > .../LegacySioDxe/SioDriver.c | 42 +++- > .../LegacySioDxe/SioDriver.h | 1 - > .../LegacySioDxe/SioService.c | 0 > .../LegacySioDxe/SioService.h | 0 > .../BoardAcpiLib/DxeBoardAcpiTableLib.inf | 3 +- > .../DxeMultiBoardAcpiSupportLib.inf | 3 +- > .../GalagoPro3/Library/Ps2KbcLib/Ps2KbcLib.c | 202 ++++++++++++++++++ > .../GalagoPro3/Library/Ps2KbcLib/Ps2KbcLib.h | 65 ++++++ > .../Library/Ps2KbcLib/Ps2KbcLib.inf | 39 ++++ > .../GalagoPro3/OpenBoardPkg.dsc | 7 + > .../GalagoPro3/OpenBoardPkg.fdf | 2 + > .../GalagoPro3/OpenBoardPkgPcd.dsc | 6 + > .../BoardAcpiLib/DxeBoardAcpiTableLib.inf | 3 +- > .../DxeMultiBoardAcpiSupportLib.inf | 3 +- > .../KabylakeRvp3/OpenBoardPkgPcd.dsc | 5 + > .../KabylakeOpenBoardPkg/OpenBoardPkg.dec | 2 - > .../BoardX58Ich10/OpenBoardPkg.dsc | 2 +- > .../BoardX58Ich10/OpenBoardPkg.fdf | 2 +- > .../BoardX58Ich10/OpenBoardPkgPcd.dsc | 6 + > .../WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec | 1 - > .../WhiskeylakeURvp/OpenBoardPkgPcd.dsc | 5 + > 29 files changed, 499 insertions(+), 33 deletions(-) rename > Platform/Intel/{SimicsOpenBoardPkg =3D> > BoardModulePkg}/LegacySioDxe/ComponentName.c (100%) rename > Platform/Intel/{SimicsOpenBoardPkg =3D> > BoardModulePkg}/LegacySioDxe/ComponentName.h (100%) rename > Platform/Intel/{SimicsOpenBoardPkg =3D> > BoardModulePkg}/LegacySioDxe/LegacySioDxe.inf (63%) rename > Platform/Intel/{SimicsOpenBoardPkg =3D> > BoardModulePkg}/LegacySioDxe/Register.h (100%) rename > Platform/Intel/{SimicsOpenBoardPkg =3D> > BoardModulePkg}/LegacySioDxe/SioChip.c (75%) rename > Platform/Intel/{SimicsOpenBoardPkg =3D> > BoardModulePkg}/LegacySioDxe/SioChip.h (90%) rename > Platform/Intel/{SimicsOpenBoardPkg =3D> > BoardModulePkg}/LegacySioDxe/SioDriver.c (88%) rename > Platform/Intel/{SimicsOpenBoardPkg =3D> > BoardModulePkg}/LegacySioDxe/SioDriver.h (95%) rename > Platform/Intel/{SimicsOpenBoardPkg =3D> > BoardModulePkg}/LegacySioDxe/SioService.c (100%) rename > Platform/Intel/{SimicsOpenBoardPkg =3D> > BoardModulePkg}/LegacySioDxe/SioService.h (100%) create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/Ps2KbcLib/Ps2K > bcLib.c > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/Ps2KbcLib/Ps2K > bcLib.h > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/Ps2KbcLib/Ps2K > bcLib.inf >=20 > -- > 2.19.1.windows.1 >=20 >=20 >=20