From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.3238.1574404317220843056 for ; Thu, 21 Nov 2019 22:31:57 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=RqiNIUTm; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: michael.a.kubacki@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2019 22:31:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,228,1571727600"; d="scan'208";a="201406109" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga008.jf.intel.com with ESMTP; 21 Nov 2019 22:31:54 -0800 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 21 Nov 2019 22:31:56 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 21 Nov 2019 22:31:55 -0800 Received: from NAM05-DM3-obe.outbound.protection.outlook.com (104.47.49.52) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 21 Nov 2019 22:31:55 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kPiL3Xz5I1MHVdXyQ27U95iYt7G6SPZu8zhGHpWjCnwediiepKsjqHUMxYQvSm8NuoyYGGmgThGbpTCE94GbG1cFDhaMDoNP23MDk0yGbx/EvfY10jhf3BG6feYjiQKHM6jYxNGsjwpR+RY3GHAlajAZ0lUE00Js+oeceXyslwd0T/F60EqDkZ9Svk04ewa4GRud2BO9Ji7BgRORk6jtHLrIW4oy2/01m2vShrKPhJwGT/AGW+pjigOxp/h5qHo7KVQr+6TViJFq/8zvXLVp+485K6Nf3oXVkWmhHUowUONNNV5I58/7TJ9h69BoF+5lLYxc12VWaMGUvcCZbd654A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kgnkOPf7MoHL1kKJmaJx2pTPW1IT43WpkmkZM7Kox7w=; b=TDsiOY8ZrI9vevsyLrbvC2ua+qCJVHlfcKEDU2xkczmIiDWMalBioMgCn1bcnk1XTzIjnS0HwxlHqYqNDM5dwClpvrC//RnHb7ohvWI9a1cGClrmohWdr+vBskjbIbULiPz7f4v0+emjQX7CYMPF9sFqVdAXOmEui1mK8xeEHr8PfoxHJnI5uc+yP6Jif100uUKJW1oz+ustDT/IFQT4NSXJL5fcxqOCtmKdTfcOo42As/0WzKRlDmpEIb1URCb/iOglEGJAEFXm7yA792dzRxNq+7EU/ndR8C4tlRM2IB+/HYTT2oFypQQeV9yljots5298ezLYyLLEYvrN84F6fw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kgnkOPf7MoHL1kKJmaJx2pTPW1IT43WpkmkZM7Kox7w=; b=RqiNIUTmpheMmptlyf6TUTnkzH5e/NECpcJr2Y1nvYTgj5t38ja8Ia5wdXkLcbJEXgsM2o4l3f9Ul/4x11yVIhgQA6OBlAFU8BaCaPHP3tbd5LzMPuUBlAIN2OasNoEVMsWAcJO4IiLEb3oZBStaXsNzMRxlTyuzbi6xBnVcjC4= Received: from BY5PR11MB4484.namprd11.prod.outlook.com (52.132.254.155) by BY5PR11MB4053.namprd11.prod.outlook.com (10.255.72.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.19; Fri, 22 Nov 2019 06:31:52 +0000 Received: from BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::a114:604b:7ca3:5420]) by BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::a114:604b:7ca3:5420%7]) with mapi id 15.20.2474.019; Fri, 22 Nov 2019 06:31:52 +0000 From: "Kubacki, Michael A" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Chaganty, Rangasai V" Subject: Re: [edk2-platforms] [PATCH V2 01/14] KabylakeSiliconPkg: Change MODULE_TYPE of SiliconInitLib to PEIM Thread-Topic: [edk2-platforms] [PATCH V2 01/14] KabylakeSiliconPkg: Change MODULE_TYPE of SiliconInitLib to PEIM Thread-Index: AQHVoEoI9r6UkbmHg0ur4K/2lPsZIKeWt3Uw Date: Fri, 22 Nov 2019 06:31:51 +0000 Message-ID: References: <20191121085853.2626-1-nathaniel.l.desimone@intel.com> <20191121085853.2626-2-nathaniel.l.desimone@intel.com> In-Reply-To: <20191121085853.2626-2-nathaniel.l.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmVhZjU2ZWYtM2FkZC00NTVlLTljMWItYmRlMGZmNzU1YWYwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiV25JUGVUSktmM3oyUnRjenFNcVBURXpmcEowdnlmOCtzOWpMVllsUFdtUGlxSWxlaXNGY2ZIU3Y3QWFDQ1hDViJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cad05aef-b79e-4395-9b5d-08d76f15a93e x-ms-traffictypediagnostic: BY5PR11MB4053: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3383; x-forefront-prvs: 02296943FF x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(376002)(346002)(136003)(396003)(39860400002)(199004)(189003)(13464003)(71200400001)(71190400001)(14454004)(25786009)(2501003)(52536014)(33656002)(5660300002)(478600001)(54906003)(186003)(7696005)(55016002)(4326008)(6246003)(316002)(99286004)(110136005)(6436002)(66066001)(102836004)(9686003)(6506007)(86362001)(6116002)(76116006)(7736002)(76176011)(3846002)(26005)(229853002)(81156014)(446003)(81166006)(66476007)(8676002)(8936002)(107886003)(256004)(11346002)(66946007)(305945005)(74316002)(66446008)(64756008)(53546011)(66556008)(2906002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY5PR11MB4053;H:BY5PR11MB4484.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CFqrYkOjU853XawGGivLFdoWw15oQGZZmsKonLjRXoxX+7jSHQV7YYoRlolNP434eP/TtaFEpSO6p3MHrUPMBr3/tl/fY6W5/fXCZ4ZA5U90lR+yzFGUVlthy9LrDVAsY1YTtt314EWXex9ayRCO2MJwnguPiCTw1RSYaj7CcD1I4USenBlDDQCUuCy6IHWgBbqo4aMzIQP3c6NQ/l+cR/YRs6a4oztDcANikmM7iOZDAbPkfFXoHDhQXXmh2A98SEBZS3lE+xwhxOPsdATTFjpt1Xv0mcmKb+AKn4clA5T99k7nkgvYfjaK/Ez8oXWdVdgbdT38NhM9nEvYGu13/arjk2cPUZLQTIt34+M/kmGkCQRKNK/B+0SKspSUPDMlErHLlvquk934qmw83WlnD2uQoxEpLAhi8POicxJT8w5Nud1hx366FGfn2h8LXQ+S MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: cad05aef-b79e-4395-9b5d-08d76f15a93e X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2019 06:31:51.9124 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: m2QGyRRduYuSjUHSKLR6npd+kh1TJardukhl9T6U8pDmG54q5mpWhIpZfvTrvkat2CBi4/vjfUzY7+Tca9kkpOD9MNCPHargfGoCVuO816I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4053 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Michael Kubacki > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Thursday, November 21, 2019 12:59 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Chaganty, Rangasai V > > Subject: [edk2-platforms] [PATCH V2 01/14] KabylakeSiliconPkg: Change > MODULE_TYPE of SiliconInitLib to PEIM >=20 > This library contains PEI phase only code. For example, > ClearIchSmiAndWake() calls PeiServicesGetBootMode(). > Accordingly, this library should have never been marked as a BASE library= . >=20 > Cc: Chasel Chiu > Cc: Michael Kubacki > Cc: Sai Chaganty > Signed-off-by: Nate DeSimone > --- > .../PeiSiliconInitLib.inf} | 5 +++-- > .../{SiliconInitLib =3D> PeiSiliconInitLib}/SiliconInit.c | 0 > .../SiliconInitPreMem.c | 0 > 3 files changed, 3 insertions(+), 2 deletions(-) rename > Silicon/Intel/KabylakeSiliconPkg/Library/{SiliconInitLib/SiliconInitLib.i= nf =3D> > PeiSiliconInitLib/PeiSiliconInitLib.inf} (86%) rename > Silicon/Intel/KabylakeSiliconPkg/Library/{SiliconInitLib =3D> > PeiSiliconInitLib}/SiliconInit.c (100%) rename > Silicon/Intel/KabylakeSiliconPkg/Library/{SiliconInitLib =3D> > PeiSiliconInitLib}/SiliconInitPreMem.c (100%) >=20 > diff --git > a/Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInitLib.= inf > b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/PeiSiliconIn= itLib.in > f > similarity index 86% > rename from > Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInitLib.in= f > rename to > Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/PeiSiliconInit= Lib.inf > index 132080e876..bd77b081e5 100644 > --- a/Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInit= Lib.inf > +++ b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/PeiSili > +++ conInitLib.inf > @@ -11,8 +11,9 @@ > BASE_NAME =3D SiliconInitLib FILE_GUID = =3D 72CD3A7B- > FEA5-4F5E-9165-4DD12187BB13 VERSION_STRING =3D 1.0- > MODULE_TYPE =3D BASE- LIBRARY_CLASS = =3D SiliconInitLib+ > MODULE_TYPE =3D PEIM+ LIBRARY_CLASS = =3D > SiliconInitLib|SEC PEIM+ # # The following information is for reference o= nly > and not required by the build tools. #diff --git > a/Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInit.c > b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInit.= c > similarity index 100% > rename from > Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInit.c > rename to > Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInit.c > diff --git > a/Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInitPreM= em.c > b/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitP= reMe > m.c > similarity index 100% > rename from > Silicon/Intel/KabylakeSiliconPkg/Library/SiliconInitLib/SiliconInitPreMem= .c > rename to > Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitPre= Mem.c > -- > 2.24.0.windows.2