From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com []) by mx.groups.io with SMTP id smtpd.web09.3232.1574404374518397508 for ; Thu, 21 Nov 2019 22:32:56 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=WR5Bd8zV; spf=fail (domain: intel.com, ip: , mailfrom: michael.a.kubacki@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2019 22:32:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,228,1571727600"; d="scan'208";a="210343257" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga006.jf.intel.com with ESMTP; 21 Nov 2019 22:32:55 -0800 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 21 Nov 2019 22:32:54 -0800 Received: from NAM05-DM3-obe.outbound.protection.outlook.com (104.47.49.56) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 21 Nov 2019 22:32:55 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A4M8Tfvs8DBXKumGS1qLF3bdRsoGmrRYS4N91mNj/R1DaVtXM6Cr3A1yIeGiqpf5iOnfvYJ3rLIo1NWqHxtnMsdmG1axjLzUTc5RupaIAgX5vLcOa9QfADnVGG/Zdcb4pyNp5fARnP4TLctzBs/1FCBZfUhpXlkzV3Xyu5KaPZJMCeI1i1mUE/UwaXPw+OzO8VjYroFEV6p9CLMrcEE/uzykRrMCmaDvN5ak53XhkIRkY5IrDYODS/baPqE1Z8Rg1+D9FpMtYkc1NMPFl8gsp6nimCnx3mrD1EvM1JAgd0JbMmtNUjj3cF1Dg/dcLOcnWp3GfEWRzCDQm2OsR7PqUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1sAJkM95nkHOP399HOe3ROMFwNzMAXo/4aG417YIbHY=; b=mxddKy0yuItfFIlGGOGTHIBiWOY7DGoqUBCSFKW5b39Rn9gf65riw2cNkbcszSUnKlWjOWAr5jbgmQSQmbB06MhgcQWiAQsYn/G6XVyg/eiO1NH3j7Z78Wx6oXn28U7mIe6Q9I1EBEUfBjXMMZUUR1vt+XvusMn1OqI7dAU8/WPyK77+ARvbcTbyHIdZQv4u24/4LiVrBNJohjl2kTAH6IFArpF+jX4RNPMUVtSl/uTAoZ86HCM86+HGp97esLKMcGxmhRqqJtiQM8vR34lWEOq2MEcwNKEI7tYQQpPLbkWNnwTey/I409ifRoR79J/RCEg3V1X4dp4rCNoaikIYaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1sAJkM95nkHOP399HOe3ROMFwNzMAXo/4aG417YIbHY=; b=WR5Bd8zVZC3SvIWnh4qaMrugsz9rhtjbT5kPadAgpjgzI44GEGNUNkjdALEh281FgIFXmMuWkrgn8hKLzjixRBZAnCEPohgNk9O0mCrJcoevjPtG5g0KEBiswjg/M8+OkhThe7BpVz2F46xplVU1/birReQKMJjkk18vcPS5T9E= Received: from BY5PR11MB4484.namprd11.prod.outlook.com (52.132.254.155) by BY5PR11MB4053.namprd11.prod.outlook.com (10.255.72.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2474.19; Fri, 22 Nov 2019 06:32:53 +0000 Received: from BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::a114:604b:7ca3:5420]) by BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::a114:604b:7ca3:5420%7]) with mapi id 15.20.2474.019; Fri, 22 Nov 2019 06:32:53 +0000 From: "Kubacki, Michael A" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Chiu, Chasel" Subject: Re: [edk2-platforms] [PATCH V2 12/14] KabylakeOpenBoardPkg: Add support for PcdFspDispatchModeUseFspPeiMain Thread-Topic: [edk2-platforms] [PATCH V2 12/14] KabylakeOpenBoardPkg: Add support for PcdFspDispatchModeUseFspPeiMain Thread-Index: AQHVoEoKkoeyOrI0PkGsj92OFKTMwKeWt/1A Date: Fri, 22 Nov 2019 06:32:53 +0000 Message-ID: References: <20191121085853.2626-1-nathaniel.l.desimone@intel.com> <20191121085853.2626-13-nathaniel.l.desimone@intel.com> In-Reply-To: <20191121085853.2626-13-nathaniel.l.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTljOGZmN2UtOGE2Zi00MjI4LWJkYjAtY2EwNGE0NjgwMzJhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiXC92MDBoZjNjNzhBVDdIQ2plZUxyUHM3b3RFWGhEUmNCd3NKYml3b0xqcEliRlVIcUNNcnRvNktMODhSZmtHVHgifQ== dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3dddef67-0921-4e1d-9295-08d76f15cdd8 x-ms-traffictypediagnostic: BY5PR11MB4053: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-forefront-prvs: 02296943FF x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(1496009)(396003)(136003)(366004)(346002)(376002)(39860400002)(13464003)(189003)(199004)(3846002)(26005)(7736002)(76176011)(76116006)(229853002)(66066001)(102836004)(9686003)(6116002)(86362001)(6506007)(305945005)(66946007)(11346002)(14444005)(256004)(64756008)(66446008)(2906002)(66556008)(53546011)(74316002)(8676002)(8936002)(19627235002)(66476007)(81166006)(446003)(81156014)(107886003)(6436002)(25786009)(52536014)(2501003)(14454004)(71200400001)(71190400001)(7696005)(186003)(55016002)(4326008)(316002)(110136005)(99286004)(6246003)(33656002)(5660300002)(508600001)(156123004)(213903007);DIR:OUT;SFP:1102;SCL:1;SRVR:BY5PR11MB4053;H:BY5PR11MB4484.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oAe5tuJzGRmrGEaTX6MI8bBGJt/9FTj10Pj4CFKZT7vjwX7x8nRuIpamcouGKOxUtzzflc8sBZqNf+zCrE5H9aVUR0olGMAl1x4PISfre0X5bw+VlTw3RZ2Ajy39PoLbuCAJmtzyvlmB993B7rYbVAM45f4V/J/l/7PjlTneQUmH6+zCV40+TOWn/N0mmeXbzPwekS1ykuU7d9BdOAB/YLJuF5esQmK5XjVhgdZjjBu6gbnx/gX1M6SmsgeIJz0NM3kBTiB8eqEk0RXWGM1KYP/UgVRZYIHfkfcwHT/dMyOCsHEloZD/2eC7ToWI3rUAwVi10lwHfYIt4o+zsisdkeGOJ4uH5cGVtWXSOHpIsV8kE09BdbaqrD/DV+6M65NeFF/EnppKIGf+hurJ86OsDV2ykl2uvPZcUM63su+CIfyvYJfOnsyUm2Pe8aeR4cQP MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 3dddef67-0921-4e1d-9295-08d76f15cdd8 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2019 06:32:53.3534 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0FyZNXDHuUs7zsgRcFj+nWBgK+oqRtjWvXPn6Xcd8XBsV/RAZ0P4Rq8V0+rmo/16TdNY6YpH1G5CfJpgZPFZa6ijrBqFC1BgS8yEYVl0Wv8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4053 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Michael Kubacki > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Thursday, November 21, 2019 12:59 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > > Subject: [edk2-platforms] [PATCH V2 12/14] KabylakeOpenBoardPkg: Add > support for PcdFspDispatchModeUseFspPeiMain >=20 > If PcdFspDispatchModeUseFspPeiMain is FALSE, then the BoardPkg should > include PeiMain in FvPreMemory. >=20 > Cc: Chasel Chiu > Cc: Michael Kubacki > Signed-off-by: Nate DeSimone > --- > .../KabylakeRvp3/OpenBoardPkg.fdf | 5 +++-- > .../KabylakeRvp3/OpenBoardPkgPcd.dsc | 20 +++++++++++++++++++ > 2 files changed, 23 insertions(+), 2 deletions(-) >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > index 98eb7dcb5a..3b3b153b68 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > @@ -229,10 +229,11 @@ READ_LOCK_STATUS =3D TRUE > FvNameGuid =3D FC8FE6B5-CD9B-411E-BD8F-31824D0CDE3D INF > UefiCpuPkg/SecCore/SecCore.inf-!if > (gMinPlatformPkgTokenSpaceGuid.PcdFspWrapperBootMode =3D=3D FALSE) || > (gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection =3D=3D 1)+!if > (gMinPlatformPkgTokenSpaceGuid.PcdFspWrapperBootMode =3D=3D FALSE) || > (gMinPlatformPkgTokenSpaceGuid.PcdFspDispatchModeUseFspPeiMain =3D=3D > FALSE) || (gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection =3D=3D 1) > # # PeiMain is needed only for FSP API mode or EDK2 build,-# in FSP dispa= tch > mode the one inside FSP Binary is launched.+# in FSP dispatch mode the on= e > inside FSP Binary is launched+# unless requested otherwise > (PcdFspDispatchModeUseFspPeiMain =3D=3D FALSE). # INF > MdeModulePkg/Core/Pei/PeiMain.inf !endifdiff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd. > dsc > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd. > dsc > index 580504cbc1..5474edd01c 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd. > dsc > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd. > d > +++ sc > @@ -39,6 +39,26 @@ > # gMinPlatformPkgTokenSpaceGuid.PcdFspWrapperBootMode|TRUE + > #+ # FALSE: The PEI Main included in FvPreMemory is used to dispatch all > PEIMs+ # (both inside FSP and outside FSP).+ # Pros:+ # = * PEI > Main is re-built from source and is always the latest version+ # = * > Platform code can link any desired LibraryClass to PEI Main+ # = (Ex: > Custom DebugLib instance, SerialPortLib, etc.)+ # Cons:+ # = * The PEI > Main being used to execute FSP PEIMs is not the PEI Main+ # t= hat the > FSP PEIMs were tested with, adding risk of breakage.+ # * Two c= opies of > PEI Main will exist in the final binary,+ # #1 in FSP-M, #2 i= n > FvPreMemory. The copy in FSP-M is never+ # executed, wasting > space.+ #+ # TRUE: The PEI Main included in FSP is used to disp= atch > all PEIMs+ # (both inside FSP and outside FSP). PEI Main will not= be > included in+ # FvPreMemory. This is the default and is the recomm= ended > choice.+ #+ > gMinPlatformPkgTokenSpaceGuid.PcdFspDispatchModeUseFspPeiMain|TR > UE+ # # FSP Base address PCD will be updated in FDF basing on flash m= ap. > #-- > 2.24.0.windows.2