From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.1160.1573087816669698340 for ; Wed, 06 Nov 2019 16:50:16 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=U0WbMPHw; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: michael.a.kubacki@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2019 16:50:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,276,1569308400"; d="scan'208";a="205513692" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by orsmga003.jf.intel.com with ESMTP; 06 Nov 2019 16:50:16 -0800 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 Nov 2019 16:50:15 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.57) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 Nov 2019 16:50:15 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cPKVJyUxjKSQxwa2q76e9OAv/94fJEE1ShC8Ym5H6hWl7ase+1TQ3PU6HAUiT3GSOFArxfxrDA2a9T8MpQOKZgDhocXs/N29qGPc5L1tOWK1+XXUf+pLr5CKKiziDf1qyeD1fUdWlA3mEoUkyIvR/Qhc+0auVCh3GeJjfA4anDWaW2ulJb43HsyxqdXcoHKnY/7JM8hmawg5QVBF5eHPsOy2Tn/Zm+l+TuNRaEVwskV11aO1nqE5llbVMxLpiXQftWMhgIsaRvY2dKwmyYl80hKKfknLey8xNCJPj0TMaDF7/swRS9ILUsGcy8kN/yHfK1SwkfCdmmHam8QIwxAMEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+9Yk3Bm7soDxqh391UBtmcmirr3WxmpIK9TIjMCUwEQ=; b=FVuZM8FTXMZEZvFwOr2IpOTOGwal2yXobuEKGh9/Xw/sOpljk0T9nPTWY+RjKynPAvh0emECiUfIOXVoKSrHjexHLBTy3zA8sHOkvB1A89ccHMSAE2KMMy3uSkjeJFg9Vmat6NkKNVyHwTHPJiUUnyUzdsgYYxk182kBGNgNJiVZrhKTmritSKCh/tJEqDeGNNGACWeSQE4F3RDZnoXYKdOT1BO0j6l8QpdnIM/3aHbZ3Km0Z6iynC6YAOdeAbaZgrggtY2WTY9xmTLHTYxOt90tgErf7XgdAPalR0/g1fErBQbqRIn0s4j+EhzGouBXCHe/IQHosLi8BuBZhMr5RA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+9Yk3Bm7soDxqh391UBtmcmirr3WxmpIK9TIjMCUwEQ=; b=U0WbMPHwssvtU91gvYnXgd47Yy6cUkSV77xxsl2fdpx/4Pgy62zEeyKqNbLb5p18tvYxL9J1YWmxxdgzgh+mLtQrGc+g4SrPOU5kSpnCVuteBgpEK8wFVQUnvLUtnrodrk4qciACyl5kveTu9B12qLcTvr2nUuu3unjgnFaNezs= Received: from BY5PR11MB4484.namprd11.prod.outlook.com (52.132.254.155) by BY5PR11MB3976.namprd11.prod.outlook.com (10.255.160.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.24; Thu, 7 Nov 2019 00:50:13 +0000 Received: from BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::c1ef:6e0b:90c8:55e2]) by BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::c1ef:6e0b:90c8:55e2%7]) with mapi id 15.20.2430.020; Thu, 7 Nov 2019 00:50:13 +0000 From: "Kubacki, Michael A" To: "Agyeman, Prince" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" Subject: Re: [edk2-platforms] [Patch v2 8/9] SimicsOpenBoardPkg: Add Ps2 keyboard Support Thread-Topic: [edk2-platforms] [Patch v2 8/9] SimicsOpenBoardPkg: Add Ps2 keyboard Support Thread-Index: AQHVlEE3FByeBoyLTEWFLznRbd2/f6d+29Jg Date: Thu, 7 Nov 2019 00:50:13 +0000 Message-ID: References: <20191106012603.4724-1-prince.agyeman@intel.com> <20191106012603.4724-9-prince.agyeman@intel.com> In-Reply-To: <20191106012603.4724-9-prince.agyeman@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2JmYzI3NGItOWRlOC00MDY2LTk4NjMtY2FiNDcxZDEzMjlmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQzJrM01WVVdKS2pCUVc2RVBSYThnTGttbFMyUmd4eUJIN0hPdm53V1Q1SFZqVW9RRFNyQVwvSmJSZGFKTFwvS1lZIn0= dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8f25567f-bf64-4cec-e488-08d7631c7302 x-ms-traffictypediagnostic: BY5PR11MB3976: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:256; x-forefront-prvs: 0214EB3F68 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(1496009)(39860400002)(136003)(376002)(396003)(346002)(366004)(13464003)(199004)(189003)(486006)(11346002)(6436002)(305945005)(66066001)(55016002)(6246003)(2501003)(14454004)(2906002)(4326008)(86362001)(6116002)(3846002)(33656002)(110136005)(7736002)(71190400001)(478600001)(25786009)(99286004)(446003)(8676002)(107886003)(52536014)(81166006)(81156014)(8936002)(54906003)(9686003)(316002)(256004)(66946007)(53546011)(66446008)(6506007)(64756008)(26005)(66556008)(7696005)(74316002)(76176011)(102836004)(476003)(186003)(71200400001)(66476007)(76116006)(229853002)(5660300002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY5PR11MB3976;H:BY5PR11MB4484.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5fTU72A1BcJ/lnaeTIH05BbHY5MFu2r68T8p3LNNA52H0dbZ5uOBX0BRw70jxfIoivil4GVMqJT3OTxCKGSeMVmP0x57l9oa87RKEAmsOOxZm+nxdR0ZXESHuhdzSQECW9p92veOwQ+87jmcJpZbIIOyScr6YooLyUbS8F1QjqRISF52NJGTpfyp49EbuUKfCO7fw1mqzv4sjG7DFl05xbpCpvA+BUsk0XZOYK/+yD+mDWAdrA17jPFdsPjHFVkMqX3Fs+c5apBKzRIUtazF+3ILQy1+8kJ0kRHDcsAZOsTWlWsg88R6CKFAH9CdSD6JNhLqk7TtZO779+zDZ4OTXOeLCcXlwrgIfSZeWlgd60F9QXk5kOXKn7mvTLpFtbipeLM1XYvBBt0jv2qVvgZqtmSJK7/fXmzNQKLa4XEx1O3dTtNBS8XuWqXosstCkuxZ MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 8f25567f-bf64-4cec-e488-08d7631c7302 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Nov 2019 00:50:13.3979 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7GUPuuNKexNNG6gEjwm/0y/6x31wRbROfubA7Mab/nk0mPTuuulJCDlbeF3r41b/ncn4mTnCR2ms03bJST9zvSUji7772c5N+L/KgUEhsHM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB3976 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Michael Kubacki > -----Original Message----- > From: Agyeman, Prince > Sent: Tuesday, November 5, 2019 5:26 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject: [edk2-platforms] [Patch v2 8/9] SimicsOpenBoardPkg: Add Ps2 > keyboard Support >=20 > Added BIOS keyboard support to BoardX58Ich10 >=20 > * Included BoardModulePkg's generic Super I/O DXE driver > * Configured Super I/O and Ps2 keyboard related PCD to enable Ps2 > keyboard >=20 > Cc: Michael Kubacki > Cc: Chasel Chiu > Cc: Nate DeSimone >=20 > Signed-off-by: Prince Agyeman > --- > .../Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 2 ++ > .../Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf | 1 + > .../SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc | 6 ++++++ > 3 files changed, 9 insertions(+) >=20 > diff --git > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > index e0a02b4efc..7329b19e8e 100644 > --- > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > +++ > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc > @@ -283,3 +283,5 @@ > $(BOARD_PKG)/SimicsDxe/SimicsDxe.inf > $(BOARD_PKG)/SimicsVideoDxe/SimicsVideoDxe.inf > $(BOARD_PKG)/SmbiosPlatformDxe/SmbiosPlatformDxe.inf > + BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > + > diff --git > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf > index 6dc7b4aa56..ef6b35c92f 100644 > --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf > +++ > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf > @@ -212,6 +212,7 @@ INF > MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf > INF MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf > INF MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf > INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > +INF BoardModulePkg/LegacySioDxe/LegacySioDxe.inf >=20 > INF MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf >=20 > diff --git > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.ds > c > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.ds > c > index 0298e4b12d..cd95755f91 100644 > --- > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.ds > c > +++ > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.ds > +++ c > @@ -196,6 +196,12 @@ > gMinPlatformPkgTokenSpaceGuid.PcdMaxCpuThreadCount|4 > gMinPlatformPkgTokenSpaceGuid.PcdPcIoApicAddressBase|0xFEC01000 >=20 > + ###################################### > + # Board Configuration > + ###################################### > + gBoardModulePkgTokenSpaceGuid.PcdPs2KbMsEnable|1 > + gBoardModulePkgTokenSpaceGuid.PcdSuperIoPciIsaBridgeDevice|{0x00, > + 0x00, 0x1F, 0x00} > + > [PcdsFixedAtBuild.X64] > ###################################### > # Edk2 Configuration > -- > 2.19.1.windows.1