From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.9290.1572891588455791128 for ; Mon, 04 Nov 2019 10:19:48 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=VaGyNKM8; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: michael.a.kubacki@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Nov 2019 10:19:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,267,1569308400"; d="scan'208";a="403058348" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by fmsmga006.fm.intel.com with ESMTP; 04 Nov 2019 10:19:47 -0800 Received: from orsmsx121.amr.corp.intel.com (10.22.225.226) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 4 Nov 2019 10:19:47 -0800 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX121.amr.corp.intel.com (10.22.225.226) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 4 Nov 2019 10:19:47 -0800 Received: from NAM03-DM3-obe.outbound.protection.outlook.com (104.47.41.52) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 4 Nov 2019 10:19:47 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oYdbdkZTwmkdK09WZgZRFQ6VCZ7wkMsg+pDoT4Vo/JQy8wEc60o360d0tGVWuTWOqM4iy8lChsU2ayx6+/pTuwe//JQLKXVwwi9mCaB5tBi3N7FWybyprYOO0WnlQGUHWtancLMus/kE0A7aDJ5NsKBBwm+D++rwPi4P6Isb3F6VFPzlt8TyWa4SD6cJ2T7SBZ3vdzy8tSNYMMDcG4unqX28moaZWdcsgMnwJqMAt5mQ3ebmQsLqAA4MejyYLWBawkH9jZp7eQI5nsaY+16aCjvGh62gPAHo2k5L6U+rjG60NG7bBC255PJ7U+0LL3o4dYDqgTeXuEMGGRAc/nsOBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fwWgC9pwPkHrRqCoVHJiGCSAH9/+jwBv8dy2+Th6W4w=; b=XRLwRtcs/YE925ZW3JuakUS4qGu0ijoTOXKKOLMy5vO6Kl7qBoUexxsJ6MyxswZLYs6Xa/m/ZujZD+FAcfJB4kkBjr4RFpCTkTCksJ6frdIapkYypFqjX/e+63J3TvM7e1ZIiikW47PbT1B9A93ud7WSJGZW+eAGxnocWL5vtMEgHPN9DP3g7cO1vCs+XS+X8aEqDiAvYfjQhRAynxn0t/j4/OlBm3ipqXLvbMm7zKRq7ohNviTWkqhliETuL+tqMhrXyR0ep95ER0sBUkWX3Z0snHaUvRFRJ0dRxG/iwIrjqneumbyJoTGzO/LUSBn4bmoZAZNv8158nK0Zf5wkAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fwWgC9pwPkHrRqCoVHJiGCSAH9/+jwBv8dy2+Th6W4w=; b=VaGyNKM88Vag/cImfxYMTSnzwOpjEpfqT5YoWUiw6HpIy3t4nEN0BgkzWDnrH2ZKnEiOy1LZIrt5I2GHOpkAvtsf54lspIMQHZdz3ofuyPti8gmR/97NuBOYcQD+8AX//An/OtdHVZg1pE85rUhFHTsLt2spYMSF5N6Tk2LiOSg= Received: from BY5PR11MB4484.namprd11.prod.outlook.com (52.132.254.155) by BY5PR11MB3926.namprd11.prod.outlook.com (10.255.160.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.24; Mon, 4 Nov 2019 18:19:44 +0000 Received: from BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::c1ef:6e0b:90c8:55e2]) by BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::c1ef:6e0b:90c8:55e2%7]) with mapi id 15.20.2408.024; Mon, 4 Nov 2019 18:19:44 +0000 From: "Kubacki, Michael A" To: "devel@edk2.groups.io" , "Agyeman, Prince" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" Subject: Re: [edk2-platforms] [PATCH 3/5] BoardModulePkg: Added Pcds Sio Driver Thread-Topic: [edk2-platforms] [PATCH 3/5] BoardModulePkg: Added Pcds Sio Driver Thread-Index: AQHVkO3RLoI2N5TlF0yAty7pVSka9Kd7RiDg Date: Mon, 4 Nov 2019 18:19:44 +0000 Message-ID: References: <20191101195116.23212-1-prince.agyeman@intel.com> <20191101195116.23212-4-prince.agyeman@intel.com> In-Reply-To: <20191101195116.23212-4-prince.agyeman@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzkzZDQzZTUtMjUyMi00YjU3LWEyODQtYjQ2YjIyMTA3MmQzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiN0FCRVQ0c1U0U3JBeGJkRzIwS3ZRUURIcXJnVEQrRkJhZytxWXdtWElsUTNUdGFabzBDRWxqQndtZlwvY0FVUXUifQ== dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 04f7b9b7-5178-4f7c-b5fa-08d76153914c x-ms-traffictypediagnostic: BY5PR11MB3926: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0211965D06 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(346002)(39860400002)(396003)(136003)(366004)(189003)(13464003)(199004)(186003)(7736002)(229853002)(7696005)(486006)(476003)(4326008)(86362001)(9686003)(52536014)(66066001)(478600001)(14454004)(81156014)(81166006)(6246003)(8936002)(6436002)(25786009)(5660300002)(8676002)(102836004)(14444005)(107886003)(99286004)(53546011)(6506007)(26005)(316002)(54906003)(2501003)(3846002)(66556008)(6116002)(76116006)(66476007)(66946007)(66446008)(64756008)(2906002)(256004)(33656002)(19627235002)(71190400001)(71200400001)(55016002)(446003)(76176011)(74316002)(11346002)(6636002)(305945005)(110136005);DIR:OUT;SFP:1102;SCL:1;SRVR:BY5PR11MB3926;H:BY5PR11MB4484.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fdaVF35HhWX64LgmPTaO7L2RRlXei+8wyRbN5fgzlMpO5uCu4MpBdicoP0VRmZg5r6UTmZLVTmtxGWzJyfhP9+9AGgOjfOQeQ1mQ8VLULfS8vZywAY/zlEIXNyT8NC4u4p4/gE0Vgs+lTRBxUNgCpM6h0SQmskKTOzQoq/vuIDlShTbbe247rwHirDXvoB/bTc1QFQp2lnUTSMZB9pYvfoTWviY/YBxMIHA53gVLhc0vkPTjod9ePw96p2gpfauSy7Ln0nh53kRpM8jNfZUHNXtWIV2o0+8dHbX0WL1St0szXP6KpfJE27O60Mm1L8+yetBmx80rUZLXU0PqDxu7EPPE8IsSveUJtrpyC7VD1b/Bi3z4hxdpAee9khXiT41SrNaHypMZi4pQ4mj4K7rJgAzBe+nKavVnVYeItC6u5wnb8mJ2Gi+TJPZSceHyPduG MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 04f7b9b7-5178-4f7c-b5fa-08d76153914c X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Nov 2019 18:19:44.2728 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hO735gcXo7VBTSWpQ0DeZE3Q3QXHnN7s/1HwVnw2M0KNP+Dg0+dn6+riFMiFEZD0TWg/2VwMjcZC9sGmpHk+0VnN7MIsUzLnCyejM5uyP3o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB3926 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Please fix style formatting, especially in this function: /** Gets the number of devices in Table of SIO Controllers mDeviceInfo @retval Number of enabled devices in Table of SIO Controllers. **/ UINTN EFIAPI GetDeviceCount( VOID ){ UINTN Count; Count =3D ARRAY_SIZE(mDeviceInfo) - 1; // -1 to account for for the end = device info return Count; } This patch contains a change in SimicsOpenBoardPkg, as I suggested in the r= eply to the cover letter, I believe that is better in a separate patch. Thanks, Michael > -----Original Message----- > From: Agyeman, Prince > Sent: Friday, November 1, 2019 12:51 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject: [edk2-platforms] [PATCH 3/5] BoardModulePkg: Added Pcds Sio > Driver >=20 > Included PCDs to the Sio dxe driver, > to allow the enable/disable of Ps2 keyboard/mouse, > UART1 and UART2 com ports. >=20 > Renamed the Sio driver's base name >=20 > Cc: Michael Kubacki > Cc: Chasel Chiu > Cc: Nate DeSimone >=20 > Signed-off-by: Prince Agyeman > --- > .../LegacySioDxe/LegacySioDxe.inf | 15 +++- > .../BoardModulePkg/LegacySioDxe/SioChip.c | 69 +++++++++++++++++-- > .../BoardModulePkg/LegacySioDxe/SioChip.h | 10 +++ > .../BoardModulePkg/LegacySioDxe/SioDriver.c | 42 ++++++++++- > .../BoardX58Ich10/OpenBoardPkgPcd.dsc | 6 ++ > 5 files changed, 133 insertions(+), 9 deletions(-) >=20 > diff --git a/Platform/Intel/BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > b/Platform/Intel/BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > index d606ba43dc..4ab01a6098 100644 > --- a/Platform/Intel/BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > +++ b/Platform/Intel/BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > @@ -10,7 +10,7 @@ >=20 > [Defines] > INF_VERSION =3D 0x00010017 > - BASE_NAME =3D HitachiH8s2113Dxe > + BASE_NAME =3D LegacySioDxe > FILE_GUID =3D 7807E404-8281-4FF1-8457-0B54BABE263= F > VERSION_STRING =3D 1.0 > MODULE_TYPE =3D UEFI_DRIVER > @@ -34,6 +34,7 @@ > [Packages] > MdePkg/MdePkg.dec > MdeModulePkg/MdeModulePkg.dec > + BoardModulePkg/BoardModulePkg.dec >=20 > [Sources] > SioChip.c > @@ -44,6 +45,18 @@ > SioDriver.h > ComponentName.c >=20 > +[Pcd] > + gBoardModulePkgTokenSpaceGuid.PcdPs2KbMsEnable > + gBoardModulePkgTokenSpaceGuid.PcdUart1Enable > + gBoardModulePkgTokenSpaceGuid.PcdUart1IrqMask > + gBoardModulePkgTokenSpaceGuid.PcdUart1IoPort > + gBoardModulePkgTokenSpaceGuid.PcdUart1Length > + gBoardModulePkgTokenSpaceGuid.PcdUart2Enable > + gBoardModulePkgTokenSpaceGuid.PcdUart2IrqMask > + gBoardModulePkgTokenSpaceGuid.PcdUart2IoPort > + gBoardModulePkgTokenSpaceGuid.PcdUart2Length > + gBoardModulePkgTokenSpaceGuid.PcdSuperIoPciIsaBridgeDevice > + > [Protocols] > gEfiPciIoProtocolGuid ## CONSUMES > gEfiDevicePathProtocolGuid ## PRODUCES > diff --git a/Platform/Intel/BoardModulePkg/LegacySioDxe/SioChip.c > b/Platform/Intel/BoardModulePkg/LegacySioDxe/SioChip.c > index 81efe3c38b..09403a7354 100644 > --- a/Platform/Intel/BoardModulePkg/LegacySioDxe/SioChip.c > +++ b/Platform/Intel/BoardModulePkg/LegacySioDxe/SioChip.c > @@ -19,12 +19,31 @@ > ACPI_SIO_RESOURCES_IO_IRQ mCom1Resources =3D { > { > { ACPI_FIXED_LOCATION_IO_PORT_DESCRIPTOR }, > - 0x3f8, > - 8 > + FixedPcdGet16 (PcdUart1IoPort), > + FixedPcdGet8 (PcdUart1Length) > + }, > + { > + { ACPI_IRQ_NOFLAG_DESCRIPTOR }, > + FixedPcdGet16 (PcdUart1IrqMask) > + }, > + { > + ACPI_END_TAG_DESCRIPTOR, > + 0 > + } > +}; > + > +// > +// COM 2 UART Controller > +// > +ACPI_SIO_RESOURCES_IO_IRQ mCom2Resources =3D { > + { > + { ACPI_FIXED_LOCATION_IO_PORT_DESCRIPTOR }, > + FixedPcdGet16 (PcdUart2IoPort), > + FixedPcdGet8 (PcdUart2Length) > }, > { > { ACPI_IRQ_NOFLAG_DESCRIPTOR }, > - BIT4 // IRQ4 > + FixedPcdGet16 (PcdUart2IrqMask), > }, > { > ACPI_END_TAG_DESCRIPTOR, > @@ -70,10 +89,12 @@ ACPI_SIO_RESOURCES_IO_IRQ mMouseResources > =3D { > } > }; >=20 > + > // > // Table of SIO Controllers > // > DEVICE_INFO mDeviceInfo[] =3D { > +#if FixedPcdGet8 (PcdUart1Enable) =3D=3D DEVICE_ENABLED > { > { > EISA_PNP_ID(0x501), > @@ -84,6 +105,20 @@ DEVICE_INFO mDeviceInfo[] =3D { > { (ACPI_SMALL_RESOURCE_HEADER *) &mCom1Resources }, > { (ACPI_SMALL_RESOURCE_HEADER *) &mCom1Resources } > }, // COM 1 UART Controller > +#endif > +#if FixedPcdGet8 (PcdUart2Enable) =3D=3D DEVICE_ENABLED > + { > + { > + EISA_PNP_ID(0x501), > + 0 > + }, > + 0, > + RESOURCE_IO | RESOURCE_IRQ, > + { (ACPI_SMALL_RESOURCE_HEADER *) &mCom2Resources }, > + { (ACPI_SMALL_RESOURCE_HEADER *) &mCom2Resources } > + }, // COM 2 UART Controller > +#endif > +#if FixedPcdGet8 (PcdPs2KbMsEnable) =3D=3D DEVICE_ENABLED > { > { > EISA_PNP_ID(0x303), > @@ -103,10 +138,28 @@ DEVICE_INFO mDeviceInfo[] =3D { > 0, // Cannot change resource > { (ACPI_SMALL_RESOURCE_HEADER *) &mMouseResources }, > { (ACPI_SMALL_RESOURCE_HEADER *) &mMouseResources } > - } // PS/2 Mouse Controller > + }, // PS/2 Mouse Controller > +#endif > + DEVICE_INFO_END > }; >=20 >=20 > + > +/** > + Gets the number of devices in Table of SIO Controllers mDeviceInfo > + > + @retval Number of enabled devices in Table of SIO Controllers. > +**/ > +UINTN > +EFIAPI > +GetDeviceCount( > + VOID > +){ > + UINTN Count; > + Count =3D ARRAY_SIZE(mDeviceInfo) - 1; // -1 to account for for the e= nd > device info > + return Count; > +} > + > /** > Return the supported devices. >=20 > @@ -128,7 +181,7 @@ DeviceGetList ( > // > // Allocate enough memory for simplicity > // > - DeviceCount =3D sizeof (mDeviceInfo) / sizeof (mDeviceInfo[0]); > + DeviceCount =3D GetDeviceCount(); > LocalDevices =3D AllocatePool (sizeof (EFI_SIO_ACPI_DEVICE_ID) * > DeviceCount); > ASSERT (LocalDevices !=3D NULL); > if (LocalDevices =3D=3D NULL) { > @@ -157,7 +210,6 @@ SioInit ( > VOID > ) > { > - > return EFI_SUCCESS; > } >=20 > @@ -175,8 +227,11 @@ DeviceSearch ( > ) > { > UINTN Index; > + UINTN DeviceCount; > + > + DeviceCount =3D GetDeviceCount(); >=20 > - for (Index =3D 0; Index < sizeof (mDeviceInfo) / sizeof (mDeviceInfo[0= ]); > Index++) { > + for (Index =3D 0; Index < DeviceCount; Index++) { > if (CompareMem (Device, &mDeviceInfo[Index].Device, sizeof (*Device)= ) > =3D=3D 0) { > return &mDeviceInfo[Index]; > } > diff --git a/Platform/Intel/BoardModulePkg/LegacySioDxe/SioChip.h > b/Platform/Intel/BoardModulePkg/LegacySioDxe/SioChip.h > index 9322365923..8bd53ccdd6 100644 > --- a/Platform/Intel/BoardModulePkg/LegacySioDxe/SioChip.h > +++ b/Platform/Intel/BoardModulePkg/LegacySioDxe/SioChip.h > @@ -24,6 +24,9 @@ UINT8 > #define RESOURCE_DMA BIT2 > #define RESOURCE_MEM BIT3 >=20 > +#define DEVICE_ENABLED 0x01 > +#define DEVICE_INFO_END { { 0xFFFFFFFF, 0xFFFFFFFF } } > + > #pragma pack(1) >=20 > typedef struct { > @@ -46,6 +49,13 @@ typedef struct { > ACPI_RESOURCE_HEADER_PTR PossibleResources; > } DEVICE_INFO; >=20 > +typedef struct { > + UINT8 Segment; > + UINT8 Bus; > + UINT8 Device; > + UINT8 Funtion; > +} SIO_PCI_ISA_BRIDGE_DEVICE_INFO; > + > /** > Return the supported devices. >=20 > diff --git a/Platform/Intel/BoardModulePkg/LegacySioDxe/SioDriver.c > b/Platform/Intel/BoardModulePkg/LegacySioDxe/SioDriver.c > index 408c6ff301..5ab9109ad9 100644 > --- a/Platform/Intel/BoardModulePkg/LegacySioDxe/SioDriver.c > +++ b/Platform/Intel/BoardModulePkg/LegacySioDxe/SioDriver.c > @@ -8,7 +8,6 @@ >=20 > #include "SioDriver.h" >=20 > - > // > // This driver is for ACPI(PNP0A03,0)/PCI(0x1f,0) // @@ -106,6 +105,27 = @@ > SioDriverEntryPoint ( } >=20 >=20 > +/** > + Compares a PCI to ISA bridge device segment, bus, device and function > +to the > + PcdSuperIoPciIsaBridgeDevice values. > + > + @param[in] CurrentDevice The device to be compared with the > PcdSuperIoPciIsaBridgeDevice information > + @retval TRUE This device matches PcdSuperIoPciIsaBr= idgeDevice > values > + @retval FALSE This device does not match the > PcdSuperIoPciIsaBridgeDevice values > +**/ > +BOOLEAN > +EFIAPI > +SioDeviceEnabled ( > + IN SIO_PCI_ISA_BRIDGE_DEVICE_INFO *CurrentDevice ){ > + SIO_PCI_ISA_BRIDGE_DEVICE_INFO *Device =3D \ > + (SIO_PCI_ISA_BRIDGE_DEVICE_INFO *) FixedPcdGetPtr > (PcdSuperIoPciIsaBridgeDevice); > + if(CompareMem (Device, CurrentDevice, sizeof > (SIO_PCI_ISA_BRIDGE_DEVICE_INFO)) =3D=3D 0) { > + return TRUE; > + } > + return FALSE; > +} > + > /** > Test to see if this driver supports Controller Handle. >=20 > @@ -138,6 +158,7 @@ SioDriverSupported ( > UINTN BusNumber; > UINTN DeviceNumber; > UINTN FunctionNumber; > + SIO_PCI_ISA_BRIDGE_DEVICE_INFO SioDevice; >=20 > // > // If RemainingDevicePath is not NULL, it should verify that the first= device > @@ -250,6 +271,25 @@ SioDriverSupported ( > Status =3D EFI_UNSUPPORTED; > } > } > + > + if(!EFI_ERROR (Status)) { > + Status =3D PciIo->GetLocation ( > + PciIo, > + &SegmentNumber, > + &BusNumber, > + &DeviceNumber, > + &FunctionNumber > + ); > + if(!EFI_ERROR (Status)) { > + SioDevice.Segment =3D (UINT8) SegmentNumber; > + SioDevice.Bus =3D (UINT8) BusNumber; > + SioDevice.Device =3D (UINT8) DeviceNumber; > + SioDevice.Funtion =3D (UINT8) FunctionNumber; > + if(!SioDeviceEnabled (&SioDevice)) { > + Status =3D EFI_UNSUPPORTED; > + } > + } > + } > } > } >=20 > diff --git > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.ds > c > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.ds > c > index 0298e4b12d..b85991b772 100644 > --- > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.ds > c > +++ > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.ds > +++ c > @@ -196,6 +196,12 @@ > gMinPlatformPkgTokenSpaceGuid.PcdMaxCpuThreadCount|4 > gMinPlatformPkgTokenSpaceGuid.PcdPcIoApicAddressBase|0xFEC01000 >=20 > + ###################################### > + # Board Configuration > + ###################################### > + gBoardModulePkgTokenSpaceGuid.PcdPs2KbMsEnable|1 > + > + > gBoardModulePkgTokenSpaceGuid.PcdSuperIoPciIsaBridgeDevice|{0x00,0x0 > 0, > + 0x1F,0x00} > + > [PcdsFixedAtBuild.X64] > ###################################### > # Edk2 Configuration > -- > 2.19.1.windows.1