From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web11.1201.1573087812032005744 for ; Wed, 06 Nov 2019 16:50:12 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=mLfmqWF+; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: michael.a.kubacki@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2019 16:50:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,276,1569308400"; d="scan'208";a="214433274" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by orsmga002.jf.intel.com with ESMTP; 06 Nov 2019 16:50:11 -0800 Received: from orsmsx155.amr.corp.intel.com (10.22.240.21) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 Nov 2019 16:50:11 -0800 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX155.amr.corp.intel.com (10.22.240.21) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 Nov 2019 16:50:10 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.50) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 Nov 2019 16:50:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FVZO3lhk1NobzFKAU9lepy2l+qoDvyz3c/+YIlTshqdBlaixQEq+0M+b9LVwpEt883hGDoWYlYBCVEb1s0rpzqpjM4N7N3SrGJGxheoyHaoeyhO9Ejdgrbarz+0wpXbE5MPkRTyLqCi9vtC1klMceLijeLScqwT2fkih2hybdO9GOAQj03oLfQbJVps+29s9AEz4Ut6tErBBs4CAziCYljoKiC4sj6eOUXa20pwlCyzfPLEwNbPW7LZlMuxBwLOcIWZ5fVeTwT0mqQ+uf91MKYElVnnC/oiC6TLoIcBQjCiszNXfsubrZT5MF+0oxxSKXdjnogwSWxngLnwct/qtZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EX9yjyg3ulmH4HR/YzzMu0fhdbZTtJCM5yFSa1vbOcc=; b=ZmddIRAEBtqHEiA6f8aarx1K+g+1qwi9zHZjIFhj1LwhypPlV3DpScfu1TFjxmTyf3BnVub1lWAv0U1Vu3ehbVsj9xcn2xwlKXhq67liUogl3IjYNdP8tv6FJhwgWpT4DNztIofAd3ORYo5uN2STi89BfRUZDp2qskh1Ir0Kmi2yT1eYZinfdKHS+jT/FKnHuyiJH4FK8IQ8Pfw1MhVbTan8KmRx9d+q1blPZu9Bm1uHme63XxbDC2ggilg0fhr9BC5aD9PlGE21B49Qog2ula6uxcBXlJ1pP4F/UPdmZKmYx6M+4X71xz5CgTUgqQxcQcYiWBM71kg65fBHkaTJqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EX9yjyg3ulmH4HR/YzzMu0fhdbZTtJCM5yFSa1vbOcc=; b=mLfmqWF+LH7Ao5/zvmVg/ABYm84gRws4yfYj4Rr7tDqf8A+bGnIabsUM1seQZmGnyHsO+mbfvW8X+U8t8VRoti3rw83KCNUKNv7nfWvQ6f7KBst+E4PD1qsHv2KP2i+CbkQ1inCypaBrAsApBSpcvUF4puWmNI7NkIKUGN04KrI= Received: from BY5PR11MB4484.namprd11.prod.outlook.com (52.132.254.155) by BY5PR11MB3976.namprd11.prod.outlook.com (10.255.160.206) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.24; Thu, 7 Nov 2019 00:50:08 +0000 Received: from BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::c1ef:6e0b:90c8:55e2]) by BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::c1ef:6e0b:90c8:55e2%7]) with mapi id 15.20.2430.020; Thu, 7 Nov 2019 00:50:08 +0000 From: "Kubacki, Michael A" To: "devel@edk2.groups.io" , "Agyeman, Prince" Subject: Re: [edk2-devel] [edk2-platforms] [Patch v2 7/9] KabylakeOpenBoardPkg: Add Ps2 Keyboard Support Thread-Topic: [edk2-devel] [edk2-platforms] [Patch v2 7/9] KabylakeOpenBoardPkg: Add Ps2 Keyboard Support Thread-Index: AQHVlEFF46++jd8k2EuxuDZXYfegdqd+28RQ Date: Thu, 7 Nov 2019 00:50:08 +0000 Message-ID: References: <20191106012603.4724-1-prince.agyeman@intel.com> <20191106012603.4724-8-prince.agyeman@intel.com> In-Reply-To: <20191106012603.4724-8-prince.agyeman@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGY1MGI5NjctYmVmOC00NzU4LTg1MjQtYmUwMGRmZWEwOTc3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiT05WVFwvT0E4Tm40TG55XC92ZmJiVHNiMWppdCtUQVUrbjQ4ellMeEdaQkRBU01Ramg5dlVnK1RRaDlGSW1HWWRQIn0= dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c95be965-c7c3-44ea-428b-08d7631c6ffd x-ms-traffictypediagnostic: BY5PR11MB3976: x-ms-exchange-purlcount: 4 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-forefront-prvs: 0214EB3F68 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(1496009)(39860400002)(136003)(376002)(396003)(346002)(366004)(13464003)(199004)(189003)(486006)(11346002)(6436002)(305945005)(66066001)(55016002)(6246003)(2501003)(6306002)(14454004)(2906002)(19627235002)(86362001)(6116002)(3846002)(33656002)(110136005)(7736002)(71190400001)(478600001)(25786009)(99286004)(446003)(8676002)(52536014)(81166006)(81156014)(966005)(8936002)(9686003)(316002)(256004)(66946007)(53546011)(66446008)(6506007)(64756008)(26005)(66556008)(7696005)(74316002)(76176011)(102836004)(6636002)(476003)(186003)(71200400001)(66476007)(76116006)(229853002)(30864003)(5660300002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY5PR11MB3976;H:BY5PR11MB4484.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: t8zq+3H07FogJc2qxK3zseiQbcjfkESVWxwhwbUMKgv8QkWLSA2oHRNlEoFyh/+M4nUDZCA3r3T1LYTMdnAsa/B/R5ai3zF5ygTRJEJGbSmJLdwSj29U9GEOuZnVme/2QivJlSYFea5vE+nlzc9pOp6KuckOntWNIsSkwLw5nOydh79ZUCiuj4xzRYgajsyZakXKKg/siHovsq9w5qvbPDrHvYlwMPZuewrjexVgHn2O0b8SWF0ALPW7YgB1ZIGl8HuDvpOocE4FkjMX78fGD18YZPU3d79IF0jyjTNsVNAknUguSnxZGOMTcT9s+P/7VTDDO+BMcjtaFKHiyp0EBg2Na7UBpwZuTvavsPgMoPGQSmE7MBcIqPziFda3/EoV4V/WWmfvR57EOEAm/ZOQH4/ClWE5MCwiPw1VHRgspOFXHX8ia1WxsF2kTwAnHcdFg6e09Ol5m7YgihCR+Fjw/gnbqys+rMng6a65mfQAmpE= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: c95be965-c7c3-44ea-428b-08d7631c6ffd X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Nov 2019 00:50:08.3578 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YZi5a12rm4ltXKeKTHJT+Ke91IgoqraHi6RxOF1rjAJHFHdvs4jiKz4I8Zu6xblM4WaYMWWlNHDkMAGEaGnAzptfnbzXcWIvmdtrfnBMag8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB3976 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable This patch is missing the Cc. Please make sure to check it in the future. Reviewed-by: Michael Kubacki > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > Agyeman, Prince > Sent: Tuesday, November 5, 2019 5:26 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [edk2-platforms] [Patch v2 7/9] > KabylakeOpenBoardPkg: Add Ps2 Keyboard Support >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2228 >=20 > What was done: >=20 > * Added BDS Ps2 keyboard DXE driver. >=20 > * Added Super I/O DXE driver to publish the SIO protocol needed by the P= s2 > keyboard DXE driver. >=20 > * Included a Ps2 Library to BdsDxe driver to add the Ps2 device path to = ConIn > and ConInDev variables >=20 > * Configured the Super I/O Pci to Isa bridge bus, device, function devic= e info > PCD. This will help the Super I/O driver identify which bridge the Super= I/O is > connected to. >=20 > * Removed duplicate Ps2 enable PCDs >=20 > * Updated libraries to use Ps2 enable PCD defined in BoardModulePkg >=20 > Signed-off-by: Prince Agyeman > --- > .../Library/BoardAcpiLib/DxeBoardAcpiTableLib.inf | 3 ++- > .../Library/BoardAcpiLib/DxeMultiBoardAcpiSupportLib.inf | 3 ++- > .../Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 7 > +++++++ .../Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf | > 2 ++ > .../KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.dsc | 6 ++++++ > .../Library/BoardAcpiLib/DxeBoardAcpiTableLib.inf | 3 ++- > .../Library/BoardAcpiLib/DxeMultiBoardAcpiSupportLib.inf | 3 ++- > .../KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc | 6 ++++++ > .../KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf | 2 ++ > .../KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc | 7 > +++++++ > Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec | 2 -- > 11 files changed, 38 insertions(+), 6 deletions(-) >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/ > DxeBoardAcpiTableLib.inf > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/ > DxeBoardAcpiTableLib.inf > index a79bdcdbc6..35cd5c8fdb 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/ > DxeBoardAcpiTableLib.inf > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLi > +++ b/DxeBoardAcpiTableLib.inf > @@ -33,9 +33,10 @@ > MinPlatformPkg/MinPlatformPkg.dec > KabylakeOpenBoardPkg/OpenBoardPkg.dec > KabylakeSiliconPkg/SiPkg.dec > + BoardModulePkg/BoardModulePkg.dec >=20 > [Pcd] > - gKabylakeOpenBoardPkgTokenSpaceGuid.PcdPs2KbMsEnable > + gBoardModulePkgTokenSpaceGuid.PcdPs2KbMsEnable > gMinPlatformPkgTokenSpaceGuid.PcdPciExpNative > gMinPlatformPkgTokenSpaceGuid.PcdNativeAspmEnable > gMinPlatformPkgTokenSpaceGuid.PcdLowPowerS0Idle > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/ > DxeMultiBoardAcpiSupportLib.inf > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/ > DxeMultiBoardAcpiSupportLib.inf > index db8ba7a822..9fe27f9fda 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/ > DxeMultiBoardAcpiSupportLib.inf > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLi > +++ b/DxeMultiBoardAcpiSupportLib.inf > @@ -34,9 +34,10 @@ > MinPlatformPkg/MinPlatformPkg.dec > KabylakeOpenBoardPkg/OpenBoardPkg.dec > KabylakeSiliconPkg/SiPkg.dec > + BoardModulePkg/BoardModulePkg.dec >=20 > [Pcd] > - gKabylakeOpenBoardPkgTokenSpaceGuid.PcdPs2KbMsEnable > + gBoardModulePkgTokenSpaceGuid.PcdPs2KbMsEnable > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdPciExpNative > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdNativeAspmEnable > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdLowPowerS0Idle > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > index f59248bba4..55edc1a2f8 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > @@ -311,6 +311,11 @@ > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf > MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf >=20 > MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDx > e.inf > + MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf > + MdeModulePkg/Universal/BdsDxe/BdsDxe.inf{ > + > + NULL|BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.inf > + } > UefiCpuPkg/CpuDxe/CpuDxe.inf >=20 > ShellPkg/Application/Shell/Shell.inf { @@ -408,3 +413,5 @@ > !endif > } > !endif > + BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > + > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf > index 80efab1aad..d58466d390 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf > @@ -335,6 +335,8 @@ INF > MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf > INF MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf > INF > MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDx > e.inf > INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > +INF BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > +INF MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf >=20 > INF ShellPkg/Application/Shell/Shell.inf >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.ds > c > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.ds > c > index c68b8a49cf..c6f5ae7534 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.ds > c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.ds > c > @@ -308,6 +308,12 @@ > gMinPlatformPkgTokenSpaceGuid.PcdTestPointIbvPlatformFeature|{0x03, > 0x0F, 0x07, 0x1F, 0x1F, 0x0F, 0x0F, 0x07, 0x03, 0x00, 0x00, 0x00, 0x00, = 0x00, > 0x00, 0x00} !endif >=20 > + ###################################### > + # Board Configuration > + ###################################### > + gBoardModulePkgTokenSpaceGuid.PcdPs2KbMsEnable|1 > + gBoardModulePkgTokenSpaceGuid.PcdSuperIoPciIsaBridgeDevice|{0x00, > + 0x00, 0x1F, 0x00} > + > [PcdsFixedAtBuild.IA32] > ###################################### > # Edk2 Configuration > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi > b/DxeBoardAcpiTableLib.inf > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi > b/DxeBoardAcpiTableLib.inf > index bfb58e868f..e0bf5823d8 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi > b/DxeBoardAcpiTableLib.inf > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi > +++ Lib/DxeBoardAcpiTableLib.inf > @@ -33,9 +33,10 @@ > MinPlatformPkg/MinPlatformPkg.dec > KabylakeOpenBoardPkg/OpenBoardPkg.dec > KabylakeSiliconPkg/SiPkg.dec > + BoardModulePkg/BoardModulePkg.dec >=20 > [Pcd] > - gKabylakeOpenBoardPkgTokenSpaceGuid.PcdPs2KbMsEnable > + gBoardModulePkgTokenSpaceGuid.PcdPs2KbMsEnable > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdPciExpNative > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdNativeAspmEnable > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdLowPowerS0Idle > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi > b/DxeMultiBoardAcpiSupportLib.inf > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi > b/DxeMultiBoardAcpiSupportLib.inf > index 00cdbe80ce..e5de9268e7 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi > b/DxeMultiBoardAcpiSupportLib.inf > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi > +++ Lib/DxeMultiBoardAcpiSupportLib.inf > @@ -34,9 +34,10 @@ > MinPlatformPkg/MinPlatformPkg.dec > KabylakeOpenBoardPkg/OpenBoardPkg.dec > KabylakeSiliconPkg/SiPkg.dec > + BoardModulePkg/BoardModulePkg.dec >=20 > [Pcd] > - gKabylakeOpenBoardPkgTokenSpaceGuid.PcdPs2KbMsEnable > + gBoardModulePkgTokenSpaceGuid.PcdPs2KbMsEnable > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdPciExpNative > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdNativeAspmEnable > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdLowPowerS0Idle > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > index 7e65eeda6f..e7f5ed39d2 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > @@ -381,6 +381,11 @@ > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf > MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf >=20 > MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDx > e.inf > + MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf > + MdeModulePkg/Universal/BdsDxe/BdsDxe.inf{ > + > + NULL|BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.inf > + } > UefiCpuPkg/CpuDxe/CpuDxe.inf >=20 > !if gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection =3D=3D 1 @@ - > 485,3 +490,4 @@ > !endif > } > !endif > + BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > index dbd6f2aa10..98eb7dcb5a 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > @@ -336,6 +336,8 @@ INF > MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf > INF MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf > INF MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf > INF > MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDx > e.inf > +INF BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > +INF MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf >=20 > INF ShellPkg/Application/Shell/Shell.inf >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd. > dsc > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd. > dsc > index 34cc731313..580504cbc1 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd. > dsc > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd. > d > +++ sc > @@ -324,6 +324,13 @@ > gMinPlatformPkgTokenSpaceGuid.PcdTestPointIbvPlatformFeature|{0x03, > 0x0F, 0x07, 0x1F, 0x1F, 0x0F, 0x0F, 0x07, 0x03, 0x00, 0x00, 0x00, 0x00, = 0x00, > 0x00, 0x00} !endif >=20 > + > + ###################################### > + # Board Configuration > + ###################################### > + gBoardModulePkgTokenSpaceGuid.PcdPs2KbMsEnable|1 > + gBoardModulePkgTokenSpaceGuid.PcdSuperIoPciIsaBridgeDevice|{0x00, > + 0x00, 0x1F, 0x00} > + > [PcdsFixedAtBuild.IA32] > ###################################### > # Edk2 Configuration > diff --git a/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec > b/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec > index 9680e63bad..01d6116616 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec > +++ b/Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec > @@ -288,8 +288,6 @@ > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdBoardUcmcGpioTableSize|0|U > INT16|0x0000001 > # Misc >=20 > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdIoExpanderPresent|FALSE|BO > OLEAN|0x000000EC >=20 > - > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdPs2KbMsEnable|1|UINT8|0x4 > 0000009 > - >=20 > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdAcpiSleepState|1|UINT8|0x40 > 000002 >=20 > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdAcpiHibernate|1|UINT8|0x40 > 000003 >=20 > gKabylakeOpenBoardPkgTokenSpaceGuid.PcdLowPowerS0Idle|0|UINT8|0x > 40000004 > -- > 2.19.1.windows.1 >=20 >=20 >=20