From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web12.3150.1576895813821226426 for ; Fri, 20 Dec 2019 18:36:53 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=uG/9WTMk; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: michael.a.kubacki@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Dec 2019 18:36:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,338,1571727600"; d="scan'208";a="218985833" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by orsmga003.jf.intel.com with ESMTP; 20 Dec 2019 18:36:53 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 20 Dec 2019 18:36:52 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 20 Dec 2019 18:36:52 -0800 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 20 Dec 2019 18:36:52 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.108) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 20 Dec 2019 18:36:52 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RqoCHSzySAKT5fdwDRISG3Z5H5Ic7sgcw2xNz4lW84j/WzSGR1EstCuW/Yz8ttFdIqE0Oa+F9J6lAMMOEhstJTNZSlFM0TEvzLLXChzZuMx4FwRA9WYAcLa7dljX81Rjp+zNyN/zTaJIDZtAzeCHGfhT51RHac5DuXMb7HgqBjz/Ot2JDA/7cRGrfVbkHEhu/+d+SNFlfANoKwnsHPqQTMQsecZ9Z7rKMQB1pHBBH079pFOujJp77rVGWsQ1Tg9rOYBL3tgc1n1+EKumwcoqBzjUUbp9QryxsVZ12eV7P1K0EcMypGnT8PjcE4eXtBQ2Ss0U/+jE4UWJkzECYWlZSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sGGFAd8trmWvk3E7x9j4bCzWXjEG1DCNfHFJaWCvgfI=; b=Z1hnKFtXUkV+DzzmUfVYkRm3F09L59x/lZLbc/psfnxboMuEf3ofMk5FgBZ/gkTLNvs2TakB3HNahL0OY+huDDTyYnNA5PtoBSPio7FzhhsPy3D1kgd2InyW56u4jAXX5n3dPv3yEVye0BzbkdZKLfOd4pf5vikoDKEHpjYShXBbuQEfiwr78NWqUGcAW2+cEIjIqzjcwENaZv03qGMFVacXHeQagOnHRNRrynG1SC7f8K+zpJXAEnNVD5Q4NaRcFzYt458zYI0SYZfF6lRkWNDX7rKaUWwyCoOtMgKBpE6lDqs2x841w7Esaw8qJzgkA0d2FYxYx+gqTcMDZtbd3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sGGFAd8trmWvk3E7x9j4bCzWXjEG1DCNfHFJaWCvgfI=; b=uG/9WTMk8e3NNWhf6f7HaFI7krotQA321CbkbLcQkRLa91Z/eX/mvT9hCtg8KI9MBDpA6SmHpamZy/+hdmQ13njCm0qvxnQJr38PJaRaS6AhrClNsXfuJbsIbrba9AzIC/6gpnQ6ggKUFtPl7qUFkOk3V6IudTCjvBo70fYoJ5Q= Received: from BY5PR11MB4484.namprd11.prod.outlook.com (52.132.254.155) by BY5PR11MB3895.namprd11.prod.outlook.com (10.255.162.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2559.15; Sat, 21 Dec 2019 02:36:50 +0000 Received: from BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::bc80:2ec3:11ba:2f8a]) by BY5PR11MB4484.namprd11.prod.outlook.com ([fe80::bc80:2ec3:11ba:2f8a%3]) with mapi id 15.20.2559.017; Sat, 21 Dec 2019 02:36:50 +0000 From: "Kubacki, Michael A" To: "Agyeman, Prince" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" Subject: Re: [edk2-platforms] [PATCH 07/11] KabylakeOpenBoardPkg: Add BDS Hook Dxe Driver Thread-Topic: [edk2-platforms] [PATCH 07/11] KabylakeOpenBoardPkg: Add BDS Hook Dxe Driver Thread-Index: AQHVsh5tyKWcR4u1WU6OgW4xHIUeM6fD54OA Date: Sat, 21 Dec 2019 02:36:50 +0000 Message-ID: References: <96314428770c53cf9d46a0baffeb378180283656.1576282834.git.prince.agyeman@intel.com> In-Reply-To: <96314428770c53cf9d46a0baffeb378180283656.1576282834.git.prince.agyeman@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGQ2Yzg3ZjMtNGM0NS00OTNlLTljZjYtYzJiODMxZTRhOWRlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUklaeEtpbTdYT0JGb082UFlxMDVZYnJwKzM4enBVMnkzcmhBT3gzeWNldHBOeTV3d1FjVUoxcGNaUjQ4MkkrVCJ9 dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=michael.a.kubacki@intel.com; x-originating-ip: [134.134.136.217] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f4efdefb-3d00-45bf-8b83-08d785bea1fa x-ms-traffictypediagnostic: BY5PR11MB3895: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-forefront-prvs: 0258E7CCD4 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39860400002)(366004)(136003)(396003)(376002)(346002)(13464003)(199004)(189003)(9686003)(107886003)(55016002)(26005)(478600001)(186003)(4326008)(86362001)(66946007)(53546011)(66446008)(966005)(64756008)(66476007)(66556008)(5660300002)(2906002)(8936002)(33656002)(8676002)(81166006)(76116006)(316002)(54906003)(81156014)(110136005)(6506007)(7696005)(52536014)(71200400001);DIR:OUT;SFP:1102;SCL:1;SRVR:BY5PR11MB3895;H:BY5PR11MB4484.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IOPKCSE/TV9799zqVOatl+tCflE6MsAd8nhg9gqDf1bX6bAS93kB6Yeat3TtRo1eYWd5z+57BQzS6PvdohSDQ5iSwPACjCDFHODn9IEpffdNng2qWddgZ7AxRXgeSS+glUh+6YStr6Ap0lLkJjz2MOQDJzpMtOmBuQx6PF1knV3g5kDFLVMsxrhlsViLbXq6+/nbzCUVnaqmkaIgSRaKZDljVtcNd6jfi+oD2oK0MlJBlLWPjrs9QSNyew+9UgYViN36zA4AsxzwkxtNWuTVEr42+lqFJUnZLAcUjZqeWJrh1F8X7De1vYWVPRV1wcq04drKXn3kPkYVen5Kz+CKMk6Gm+WGPiw20Cungai3Jz4uE0uxKLz4TD7WhDzGnEhNifBqUAWgPFGYTRdJNCWa6pztdQawjuNKOPzSyFMRWLetQfZf5AtUXEpUG7P53bzT3NiZ/cwPo3lAlDNkZfHUxvbNK35CYlz8tGfIu75pCUF2yZtqzvCISPofH6/28Osv6F6Th/rTPeJMjiU0bScBItYXfYLleXoTDfMlUxpgzj4= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f4efdefb-3d00-45bf-8b83-08d785bea1fa X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2019 02:36:50.2187 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wqjCKDWsf1wujU7pfgk/f/vku6ETq5bmsQV3XMqymatPzcInovtHDOzZYCaNkiXPsYOY8MI0V/arw+52NJoLlc25FKeW4P9/P0mrR2kcc2o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB3895 Return-Path: michael.a.kubacki@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Michael Kubacki > -----Original Message----- > From: Agyeman, Prince > Sent: Friday, December 13, 2019 5:33 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject: [edk2-platforms] [PATCH 07/11] KabylakeOpenBoardPkg: Add BDS > Hook Dxe Driver >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2336 >=20 > Added a DXE driver that registers the minimum platform BDS hook points fo= r > the GalagoPro3 and KabylakeRvp3 boards. > These hooks are triggered on the BDS hook events >=20 > What was done: >=20 > * Included an instance of BoardBdsHookLib and BoardBootManagerLib from > BoardModulePkg >=20 > * Included BdsHookDxe to register the callbacks implemented in > BoardBdsHookLib >=20 > Cc: Michael Kubacki > Cc: Chasel Chiu > Cc: Nate DeSimone >=20 > Signed-off-by: Prince Agyeman > --- > .../Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 7 > +++++++ .../Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf | > 1 + > .../KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc | 6 ++++++ > .../KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf | 1 + > 4 files changed, 15 insertions(+) >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > index a39547f41f..bf63d53bef 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > @@ -201,6 +201,12 @@ >=20 > TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLib > /DxeTestPointCheckLib.inf > !endif >=20 > + ####################################### > + # Board Package > + ####################################### > + > + > BoardBdsHookLib|BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHoo > kLib > + .inf > + > BoardBootManagerLib|BoardModulePkg/Library/BoardBootManagerLib/Boa > rdBo > + otManagerLib.inf > + > ####################################### > # Board-specific > ####################################### > @@ -425,3 +431,4 @@ > } > !endif > BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > + BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf > index da94ed0cd1..196f04c68d 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf > @@ -341,6 +341,7 @@ INF > MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDx > e.inf > INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > INF BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > INF MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf > +INF BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf >=20 > INF ShellPkg/Application/Shell/Shell.inf >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > index 50be2bb624..044688ba4e 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc > @@ -241,6 +241,11 @@ > !if $(TARGET) =3D=3D DEBUG >=20 > TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLib > /DxeTestPointCheckLib.inf > !endif > + ####################################### > + # Board Package > + ####################################### > + > + > BoardBdsHookLib|BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHoo > kLib > + .inf > + > BoardBootManagerLib|BoardModulePkg/Library/BoardBootManagerLib/Boa > rdBo > + otManagerLib.inf >=20 > ####################################### > # Board-specific > @@ -505,3 +510,4 @@ > } > !endif > BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > + BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > index fc1c6a9c25..f2cfff1c7b 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > @@ -343,6 +343,7 @@ INF > MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf > INF > MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDx > e.inf > INF BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > INF MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf > +INF BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf >=20 > INF ShellPkg/Application/Shell/Shell.inf >=20 > -- > 2.19.1.windows.1