Re: [edk2-devel] [PATCH v4 2/9] ManageabilityPkg: Initial package

["Chang, Abner" <abner.chang@amd.com>]

[AMD Official Use Only - General]

Hi Tinh,
See my response below,

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Tinh
> Nguyen via groups.io
> Sent: Tuesday, March 28, 2023 8:37 PM
> To: devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>; Isaac Oram
> <isaac.w.oram@intel.com>; Nate DeSimone
> <nathaniel.l.desimone@intel.com>; Attar, AbdulLateef (Abdul Lateef)
> <AbdulLateef.Attar@amd.com>; Nickle Wang <nicklew@nvidia.com>; Igor
> Kulchytskyy <igork@ami.com>; Attar, AbdulLateef (Abdul Lateef)
> <AbdulLateef.Attar@amd.com>
> Subject: Re: [edk2-devel] [PATCH v4 2/9] ManageabilityPkg: Initial package
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> Hi Abner,
> 
>   How can I include this package into flash description? May we lack the FDF
> file?
> 
> We can refer to AdvanceFeaturePkg, could have PreMemory.fdf and
> PostMemory.fdf
Yes, this is the plan to leverage AdvanceFeaturePkg.

> 
> BTW, Please add PCDs to the feature configuration; this will be very useful
> when other transport drivers are supported.
Sure, I didn’t do this yet because there are not many drivers so far. I will add PCD in next patch set. The first patch is already got reviewed and I am thinking to merge it now or adding more patches on top of it as a new patch version for community review.
Thanks
Abner


> 
> Regards,
> 
> Tinh
> 
> 
> On 3/22/2023 9:48 AM, Chang, Abner via groups.io wrote:
> > From: Abner Chang <abner.chang@amd.com>
> >
> > Initial commit of ManageabilityPkg
> >
> > Signed-off-by: Abner Chang <abner.chang@amd.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Isaac Oram <isaac.w.oram@intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > Cc: Abdul Lateef Attar <abdattar@amd.com>
> > Cc: Nickle Wang <nicklew@nvidia.com>
> > Cc: Igor Kulchytskyy <igork@ami.com>
> > Reviewed-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> > Reviewed-by: Nickle Wang <nicklew@nvidia.com>
> > ---
> >   .../ManageabilityPkg/ManageabilityPkg.dec     | 21 ++++++++++
> >   .../Include/Dsc/Manageability.dsc             | 16 ++++++++
> >   .../ManageabilityPkg/ManageabilityPkg.dsc     | 39
> +++++++++++++++++++
> >   3 files changed, 76 insertions(+)
> >   create mode 100644 Features/ManageabilityPkg/ManageabilityPkg.dec
> >   create mode 100644
> Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
> >   create mode 100644 Features/ManageabilityPkg/ManageabilityPkg.dsc
> >
> > diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec
> > b/Features/ManageabilityPkg/ManageabilityPkg.dec
> > new file mode 100644
> > index 0000000000..71bd8a0c80
> > --- /dev/null
> > +++ b/Features/ManageabilityPkg/ManageabilityPkg.dec
> > @@ -0,0 +1,21 @@
> > +## @file
> > +# Manageabilty Package
> > +# This is the package provides the edk2 drivers and libraries # those
> > +are related to the platform management.
> > +#
> > +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
> > +reserved.<BR> # SPDX-License-Identifier: BSD-2-Clause-Patent # ##
> > +
> > +[Defines]
> > +  DEC_SPECIFICATION = 0x0001001d
> > +  PACKAGE_NAME      = ManageabilityPkg
> > +  PACKAGE_GUID      = 36310119-4FB2-4BA3-959D-74C16B849F9E
> > +  PACKAGE_VERSION   = 1.0
> > +
> > +[Includes]
> > +  Include
> > +
> > +[Guids]
> > +  gManageabilityPkgTokenSpaceGuid = { 0xBDEFFF48, 0x1C31, 0x49CD, {
> > +0xA7, 0x6D, 0x92, 0x9E, 0x60, 0xDB, 0xB9, 0xF8 } }
> > diff --git a/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
> > b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
> > new file mode 100644
> > index 0000000000..2cb63c1ca6
> > --- /dev/null
> > +++ b/Features/ManageabilityPkg/Include/Dsc/Manageability.dsc
> > @@ -0,0 +1,16 @@
> > +## @file
> > +# Common libraries for Manageabilty Package # # Copyright (C) 2023
> > +Advanced Micro Devices, Inc. All rights reserved.<BR> #
> > +SPDX-License-Identifier: BSD-2-Clause-Patent # ##
> > +
> > +[LibraryClasses.ARM, LibraryClasses.AARCH64]
> > +  #
> > +  # This library provides the instrinsic functions generated by a given
> compiler.
> > +  #
> > +  NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
> > +  NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
> > +  ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
> > +
> > diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dsc
> > b/Features/ManageabilityPkg/ManageabilityPkg.dsc
> > new file mode 100644
> > index 0000000000..b3586afa07
> > --- /dev/null
> > +++ b/Features/ManageabilityPkg/ManageabilityPkg.dsc
> > @@ -0,0 +1,39 @@
> > +## @file
> > +# Manageabilty Package
> > +# This is the package provides edk2 drivers and libraries # those are
> > +related to the platform management.
> > +#
> > +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
> > +reserved.<BR> # SPDX-License-Identifier: BSD-2-Clause-Patent # ##
> > +
> > +[Defines]
> > +  PLATFORM_NAME                  = ManageabilityPkg
> > +  PLATFORM_GUID                  = 7A98123A-B194-40B6-A863-A52192F6D65D
> > +  PLATFORM_VERSION               = 1.0
> > +  DSC_SPECIFICATION              = 0x0001001e
> > +  OUTPUT_DIRECTORY               = Build/ManageabilityPkg
> > +  SUPPORTED_ARCHITECTURES        = IA32|X64|ARM|AARCH64|RISCV64
> > +  BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT
> > +  SKUID_IDENTIFIER               = DEFAULT
> > +
> > +[Packages]
> > +  MinPlatformPkg/MinPlatformPkg.dec
> > +
> > +[PcdsFeatureFlag]
> > +  #
> > +  # MinPlatform common include currently required PCD
> > +  #
> > +  gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable
> |FALSE
> > +  gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable
> |FALSE
> > +
> > +#
> > +# Include common libraries
> > +#
> > +!include MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> > +!include MinPlatformPkg/Include/Dsc/CorePeiLib.dsc
> > +!include MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc
> > +
> > +!include Include/Dsc/Manageability.dsc
> > +
> 
> 
> 
>