From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.40]) by mx.groups.io with SMTP id smtpd.web10.14877.1680056493088285662 for ; Tue, 28 Mar 2023 19:21:33 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=bLqEl2R4; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.243.40, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KG6DDhMD5AIcD77ezHkl+rE4FXsmtxy4wIIWWAfUcmrOiU8IgAYUMVpuRivLpetxk/gB4u9MCaTuzB3DkIQl9Hg45lWtkj2WJo2JDg+sKublwuqAetieR3mhBgfjKi9ELaiP5XS9My6kBrnyGgZ2GL/ExKz9qq/2sn6GpcUR8r+zz3h/hmOp570oNRrBdDI10UroEFc2azCwW6T4kn+mj6zNYnB5bAdgThrGKSATlXlHeXAA3Muk07cc5lecQrjnXR/OMgCdxG/TjihjLg9yxn35AN3snMYdgi5miCXJ+2bWUtMyMW09TQ62yq+FCAJ+7Z6C/AI8JxGGWrcnt8bu4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SqRcC2tHy4hj8x/Q2hdVD962F+5pkgMSDTh8qv4v1EY=; b=NlSPnyO4eT+QZHH4dX05mhHhUEgXKw8ZpGzmbdFjjDlmfDpMpBUGekDNLvW84StoY3wsUwE73E8gK+Ym5h07TzWpvHU3KpQ8nIPwR00uROkblZoOiK34IUmdQW37UDWfLuzYFLCXrrqsLcRKw2RAAE2le6MUkTESE8aUI1Q7z4TfkSAx1nUyNuH5HGLHEoyuUL+nF2xqPjXMGHq3SQ8Mxa8K8YdNoxUNM9xcVI0+P3WCsNT1vfJh0pv45P/FNJW5jaCUpcu58OUALWIwIxt1LCJyXg26fLCq4KqK2rHiAfPyihWtN7ONYJEQbguXnb9PJk6aSNscB6+yeyTwVm178A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SqRcC2tHy4hj8x/Q2hdVD962F+5pkgMSDTh8qv4v1EY=; b=bLqEl2R4OdmR1BGI0/pcuEumqM+tfqeJdQIgXKm5RVr6VfStRjPn9RLdzxZs6r6lLDYsYcdD0xTAfj3lbqFpccsDzJxSLOHgju20y2ShwudG1elPPfYFYF7V8uFBH1hywctiuXTODmjxcE2FX60A6NzFho+WS1q3dkVTMDK7KSs= Received: from BY5PR12MB3954.namprd12.prod.outlook.com (2603:10b6:a03:1af::16) by DM6PR12MB4139.namprd12.prod.outlook.com (2603:10b6:5:214::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.41; Wed, 29 Mar 2023 02:21:30 +0000 Received: from BY5PR12MB3954.namprd12.prod.outlook.com ([fe80::8658:10bf:b7b9:4da1]) by BY5PR12MB3954.namprd12.prod.outlook.com ([fe80::8658:10bf:b7b9:4da1%6]) with mapi id 15.20.6222.028; Wed, 29 Mar 2023 02:21:30 +0000 From: "Chang, Abner" To: Nickle Wang , "devel@edk2.groups.io" CC: Igor Kulchytskyy , Nick Ramirez Subject: Re: [PATCH 3/3] RedfishPkg: fix config handler driver issues Thread-Topic: [PATCH 3/3] RedfishPkg: fix config handler driver issues Thread-Index: AQHZYTp44Kpkh1gCT0OlHCakJPAGMa8RB7Zg Date: Wed, 29 Mar 2023 02:21:30 +0000 Message-ID: References: <20230328055919.267-1-nicklew@nvidia.com> In-Reply-To: <20230328055919.267-1-nicklew@nvidia.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-03-29T02:21:28Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=6cc34d5c-575b-4bee-8943-620f7d6859f9; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BY5PR12MB3954:EE_|DM6PR12MB4139:EE_ x-ms-office365-filtering-correlation-id: 9a015453-2838-4c2b-769e-08db2ffc4f0c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ceuc1V5Iqlg3syroHgXysQKmhMHebpBkU/o6bV+HcXOm5R4KleK3wkxywPug1lE4UxJkYzWXKbVVRXpQvnI8/BgjsKuojqgb85X/gakB5yjnHxMxsgVnOSKB0S1PY8jidkuvMzYvFwjDkd6U6KkVX1pf7M4GoVR6inNRESfNR2t3phAqP5I40SHDxhWPBVZhTcf/e/1VZLd1Etiu3QuKMUUFAcK5NwvDuY6TxxNf06WyoP1NHC5yngPqsrc53OZIM663dN9RXvvZaAdSSkV3nreBZVDkyhju3WYP/Lon1+YCt0FPdWSzDhBkp5+rV1+mQ/azi+ZJg7kFd8ywoa7XWPQWo7z0HhGWsQpvCO1sUeZJkstSQPwnK7hZ0UsFb+wBLNcCjK+93EIIJ5jIZ1jQX0HYamns3/TnhtYp3npGHXNuMPoSuMG6PtjpbZ5Y5RQuCHFKp6ysWQyCYs+HZOrCDAvgPE9DqRHTlsDvc7mG1/fK6wImw1LsIUrwWTSPJM52L2j8vFyqpk625YiZy663gS16j0sg9Rldu0sg20GhGNzLtoThTcGFLQjSfcD5NLPWog4rZqQhZS56aFVPCiXNNKjrahSRvODz334CN5RlddZOs8XymALK8NMsWJRWgrd1 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR12MB3954.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(366004)(376002)(39860400002)(136003)(346002)(451199021)(26005)(186003)(7696005)(71200400001)(53546011)(6506007)(76116006)(316002)(66946007)(66446008)(110136005)(64756008)(9686003)(66476007)(66556008)(4326008)(8676002)(54906003)(478600001)(41300700001)(5660300002)(8936002)(52536014)(83380400001)(2906002)(122000001)(55016003)(86362001)(38100700002)(38070700005)(33656002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+rddEOEOOT2xtOde8BkcmqW1aTaA5WeYnyD83SbK5xlO1zd1OpljwIwJEPgo?= =?us-ascii?Q?Kh10lGcPfAJgsYqwaBxjdLTni232JhYveB7OXtj07+o6LGKE6myPGlXhWgd7?= =?us-ascii?Q?ZaoPK/jhTkUmDL5FB31YxGyy3TX3BgCk8fQ2oDkL5UbMM7kahjLtoxDSkAqp?= =?us-ascii?Q?Yi7uxGYROQcHZZrlfkSuQRO/yrvRyW8w76Zn/lLm66EAH3m8NoVZlQvpGcnU?= =?us-ascii?Q?38bWEeVj0T3m4zOUliVIrLy2xkpp/9VxlrcCR7mXJrRQ2FwGmsL0Bzog4iD9?= =?us-ascii?Q?NpQdsOvXobTLPVQLmMyNU6wpGHb0DU4asuysLmZ5PN4wF5LAzxBvMH8BmGuD?= =?us-ascii?Q?sPORoVaTiEP5DuI3AP0kMUar8t+av1clGWHiGFgGy6CBpuDSSzU8t81epF36?= =?us-ascii?Q?/hOOcpEdOlNW/ZiTDWb0SAALvOVrHsrurl5AaBz4GragGvV/D2F4YHj/dsyv?= =?us-ascii?Q?WUPDKLNNzLRubWICJxKmmIfOsq0jqc1isE2AE7KwGDKbmzA9l1Lugrm4hikt?= =?us-ascii?Q?JuEqzrp4xSfkAfAPtdJBzD2GQ6w71P+lsWXLbaI1Yeu3MUwt7z4anWMaKjHT?= =?us-ascii?Q?WbdvvNiqCWT3rLBR168byoMhVJP2XRdQbCCAYE4hJVpe+3Qab+QWagGLJV/l?= =?us-ascii?Q?OTCgZ7yvSA6uFwVE/GmKa07kcc10Q5mPJjMyB/QoJuVg+Rtq7LmcxUW7vkRH?= =?us-ascii?Q?aV2z+KGxeQRxZjHfto/Iy4N5jiJk0T5CRtoMHuQiISYYTi3200KUkpyv4nKE?= =?us-ascii?Q?s76w6Ne+kzmx0HrDX/UBhQntDOXeX5YSLL4doxn0q0ZILDcNFRwa32npiMBI?= =?us-ascii?Q?ERDYZXU5Uf2A0+9hMHu3wYFmQfY9qhEpI9kpF0M8ShqIJEh4zSFZmz2er3dO?= =?us-ascii?Q?1725EIyj0WldIJacg5EX6Iz/pmbXa7gfN2TXdUrahcxlohX9CvzrZda9mM5x?= =?us-ascii?Q?g8gN4kxxYe5x/dx8jPxUt50JMVQeCQgyTAn2OSZbZTzXHM9Dc/jOSSaSSBWc?= =?us-ascii?Q?nNBo1GRGxNT3y3nbrCPAIOjBUusx0Z+n+G0G3H7XZftPEaAzEIFbbklvhujy?= =?us-ascii?Q?NrMOqc+EUwNvwkQJPYwLCzlcbGwHacUbgxLDtI2dKN3It2ieq6ht7gc2gFdT?= =?us-ascii?Q?25scQ1kVt4b1qG5MLszOohLZ+imhlbSUeWiS9D/Zkab7vrkESQGk8OTrAmF9?= =?us-ascii?Q?h+SYXxRo7KkgxM6wwjf+hGwF/arzV+zV9QMu29nZxuncKvI8XiLoPgJl+2NY?= =?us-ascii?Q?IkZR49dXnIEQ2ykfgqdX+x/8izU4ZgVrth3q3SmmpR1eq6YmgOPH12iwAHk+?= =?us-ascii?Q?r9S2H0J4+hkthqtbVd7aq5dmRJkKQcnX8G8JradsLKLf2H52fNDyx2v8M0tg?= =?us-ascii?Q?17TtyfdB/AQ+ewKJHIpOaA4dETkcMi0tUZHZ3XXjuPF6Dxet6oAmDmKTslF9?= =?us-ascii?Q?db1fdSHkwztTfJNW5oFr/0nKshuLKt27AgbZYNdLBMOUW1BI6HLXchjajbEg?= =?us-ascii?Q?eBLp/JyR70nzH7i6LqV58cBHR3t073sgAC59dqRHdlEouFX+JssQiNl/b7u+?= =?us-ascii?Q?OlUK5c4tNdd/mdpIk7c=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB3954.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a015453-2838-4c2b-769e-08db2ffc4f0c X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2023 02:21:30.7461 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JdV73hqUVDZE3DB+OEEzPhsm/UEyKVvoYdaZEtu2fdjlHjX3kf/FrSP/oZ+nvIkLQYmLlxWQPskaaN6pGtmqqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4139 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Nickle Wang > Sent: Tuesday, March 28, 2023 1:59 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [PATCH 3/3] RedfishPkg: fix config handler driver issues >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > Bug fix: > - function stack fault > - config handler driver requires the dependency of Redfish Credential > Protocol > - incorrect caller id installation when failed to perform init() > - fix typo >=20 > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nick Ramirez > --- > .../RedfishConfigHandlerDriver.inf | 4 ++-- > .../RedfishConfigHandler/RedfishConfigHandlerCommon.c | 10 ++++++---- > 2 files changed, 8 insertions(+), 6 deletions(-) >=20 > diff --git a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.i= nf > b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.inf > index def91c7531..b167c6e1ee 100644 > --- a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.inf > +++ b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.inf > @@ -4,6 +4,7 @@ > # > # Copyright (c) 2019, Intel Corporation. All rights reserved.
# (= C) > Copyright 2021 Hewlett Packard Enterprise Development LP
> +# Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights > reserved. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -56,5 +57,4 @@ > gEfiEndOfDxeEventGroupGuid ## CONSUMES ## Event >=20 > [Depex] > - TRUE > - > + gEdkIIRedfishCredentialProtocolGuid > diff --git > a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c > b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c > index c3a7efd796..96aac125ee 100644 > --- a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c > +++ b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c > @@ -2,6 +2,7 @@ > The common code of EDKII Redfish Configuration Handler driver. >=20 > (C) Copyright 2021 Hewlett Packard Enterprise Development LP
> + Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserv= ed. >=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @@ -9,7 +10,7 @@ >=20 > #include "RedfishConfigHandlerCommon.h" >=20 > -REDFISH_CONFIG_DRIVER_DATA gRedfishConfigData; // Only one > Redfish service supproted > +REDFISH_CONFIG_DRIVER_DATA gRedfishConfigData; // Only one > Redfish service supported > // on platform for t= he BIOS > // Redfish configura= tion. > EFI_EVENT gEndOfDxeEvent =3D NULL; > @@ -34,7 +35,7 @@ RedfishConfigOnEndOfDxe ( >=20 > Status =3D gCredential->StopService (gCredential, > ServiceStopTypeSecureBootDisabled); > if (EFI_ERROR (Status) && (Status !=3D EFI_UNSUPPORTED)) { > - DEBUG ((DEBUG_ERROR, "Redfish credential protocol faied to stop serv= ice > on EndOfDxe: %r", Status)); > + DEBUG ((DEBUG_ERROR, "Redfish credential protocol failed to stop > + service on EndOfDxe: %r", Status)); > } >=20 > // > @@ -62,7 +63,7 @@ RedfishConfigOnExitBootService ( >=20 > Status =3D gCredential->StopService (gCredential, > ServiceStopTypeExitBootService); > if (EFI_ERROR (Status) && (Status !=3D EFI_UNSUPPORTED)) { > - DEBUG ((DEBUG_ERROR, "Redfish credential protocol faied to stop serv= ice > on ExitBootService: %r", Status)); > + DEBUG ((DEBUG_ERROR, "Redfish credential protocol failed to stop > + service on ExitBootService: %r", Status)); > } > } >=20 > @@ -225,7 +226,7 @@ RedfishConfigHandlerInitialization ( > UINTN NumberOfHandles; > EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL *ConfigHandler; > UINTN Index; > - UINT32 Id; > + UINT32 *Id; >=20 > Status =3D gBS->LocateHandleBuffer ( > ByProtocol, > @@ -257,6 +258,7 @@ RedfishConfigHandlerInitialization ( > Status =3D ConfigHandler->Init (ConfigHandler, > &gRedfishConfigData.RedfishServiceInfo); > if (EFI_ERROR (Status) && (Status !=3D EFI_ALREADY_STARTED)) { > DEBUG ((DEBUG_ERROR, "ERROR: Failed to init Redfish config handler > %p.\n", ConfigHandler)); > + continue; > } >=20 > // > -- > 2.40.0.windows.1