From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id E9A3D780091 for ; Wed, 15 Nov 2023 16:24:53 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=AvUtLU04wT130ADut+3RnjXv/o1S9OLbUOAOaewcjMg=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20140610; t=1700065492; v=1; b=Vcl1cxjyn84E9XqGyBXKGl0+McUBxORQufUga0pv30OioTNuYcr61djWbO3VdispHl7HZ3eY 0oHnhT1BLBW7bglrINLifAItJDohoKdSS7mQHBSKAa/R4Rv7mS01AWmmNCNOl/ehTJ7arh64zr6 KKx4dQ/s/vHz5o7COWmj2DQ8= X-Received: by 127.0.0.2 with SMTP id xNo2YY7687511xf3bSlT7rLy; Wed, 15 Nov 2023 08:24:52 -0800 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.59]) by mx.groups.io with SMTP id smtpd.web10.17640.1700065491870080531 for ; Wed, 15 Nov 2023 08:24:52 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jyFr9xoz0tHUPm53H5rPMFq6WobSI+IKdczEnPXsHQVhJUm6MpZQoxus+a7YiXfZgAm3IHwS6wgkf8cpGQL2RkmsMrplbw5QAw+fopFsXXJg5vMmMHf3GakLg41gIq3yzvYBFDeI8HO3RZxWcPFE8Q/IGJOj/Fwlt8H9i9DvpY6EvqIKMXoPqftLHV11FFUT8nOq35TnM2VtsVhvdkJcRiWPP6WZglsAZVuUWNryieeC0f1IOzYG7N37Q1WHbTSMVpGE8mVZqXUyywXYTZrUeoPL0IAi5gj0otY9RrVe6aObnIabXpQcJSMc/FDqr8gsh9Uc1hnPOBrrBeZvLCHaFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U7/BtmZ6q0N+7x2qoC2Ek3LeTEeBL08L/gaL1PhK1Zk=; b=b8yzTRRxDdQSpEhsEbVzYmw+uFnYK3uTkLa7l1/aMPpnVpxoo0mA7C7IwdRhkteMtbxZ/ISl/WinBQmnXTKcJE2RecggFuifRimQwrKv/ELN8J4nfDz3RFJ1x1EqeKzHVdyyiU0R7BI6sGKAZ7tewEf9vIlVYuXtRRHjqYLqt5S5RHH98thOy/z2ADpaSACwkWZ3sXwAFFdLTvB1+TDdDLO1tIe0B4CHMDQ9SFQaLm5Qc+qUCFDKqNzgvXiV6ov5hDlwsoBVeWGC30bj8d6Uzfsp9htSwmk+1S1cpQw+XrVdrpEwhCG0F3Q0vecYZqLx7f7KOSklccNfNdKRx29rvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from BY5PR12MB5544.namprd12.prod.outlook.com (2603:10b6:a03:1d9::22) by CH0PR12MB5234.namprd12.prod.outlook.com (2603:10b6:610:d1::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.31; Wed, 15 Nov 2023 16:24:46 +0000 X-Received: from BY5PR12MB5544.namprd12.prod.outlook.com ([fe80::108e:2378:282b:6d89]) by BY5PR12MB5544.namprd12.prod.outlook.com ([fe80::108e:2378:282b:6d89%4]) with mapi id 15.20.7002.018; Wed, 15 Nov 2023 16:24:46 +0000 From: "Ashish Singhal via groups.io" To: Leif Lindholm CC: "devel@edk2.groups.io" , "ardb+tianocore@kernel.org" , "sami.mujawar@arm.com" , Jeff Brasen Subject: Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation Thread-Topic: [PATCH] DynamicTablesPkg: Fix ETE _UID Creation Thread-Index: AQHaF3KJdq6FPxbXTk2NbRrvZtcxGLB7kI4AgAAApKY= Date: Wed, 15 Nov 2023 16:24:46 +0000 Message-ID: References: <0dfe6159ce24094f914dbe340a5656b95895b808.1700018266.git.ashishsingha@nvidia.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BY5PR12MB5544:EE_|CH0PR12MB5234:EE_ x-ms-office365-filtering-correlation-id: 040f69fe-4deb-4ffd-1d5d-08dbe5f761d4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: qZ4q28hyCSiJLaQ4xwuHjcx/G8SqSCqiBd3fX+iFjB+VIBc69G8BoTxshMoAAZ2+9jDgbm4Aw1GLWPOCqbsTYEasxqC/Zgkvsn7xqMTWy04qzot+v+s0l+yqBaD3idXFdKLZ8QwkwFlqlbxrRGpma16etVz8E3Jg+oR7/s4NFeoHSXrgARWM+jSNXDo7ZpdLnFogrRMczFc3fzAZZJoudiNjcH9qheWA2itgXG7zsYKV0i7k9B+p9jOLbW1K7zzuNWGc2FJh2dyJ9a7yGlMfyz3KBq7xKfokN31XhhOZK2FcI64GEBxxEnYyReQ1wz94/ZPT0VHilqOZ+rgBsTa/pTpfWBaH2U1pprLsMRsukgDISPPuktFVQZ1cIFTWkeg4N0PLw+dnZGMBSTl5Hd5HTVr3FLJikoqFrHfbfxC2vVe/lUjI3zqVhQNMDMuRANx26kBHvoRLKVl7rb0ZTSNIdlmsQ2VwsSYd+VbumR/nCZ+MrGBBt2dA1veRXLgXx2HmXFrj/bsHFUnEJj+9RV1/n5pMU+3Gy5hERh6x0si+mr43W7cFZTeo+bKaT2ITAV6j1dCd6SfqKNhS99UlISC1DtA+wGJ7/3XmAVeWQ8HTvUvQF3pCWnhj4Waemv9hyoAmzGExiS2kIz/eUA8zpqIvG2h+v1ArRhcUR+UOtLBibNo= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?g6kbMXy5C+/nMqES1EVIjigKjrwoUumJEd1hyX26hWDw3Ol/5X2I8buWDY?= =?iso-8859-1?Q?KJp+CgXkapE1YD7x16+tTeubJvfce1JhhrNHS86QbeiS70Xx1ct5XlJzdW?= =?iso-8859-1?Q?UB8lAbGWpvtiUcBK7DIZE51IDn5o3/hWAxQp4UvOsx5U7LYiMjA9XoSlRn?= =?iso-8859-1?Q?OKylWwcZ0zttzUYVKKKzhRwFoSORmSfFoyRQ4p5pxh53G1W9+9w6A8WYv1?= =?iso-8859-1?Q?BCtDp/OfLip+x+/+4VZ4P4xH+h4rXY9N5bNkZh5YsNqlvTbZrY+qYB+Zb4?= =?iso-8859-1?Q?mGTO4qeJkZ598/ZymySy5+IEO6yYhR3VpV4bNnfUCiuqCcJuL7B8EVwb32?= =?iso-8859-1?Q?fP0brDGUP+LHeYSDAGSnLeYQ+rZ/O1Cdmc3iQHhCOjVxgaDYcDEdOoxcnx?= =?iso-8859-1?Q?rtPTTFAC4coaUaLowFt2tcJcnEe3RpTHcFtaJF0+skgTwFfCVz6cLclyRj?= =?iso-8859-1?Q?7f2/npKeevViiT9eug71gboJuDUnTegQusXY+lULUY7/qs/7BjuY39LroX?= =?iso-8859-1?Q?aVOgvydZC1oSOdThk03cYPrCQsrC5zkRoVy/AIAS8W6wh2nq0qCygYf4Wf?= =?iso-8859-1?Q?CGCDnndejiWz7WAObM2MyqOQ8WhuYBQkOHWbnbeX9izrfP8w3Ww3yDxlam?= =?iso-8859-1?Q?K7yfobIrqgSVGLV/T+144Y84A+McwCAaBKsMmjnnGLvCo4mXwtPx9U1STh?= =?iso-8859-1?Q?qjEDt0uk8aEMEoMyB3KXzwKPxwM7fcQUdAC++pCokpJ3ipY0yJ8L2KI1/m?= =?iso-8859-1?Q?37HYwLNThvk17ZyzbQj1YNjA0GrGfz89LcXyniiYYUNQKrmHPeFJT4isVA?= =?iso-8859-1?Q?2wFOco/hf5VtMd55Nh9q6RmyNZI+hYn51/SS07sgavVb06oesA4L0YrG/h?= =?iso-8859-1?Q?8+Z3NLbpbzHgCLmZtQnvco7OAJ/DNXMplb0g/44VhkFWhovxGZXTL40vSB?= =?iso-8859-1?Q?tMe9BOdbQGEsW2V9Z3z2zlMNb7qEN45nEvVYrg8iSeeRAAIECSZ6UN2DmX?= =?iso-8859-1?Q?iv+/PC2KeLvGlmKwxtaGyYhqEV9QbXxCS8FR8sZNRz7fo+OnfZmoQ5Vf+y?= =?iso-8859-1?Q?Xc9cBc7sdSsvj1gJ8bjduEJdLFcwH9WocLT4uLvTyKKpMoWNXZ8jVKT46q?= =?iso-8859-1?Q?TWgiszerLHew78OuILNHbro7TMD32xckITjriQsJPmgB8j1Vu6gmYrAuII?= =?iso-8859-1?Q?2Nh/KsUB5FjN3RJzc2/h7Nt0izMGLq9ZCgNPrWEfRsllB+m/bJCK2dhCwW?= =?iso-8859-1?Q?4kldWPWIojjaWUWXx6CiV5TwvMyb4FX92iQkuE6KmfVa8wdPN+f7EJVRin?= =?iso-8859-1?Q?as+ztcKP1wX0oMin/UupZs18D689ZxuxJSpoCVTVecIWsqiv5aIFkVXFjX?= =?iso-8859-1?Q?NMtV2q6AJWygvHCjIX6N1vDcsGRZwFc9mjS5YtuBtn8ppsp2WRoH6JUNxX?= =?iso-8859-1?Q?imt9p5zNgMsroOREiAoz/+K40h9KBDXgid4Zz09eBRdgkEqtDWmsl2yajk?= =?iso-8859-1?Q?pB+fJcsBab1Gr8azrlURA3ySokTanePQfn6siRvnupJFSVlJx35pXzYYkH?= =?iso-8859-1?Q?7ojqHy/lMe+Hdus1xT/lPDJyahTT9+HtI0NQeubc65r2YCANWiwXp4TkCy?= =?iso-8859-1?Q?9wN/fGXatKLkig0FtWrkZEy4vEnP9NS8+4?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB5544.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 040f69fe-4deb-4ffd-1d5d-08dbe5f761d4 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Nov 2023 16:24:46.3924 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JLPzGEG505cSsWw8y9qOha3VJ5rFSa9meCMFVB2hHTJKKWZDgKFRO7ymwi3bXypmt0T56WHVPHNbdtsLxPNgkw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5234 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ashishsingha@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: UstCvlvjkIyyJNLgORg66nuAx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BY5PR12MB554406A035F719FD1C83CEDBBAB1ABY5PR12MB5544namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Vcl1cxjy; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_BY5PR12MB554406A035F719FD1C83CEDBBAB1ABY5PR12MB5544namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable ________________________________ From: Leif Lindholm Sent: Wednesday, November 15, 2023 9:21 AM To: Ashish Singhal Cc: devel@edk2.groups.io ; ardb+tianocore@kernel.org = ; sami.mujawar@arm.com ; J= eff Brasen Subject: Re: [PATCH] DynamicTablesPkg: Fix ETE _UID Creation External email: Use caution opening links or attachments On Tue, Nov 14, 2023 at 20:19:04 -0700, Ashish Singhal wrote: > Just like CPU _UID, ETE UID also needs to be unique so > use AcpiProcessorUid instead of CpuName > > Signed-off-by: Ashish Singhal > --- > .../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/= SsdtCpuTopologyGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuT= opologyLibArm/SsdtCpuTopologyGenerator.c > index 8228c7845a..724f33c660 100644 > --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpu= TopologyGenerator.c > +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpu= TopologyGenerator.c > @@ -359,6 +359,7 @@ CreateAmlCpcNode ( > > @param [in] Generator The SSDT Cpu Topology generator. > @param [in] ParentNode Parent node to attach the Cpu node to. > + @param [in] GicCInfo CM_ARM_GICC_INFO object used to create the n= ode. > @param [in] CpuName Value used to generate the node name. Can that replace both uses of CpuName in the function (so it can be dropped), or does Status =3D WriteAslName ('E', CpuName, AslName); have other requirements? / Leif Hello Leif, CPU Name can be more logical, and you may have the same CPU name in differe= nt clusters for example. _UID however needs to be unique. Thanks Ashish > @param [out] EtNodePtr If not NULL, return the created Cpu node. > > @@ -372,6 +373,7 @@ EFIAPI > CreateAmlEtd ( > IN ACPI_CPU_TOPOLOGY_GENERATOR *Generator, > IN AML_NODE_HANDLE ParentNode, > + IN CM_ARM_GICC_INFO *GicCInfo, > IN UINT32 CpuName, > OUT AML_OBJECT_NODE_HANDLE *EtNodePtr OPTIONAL > ) > @@ -397,7 +399,7 @@ CreateAmlEtd ( > > Status =3D AmlCodeGenNameInteger ( > "_UID", > - CpuName, > + GicCInfo->AcpiProcessorUid, > EtNode, > NULL > ); > @@ -474,6 +476,7 @@ CreateAmlEtNode ( > Status =3D CreateAmlEtd ( > Generator, > Node, > + GicCInfo, > CpuName, > NULL > ); > -- > 2.17.1 > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111280): https://edk2.groups.io/g/devel/message/111280 Mute This Topic: https://groups.io/mt/102598848/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_BY5PR12MB554406A035F719FD1C83CEDBBAB1ABY5PR12MB5544namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable


From: Leif Lindholm &l= t;quic_llindhol@quicinc.com>
Sent: Wednesday, November 15, 2023 9:21 AM
To: Ashish Singhal <ashishsingha@nvidia.com>
Cc: devel@edk2.groups.io <devel@edk2.groups.io>; ardb+tianocor= e@kernel.org <ardb+tianocore@kernel.org>; sami.mujawar@arm.com <sa= mi.mujawar@arm.com>; Jeff Brasen <jbrasen@nvidia.com>
Subject: Re: [PATCH] DynamicTablesPkg: Fix ETE _UID Creation
 
External email: Use caution opening= links or attachments


On Tue, Nov 14, 2023 at 20:19:04 -0700, Ashish Singhal wrote:
> Just like CPU _UID, ETE UID also needs to be unique so
> use AcpiProcessorUid instead of CpuName
>
> Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com>
> ---
>  .../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 5= ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibA= rm/SsdtCpuTopologyGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtC= puTopologyLibArm/SsdtCpuTopologyGenerator.c
> index 8228c7845a..724f33c660 100644
> --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/Ssdt= CpuTopologyGenerator.c
> +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/Ssdt= CpuTopologyGenerator.c
> @@ -359,6 +359,7 @@ CreateAmlCpcNode (
>
>    @param [in]  Generator    The SS= DT Cpu Topology generator.
>    @param [in]  ParentNode   Parent node= to attach the Cpu node to.
> +  @param [in]  GicCInfo     CM_ARM_GICC= _INFO object used to create the node.
>    @param [in]  CpuName    &nb= sp; Value used to generate the node name.

Can that replace both uses of CpuName in the function (so it can be
dropped), or does

  Status =3D WriteAslName ('E', CpuName, AslName);

have other requirements?

/
    Leif

Hello Leif,

CPU Name can be more logical, and y= ou may have the same CPU name in different clusters for example. _UID howev= er needs to be unique.

Thanks
Ashish

>    @param [out] EtNodePtr   If not NULL, retu= rn the created Cpu node.
>
> @@ -372,6 +373,7 @@ EFIAPI
>  CreateAmlEtd (
>    IN   ACPI_CPU_TOPOLOGY_GENERATOR  *Ge= nerator,
>    IN   AML_NODE_HANDLE   &nbs= p;          ParentNode,
> +  IN   CM_ARM_GICC_INFO     &= nbsp;       *GicCInfo,
>    IN   UINT32     &= nbsp;           &nbs= p;     CpuName,
>    OUT  AML_OBJECT_NODE_HANDLE   &n= bsp;   *EtNodePtr OPTIONAL
>    )
> @@ -397,7 +399,7 @@ CreateAmlEtd (
>
>    Status =3D AmlCodeGenNameInteger (
>            = ;   "_UID",
> -           &nb= sp; CpuName,
> +           &nb= sp; GicCInfo->AcpiProcessorUid,
>            = ;   EtNode,
>            = ;   NULL
>            = ;   );
> @@ -474,6 +476,7 @@ CreateAmlEtNode (
>    Status =3D CreateAmlEtd (
>            = ;   Generator,
>            = ;   Node,
> +           &nb= sp; GicCInfo,
>            = ;   CpuName,
>            = ;   NULL
>            = ;   );
> --
> 2.17.1
>
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#111280) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_BY5PR12MB554406A035F719FD1C83CEDBBAB1ABY5PR12MB5544namp_--