From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6E81DD804D6 for ; Fri, 17 Nov 2023 16:37:50 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=zGZiGBk1lKq47jY7vpR6IbYi3OQ/31OE2hh27qeV/dc=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20140610; t=1700239069; v=1; b=ZNbt8qveDGv7y66FCJzCEEUqvCk2AAYFJbkjxNNOGziBlFWWUz5Hc1IaHALUEyTvWAxpv5ud 4kpZvYR4ZgHMGxdM6mRXvs9phy/O2WOXB5rZmiwBPnvCtyPoeO8p1LWWk5tYNbdD5i2+FGBhUJL LJkegi5FQLI1Fl/WxZSrC1Fc= X-Received: by 127.0.0.2 with SMTP id 1lUyYY7687511xHQebDQFdSQ; Fri, 17 Nov 2023 08:37:49 -0800 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.51]) by mx.groups.io with SMTP id smtpd.web11.80.1700239068278148026 for ; Fri, 17 Nov 2023 08:37:48 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QvmkkVwVnIiw/wMDYOSLsHJV6CXgkHmQfyWiJ4anx1f9RvWYHpn2AOAQUCKazcajIjLyH6sX3fjAn11tVaocIrcG+G3bfLM1zZARONvlja21imbuUHoRY897+k+M8gXbhTnduCClKvV25k1p749cZlrhO+gMLLB94lZpGI91kaxeKAJdUTopbh28bQEf6pwh/61v45uM7maNEt5X8Cc1BqXPnlH91y9SrPJZgCMMBzERt2cz7oZYWV95qLxpZO9lo3MZp9ekSEL8VQ5MifY58q5utrTOEcbxLAUsKj1260yIoGuRkc5HXasM6PAPeuTnrEuadapB36/rzYAqbIPIMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rzktcO1QKtYmM7CxElaETu9uj03rXpjh3UjS9ffq/7g=; b=E5mrq5if8czkMr9jFi3fIjPuUaGIEkm5pQBlBCAj2MSJSJeRq9XlVRn4o3+YzLBpEKk+Rqft/miTvcjQissRs0cjyO4RfvrlrjrDRDmx/lny8YNdT5g9ad6R1cWduLzaUjxt4J2lL3PZAapQn48fhYOxp01gbTctN5yDCYHBCmD/PChL52xEkCuFoBqYG/RgPXPQcjq3qRgegXqpCPPI/gN5Siub2tkXvWyZPIZ0xhn5iDPk2NeCuxzmbet96wERrtMlNxHXOpORBazUTIvCu1KkTYNl57qW9C4AA2/g6lkHeH6Me0f2PcGXXXKNnmKAygBj4+oX+HNaRLXr+rQSSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from BY5PR12MB5544.namprd12.prod.outlook.com (2603:10b6:a03:1d9::22) by DM4PR12MB6663.namprd12.prod.outlook.com (2603:10b6:8:8f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.21; Fri, 17 Nov 2023 16:37:44 +0000 X-Received: from BY5PR12MB5544.namprd12.prod.outlook.com ([fe80::108e:2378:282b:6d89]) by BY5PR12MB5544.namprd12.prod.outlook.com ([fe80::108e:2378:282b:6d89%4]) with mapi id 15.20.7002.022; Fri, 17 Nov 2023 16:37:44 +0000 From: "Ashish Singhal via groups.io" To: Laszlo Ersek , "devel@edk2.groups.io" , "quic_llindhol@quicinc.com" , "ardb+tianocore@kernel.org" , "sami.mujawar@arm.com" , Jeff Brasen CC: Michael Kinney , "Liming Gao (Byosoft address)" Subject: Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation Thread-Topic: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation Thread-Index: AQHaF3KJdq6FPxbXTk2NbRrvZtcxGLB+P8IAgAB5oUc= Date: Fri, 17 Nov 2023 16:37:44 +0000 Message-ID: References: <0dfe6159ce24094f914dbe340a5656b95895b808.1700018266.git.ashishsingha@nvidia.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BY5PR12MB5544:EE_|DM4PR12MB6663:EE_ x-ms-office365-filtering-correlation-id: 57fef262-b965-4cd5-7744-08dbe78b8697 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: Q6XIgnhoury277xceypmmIiU2tfre02MvKFOQa8tJWzTCs4x0f2mJJA0YOySjiSl/C57O7v5yCR1pojzQ7Moxp8tSLywAYJ9j+1+a8/Apab0JjzW8VHgBMf0dPwZ53Qdq99lXb364f9w8B5IsYzniFwdKEToJuczZb6I+jYM3LLPZMsCZ6uE7j8Vsgg8TLY1W73aaDv52X+iiX4BmS4poRaXkGZQtSSqeyIy/XR9TIZJbA8AgOKduJQ0v0BHHA9oJigXrHAVFCqYjvvMvMpXu8OWGVe/RzgT64mk2mDc+4LLnRjfdY+/Y/SDPiFsYdOrl1+qXVhq78HjQ/l6XEGbZyeWFkpqm3gL1qqq4ZP9eBHwmUQZtmNg7oFjfcgCR8RBz7JXZpLERpwkwecLigWTUUkck8ZDXQnjzVIoeudeEpzqPGDldzWkO18SEacnjQ4pf8E/fWkXVF/QSvfq6ciYjxhBL4Z/mTiFifmnEJYVr56w7z01BsLqhw3ZwqfVk8epM2gZmt33e6LBx3yVxnzXq2w1zMsXfSEeuBKIG9mK5jll6eezUgdjiO/S1K9PAlmjWGW9fMQaG53j6LT8fxcq8HyrYcVx60WiF6RWmmrqAkWuO3nWdP6jNuvYTfcvZBKjZpRg2jmVaf/uIObijlE7CQ== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?JudVd6H07AYrSEJJ4r0qLL9v4nwYvik005YxrNU8d8G6Ptt0IdhhnGpvkV?= =?iso-8859-1?Q?royipyy3WRjfMmV3Bhn5VulUz2pzROp1rKuOEI8MRNyW5kv++mh7fPLoTR?= =?iso-8859-1?Q?je0ognvFx2KDDtAMINZgTAQhHenfsCumtt5BAHO6DRUlJKa+M32VQH8fHV?= =?iso-8859-1?Q?i4zxErJQKI63xYrBuRD8sDx7Bcm1/gXdzOIXp+0iL7cKbLi7GxgWodpkDo?= =?iso-8859-1?Q?gbhV2rp75Up+6e9TbKVzTLRXIfIVkG4yl2QJ3y+7twwU4XCkchd3OU5qzl?= =?iso-8859-1?Q?iTfStFMgKoVfped8d0R08jYp2cF0JG6ByZbVrjTrf+GaVTCrjh1JMsy4lO?= =?iso-8859-1?Q?OGyeF2TMe6NVNUX8gNoI3zN6lNmGBzvL5EOj/SFqOQ5zgB1SruQO9XDdzL?= =?iso-8859-1?Q?Q7ulMpwWTZodDRYNYbWIuTcWF+e1LC209eIrlmsfrQtQLkfdUPGAUDeOXb?= =?iso-8859-1?Q?0KejsLvs/tJv5ZKpp4Xc+JypLpttvcDZk+73lQb0it5ZuQAk8UlGOtpEAy?= =?iso-8859-1?Q?2UsWR6UDrqiYb8WMlmKhUuaMmo2aGzZwHN0BMZOwBlnM6yvnp1x2gaRUA6?= =?iso-8859-1?Q?GOskvsoNQkxKS/4W/Y79lkoEpeT1oOU0/PLAWajF1+jhkKLvGsMXSCC1wB?= =?iso-8859-1?Q?izOw1wlj7ef8IYENHUxrulkOlvjYQ6AerP1rUc/T/E5XNajRLdDM6C3AlD?= =?iso-8859-1?Q?khoFRFFFM2p4ObB8J1DI5mV3nmEsdR729ZHuKe3oloNQslJQGifODHDwF8?= =?iso-8859-1?Q?yoJ9Irv//LeL5fAOKLuCE7gSJWdsPcE+Kfx28/FbLaLHarEHDVSEIvFWnT?= =?iso-8859-1?Q?rdLIhdU8B4GZeAYdqJqETPQc0guxS4Tw1n7JjF6OxSJtkRMOjyj+311NjQ?= =?iso-8859-1?Q?7B0T2qIePgEmuvRTWPiLKHSfzxjePryPtLszEfup5PJRGQ0nhARn8xOIzd?= =?iso-8859-1?Q?4KIWS3A0yHCv6bOKdtbns30kaFJGDdQuLvvr1FEEw2BfLwJTk5OcOAVpYL?= =?iso-8859-1?Q?3ZiKqRikm0kW/YkCD/1tWO7aEzK1X6b9jWCXF5RI2WNLvTXltgk4NQExYk?= =?iso-8859-1?Q?m/759mM+asckR3urFr0jiOnPILThLugeYxHbzj02OaZfsYmFaSQslJC6KE?= =?iso-8859-1?Q?ZD2HY475b8j0LPV2NGZmnTA3LMKFJUV0BvNzMDQBLeBfP9ec8zt8fiU+Zd?= =?iso-8859-1?Q?I/afMi8/gZkqEUyHIrf5CDvMe3MdRNS8QJMimpEHWthLGbGUtkQIiU1pIn?= =?iso-8859-1?Q?bCrg4ckH3HzhSrhfMiwlJmLF79djUl9XcLH1pZrooSDC/M/Q6hS2QQF37Z?= =?iso-8859-1?Q?kcmTk0DjKQ7ZSd2OvjHeY7FCsWsATBji/Eji8UXNqeHKJKj2i5q6160Pr/?= =?iso-8859-1?Q?IzaFVx7bJ1BdXUdxnqYcEs4ri0rrExGEAa7qS75wSxOm3zKSlr/RV6Ck5S?= =?iso-8859-1?Q?aCfJuS7ogUClUsGuIK8I9nnKL6Jp3znu+ZAH+Ai06m788uz0Di+jgoa1Z7?= =?iso-8859-1?Q?TAUGlxa8OxOJRUMt47C/v1NwmZUgOlzpoHUUGL7J+OdKcdzU/NUz1Lrw2b?= =?iso-8859-1?Q?vhR/uPM2CUPcgcDmIZakkx6GyXPX2XkYB6Cc3JDQUosbx4EcFqnA/nvQjE?= =?iso-8859-1?Q?981vcmJTBEVie5720hdoS8xgUS9ffG2rTy?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB5544.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 57fef262-b965-4cd5-7744-08dbe78b8697 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2023 16:37:44.7192 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ke9v+VVWmJQAvZZjXxj7QzQvyUv7z4uUWCikJ7+Pnnu9Sr3qZ5zw1YolNg8lTFch9yAFWp3rcMiHNSwGXQFDMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6663 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ashishsingha@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: d1WMPT8KHc5sKeLYAI2bih3yx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BY5PR12MB55442668B0872C439028C51ABAB7ABY5PR12MB5544namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ZNbt8qve; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") --_000_BY5PR12MB55442668B0872C439028C51ABAB7ABY5PR12MB5544namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable ________________________________ From: Laszlo Ersek Sent: Friday, November 17, 2023 2:20 AM To: devel@edk2.groups.io ; Ashish Singhal ; quic_llindhol@quicinc.com ; ardb= +tianocore@kernel.org ; sami.mujawar@arm.com ; Jeff Brasen Cc: Michael Kinney ; Liming Gao (Byosoft addres= s) Subject: Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation External email: Use caution opening links or attachments On 11/15/23 04:19, Ashish Singhal via groups.io wrote: > Just like CPU _UID, ETE UID also needs to be unique so > use AcpiProcessorUid instead of CpuName > > Signed-off-by: Ashish Singhal > --- > .../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Is this a fixup for the recent feature [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support https://edk2.groups.io/g/devel/message/108996 ? If so, then I *think* this qualifies to be merged during the hard feature freeze (+Liming +Mike), but: - I think we should have a "Fixes:" tag in the commit message (for pointing out the commit that should have contained the code being added/updated now) - I think we should have a BZ too (also linked into the commit message). Laszlo Hello Laszlo, The issue was indeed introduced in the patch series you pointed to and prec= isely in the commit https://github.com/tianocore/edk2/commit/3ee23713e1ce09= faa6fa66ee6799e3e336deb58b. This is indeed a bug and should ideally be fixe= d as soon as possible. Do you need me to file BZ bug and link that in commi= t message? Thanks Ashish > > diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/= SsdtCpuTopologyGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuT= opologyLibArm/SsdtCpuTopologyGenerator.c > index 8228c7845a..724f33c660 100644 > --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpu= TopologyGenerator.c > +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpu= TopologyGenerator.c > @@ -359,6 +359,7 @@ CreateAmlCpcNode ( > > @param [in] Generator The SSDT Cpu Topology generator. > @param [in] ParentNode Parent node to attach the Cpu node to. > + @param [in] GicCInfo CM_ARM_GICC_INFO object used to create the n= ode. > @param [in] CpuName Value used to generate the node name. > @param [out] EtNodePtr If not NULL, return the created Cpu node. > > @@ -372,6 +373,7 @@ EFIAPI > CreateAmlEtd ( > IN ACPI_CPU_TOPOLOGY_GENERATOR *Generator, > IN AML_NODE_HANDLE ParentNode, > + IN CM_ARM_GICC_INFO *GicCInfo, > IN UINT32 CpuName, > OUT AML_OBJECT_NODE_HANDLE *EtNodePtr OPTIONAL > ) > @@ -397,7 +399,7 @@ CreateAmlEtd ( > > Status =3D AmlCodeGenNameInteger ( > "_UID", > - CpuName, > + GicCInfo->AcpiProcessorUid, > EtNode, > NULL > ); > @@ -474,6 +476,7 @@ CreateAmlEtNode ( > Status =3D CreateAmlEtd ( > Generator, > Node, > + GicCInfo, > CpuName, > NULL > ); -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111404): https://edk2.groups.io/g/devel/message/111404 Mute This Topic: https://groups.io/mt/102598848/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_BY5PR12MB55442668B0872C439028C51ABAB7ABY5PR12MB5544namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable


From: Laszlo= Ersek <lersek@redhat.com>
Sent: Friday, November 17, 2023 2:20 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Ashish S= inghal <ashishsingha@nvidia.com>; quic_llindhol@quicinc.com <quic_= llindhol@quicinc.com>; ardb+tianocore@kernel.org <ardb+tianocore@kern= el.org>; sami.mujawar@arm.com <sami.mujawar@arm.com>; Jeff Brasen <jbrasen@nvidia.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>; Liming G= ao (Byosoft address) <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UI= D Creation
 
External email: Use caution opening l= inks or attachments


On 11/15/23 04:19, Ashish Singhal via groups.io wrote:
> Just like CPU _UID, ETE UID also needs to be unique so
> use AcpiProcessorUid instead of CpuName
>
> Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com>
> ---
>  .../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 5= ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Is this a fixup for the recent feature

[PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support https://edk2.groups.io/g/devel/message/108= 996

?

If so, then I *think* this qualifies to be merged during the hard
feature freeze (+Liming +Mike), but:

- I think we should have a "Fixes:" tag in the commit message (fo= r
pointing out the commit that should have contained the code being
added/updated now)

- I think we should have a BZ too (also linked into the commit message).
Laszlo

Hello Laszlo,

The issue wa= s indeed introduced in the patch series you pointed to and precisely in the= commit https://github.com/tianocore/edk2/commit/3ee23713e1ce09faa6fa66ee6799e3e336= deb58b. This is indeed a bug and should ideally be fixed as soon as pos= sible. Do you need me to file BZ bug and link that in commit message?

Thanks
Ashish

>
> diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibA= rm/SsdtCpuTopologyGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtC= puTopologyLibArm/SsdtCpuTopologyGenerator.c
> index 8228c7845a..724f33c660 100644
> --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/Ssdt= CpuTopologyGenerator.c
> +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/Ssdt= CpuTopologyGenerator.c
> @@ -359,6 +359,7 @@ CreateAmlCpcNode (
>
>    @param [in]  Generator    The SS= DT Cpu Topology generator.
>    @param [in]  ParentNode   Parent node= to attach the Cpu node to.
> +  @param [in]  GicCInfo     CM_ARM_GICC= _INFO object used to create the node.
>    @param [in]  CpuName    &nb= sp; Value used to generate the node name.
>    @param [out] EtNodePtr   If not NULL, retu= rn the created Cpu node.
>
> @@ -372,6 +373,7 @@ EFIAPI
>  CreateAmlEtd (
>    IN   ACPI_CPU_TOPOLOGY_GENERATOR  *Ge= nerator,
>    IN   AML_NODE_HANDLE   &nbs= p;          ParentNode,
> +  IN   CM_ARM_GICC_INFO     &= nbsp;       *GicCInfo,
>    IN   UINT32     &= nbsp;           &nbs= p;     CpuName,
>    OUT  AML_OBJECT_NODE_HANDLE   &n= bsp;   *EtNodePtr OPTIONAL
>    )
> @@ -397,7 +399,7 @@ CreateAmlEtd (
>
>    Status =3D AmlCodeGenNameInteger (
>            = ;   "_UID",
> -           &nb= sp; CpuName,
> +           &nb= sp; GicCInfo->AcpiProcessorUid,
>            = ;   EtNode,
>            = ;   NULL
>            = ;   );
> @@ -474,6 +476,7 @@ CreateAmlEtNode (
>    Status =3D CreateAmlEtd (
>            = ;   Generator,
>            = ;   Node,
> +           &nb= sp; GicCInfo,
>            = ;   CpuName,
>            = ;   NULL
>            = ;   );

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#111404) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_BY5PR12MB55442668B0872C439028C51ABAB7ABY5PR12MB5544namp_--