From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 973D9D8024B for ; Fri, 17 Nov 2023 22:14:51 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=fBcRkdvd6QszgxMXFHWwM8lpFXEP9ws18Ajh1le0YUw=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20140610; t=1700259289; v=1; b=KWJfPzD7xU6QeI4vqLKleyRApWqYG7/wySWrCUiSGLblAwdadRATy7f/O1CjHIT5MjIMMIIc zj+AqfAUImnh8wUrBnLlSuepG58X5VhGwyt3c+AlTUYFTBI1l0ob1Z1MsJKFerTBPB7QxY6dDW7 HPgjUhNpSyuZAHIXdtKGhd5U= X-Received: by 127.0.0.2 with SMTP id iCGPYY7687511xz8a10xCTTu; Fri, 17 Nov 2023 14:14:49 -0800 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.47]) by mx.groups.io with SMTP id smtpd.web10.9220.1700259289201707256 for ; Fri, 17 Nov 2023 14:14:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GzgwK2MSL+bb0rxPdVrs9hD/ziv/c0JLZzyTNAAfSoKI+lFg4wY+Ds7Cl4MXuzIcp+ZcL94JmIk5TACVMlZV+NhZTgbj3r4awaJzddiOnEWsTs35/CqGAI0+Q8VYo7A7ppKYwI4rEXhUV1sJNRb3bo0RXsaMNupgS38ajf/7bbY0Gc0wyNUE76zFx74ZOeTObVHWBj8ZlFX+jR3auFpW6YnbRlAhbH6BW8wqzJScY871xBishixevCrWkwNBcv0GJARKYAHW+9zNzzeJ8yacl3Q2Mn40HTiYF2iuHi+qER7W2s2O8vdN1KeuVaW2Y3Uo/sxUcWEcWiDckvcMGZuFBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ToHpQXLYJ2AYMLZ2sMT3p2IZmQec5q/OSxtGI9k7zA8=; b=LrvF9FV/0PSsQ3p3VP0jsTRFDGrsDwTQECWMnGzOsVMJM3iVM48qoI4SJVathzdOi210KNARI7qHwX93TW86/IeNitmrNSgxRYsJ3foHK7yidG5sCvFgdCaR+yIQygLGXNTL66TC84JrUlvp9ab6KorD4qEOgtlIGThxBQ+ZT4k6fENJ1ZnFOj3hQ2kmMsanfOWGbnJstTwTsCvqmOsSrUUKAnTJvFruy4lY/DB4XoofZjb6+ck7+AqkPBBuioIMoE4mO66Jjo+uSnbmZwJ8BBeoajyJVk0oNKCt66nclgPU4QAfbQlO62g1ys/VVxdbN7VMSgiDJSwY56I6UPM45Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from BY5PR12MB5544.namprd12.prod.outlook.com (2603:10b6:a03:1d9::22) by CH3PR12MB8909.namprd12.prod.outlook.com (2603:10b6:610:179::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.20; Fri, 17 Nov 2023 22:14:44 +0000 X-Received: from BY5PR12MB5544.namprd12.prod.outlook.com ([fe80::108e:2378:282b:6d89]) by BY5PR12MB5544.namprd12.prod.outlook.com ([fe80::108e:2378:282b:6d89%4]) with mapi id 15.20.7002.022; Fri, 17 Nov 2023 22:14:43 +0000 From: "Ashish Singhal via groups.io" To: Laszlo Ersek , "devel@edk2.groups.io" , "quic_llindhol@quicinc.com" , "ardb+tianocore@kernel.org" , "sami.mujawar@arm.com" , Jeff Brasen CC: Michael Kinney , "Liming Gao (Byosoft address)" Subject: Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation Thread-Topic: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation Thread-Index: AQHaF3KJdq6FPxbXTk2NbRrvZtcxGLB+P8IAgAB5oUeAAEFlgIAAHPS8 Date: Fri, 17 Nov 2023 22:14:43 +0000 Message-ID: References: <0dfe6159ce24094f914dbe340a5656b95895b808.1700018266.git.ashishsingha@nvidia.com> <783347b8-2ea4-7dc4-7793-1d6d871fb47b@redhat.com> In-Reply-To: <783347b8-2ea4-7dc4-7793-1d6d871fb47b@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BY5PR12MB5544:EE_|CH3PR12MB8909:EE_ x-ms-office365-filtering-correlation-id: 3daaf100-6a84-4922-0cf5-08dbe7ba99e8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: DixN0aWCriL5wr5uhgJf9MiAazvI+oYcMEZdsd2m0GhP6faqPJYkOWlQCjqOwAQzVcReXKZVSksRa6g4cKh2y3BazdpSiSovnNApXqz34ym/wH1mbBguMxT6mYFt5NxTCe4faczd1PmO2sIFxyOpPOOTxPmnYrjYNjnTF2JAkS2rrM3Qs02mb1bY5mLnE5hpckR3OdZhSfk8ZvGUMiDXZkXIDxvA1XQKI0FmHorg0T/Bgt81vjT4GXV5p7rER6EWISPABM74nqQE1dbSeAcDm0Cm3IodjVIb0odgW6Hp8n0kSkx43Q8hvKnqwDkLbN/LFuqJaquDJcplMhDJijXBJIFf/BCjD7DpKyeiisREPERCszSCOWqZ6oMjcLUrHnK64EH9fz4AIz1YpbD9tck4gzc4cRVs0sZoW9P30XDKsKYL3cjnW+8az1WlajKH+3wde3SvSxOQKuJdVNpmgtGpjGf6kgxFcU+lRbRoC1RDlWtVoa7FUiHI+lYLOSVrTDa6mKHOzBHL2IYu+LAASh1QYppSrD0Dz2c6jPWe2i729cK/1YWHsHdyoRhe0oBY3x1jj7T1BmNX5SiRi6LB0EFwQvv/0BHKmeYsWVJg7lU7ge0yD75xhTtNOsGPicgSodDSlkHnZP9bm0dbvqMENauJaQ== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sjMSR3/5Gbug+qFSRMYVBSLqypspmWleQU9F1DNOMNBrLzsXdzIDLg3b9QZB?= =?us-ascii?Q?K1DOUcrwhN20QMx+n0arLSr3g/Dm1e3dj8urDa3DHtlAlEP/Kou1ZqqXuNuu?= =?us-ascii?Q?K/Im7TX2bEbb52EESVS2SDKWnh8AvjbbjBOnA5rpZ5+/pj79EKsG+q23WFl+?= =?us-ascii?Q?XHmnt4i/ibhOUzyM4/hx7Em9AAQmC7C22yDabx+Fd8KWsiRq9hnYhLEiKc8G?= =?us-ascii?Q?DLTrA+JmydkTXMx8sp61Z0UjQ6xw/P9DL7g8BB34qMeRjegM1cLzv3+dFKUL?= =?us-ascii?Q?8YSO2fpWNMRPLAsw46n0UkPo0p1m95BeP53nyB+5/lVER/ehD8g/xpOXUB45?= =?us-ascii?Q?GJ6cMN+56okHQeke/I3rf3ui9R9FbZtGZzqc63YACSLTTqapFnUL3igEHB/B?= =?us-ascii?Q?q2caLc5NQmqvGFPXNppENh5bAFlk12PqdNtNhNtjHDKKnOXcn8vunWoLQhwp?= =?us-ascii?Q?51MnNBZn1yUfs4qFQ9ZszKC4vmkRgVCigMWPoqAaaGTzXoGg3Pjj5QYMOoRu?= =?us-ascii?Q?UZ0Cl/Jc+4uI36S49qSk8PvsEUmnM1zfYryXkgxA6ZRpVF+LSLdIuQkAMFwk?= =?us-ascii?Q?hHGuus37n2EHh6QRcTsKivwoj9ruGCCoEAIyWHPRxLtODIUel/Idr6LI2Eul?= =?us-ascii?Q?stGnlRF2xwAIsPFERWOldv8FHagOso35St+XRe6nbkIokFJrk7ZBzJX0j0bc?= =?us-ascii?Q?g9JVwmhOXhAexdSkbfw5xvw6+evljpLHmdOqgdolYJj3EPM9fI8tkkq5WwnL?= =?us-ascii?Q?65mt8lMWXFMl/r7MWmGEDIliZ8JnWpKPGakVDozUAGjl+X05lMy+dKAMDlyl?= =?us-ascii?Q?5m3uOfCKDh2X1UKYAw6Nb/ceDabLjxLm6Zjd0yGpNdFIgd6AdpqVe8RvOdBw?= =?us-ascii?Q?nCix8jp1MiixR1OM7qf5NQ+4HMJ72o/j6RenawQrZoyWbxfZ1Nlaa1nqIeWY?= =?us-ascii?Q?62pWHoT82Y5ywIuwtAD8zIV4nArqlD/LXPrB7YAZ9JBjVbYP0iD3oIjqbDQc?= =?us-ascii?Q?Ju4lxoMgd1aTIzT5kq6H83N8B6oOEnd4G6hVXRL7UIsZYE5BPF2RTb6MXukb?= =?us-ascii?Q?qQ9Guopd66R+ekdNNNDbJDR/D5p778k2Jf3AUrCXSC0HHNuLjhikyVZAF2Ro?= =?us-ascii?Q?KTP+gVyAi1JdEpm+iMbkI2whkpawpGJxjrbth2VB+SjHELtpC+9GUYJyg6bl?= =?us-ascii?Q?7NVJIHFjOOSBwHLZmizUnBYnz4A7K6IqEoh4+25KtHxaWOc3+5OqmFKk5XEf?= =?us-ascii?Q?sb7f45fcDYP8uj/YGFJdfN60fMu2sBGNYR3Y3LmJEKzMb/mdP9T5Fz07lsr+?= =?us-ascii?Q?RegNaGaNSvNRitaHB3+HokEZQYKSPSllatSm+8pDxN90GMyedIyya7yjmWlI?= =?us-ascii?Q?m8dS3CCGHInPdWOeH31rxu2vs1R7L4Gt7xT5lLTJS91rtHHOvHF+xx4tC32u?= =?us-ascii?Q?qmaDWV6qwzBDStowO88aG0BSflUwog2/YsRkjWV7Sc72c5LPoZCIpk//gBst?= =?us-ascii?Q?IUj6yM7EHxX0bKNJtW+CM2deXJl2lH3zPJ05ciLeT9A1sZMhu6b5FivmHAqP?= =?us-ascii?Q?z/+FU1gS1CH5xOFNHBa4GM9meX3+g5qomltgyZJ7?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB5544.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3daaf100-6a84-4922-0cf5-08dbe7ba99e8 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2023 22:14:43.4849 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ojmS1ZOlfOttW5oRuj8yWov+BbXy3TBzfOU+oFAqaqjt9wHtmoF6CTsTDsCYW8NUJhHtWSeUOh+vnI5ThrSdAg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8909 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ashishsingha@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 3qMWTa8smCyosyacWUx9nxx9x7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BY5PR12MB5544BE2530849151A1FAF446BAB7ABY5PR12MB5544namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=KWJfPzD7; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") --_000_BY5PR12MB5544BE2530849151A1FAF446BAB7ABY5PR12MB5544namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable It seems like my BZ account has been disabled and I am not able to create a= n issue there myself. Can one of you create it so that the bug can be fixed= ? I am meanwhile working to restore my account. ________________________________ From: Laszlo Ersek Sent: Friday, November 17, 2023 1:30 PM To: Ashish Singhal ; devel@edk2.groups.io ; quic_llindhol@quicinc.com ; ardb= +tianocore@kernel.org ; sami.mujawar@arm.com ; Jeff Brasen Cc: Michael Kinney ; Liming Gao (Byosoft addres= s) Subject: Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation External email: Use caution opening links or attachments On 11/17/23 17:37, Ashish Singhal wrote: > > > ------------------------------------------------------------------------ > *From:* Laszlo Ersek > *Sent:* Friday, November 17, 2023 2:20 AM > *To:* devel@edk2.groups.io ; Ashish Singhal > ; quic_llindhol@quicinc.com > ; ardb+tianocore@kernel.org > ; sami.mujawar@arm.com > ; Jeff Brasen > *Cc:* Michael Kinney ; Liming Gao (Byosoft > address) > *Subject:* Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creati= on > > External email: Use caution opening links or attachments > > > On 11/15/23 04:19, Ashish Singhal via groups.io wrote: >> Just like CPU _UID, ETE UID also needs to be unique so >> use AcpiProcessorUid instead of CpuName >> >> Signed-off-by: Ashish Singhal >> --- >> .../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) > > Is this a fixup for the recent feature > > [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support > https://edk2.groups.io/g/devel/message/108996 > > > ? > > If so, then I *think* this qualifies to be merged during the hard > feature freeze (+Liming +Mike), but: > > - I think we should have a "Fixes:" tag in the commit message (for > pointing out the commit that should have contained the code being > added/updated now) > > - I think we should have a BZ too (also linked into the commit message). > > Laszlo > > Hello Laszlo, > > The issue was indeed introduced in the patch series you pointed to and > precisely in the commit > https://github.com/tianocore/edk2/commit/3ee23713e1ce09faa6fa66ee6799e3e3= 36deb58b . This is indeed a bug and should ideally be fixed as soon= as possible. Do you need me to file BZ bug and link that in commit message= ? A BZ ticket would be great, yes. It helps with the release notes (determining the contents of a release). If/when you file the new BZ, please add the old BZ's URL to the See Also field. ... Oh, wait, the original series didn't have a BZ. That's a pity. Thanks Laszlo > > Thanks > Ashish > >> >> diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm= /SsdtCpuTopologyGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpu= TopologyLibArm/SsdtCpuTopologyGenerator.c >> index 8228c7845a..724f33c660 100644 >> --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCp= uTopologyGenerator.c >> +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCp= uTopologyGenerator.c >> @@ -359,6 +359,7 @@ CreateAmlCpcNode ( >> >> @param [in] Generator The SSDT Cpu Topology generator. >> @param [in] ParentNode Parent node to attach the Cpu node to. >> + @param [in] GicCInfo CM_ARM_GICC_INFO object used to create the = node. >> @param [in] CpuName Value used to generate the node name. >> @param [out] EtNodePtr If not NULL, return the created Cpu node. >> >> @@ -372,6 +373,7 @@ EFIAPI >> CreateAmlEtd ( >> IN ACPI_CPU_TOPOLOGY_GENERATOR *Generator, >> IN AML_NODE_HANDLE ParentNode, >> + IN CM_ARM_GICC_INFO *GicCInfo, >> IN UINT32 CpuName, >> OUT AML_OBJECT_NODE_HANDLE *EtNodePtr OPTIONAL >> ) >> @@ -397,7 +399,7 @@ CreateAmlEtd ( >> >> Status =3D AmlCodeGenNameInteger ( >> "_UID", >> - CpuName, >> + GicCInfo->AcpiProcessorUid, >> EtNode, >> NULL >> ); >> @@ -474,6 +476,7 @@ CreateAmlEtNode ( >> Status =3D CreateAmlEtd ( >> Generator, >> Node, >> + GicCInfo, >> CpuName, >> NULL >> ); > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111419): https://edk2.groups.io/g/devel/message/111419 Mute This Topic: https://groups.io/mt/102598848/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_BY5PR12MB5544BE2530849151A1FAF446BAB7ABY5PR12MB5544namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
It seems like my BZ account has been disabled and I am not able to create a= n issue there myself. Can one of you create it so that the bug can be fixed= ? I am meanwhile working to restore my account.
From: Laszlo Ersek <lers= ek@redhat.com>
Sent: Friday, November 17, 2023 1:30 PM
To: Ashish Singhal <ashishsingha@nvidia.com>; devel@edk2.group= s.io <devel@edk2.groups.io>; quic_llindhol@quicinc.com <quic_llind= hol@quicinc.com>; ardb+tianocore@kernel.org <ardb+tianocore@kernel.or= g>; sami.mujawar@arm.com <sami.mujawar@arm.com>; Jeff Brasen <jbrasen@nvidia.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>; Liming Gao (B= yosoft address) <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Cre= ation
 
External email: Use caution opening links or attac= hments


On 11/17/23 17:37, Ashish Singhal wrote:
>
>
> ----------------------------------------------------------------------= --
> *From:* Laszlo Ersek <lersek@redhat.com>
> *Sent:* Friday, November 17, 2023 2:20 AM
> *To:* devel@edk2.groups.io <devel@edk2.groups.io>; Ashish Singha= l
> <ashishsingha@nvidia.com>; quic_llindhol@quicinc.com
> <quic_llindhol@quicinc.com>; ardb+tianocore@kernel.org
> <ardb+tianocore@kernel.org>; sami.mujawar@arm.com
> <sami.mujawar@arm.com>; Jeff Brasen <jbrasen@nvidia.com> > *Cc:* Michael Kinney <michael.d.kinney@intel.com>; Liming Gao (B= yosoft
> address) <gaoliming@byosoft.com.cn>
> *Subject:* Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Cre= ation
>
> External email: Use caution opening links or attachments
>
>
> On 11/15/23 04:19, Ashish Singhal via groups.io wrote:
>> Just like CPU _UID, ETE UID also needs to be unique so
>> use AcpiProcessorUid instead of CpuName
>>
>> Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com>
>> ---
>>  .../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c= | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> Is this a fixup for the recent feature
>
> [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE supp= ort
> https://edk2= .groups.io/g/devel/message/108996
> <https://= edk2.groups.io/g/devel/message/108996>
>
> ?
>
> If so, then I *think* this qualifies to be merged during the hard
> feature freeze (+Liming +Mike), but:
>
> - I think we should have a "Fixes:" tag in the commit messag= e (for
> pointing out the commit that should have contained the code being
> added/updated now)
>
> - I think we should have a BZ too (also linked into the commit message= ).
>
> Laszlo
>
> Hello Laszlo,
>
> The issue was indeed introduced in the patch series you pointed to and=
> precisely in the commit
> https://github.com/tianocore/edk2/commit/3ee23713e1ce09faa6fa66ee6799e3e336= deb58b <https://github.com/tianocore/edk2/commit/= 3ee23713e1ce09faa6fa66ee6799e3e336deb58b>. This is indeed a bug and should ideally be fixed as soon as possible. Do y= ou need me to file BZ bug and link that in commit message?

A BZ ticket would be great, yes. It helps with the release notes
(determining the contents of a release).

If/when you file the new BZ, please add the old BZ's URL to the See Also field. ... Oh, wait, the original series didn't have a BZ. That's a pity.
Thanks
Laszlo

>
> Thanks
> Ashish
>
>>
>> diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopology= LibArm/SsdtCpuTopologyGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiS= sdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
>> index 8228c7845a..724f33c660 100644
>> --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/= SsdtCpuTopologyGenerator.c
>> +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/= SsdtCpuTopologyGenerator.c
>> @@ -359,6 +359,7 @@ CreateAmlCpcNode (
>>
>>    @param [in]  Generator    Th= e SSDT Cpu Topology generator.
>>    @param [in]  ParentNode   Parent = node to attach the Cpu node to.
>> +  @param [in]  GicCInfo     CM_ARM_= GICC_INFO object used to create the node.
>>    @param [in]  CpuName    = ;  Value used to generate the node name.
>>    @param [out] EtNodePtr   If not NULL, = return the created Cpu node.
>>
>> @@ -372,6 +373,7 @@ EFIAPI
>>  CreateAmlEtd (
>>    IN   ACPI_CPU_TOPOLOGY_GENERATOR = *Generator,
>>    IN   AML_NODE_HANDLE   =            ParentNode, >> +  IN   CM_ARM_GICC_INFO    &nb= sp;        *GicCInfo,
>>    IN   UINT32    &nb= sp;            =       CpuName,
>>    OUT  AML_OBJECT_NODE_HANDLE  &nbs= p;    *EtNodePtr OPTIONAL
>>    )
>> @@ -397,7 +399,7 @@ CreateAmlEtd (
>>
>>    Status =3D AmlCodeGenNameInteger (
>>           &= nbsp;   "_UID",
>> -           = ;  CpuName,
>> +           = ;  GicCInfo->AcpiProcessorUid,
>>           &= nbsp;   EtNode,
>>           &= nbsp;   NULL
>>           &= nbsp;   );
>> @@ -474,6 +476,7 @@ CreateAmlEtNode (
>>    Status =3D CreateAmlEtd (
>>           &= nbsp;   Generator,
>>           &= nbsp;   Node,
>> +           = ;  GicCInfo,
>>           &= nbsp;   CpuName,
>>           &= nbsp;   NULL
>>           &= nbsp;   );
>

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#111419) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_BY5PR12MB5544BE2530849151A1FAF446BAB7ABY5PR12MB5544namp_--