From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2DDDDD801B0 for ; Wed, 15 Nov 2023 17:28:00 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ZScVV3HN9kAX5mwtuCLh6e6LdcTpn3Qbb7VpluWDGgk=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20140610; t=1700069279; v=1; b=X1LHrhiOomlfLP4GNLcK2gE301U6xLpD15m4z0fkkARi1LfcOLLD3Q76GScnNO1ZR7PrANEn TVdU+kumICxqf9Y7+RJ4jXS/wQhtFPu5CoA6XpzrDc9cX8hy+YxvkEsHI8YW4mqvnSmmeXyy9RN oe2mMZC5O+Dng93FiShkFXWo= X-Received: by 127.0.0.2 with SMTP id jdldYY7687511xaaPdn4iXKp; Wed, 15 Nov 2023 09:27:59 -0800 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.65]) by mx.groups.io with SMTP id smtpd.web11.19369.1700069279004293608 for ; Wed, 15 Nov 2023 09:27:59 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hauDAJm1pXP3x4Z73aGZKWaFzVs5ta0nP9tKEyoZHKv53ee/5Yv6SrvglgVA1Hz9GpMFlCro3nQYGdep+aSBxAf9XLgKVV85qKWHUnxiBHVVT6CAhnVBKDYe+wzsFrWyqaAmzE9xMU8MN77sK5AuFUSC6QrVLF4MiaTumA9ntmP22IWqei+q/WfRw2F5Bq9n/hNWtnpi4Pm1OJocag89vjLSy1YlTEflY/R+mUQg8zCbqLgYwWH259pA+/oxuGFlEnYGwMPMu71d5agZv1akwCccMLr6jcVLSFOYo4HgnxiB5iz46TK/lAqqDsgWtwVsfb1jJspma13h9AjRyWfJkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GTz5mnWT482wLDWnfgi3ANqoc9rT9Ibs1gW8RDwF164=; b=YpdktZR04t7WODuhNzgeABJFHcGZSGr2NqAbGKd0sB1R3TS6MVX9ntkKEXxbBNG9hGyZirugpiIxqr3fa752+fK745zLlfokEhL2/V5UvBVCosGVU+5fxDCVHLMk3aKYdZxPWGHWDE/njAX5OSZ7Fdyzl1FijnaPUuEwX8Ut2j+024igY9yGeiN+MkaLiDOoKcp1ugM2v1A4q1Za1eLqDWhcE/xvwDC3rTMQUaKrMpGnNu26fpm1x9hMZmKvWnVKPxgHwEM/7ZHLtC+fY/5Bx/tnWGsiUy0iAFAsFcRhYwuE+JSkGHsiH9b0ZvOXFNel2zpeDU28oPT+lX3lwYjvAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from BY5PR12MB5544.namprd12.prod.outlook.com (2603:10b6:a03:1d9::22) by SJ0PR12MB7460.namprd12.prod.outlook.com (2603:10b6:a03:48d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.18; Wed, 15 Nov 2023 17:27:55 +0000 X-Received: from BY5PR12MB5544.namprd12.prod.outlook.com ([fe80::108e:2378:282b:6d89]) by BY5PR12MB5544.namprd12.prod.outlook.com ([fe80::108e:2378:282b:6d89%4]) with mapi id 15.20.7002.018; Wed, 15 Nov 2023 17:27:55 +0000 From: "Ashish Singhal via groups.io" To: Leif Lindholm , "devel@edk2.groups.io" CC: "ardb+tianocore@kernel.org" , "sami.mujawar@arm.com" , Jeff Brasen Subject: Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation Thread-Topic: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation Thread-Index: AQHaF3KJdq6FPxbXTk2NbRrvZtcxGLB7kI4AgAAApKaAABANgIAAAc3t Date: Wed, 15 Nov 2023 17:27:55 +0000 Message-ID: References: <0dfe6159ce24094f914dbe340a5656b95895b808.1700018266.git.ashishsingha@nvidia.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BY5PR12MB5544:EE_|SJ0PR12MB7460:EE_ x-ms-office365-filtering-correlation-id: d2753066-c26a-48a1-5a2c-08dbe6003463 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 5FcoStjYRSqnAIkStKTM7pDkFGIBqNrllVfdNqz+c2F9jxylgkrF3X3A0InbgZywcA7rmK54UmZ2nhGF6LokxoBmL9OG3glDOWAG2ArVnvqBcRssSyb4jJ143TzixM+H07BFyQpAy9Bqh/0HlGTnkX2BwbDlwjg52BNTwIdP0GQJSgNqKLJ5L2HqeI4HJchtRw9F6ja4jm3JDWU5Y96vCltuOKptg0TeOiYYeaVkl9vfOQSeS3WC/FUWdxSKPNzhMXbMUYx8fq1lSxFzV1XfI9/UTm9z3tNW78e/1rdGYWrO+k1NtEaXEEZs9q4vMF2Zk6H4BR4obCkEnZgHobc2RPZdIl9spfmcL+SiUxzNBNQIlug62BkOe2mES/doaFfH7oKlCHhG6YOftfA1lVoEcvAdBB3qkMI1bFizEQ6gMebKIVwBFbqDPN0hTxhuFTM3vIQ1jlsffxzq/+4BCsPWyHyKoKCFI2Q5OMgB1lyqv9eARuNejc/pwjEJg7CofGuRN9AHs6LT/JFDmSl5+ENd8Wdx4eF+pRdZPvmk/EfoI3sa/09rJ5JsGJ9TOyi2yvQXHag11GSB+RkTAdhLnPc2+wSuJNXunz7mbzP26i21vF89Ve+LooB0vfK5sShSPyfqFN/yaSnE9vyT/1XWwsErkw== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?Uican5pr4YRCakCYXBCZwTatO8XzHUdic+xXLd+bJpCIP1zSvTGteEU0D2?= =?iso-8859-1?Q?Zg6r0cW0zk3Up8Yhtjh7B4BtY/j0GZ95qPXgr7i/ouhiSj2D593M/4gmOR?= =?iso-8859-1?Q?rWd9jTwxVl84DXLolyi3sfzyQf0qwPkhS5fU/k/QXHlh4hQjIyn4sAPkZe?= =?iso-8859-1?Q?v7ROzOZ51kbhuGDKTPmpZhNqRgmoDyVRCReUyIApE56LzJIzjtMtb3/ZuT?= =?iso-8859-1?Q?j5BtR0lFHsh28AYPTcGsdeI6RsyGHw9vAgrU8K9WwlUCBWYqhJBZak8Ate?= =?iso-8859-1?Q?yhIZYzcaChFy2k1CnU5gAQAh1cN/7VXPTUSyeCaGv2lE042gzHvGZoIYSz?= =?iso-8859-1?Q?ZDjnSNZFU9PmtEJEmrhpc/uFwjmgoVwSPTnedX7tCEYiXze9Lm/RAMWGWS?= =?iso-8859-1?Q?jNT6kt5Lh3fWn1g8XnocqL7IuZOHZqW7gGLMYT4OiomnHULgylrgfaYgbx?= =?iso-8859-1?Q?YqsDALyP2QCxanziRBRznVKgKE5WuVj7uDrU+Eq5Xr5D9/TzUaNoZ41PqS?= =?iso-8859-1?Q?dLB/eGrYjjz57tVWdo3g4RNvvaKjHiNhPi/XmrJsDHWrfL+sXpIAK8UlQS?= =?iso-8859-1?Q?bVhTXqdaut62OsgK0C3xMzKGH2faMJ/Ano8ai7piO0NHl0UoVj6w4ysns6?= =?iso-8859-1?Q?etAl05x+03fsLpo+mlXHlPb8Ga3JMgezxK3zkV+ubtUt0ipUTKtsRmLvNs?= =?iso-8859-1?Q?4/F0nKZHx5Q7qFq+8t8n8pPJzwcFafEHRkRNCopmGe/GY4bwI13kWtKS9q?= =?iso-8859-1?Q?ejUCeq+zBS2Zj45U8WELNyFpCP0DZrGj9txZyuK6psKfQp4NG8VnYJ3Vn7?= =?iso-8859-1?Q?gJaclf+NAGJnF9hYusBqRKcHnoYXfQkAMDS3na5yVEjzAz+FOiV09IUUKH?= =?iso-8859-1?Q?CxkXhRV/BISaCicx5/QghyAgu0gNVKcdStO6nrqyCr9NSxhsteBRxaGOH9?= =?iso-8859-1?Q?D6Uj2Md2Tdsd21313dOF5WLzkAEheowuAizHv5qtwfbRGhSRjwOCa1JEhS?= =?iso-8859-1?Q?GkC0rjCwD5jpZcOFp2EDoPta8iTGquzqOpAylSI5uznzkUH4UyUIaERKuy?= =?iso-8859-1?Q?Ku1omyrilPW0v4OVpsxWGs3tJ0GViHQ9Ya5F12JljvLpkV0BdWxxcnaN7W?= =?iso-8859-1?Q?KT7tV/WfIV5d7XaGOmWK3KmsQ0t6GHL12VqjGAx9i04RwrinikhsvRQvaA?= =?iso-8859-1?Q?eQy8ZH7OJ58vxmYRS0TdSPkxVQIZ13Mx+CLrublJNxzMwcXLeKTY+uPdRy?= =?iso-8859-1?Q?iWiPFZpdMw9rQWueQWRmipqD3ZOmOtzIkJ90f+FMj+Duxv4sCcyKsoqERa?= =?iso-8859-1?Q?YjuEskQomj2887GXJI8KHaP2eCpJiTT207gplUVRzB5kbmCfFjHajZIYfZ?= =?iso-8859-1?Q?CScaHoJjEveLJuiy3cFHNrLCy0d+2RMorpos0RIpwTeRbiuJaV6gkDDGVQ?= =?iso-8859-1?Q?E4NuxsPQzH+xRvIKIW5/7yF5q81+pcwFv7VpDqQV+uoh8VyfffRfya3cOx?= =?iso-8859-1?Q?Px45QKKpIjk00P44zTy1rGns9wSi+DlDQyKyRPLKJvIeox2/um7SphRuUt?= =?iso-8859-1?Q?bsln/ypntYC1nl+xEAbV8iSYAhlfUKHsP2l0Mi37ah60en8KN2LjF+9E1t?= =?iso-8859-1?Q?doxF1EklCv05MbseicCRHSl2rO/JUIRXbp?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB5544.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2753066-c26a-48a1-5a2c-08dbe6003463 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Nov 2023 17:27:55.6164 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3p1CGssDE28ODfUc3Hq1+rNLfrr+AJPFwMPd65edkwOAXrJHWo0ANAHIaLxwOYsRcZQZJYa1m2cTUh9tvtNPzA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB7460 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ashishsingha@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: lgHCgJRrif0LdTDe1OdmY10gx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BY5PR12MB5544D2D00D2730D2AD148601BAB1ABY5PR12MB5544namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=X1LHrhiO; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") --_000_BY5PR12MB5544D2D00D2730D2AD148601BAB1ABY5PR12MB5544namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable ________________________________ From: Leif Lindholm Sent: Wednesday, November 15, 2023 10:20 AM To: devel@edk2.groups.io ; Ashish Singhal Cc: ardb+tianocore@kernel.org ; sami.mujawar@arm= .com ; Jeff Brasen Subject: Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation External email: Use caution opening links or attachments On Wed, Nov 15, 2023 at 16:24:46 +0000, Ashish Singhal via groups.io wrote: > On Tue, Nov 14, 2023 at 20:19:04 -0700, Ashish Singhal wrote: > > Just like CPU _UID, ETE UID also needs to be unique so > > use AcpiProcessorUid instead of CpuName > > > > Signed-off-by: Ashish Singhal > > --- > > .../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibAr= m/SsdtCpuTopologyGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCp= uTopologyLibArm/SsdtCpuTopologyGenerator.c > > index 8228c7845a..724f33c660 100644 > > --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtC= puTopologyGenerator.c > > +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtC= puTopologyGenerator.c > > @@ -359,6 +359,7 @@ CreateAmlCpcNode ( > > > > @param [in] Generator The SSDT Cpu Topology generator. > > @param [in] ParentNode Parent node to attach the Cpu node to. > > + @param [in] GicCInfo CM_ARM_GICC_INFO object used to create the= node. > > @param [in] CpuName Value used to generate the node name. > > Can that replace both uses of CpuName in the function (so it can be > dropped), or does > > Status =3D WriteAslName ('E', CpuName, AslName); > > have other requirements? > > / > Leif > > Hello Leif, > > CPU Name can be more logical, and you may have the same CPU name in > different clusters for example. _UID however needs to be unique. Sure, makes sense. I just dislike functions that take too many arguments, so wanted to make sure we weren't missing an opportunity to drop one as we were adding this new one. Never mind me :) Thanks, Leif No worries at all. Please let me know if you have any other questions befor= e this patch can be accepted. Thanks Ashish > Thanks > Ashish > > > @param [out] EtNodePtr If not NULL, return the created Cpu node. > > > > @@ -372,6 +373,7 @@ EFIAPI > > CreateAmlEtd ( > > IN ACPI_CPU_TOPOLOGY_GENERATOR *Generator, > > IN AML_NODE_HANDLE ParentNode, > > + IN CM_ARM_GICC_INFO *GicCInfo, > > IN UINT32 CpuName, > > OUT AML_OBJECT_NODE_HANDLE *EtNodePtr OPTIONAL > > ) > > @@ -397,7 +399,7 @@ CreateAmlEtd ( > > > > Status =3D AmlCodeGenNameInteger ( > > "_UID", > > - CpuName, > > + GicCInfo->AcpiProcessorUid, > > EtNode, > > NULL > > ); > > @@ -474,6 +476,7 @@ CreateAmlEtNode ( > > Status =3D CreateAmlEtd ( > > Generator, > > Node, > > + GicCInfo, > > CpuName, > > NULL > > ); > > -- > > 2.17.1 > > > > >=20 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111282): https://edk2.groups.io/g/devel/message/111282 Mute This Topic: https://groups.io/mt/102598848/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_BY5PR12MB5544D2D00D2730D2AD148601BAB1ABY5PR12MB5544namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable


From: Leif Lindholm &l= t;quic_llindhol@quicinc.com>
Sent: Wednesday, November 15, 2023 10:20 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Ashish Singha= l <ashishsingha@nvidia.com>
Cc: ardb+tianocore@kernel.org <ardb+tianocore@kernel.org>; sam= i.mujawar@arm.com <sami.mujawar@arm.com>; Jeff Brasen <jbrasen@nvi= dia.com>
Subject: Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Cre= ation
 
External email: Use caution opening= links or attachments


On Wed, Nov 15, 2023 at 16:24:46 +0000, Ashish Singhal via groups.io wrote:=
> On Tue, Nov 14, 2023 at 20:19:04 -0700, Ashish Singhal wrote:
> > Just like CPU _UID, ETE UID also needs to be unique so
> > use AcpiProcessorUid instead of CpuName
> >
> > Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com>
> > ---
> >  .../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.= c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopolog= yLibArm/SsdtCpuTopologyGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/Acpi= SsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
> > index 8228c7845a..724f33c660 100644
> > --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm= /SsdtCpuTopologyGenerator.c
> > +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm= /SsdtCpuTopologyGenerator.c
> > @@ -359,6 +359,7 @@ CreateAmlCpcNode (
> >
> >    @param [in]  Generator    T= he SSDT Cpu Topology generator.
> >    @param [in]  ParentNode   Parent= node to attach the Cpu node to.
> > +  @param [in]  GicCInfo     CM_ARM= _GICC_INFO object used to create the node.
> >    @param [in]  CpuName   &nbs= p;  Value used to generate the node name.
>
> Can that replace both uses of CpuName in the function (so it can be > dropped), or does
>
>   Status =3D WriteAslName ('E', CpuName, AslName);
>
> have other requirements?
>
> /
>     Leif
>
> Hello Leif,
>
> CPU Name can be more logical, and you may have the same CPU name in > different clusters for example. _UID however needs to be unique.

Sure, makes sense.
I just dislike functions that take too many arguments, so wanted to
make sure we weren't missing an opportunity to drop one as we were
adding this new one.
Never mind me :)

Thanks,

Leif

No worries at all. Please let me know if you have any other questions befor= e this patch can be accepted.

Thanks
Ashish

> Thanks
> Ashish
>
> >    @param [out] EtNodePtr   If not NULL,= return the created Cpu node.
> >
> > @@ -372,6 +373,7 @@ EFIAPI
> >  CreateAmlEtd (
> >    IN   ACPI_CPU_TOPOLOGY_GENERATOR = ; *Generator,
> >    IN   AML_NODE_HANDLE   = ;           ParentNode, > > +  IN   CM_ARM_GICC_INFO    &n= bsp;        *GicCInfo,
> >    IN   UINT32    &n= bsp;            = ;      CpuName,
> >    OUT  AML_OBJECT_NODE_HANDLE  &nb= sp;    *EtNodePtr OPTIONAL
> >    )
> > @@ -397,7 +399,7 @@ CreateAmlEtd (
> >
> >    Status =3D AmlCodeGenNameInteger (
> >           =     "_UID",
> > -          &nbs= p;  CpuName,
> > +          &nbs= p;  GicCInfo->AcpiProcessorUid,
> >           =     EtNode,
> >           =     NULL
> >           =     );
> > @@ -474,6 +476,7 @@ CreateAmlEtNode (
> >    Status =3D CreateAmlEtd (
> >           =     Generator,
> >           =     Node,
> > +          &nbs= p;  GicCInfo,
> >           =     CpuName,
> >           =     NULL
> >           =     );
> > --
> > 2.17.1
> >
>
>
>
>
>
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#111282) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_BY5PR12MB5544D2D00D2730D2AD148601BAB1ABY5PR12MB5544namp_--