From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B5FBF7803CC for ; Mon, 22 Jan 2024 02:52:58 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=9vhvrQUHeDI50CnJwAB2xnTpM0o0mbag1O43tionNH0=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20140610; t=1705891977; v=1; b=anqzZ4JlTZivQlUUClh/fskXsDG8T3Fg3laBkU3sRhn2qG0VmhW2NQ23B8MiKFcXSavViAmq 1UBvM0JA1hDQoGWgGpjPJZ3vtIrA1+NJqN5LW8SrP0wjlIeEPmY7DdFsEU2uWK/oa/Cez+Smhh+ 8w5mSVi0pNCW3zzySiT/sDl0= X-Received: by 127.0.0.2 with SMTP id WigzYY7687511xEnK4LJVOuB; Sun, 21 Jan 2024 18:52:57 -0800 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.43]) by mx.groups.io with SMTP id smtpd.web11.64538.1705891976496114018 for ; Sun, 21 Jan 2024 18:52:56 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VoUK/HkwmDJoJ7meUIBndO3vtLMTGD/4GWyBZ4Dy6rsPQBMTV68DRFMIM/HW0Z7PJhQWFHwS/iLK8k7/RaJsEorIPbeJhto1RgFf7lOLIPjfUwYO05h9eP0leixqFhym+GRrZ9ynGq20topYXhYlVcR0u+Dc1Z8qRovkp9FVF8aghba/xbl43jjldzWEc7tVxlmo5h91X+0lgZYRH1j4qfmWe++2hl3fR/wJPPm2iBZFYVUxmPuYnYbf9cEdctwKIvTEdIMRGYswdjVTiietJrJtIj1tHG/VEtXuPiolYlAAKP7lOmJKzlhq1ApWA52CzWOtUc8xIH31rHvrodwCoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kTv8MP6tyxxye6CIUxkS/pQnKhsgMuGF+XKQKvB0pm8=; b=XCEwT3XWmUM23zELFvgPTvxukcsZyzp921znzTIhrMIuxN70N05ICOFYprkFkv1iluKM7li4tUWT2E7IzFSS3t9s23ZlpqA6bwhjJ5E3zFdyQTDsuK5aLTdV78IxSS31VPvz16Wk7aOscnjndVmpRmvM/w1yMNpvG1f0myBi7H5iTwqPFFiv7UIUlUHTZmZrCAHGaEEtKZBdQKX5D9VmJivnBPozqkrSaAqcSY1kv2oeOmWhTGB1adJOxeh/kyfEiZnd3Yh1tChnwvz+eR2d+Xxr1aXX3RudktYViuACrlg3DlCHbPw+BcWufqNmdvGBX3azAEewVHrLBQbO8vn1bA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from BY5PR12MB5544.namprd12.prod.outlook.com (2603:10b6:a03:1d9::22) by DM6PR12MB5008.namprd12.prod.outlook.com (2603:10b6:5:1b7::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.32; Mon, 22 Jan 2024 02:52:51 +0000 X-Received: from BY5PR12MB5544.namprd12.prod.outlook.com ([fe80::2577:1f5e:c2e9:324f]) by BY5PR12MB5544.namprd12.prod.outlook.com ([fe80::2577:1f5e:c2e9:324f%6]) with mapi id 15.20.7202.031; Mon, 22 Jan 2024 02:52:50 +0000 From: "Ashish Singhal via groups.io" To: "Gao, Zhichao" , Leif Lindholm , "devel@edk2.groups.io" , "gaoliming@byosoft.com.cn" , Jeff Brasen , "Kinney, Michael D" , "afish@apple.com" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/ResetSystemRuntimeDxe: Print Reset Data Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg/ResetSystemRuntimeDxe: Print Reset Data Thread-Index: AQHaKKNns0GobTbuX0OlMOOmADJQRrCpeYP2gBvZZS+AHGDibYAACEKAgAOYNICAABZsaw== Date: Mon, 22 Jan 2024 02:52:50 +0000 Message-ID: References: <0f89bcebf449a681273f736de534d51afaea580c.1701908231.git.ashishsingha@nvidia.com> <299233b3-fec2-46dd-9c69-c0fab3a9586b@quicinc.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BY5PR12MB5544:EE_|DM6PR12MB5008:EE_ x-ms-office365-filtering-correlation-id: 4f90df8d-a18a-422f-d5bf-08dc1af538ec x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: zDVkwg+XW9N+ejo+24TQLeIrajWzZHpVOeAqpAuM3h1pp98K602bIi2gc7tta/L4GdOX6mHDah7473SlN49UCPSV4QW/rkkyTHaJ/xmDXsdTtVZPtFUX6rZogE/Kx2PIttLOgl/7WclzBqiXtpITm86EL9kimBz6Tlnp6MV01MlMUUW2r0Vjbz1LzSrDopKYctiSuSU460ue+ZNp7KCT9vlaO7DToXHCtdsAzEVVJC1MxVaA8ysHKoIhF1f85dha4qYVCvnAY45A2Ge1eRFYhZvW8jJrrDCryUogaoTyHXkd2F2axA5nMD6Q1JHsH1embP+png2tDkjef5s2uBUQqH9L/S+D0Gx0IT7PjwUbmk7mrSv+rPqns/nNEJS8bAyBmEgTdNtk+rgya+3eQrqM4tZX16pMd8bsfjY3v3RdRnXIw+DSBeNpUMQS4JUpeloA1/OT6RjxR/lsQguvr3cRu8blPKPEoqL9CDw4YoVOSdJCp/meTlsNgPTxNloHBZB7LM5r/GUwrhx8ZHDcXfzSok7YdD+5ld9phjZ5B3/D3UOjUt1xvysmL+FVwfeDJnXsrr6w4N5I6vuhrWPwdac9z7KqJ55s6djto0hrt8sj5ZB/v4I2g+r5ItwwDgVG5gFOJz+yDxL07/ldTDxfmqcdZg== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zkjxN8JvQdwapaGlc0dLSU6wrgOHngdq2g/fbsvVva7EKJ2Xi6vHFsdDMnBf?= =?us-ascii?Q?VhgzKbM/Fr5BKrVrdc6H33J4af2Bz5tezdVXd3582K1sXyW+ZreP88qCoIHf?= =?us-ascii?Q?szGOhuQt4GxibIIr0s2D83u9QBa097UUFYro44l2pnOZJalFefVSQLkWlL0p?= =?us-ascii?Q?8YyqypLFqEIMQNsovjKSsGOtfpuC7B21a6k5Uk5wLHLRAtc/bXstJJpnFFJh?= =?us-ascii?Q?IfD7ws5kOjVy/aFLwNs/gWXc/T9znDxzHJtBe1ozLHvAfGw5s2lwffBrHNBl?= =?us-ascii?Q?+LzJv6DFbZyH9I7Pg6PXBBqwMUJ+TN69QT8VCC2ypHIa/arSgvudUTJWHWN+?= =?us-ascii?Q?Jnb2HeFUAmSnuHA4OK4GLb35ZB/02yZMHgsP18MgkRgUiGwijI3VYlcTmHuB?= =?us-ascii?Q?uGp3sxls5JrPDlI60SElGGFbt42WIrhnErB+iPLJib1CJj5MX+2O9H3EvZ79?= =?us-ascii?Q?bUsqCtnwHg8kwB3ZntGjradIQiogNcOD+RkJpb0/L7EbIaNff0Ip39+nV/I4?= =?us-ascii?Q?G9G+tVYe5Q5x/ssjxQDklKqvUr0hMUpDJL2XCuxsF0J4asrjN0K9Tje3BXqZ?= =?us-ascii?Q?T37uKDvY7aYdeTZ8OTlR3kyhTk6qcdKGgBlzrxkBJGBhMFYDt7b/kNa1PLm7?= =?us-ascii?Q?OZD3rKM2j18Lvjz7QhwQsq8edjcWJr817AYUpO+f92kVet4l8c9as18jKrx3?= =?us-ascii?Q?piG3pKTYv2LKA0qUhRTPi/KuCKp2+AB4j07nmZS93s/tufYklydczucHt/y6?= =?us-ascii?Q?7PIbc+94IYI2TGE63y1ongrGFbqdD3MlPTCHM0pJTPOMPcVwslfDDBOcYfMr?= =?us-ascii?Q?HmCal32bjVWW1kMnWD/RzRJn4m7qkz2letqUthm9JYK5zlsLn7ngvlWEJsAn?= =?us-ascii?Q?2sxIOzxeaW6qK6B6nQqlE6EZPb+QIJ+L/FklDdYuH3g36PdIx17RZ+D+1Vqb?= =?us-ascii?Q?xnVIa/lo+tJnR0XS0vL1GOy+3VMCptjMDYUTRb7Xdz3PzkHFKfLWN3xgBThu?= =?us-ascii?Q?ubfKN9aDf2pwiqIvrkGtxI4EWyWnGFZD+h47A68jjjsmHi98dbJ4ztk7uQvd?= =?us-ascii?Q?BeQaTpfksi8p0EFI50yh8UAs1vO0SE8naBZ9YRtK/hfANADiUnGk5XFYWSTx?= =?us-ascii?Q?ro1iueUOn+nCEo1neFwSXeDhIAWdCGBSYdHqyydXC58TRJ0enSB5mUcMmPpP?= =?us-ascii?Q?sMeOs0UfsJM/PO0j2tW7qAjjMosAQ9Eg7JeksAQjA5Jdt1YtbJjIlG1dR7GL?= =?us-ascii?Q?Yh53/MPDFS0H9OuM5qhI98MtfZFd8TPxpekvOUiJ9DyZwB//8RirTcngpj57?= =?us-ascii?Q?QhGSJ7ElboSjdDI/v1FCk48J48B4iHdch7lji+I+qPaLLImPNEToOIYp+tlA?= =?us-ascii?Q?M3J4g7jbagMBCrpLazilgvAKMsUJD8tJyqCTdRpgPOl3ljASY7kTrLfmzG6Z?= =?us-ascii?Q?38BusY2W2Gzl89LFdNxQO4SFCM/svxtYB2VjClOjKE5NMzF/Anr1ishfbU7R?= =?us-ascii?Q?nqBaQf5+7IqHbcrTi+AFXZTSYX5Q1HTF4AAxfxIDhH9L0yhgzS25ltw79uw7?= =?us-ascii?Q?t+0Y0hbFzKex8JhJJ+MRHhSuGlTrw7qPv4XqsqTp?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB5544.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f90df8d-a18a-422f-d5bf-08dc1af538ec X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jan 2024 02:52:50.3969 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /r0iAHiWlswa9qb7a1z+NiwrcM3NaNgE/6mV8eWoBbZ6jXwIfBy5PbBuFYf7KgTcNpvV7waeaMN23FruesA/mw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB5008 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ashishsingha@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 7waZ6Hp7Qbg8A5Cik5Yt83Q4x7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_BY5PR12MB5544D95B9730716E947CF262BA752BY5PR12MB5544namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=anqzZ4Jl; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_BY5PR12MB5544D95B9730716E947CF262BA752BY5PR12MB5544namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for the information Leif. Zhichao, I have created the PR https://github.com/tianocore/edk2/pull/5151 for this = change and it has passed all tests. Please provide the push label. Thanks Ashish ________________________________ From: Gao, Zhichao Sent: Monday, January 22, 2024 7:01 AM To: Leif Lindholm ; devel@edk2.groups.io ; Ashish Singhal ; gaoliming@byosof= t.com.cn ; Jeff Brasen ; Kinn= ey, Michael D ; afish@apple.com Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/ResetSystemRuntimeDxe: Print= Reset Data External email: Use caution opening links or attachments Reviewed-by: Zhichao Gao Thanks, Zhichao > -----Original Message----- > From: Leif Lindholm > Sent: Saturday, January 20, 2024 2:38 AM > To: devel@edk2.groups.io; ashishsingha@nvidia.com; > gaoliming@byosoft.com.cn; Jeff Brasen ; Kinney, > Michael D ; afish@apple.com; Gao, Zhichao > > Subject: Re: [edk2-devel] [PATCH] > MdeModulePkg/ResetSystemRuntimeDxe: Print Reset Data > > Hi Ashish, > > On 2024-01-19 18:09, Ashish Singhal via groups.io wrote: > > Adding tianocore stewards to see if we can get some traction on this. > > You've not cc:d Zhichao - who maintains that component - on this patch, I= 've > added them. > > Please use BaseTools/Scripts/GetMaintainer.py to see who to cc - > maintainership of some of the modules are split in multiple dimensions an= d > it's basically impossible to work out manually. > > / > Leif > > > -----------------------------------------------------------------------= - > > *From:* Ashish Singhal > > *Sent:* Wednesday, December 6, 2023 5:21 PM > > *To:* devel@edk2.groups.io ; > > gaoliming@byosoft.com.cn ; Jeff Brasen > > > > *Cc:* Ashish Singhal > > *Subject:* [PATCH] MdeModulePkg/ResetSystemRuntimeDxe: Print Reset > Data > > ResetSystem runtime call allows for sending reset data that > > starts with a NULL terminated string. Add support to print > > that string on console. > > > > Signed-off-by: Ashish Singhal > > --- > > .../Universal/ResetSystemRuntimeDxe/ResetSystem.c | 8 +++++++= + > > 1 file changed, 8 insertions(+) > > > > diff --git > a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c > > b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c > > index 42f1b1d015..72bb1d2be6 100644 > > --- a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c > > +++ > b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c > > @@ -252,6 +252,14 @@ RuntimeServiceResetSystem ( > > mResetNotifyDepth > > )); > > > > + if ((ResetData !=3D NULL) && (DataSize !=3D 0)) { > > + DEBUG (( > > + DEBUG_INFO, > > + "DXE ResetSystem2: ResetData: %s\n", > > + ResetData > > + )); > > + } > > + > > if (mResetNotifyDepth <=3D MAX_RESET_NOTIFY_DEPTH) { > > if (!EfiAtRuntime ()) { > > // > > -- > > 2.17.1 > > > >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114132): https://edk2.groups.io/g/devel/message/114132 Mute This Topic: https://groups.io/mt/103025596/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_BY5PR12MB5544D95B9730716E947CF262BA752BY5PR12MB5544namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Thanks for the information Leif.

Zhichao,

I have created the PR = https://github.com/tianocore/edk2/pull/5151 for this change and it= has passed all tests. Please provide the push label.

Thanks
Ashish
From: Gao, Zhichao <zhic= hao.gao@intel.com>
Sent: Monday, January 22, 2024 7:01 AM
To: Leif Lindholm <quic_llindhol@quicinc.com>; devel@edk2.grou= ps.io <devel@edk2.groups.io>; Ashish Singhal <ashishsingha@nvidia.= com>; gaoliming@byosoft.com.cn <gaoliming@byosoft.com.cn>; Jeff Br= asen <jbrasen@nvidia.com>; Kinney, Michael D <michael.d.kinney@int= el.com>; afish@apple.com <afish@apple.com>
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/ResetSystemRuntimeDxe= : Print Reset Data
 
External email: Use caution opening links or attac= hments


Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: Leif Lindholm <quic_llindhol@quicinc.com>
> Sent: Saturday, January 20, 2024 2:38 AM
> To: devel@edk2.groups.io; ashishsingha@nvidia.com;
> gaoliming@byosoft.com.cn; Jeff Brasen <jbrasen@nvidia.com>; Kinn= ey,
> Michael D <michael.d.kinney@intel.com>; afish@apple.com; Gao, Zh= ichao
> <zhichao.gao@intel.com>
> Subject: Re: [edk2-devel] [PATCH]
> MdeModulePkg/ResetSystemRuntimeDxe: Print Reset Data
>
> Hi Ashish,
>
> On 2024-01-19 18:09, Ashish Singhal via groups.io wrote:
> > Adding tianocore stewards to see if we can get some traction on t= his.
>
> You've not cc:d Zhichao - who maintains that component - on this patch= , I've
> added them.
>
> Please use BaseTools/Scripts/GetMaintainer.py to see who to cc -
> maintainership of some of the modules are split in multiple dimensions= and
> it's basically impossible to work out manually.
>
> /
>      Leif
>
> > -----------------------------------------------------------------= -------
> > *From:* Ashish Singhal <ashishsingha@nvidia.com>
> > *Sent:* Wednesday, December 6, 2023 5:21 PM
> > *To:* devel@edk2.groups.io <devel@edk2.groups.io>;
> > gaoliming@byosoft.com.cn <gaoliming@byosoft.com.cn>; Jeff B= rasen
> > <jbrasen@nvidia.com>
> > *Cc:* Ashish Singhal <ashishsingha@nvidia.com>
> > *Subject:* [PATCH] MdeModulePkg/ResetSystemRuntimeDxe: Print Rese= t
> Data
> > ResetSystem runtime call allows for sending reset data that
> > starts with a NULL terminated string. Add support to print
> > that string on console.
> >
> > Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com>
> > ---
> >   .../Universal/ResetSystemRuntimeDxe/ResetSystem.c&nbs= p;        | 8 ++++++++
> >   1 file changed, 8 insertions(+)
> >
> > diff --git
> a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c
> > b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c
> > index 42f1b1d015..72bb1d2be6 100644
> > --- a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c<= br> > > +++
> b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c
> > @@ -252,6 +252,14 @@ RuntimeServiceResetSystem (
> >       mResetNotifyDepth
> >       ));
> >
> > +  if ((ResetData !=3D NULL) && (DataSize !=3D 0)) {=
> > +    DEBUG ((
> > +      DEBUG_INFO,
> > +      "DXE ResetSystem2: ResetData= : %s\n",
> > +      ResetData
> > +      ));
> > +  }
> > +
> >     if (mResetNotifyDepth <=3D MAX_RESET_N= OTIFY_DEPTH) {
> >       if (!EfiAtRuntime ()) {
> >         //
> > --
> > 2.17.1
> >
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#114132) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_BY5PR12MB5544D95B9730716E947CF262BA752BY5PR12MB5544namp_--