public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ashish Singhal via groups.io" <ashishsingha=nvidia.com@groups.io>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"gaoliming@byosoft.com.cn" <gaoliming@byosoft.com.cn>,
	Jeff Brasen <jbrasen@nvidia.com>,
	"michael.d.kinney@intel.com" <michael.d.kinney@intel.com>,
	"quic_llindhol@quicinc.com" <quic_llindhol@quicinc.com>,
	"afish@apple.com" <afish@apple.com>
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/ResetSystemRuntimeDxe: Print Reset Data
Date: Fri, 19 Jan 2024 18:09:40 +0000	[thread overview]
Message-ID: <BY5PR12MB5544DC2D8DE70691CF9EDDB1BA702@BY5PR12MB5544.namprd12.prod.outlook.com> (raw)
In-Reply-To: <BY5PR12MB5544CD6096801DD1BCA06097BA62A@BY5PR12MB5544.namprd12.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 2624 bytes --]

Adding tianocore stewards to see if we can get some traction on this.
________________________________
From: Ashish Singhal <ashishsingha@nvidia.com>
Sent: Monday, January 1, 2024 10:17 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>; gaoliming@byosoft.com.cn <gaoliming@byosoft.com.cn>; Jeff Brasen <jbrasen@nvidia.com>
Subject: Re: [PATCH] MdeModulePkg/ResetSystemRuntimeDxe: Print Reset Data

Hello,

Checking again for some feedback on this.

Thanks
Ashish
________________________________
From: Ashish Singhal <ashishsingha@nvidia.com>
Sent: Thursday, December 14, 2023 4:30 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>; gaoliming@byosoft.com.cn <gaoliming@byosoft.com.cn>; Jeff Brasen <jbrasen@nvidia.com>
Subject: Re: [PATCH] MdeModulePkg/ResetSystemRuntimeDxe: Print Reset Data

Hello Gao,

Checking if you have any feedback on this.

Thanks
Ashish
________________________________
From: Ashish Singhal <ashishsingha@nvidia.com>
Sent: Wednesday, December 6, 2023 5:21 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>; gaoliming@byosoft.com.cn <gaoliming@byosoft.com.cn>; Jeff Brasen <jbrasen@nvidia.com>
Cc: Ashish Singhal <ashishsingha@nvidia.com>
Subject: [PATCH] MdeModulePkg/ResetSystemRuntimeDxe: Print Reset Data

ResetSystem runtime call allows for sending reset data that
starts with a NULL terminated string. Add support to print
that string on console.

Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com>
---
 .../Universal/ResetSystemRuntimeDxe/ResetSystem.c         | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c
index 42f1b1d015..72bb1d2be6 100644
--- a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c
+++ b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c
@@ -252,6 +252,14 @@ RuntimeServiceResetSystem (
     mResetNotifyDepth
     ));

+  if ((ResetData != NULL) && (DataSize != 0)) {
+    DEBUG ((
+      DEBUG_INFO,
+      "DXE ResetSystem2: ResetData: %s\n",
+      ResetData
+      ));
+  }
+
   if (mResetNotifyDepth <= MAX_RESET_NOTIFY_DEPTH) {
     if (!EfiAtRuntime ()) {
       //
--
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114092): https://edk2.groups.io/g/devel/message/114092
Mute This Topic: https://groups.io/mt/103025596/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 7845 bytes --]

  reply	other threads:[~2024-01-19 18:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-07  0:21 [edk2-devel] [PATCH] MdeModulePkg/ResetSystemRuntimeDxe: Print Reset Data Ashish Singhal via groups.io
2023-12-14 23:30 ` Ashish Singhal via groups.io
2024-01-01 16:47   ` Ashish Singhal via groups.io
2024-01-19 18:09     ` Ashish Singhal via groups.io [this message]
2024-01-19 18:38       ` Leif Lindholm
2024-01-22  1:31         ` Gao, Zhichao
2024-01-22  2:52           ` Ashish Singhal via groups.io

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BY5PR12MB5544DC2D8DE70691CF9EDDB1BA702@BY5PR12MB5544.namprd12.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox